From: Shawn Lin <shawn.lin@rock-chips.com> To: SF Markus Elfring <elfring@users.sourceforge.net>, linux-mmc@vger.kernel.org, Adrian Hunter <adrian.hunter@intel.com>, Harjani Ritesh <riteshh@codeaurora.org>, Jens Axboe <axboe@fb.com>, Linus Walleij <linus.walleij@linaro.org>, Mike Christie <mchristi@redhat.com>, Ulf Hansson <ulf.hansson@linaro.org>, Wolfram Sang <wsa+renesas@sang-engineering.com> Cc: shawn.lin@rock-chips.com, LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 8/8] mmc-core: Use kmalloc_array() in mmc_alloc_sg() Date: Tue, 10 Jan 2017 16:27:19 +0800 [thread overview] Message-ID: <cccfd6b4-5b20-8541-6ba0-40db1a150337@rock-chips.com> (raw) In-Reply-To: <a2c80b39-6f7e-81ad-01d2-fce831e6cd8c@users.sourceforge.net> On 2017/1/9 5:55, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 8 Jan 2017 22:10:40 +0100 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > * Replace the specification of a data structure by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/mmc/core/queue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c > index a6496d8027bc..b1986622c60e 100644 > --- a/drivers/mmc/core/queue.c > +++ b/drivers/mmc/core/queue.c > @@ -152,7 +152,7 @@ static struct scatterlist *mmc_alloc_sg(int sg_len, int *err) > { > struct scatterlist *sg; > > - sg = kmalloc(sizeof(struct scatterlist)*sg_len, GFP_KERNEL); > + sg = kmalloc_array(sg_len, sizeof(*sg), GFP_KERNEL); > if (!sg) > *err = -ENOMEM; > else { > -- Best Regards Shawn Lin
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Lin <shawn.lin@rock-chips.com> To: SF Markus Elfring <elfring@users.sourceforge.net>, linux-mmc@vger.kernel.org, Adrian Hunter <adrian.hunter@intel.com>, Harjani Ritesh <riteshh@codeaurora.org>, Jens Axboe <axboe@fb.com>, Linus Walleij <linus.walleij@linaro.org>, Mike Christie <mchristi@redhat.com>, Ulf Hansson <ulf.hansson@linaro.org>, Wolfram Sang <wsa+renesas@sang-engineering.com> Cc: shawn.lin@rock-chips.com, LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 8/8] mmc-core: Use kmalloc_array() in mmc_alloc_sg() Date: Tue, 10 Jan 2017 08:27:19 +0000 [thread overview] Message-ID: <cccfd6b4-5b20-8541-6ba0-40db1a150337@rock-chips.com> (raw) In-Reply-To: <a2c80b39-6f7e-81ad-01d2-fce831e6cd8c@users.sourceforge.net> On 2017/1/9 5:55, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 8 Jan 2017 22:10:40 +0100 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > * Replace the specification of a data structure by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/mmc/core/queue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c > index a6496d8027bc..b1986622c60e 100644 > --- a/drivers/mmc/core/queue.c > +++ b/drivers/mmc/core/queue.c > @@ -152,7 +152,7 @@ static struct scatterlist *mmc_alloc_sg(int sg_len, int *err) > { > struct scatterlist *sg; > > - sg = kmalloc(sizeof(struct scatterlist)*sg_len, GFP_KERNEL); > + sg = kmalloc_array(sg_len, sizeof(*sg), GFP_KERNEL); > if (!sg) > *err = -ENOMEM; > else { > -- Best Regards Shawn Lin
next prev parent reply other threads:[~2017-01-10 8:28 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-08 21:38 [PATCH 0/8] MMC-core: Fine-tuning for some function implementations SF Markus Elfring 2017-01-08 21:38 ` SF Markus Elfring 2017-01-08 21:42 ` [PATCH 1/8] mmc-core: Use kmalloc_array() in mmc_test_area_init() SF Markus Elfring 2017-01-08 21:42 ` SF Markus Elfring 2017-01-09 18:31 ` Linus Walleij 2017-01-09 18:31 ` Linus Walleij 2017-01-10 7:37 ` Chunyan Zhang 2017-01-10 7:37 ` Chunyan Zhang 2017-01-10 8:44 ` Shawn Lin 2017-01-10 8:44 ` Shawn Lin 2017-01-11 1:59 ` Andy Shevchenko 2017-01-11 1:59 ` Andy Shevchenko 2017-01-08 21:43 ` [PATCH 2/8] mmc-core: Fix a typo in a comment line SF Markus Elfring 2017-01-08 21:43 ` SF Markus Elfring 2017-01-09 18:32 ` Linus Walleij 2017-01-09 18:32 ` Linus Walleij 2017-01-10 8:43 ` Shawn Lin 2017-01-10 8:43 ` Shawn Lin 2017-01-08 21:45 ` [PATCH 3/8] mmc-core: Use seq_puts() in mtf_testlist_show() SF Markus Elfring 2017-01-08 21:45 ` SF Markus Elfring 2017-01-09 18:33 ` Linus Walleij 2017-01-09 18:33 ` Linus Walleij 2017-01-10 8:41 ` Shawn Lin 2017-01-10 8:41 ` Shawn Lin 2017-01-08 21:46 ` [PATCH 4/8] mmc/core/mmc_test: Add some spaces for better code readability SF Markus Elfring 2017-01-08 21:46 ` SF Markus Elfring 2017-01-09 18:34 ` Linus Walleij 2017-01-09 18:34 ` Linus Walleij 2017-01-10 8:35 ` Shawn Lin 2017-01-10 8:35 ` Shawn Lin 2017-01-08 21:47 ` [PATCH 5/8] mmc/core/mmc_test: Combine substrings for 5 messages SF Markus Elfring 2017-01-08 21:47 ` SF Markus Elfring 2017-01-09 18:35 ` Linus Walleij 2017-01-09 18:35 ` Linus Walleij 2017-01-10 8:34 ` Shawn Lin 2017-01-10 8:34 ` Shawn Lin 2017-01-08 21:49 ` [PATCH 6/8] mmc/core/mmc_test: Improve a size determination in five functions SF Markus Elfring 2017-01-08 21:49 ` SF Markus Elfring 2017-01-09 18:35 ` Linus Walleij 2017-01-09 18:35 ` Linus Walleij 2017-01-10 8:31 ` Shawn Lin 2017-01-10 8:31 ` Shawn Lin 2017-01-08 21:50 ` [PATCH 7/8] mmc-core: Use kcalloc() in mmc_test_alloc_mem() SF Markus Elfring 2017-01-08 21:50 ` SF Markus Elfring 2017-01-09 18:36 ` Linus Walleij 2017-01-09 18:36 ` Linus Walleij 2017-01-10 8:28 ` Shawn Lin 2017-01-10 8:28 ` Shawn Lin 2017-01-08 21:55 ` [PATCH 8/8] mmc-core: Use kmalloc_array() in mmc_alloc_sg() SF Markus Elfring 2017-01-08 21:55 ` SF Markus Elfring 2017-01-09 18:37 ` Linus Walleij 2017-01-09 18:37 ` Linus Walleij 2017-01-10 8:27 ` Shawn Lin [this message] 2017-01-10 8:27 ` Shawn Lin 2017-01-12 12:01 ` [PATCH 0/8] MMC-core: Fine-tuning for some function implementations Ulf Hansson 2017-01-12 12:01 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cccfd6b4-5b20-8541-6ba0-40db1a150337@rock-chips.com \ --to=shawn.lin@rock-chips.com \ --cc=adrian.hunter@intel.com \ --cc=axboe@fb.com \ --cc=elfring@users.sourceforge.net \ --cc=kernel-janitors@vger.kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=mchristi@redhat.com \ --cc=riteshh@codeaurora.org \ --cc=ulf.hansson@linaro.org \ --cc=wsa+renesas@sang-engineering.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.