* [PATCH] IB/ehca: use kthread_create_on_node
@ 2011-07-29 7:15 ` Eric Dumazet
0 siblings, 0 replies; 13+ messages in thread
From: Eric Dumazet @ 2011-07-29 7:15 UTC (permalink / raw)
To: Hoang-Nam Nguyen
Cc: Christoph Raisch, Roland Dreier, Sean Hefty,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, linux-kernel
Since create_comp_task() creates percpu kthread, it makes
sense to use kthread_create_on_node() to get proper NUMA affinity for
kthread stack.
Signed-off-by: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
CC: Hoang-Nam Nguyen <hnguyen-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
CC: Christoph Raisch <raisch-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
CC: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
CC: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
drivers/infiniband/hw/ehca/ehca_irq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c b/drivers/infiniband/hw/ehca/ehca_irq.c
index e571e60..5358900 100644
--- a/drivers/infiniband/hw/ehca/ehca_irq.c
+++ b/drivers/infiniband/hw/ehca/ehca_irq.c
@@ -786,7 +786,8 @@ static struct task_struct *create_comp_task(struct ehca_comp_pool *pool,
spin_lock_init(&cct->task_lock);
INIT_LIST_HEAD(&cct->cq_list);
init_waitqueue_head(&cct->wait_queue);
- cct->task = kthread_create(comp_task, cct, "ehca_comp/%d", cpu);
+ cct->task = kthread_create_on_node(comp_task, cct, cpu_to_node(cpu),
+ "ehca_comp/%d", cpu);
return cct->task;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] IB/ehca: use kthread_create_on_node
@ 2011-07-29 7:15 ` Eric Dumazet
0 siblings, 0 replies; 13+ messages in thread
From: Eric Dumazet @ 2011-07-29 7:15 UTC (permalink / raw)
To: Hoang-Nam Nguyen
Cc: Christoph Raisch, Roland Dreier, Sean Hefty, linux-rdma, linux-kernel
Since create_comp_task() creates percpu kthread, it makes
sense to use kthread_create_on_node() to get proper NUMA affinity for
kthread stack.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Hoang-Nam Nguyen <hnguyen@de.ibm.com>
CC: Christoph Raisch <raisch@de.ibm.com>
CC: Roland Dreier <roland@kernel.org>
CC: Sean Hefty <sean.hefty@intel.com>
---
drivers/infiniband/hw/ehca/ehca_irq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c b/drivers/infiniband/hw/ehca/ehca_irq.c
index e571e60..5358900 100644
--- a/drivers/infiniband/hw/ehca/ehca_irq.c
+++ b/drivers/infiniband/hw/ehca/ehca_irq.c
@@ -786,7 +786,8 @@ static struct task_struct *create_comp_task(struct ehca_comp_pool *pool,
spin_lock_init(&cct->task_lock);
INIT_LIST_HEAD(&cct->cq_list);
init_waitqueue_head(&cct->wait_queue);
- cct->task = kthread_create(comp_task, cct, "ehca_comp/%d", cpu);
+ cct->task = kthread_create_on_node(comp_task, cct, cpu_to_node(cpu),
+ "ehca_comp/%d", cpu);
return cct->task;
}
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] IB/ehca: use kthread_create_on_node
2011-07-29 7:15 ` Eric Dumazet
@ 2011-07-29 17:10 ` Roland Dreier
-1 siblings, 0 replies; 13+ messages in thread
From: Roland Dreier @ 2011-07-29 17:10 UTC (permalink / raw)
To: Eric Dumazet
Cc: Hoang-Nam Nguyen, Christoph Raisch, Sean Hefty,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, linux-kernel
On Fri, Jul 29, 2011 at 12:15 AM, Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Since create_comp_task() creates percpu kthread, it makes
> sense to use kthread_create_on_node() to get proper NUMA affinity for
> kthread stack.
Seems eminently sane to me. ehca guys, any concern about this?
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] IB/ehca: use kthread_create_on_node
@ 2011-07-29 17:10 ` Roland Dreier
0 siblings, 0 replies; 13+ messages in thread
From: Roland Dreier @ 2011-07-29 17:10 UTC (permalink / raw)
To: Eric Dumazet
Cc: Hoang-Nam Nguyen, Christoph Raisch, Sean Hefty, linux-rdma, linux-kernel
On Fri, Jul 29, 2011 at 12:15 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Since create_comp_task() creates percpu kthread, it makes
> sense to use kthread_create_on_node() to get proper NUMA affinity for
> kthread stack.
Seems eminently sane to me. ehca guys, any concern about this?
- R.
^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <CAL1RGDXJzW7e2LTyex1EZXSLBdB_xmcBvBiiS2XKL-5qUCOQ1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] IB/ehca: use kthread_create_on_node
2011-07-29 17:10 ` Roland Dreier
@ 2011-07-29 17:39 ` Hoang-Nam Nguyen
-1 siblings, 0 replies; 13+ messages in thread
From: Hoang-Nam Nguyen @ 2011-07-29 17:39 UTC (permalink / raw)
To: Roland Dreier
Cc: Christoph Raisch, Eric Dumazet, linux-kernel,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, roland-BHEL68pLQRGGvPXPguhicg,
Sean Hefty
Hi Roland,
This patch looks fine to me.
Thanks
Nam
roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org wrote on 29.07.2011 19:10:32:
> [image removed]
>
> Re: [PATCH] IB/ehca: use kthread_create_on_node
>
> Roland Dreier
>
> to:
>
> Eric Dumazet
>
> 29.07.2011 19:11
>
> Sent by:
>
> roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org
>
> Cc:
>
> Hoang-Nam Nguyen, Christoph Raisch, Sean Hefty, linux-rdma, linux-kernel
>
> On Fri, Jul 29, 2011 at 12:15 AM, Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
wrote:
> > Since create_comp_task() creates percpu kthread, it makes
> > sense to use kthread_create_on_node() to get proper NUMA affinity for
> > kthread stack.
>
> Seems eminently sane to me. ehca guys, any concern about this?
>
> - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] IB/ehca: use kthread_create_on_node
@ 2011-07-29 17:39 ` Hoang-Nam Nguyen
0 siblings, 0 replies; 13+ messages in thread
From: Hoang-Nam Nguyen @ 2011-07-29 17:39 UTC (permalink / raw)
To: Roland Dreier
Cc: Christoph Raisch, Eric Dumazet, linux-kernel, linux-rdma, roland,
Sean Hefty
Hi Roland,
This patch looks fine to me.
Thanks
Nam
roland@purestorage.com wrote on 29.07.2011 19:10:32:
> [image removed]
>
> Re: [PATCH] IB/ehca: use kthread_create_on_node
>
> Roland Dreier
>
> to:
>
> Eric Dumazet
>
> 29.07.2011 19:11
>
> Sent by:
>
> roland@purestorage.com
>
> Cc:
>
> Hoang-Nam Nguyen, Christoph Raisch, Sean Hefty, linux-rdma, linux-kernel
>
> On Fri, Jul 29, 2011 at 12:15 AM, Eric Dumazet <eric.dumazet@gmail.com>
wrote:
> > Since create_comp_task() creates percpu kthread, it makes
> > sense to use kthread_create_on_node() to get proper NUMA affinity for
> > kthread stack.
>
> Seems eminently sane to me. ehca guys, any concern about this?
>
> - R.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] IB/ehca: use kthread_create_on_node
2011-07-29 7:15 ` Eric Dumazet
@ 2012-02-02 11:12 ` Eric Dumazet
-1 siblings, 0 replies; 13+ messages in thread
From: Eric Dumazet @ 2012-02-02 11:12 UTC (permalink / raw)
To: Hoang-Nam Nguyen
Cc: Christoph Raisch, Roland Dreier, Sean Hefty,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, linux-kernel
Le vendredi 29 juillet 2011 à 09:15 +0200, Eric Dumazet a écrit :
> Since create_comp_task() creates percpu kthread, it makes
> sense to use kthread_create_on_node() to get proper NUMA affinity for
> kthread stack.
>
> Signed-off-by: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> CC: Hoang-Nam Nguyen <hnguyen-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
> CC: Christoph Raisch <raisch-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
> CC: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> CC: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
> drivers/infiniband/hw/ehca/ehca_irq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c b/drivers/infiniband/hw/ehca/ehca_irq.c
> index e571e60..5358900 100644
> --- a/drivers/infiniband/hw/ehca/ehca_irq.c
> +++ b/drivers/infiniband/hw/ehca/ehca_irq.c
> @@ -786,7 +786,8 @@ static struct task_struct *create_comp_task(struct ehca_comp_pool *pool,
> spin_lock_init(&cct->task_lock);
> INIT_LIST_HEAD(&cct->cq_list);
> init_waitqueue_head(&cct->wait_queue);
> - cct->task = kthread_create(comp_task, cct, "ehca_comp/%d", cpu);
> + cct->task = kthread_create_on_node(comp_task, cct, cpu_to_node(cpu),
> + "ehca_comp/%d", cpu);
>
> return cct->task;
> }
>
Any news on this patch ?
Should I submit it again ?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] IB/ehca: use kthread_create_on_node
@ 2012-02-02 11:12 ` Eric Dumazet
0 siblings, 0 replies; 13+ messages in thread
From: Eric Dumazet @ 2012-02-02 11:12 UTC (permalink / raw)
To: Hoang-Nam Nguyen
Cc: Christoph Raisch, Roland Dreier, Sean Hefty, linux-rdma, linux-kernel
Le vendredi 29 juillet 2011 à 09:15 +0200, Eric Dumazet a écrit :
> Since create_comp_task() creates percpu kthread, it makes
> sense to use kthread_create_on_node() to get proper NUMA affinity for
> kthread stack.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> CC: Hoang-Nam Nguyen <hnguyen@de.ibm.com>
> CC: Christoph Raisch <raisch@de.ibm.com>
> CC: Roland Dreier <roland@kernel.org>
> CC: Sean Hefty <sean.hefty@intel.com>
> ---
> drivers/infiniband/hw/ehca/ehca_irq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c b/drivers/infiniband/hw/ehca/ehca_irq.c
> index e571e60..5358900 100644
> --- a/drivers/infiniband/hw/ehca/ehca_irq.c
> +++ b/drivers/infiniband/hw/ehca/ehca_irq.c
> @@ -786,7 +786,8 @@ static struct task_struct *create_comp_task(struct ehca_comp_pool *pool,
> spin_lock_init(&cct->task_lock);
> INIT_LIST_HEAD(&cct->cq_list);
> init_waitqueue_head(&cct->wait_queue);
> - cct->task = kthread_create(comp_task, cct, "ehca_comp/%d", cpu);
> + cct->task = kthread_create_on_node(comp_task, cct, cpu_to_node(cpu),
> + "ehca_comp/%d", cpu);
>
> return cct->task;
> }
>
Any news on this patch ?
Should I submit it again ?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] IB/ehca: use kthread_create_on_node
2012-02-02 11:12 ` Eric Dumazet
(?)
@ 2012-02-02 17:08 ` Roland Dreier
2012-02-08 21:26 ` Or Gerlitz
-1 siblings, 1 reply; 13+ messages in thread
From: Roland Dreier @ 2012-02-02 17:08 UTC (permalink / raw)
To: Eric Dumazet
Cc: Hoang-Nam Nguyen, Christoph Raisch, Sean Hefty, linux-rdma, linux-kernel
On Thu, Feb 2, 2012 at 3:12 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Any news on this patch ?
Sorry, just dropped it in the shuffle. I'll get it into 3.4, thanks.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] IB/ehca: use kthread_create_on_node
2012-02-02 17:08 ` Roland Dreier
@ 2012-02-08 21:26 ` Or Gerlitz
[not found] ` <CAJZOPZJtXGq36Hx5BQAc2Q7znErJ-Uaiqs-DaJQ=jCSy49uTiQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 13+ messages in thread
From: Or Gerlitz @ 2012-02-08 21:26 UTC (permalink / raw)
To: Roland Dreier; +Cc: Eric Dumazet, Sean Hefty, linux-rdma, linux-kernel
On Thu, Feb 2, 2012 at 7:08 PM, Roland Dreier <roland@kernel.org> wrote:
> On Thu, Feb 2, 2012 at 3:12 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> Any news on this patch ?
> Sorry, just dropped it in the shuffle. I'll get it into 3.4, thanks.
Roland,
I noted that you typically use the for-next branch of the infiniband
tree for fixes during
the 1 < kernN-rc < (say) 6 time and for features during (kernN-rc > 6)
till kern(N+1)-rc1
This means that the window of time when features are actually accepted
into your tree is kind of very limited. Would it be possible to
maintain two branches: for-next and (say) rc-fixes, such that
practically patches are reviewed/accepted to for-next at almost all
times?
BTW I see that networking and scsi maintainers use two trees
(net/net-next) and (scsi-misc/scsi-rc-fixes), maybe it would be eaiser
for you go this way?
Or.
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2012-02-08 22:28 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-29 7:15 [PATCH] IB/ehca: use kthread_create_on_node Eric Dumazet
2011-07-29 7:15 ` Eric Dumazet
2011-07-29 17:10 ` Roland Dreier
2011-07-29 17:10 ` Roland Dreier
[not found] ` <CAL1RGDXJzW7e2LTyex1EZXSLBdB_xmcBvBiiS2XKL-5qUCOQ1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-29 17:39 ` Hoang-Nam Nguyen
2011-07-29 17:39 ` Hoang-Nam Nguyen
2012-02-02 11:12 ` Eric Dumazet
2012-02-02 11:12 ` Eric Dumazet
2012-02-02 17:08 ` Roland Dreier
2012-02-08 21:26 ` Or Gerlitz
[not found] ` <CAJZOPZJtXGq36Hx5BQAc2Q7znErJ-Uaiqs-DaJQ=jCSy49uTiQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-02-08 21:35 ` Roland Dreier
2012-02-08 21:35 ` Roland Dreier
2012-02-08 22:28 ` Or Gerlitz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.