From: Daniel Kurtz <djkurtz@chromium.org> To: Sascha Hauer <s.hauer@pengutronix.de> Cc: "James Liao" <jamesjj.liao@mediatek.com>, "Heiko Stübner" <heiko@sntech.de>, linux-mediatek@lists.infradead.org, "Eddie Huang" <eddie.huang@mediatek.com>, "Matthias Brugger" <matthias.bgg@gmail.com>, "open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "Mike Turquette" <mturquette@baylibre.com>, "Stephen Boyd" <sboyd@codeaurora.org>, ted.lin@mediatek.com Subject: Re: [PATCH] arm64: dts: mt8173: add clock_null Date: Wed, 1 Jul 2015 19:54:09 +0800 [thread overview] Message-ID: <CAGS+omBdz2df7ykYpx5Gh1B2Ym+XhpOPOOUu0a_qg7tJKqOy6A@mail.gmail.com> (raw) In-Reply-To: <20150701064935.GC18611@pengutronix.de> On Wed, Jul 1, 2015 at 2:49 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote: > > On Tue, Jun 30, 2015 at 05:07:09PM +0800, James Liao wrote: > > Hi Heiko, > > > > There are 4 clocks which are derived from clk_null directly in current > > topckgen implementation: > > > > clkph_mck_o, dpi_ck, usb_syspll_125m, hdmitx_dig_cts > > > > Our designer mentioned 2 things about external clocks: > > > > 1. These 4 clocks come from analog macro, not from PLL, nor from > > external clocks directly. > > Ok, this means there actually are clocks. We can't control these clock and > they have some known or unknown rate. This makes them fixed clocks. Just > specify them in the device tree and you are done. Give them reasonable > names and the rate if you know it, 0 otherwise. > > The problem is not that you use fixed clocks for non software > controllable clocks of unknwown rates, but that you try to use a single > clock for all of them and name it 'dummy' or 'null'. Name it > > dpi_ck { > compatible = "fixed-clock"; > rate = <0>; /* unknown, generated by some Analog block */ > }; It would be nice, though, to use the real clock rates. Otherwise, we end up with a bunch of unknown clock rates, like this: clock enable_cnt prepare_cnt rate accuracy phase ---------------------------------------------------------------------------------------- clk_null 2 2 0 0 0 mm_lvds_cts 0 0 0 0 0 mm_lvds_pixel 0 0 0 0 0 mm_dpi1_pixel 0 0 0 0 0 mm_dsi1_digital 0 0 0 0 0 mm_dsi0_digital 1 1 0 0 0 infra_cpum 0 0 0 0 0 hdmitx_dig_cts 0 0 0 0 0 hdmi_sel 0 0 0 0 0 mm_hdmi_pllck 0 0 0 0 0 hdmitxpll_d3 0 0 0 0 0 hdmitxpll_d2 0 0 0 0 0 usb_syspll_125m 0 0 0 0 0 dpi_ck 0 0 0 0 0 clkph_mck_o 1 1 0 0 0 dmpll_d16 0 0 0 0 0 dmpll_d8 0 0 0 0 0 dmpll_d4 0 0 0 0 0 dmpll_d2 0 0 0 0 0 dmpll_ck 1 1 0 0 0 mem_sel 2 2 0 0 0 infra_m4u 1 1 0 0 0 Furthermore, at least some of these children clocks are possible source clocks for other clocks for which we do want to know the resulting frequency. For example, the "dmpll_*" clocks are mux inputs for many of the subsystem clocks. -Dan > > Technically it's the same, but it sounds much more professional and like > you know what you are doing ;) > > Sascha > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: djkurtz@chromium.org (Daniel Kurtz) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] arm64: dts: mt8173: add clock_null Date: Wed, 1 Jul 2015 19:54:09 +0800 [thread overview] Message-ID: <CAGS+omBdz2df7ykYpx5Gh1B2Ym+XhpOPOOUu0a_qg7tJKqOy6A@mail.gmail.com> (raw) In-Reply-To: <20150701064935.GC18611@pengutronix.de> On Wed, Jul 1, 2015 at 2:49 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote: > > On Tue, Jun 30, 2015 at 05:07:09PM +0800, James Liao wrote: > > Hi Heiko, > > > > There are 4 clocks which are derived from clk_null directly in current > > topckgen implementation: > > > > clkph_mck_o, dpi_ck, usb_syspll_125m, hdmitx_dig_cts > > > > Our designer mentioned 2 things about external clocks: > > > > 1. These 4 clocks come from analog macro, not from PLL, nor from > > external clocks directly. > > Ok, this means there actually are clocks. We can't control these clock and > they have some known or unknown rate. This makes them fixed clocks. Just > specify them in the device tree and you are done. Give them reasonable > names and the rate if you know it, 0 otherwise. > > The problem is not that you use fixed clocks for non software > controllable clocks of unknwown rates, but that you try to use a single > clock for all of them and name it 'dummy' or 'null'. Name it > > dpi_ck { > compatible = "fixed-clock"; > rate = <0>; /* unknown, generated by some Analog block */ > }; It would be nice, though, to use the real clock rates. Otherwise, we end up with a bunch of unknown clock rates, like this: clock enable_cnt prepare_cnt rate accuracy phase ---------------------------------------------------------------------------------------- clk_null 2 2 0 0 0 mm_lvds_cts 0 0 0 0 0 mm_lvds_pixel 0 0 0 0 0 mm_dpi1_pixel 0 0 0 0 0 mm_dsi1_digital 0 0 0 0 0 mm_dsi0_digital 1 1 0 0 0 infra_cpum 0 0 0 0 0 hdmitx_dig_cts 0 0 0 0 0 hdmi_sel 0 0 0 0 0 mm_hdmi_pllck 0 0 0 0 0 hdmitxpll_d3 0 0 0 0 0 hdmitxpll_d2 0 0 0 0 0 usb_syspll_125m 0 0 0 0 0 dpi_ck 0 0 0 0 0 clkph_mck_o 1 1 0 0 0 dmpll_d16 0 0 0 0 0 dmpll_d8 0 0 0 0 0 dmpll_d4 0 0 0 0 0 dmpll_d2 0 0 0 0 0 dmpll_ck 1 1 0 0 0 mem_sel 2 2 0 0 0 infra_m4u 1 1 0 0 0 Furthermore, at least some of these children clocks are possible source clocks for other clocks for which we do want to know the resulting frequency. For example, the "dmpll_*" clocks are mux inputs for many of the subsystem clocks. -Dan > > Technically it's the same, but it sounds much more professional and like > you know what you are doing ;) > > Sascha > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-07-01 11:54 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-18 5:29 [PATCH] arm64: dts: mt8173: add clock_null Eddie Huang 2015-06-18 5:29 ` Eddie Huang 2015-06-18 5:29 ` Eddie Huang 2015-06-18 16:15 ` Heiko Stuebner 2015-06-18 16:15 ` Heiko Stuebner 2015-06-18 16:15 ` Heiko Stuebner 2015-06-19 11:36 ` Heiko Stuebner 2015-06-19 11:36 ` Heiko Stuebner 2015-06-19 11:36 ` Heiko Stuebner 2015-06-22 3:38 ` James Liao 2015-06-22 3:38 ` James Liao 2015-06-22 3:38 ` James Liao 2015-06-22 12:53 ` Heiko Stübner 2015-06-22 12:53 ` Heiko Stübner 2015-06-22 12:53 ` Heiko Stübner 2015-06-24 7:54 ` James Liao 2015-06-24 7:54 ` James Liao 2015-06-24 7:54 ` James Liao 2015-06-24 10:24 ` Heiko Stübner 2015-06-24 10:24 ` Heiko Stübner 2015-06-24 10:24 ` Heiko Stübner 2015-06-30 9:07 ` James Liao 2015-06-30 9:07 ` James Liao 2015-06-30 9:07 ` James Liao 2015-07-01 6:49 ` Sascha Hauer 2015-07-01 6:49 ` Sascha Hauer 2015-07-01 6:49 ` Sascha Hauer 2015-07-01 11:54 ` Daniel Kurtz [this message] 2015-07-01 11:54 ` Daniel Kurtz 2015-07-02 3:06 ` James Liao 2015-07-02 3:06 ` James Liao 2015-07-02 3:06 ` James Liao 2015-07-02 4:23 ` Daniel Kurtz 2015-07-02 4:23 ` Daniel Kurtz 2015-07-02 4:23 ` Daniel Kurtz 2015-07-03 7:45 ` James Liao 2015-07-03 7:45 ` James Liao 2015-07-03 7:45 ` James Liao 2015-07-03 8:38 ` Heiko Stübner 2015-07-03 8:38 ` Heiko Stübner 2015-07-03 8:38 ` Heiko Stübner 2015-07-02 2:05 ` James Liao 2015-07-02 2:05 ` James Liao 2015-07-02 2:05 ` James Liao 2015-07-07 13:07 ` Sascha Hauer 2015-07-07 13:07 ` Sascha Hauer 2015-07-07 13:07 ` Sascha Hauer 2015-07-07 14:15 ` Daniel Kurtz 2015-07-07 14:15 ` Daniel Kurtz 2015-07-07 14:15 ` Daniel Kurtz 2015-07-07 14:36 ` Sascha Hauer 2015-07-07 14:36 ` Sascha Hauer 2015-07-07 14:36 ` Sascha Hauer 2015-07-07 15:10 ` Daniel Kurtz 2015-07-07 15:10 ` Daniel Kurtz 2015-07-07 15:10 ` Daniel Kurtz 2015-07-08 2:37 ` Eddie Huang 2015-07-08 2:37 ` Eddie Huang 2015-07-08 2:37 ` Eddie Huang 2015-07-08 5:44 ` Sascha Hauer 2015-07-08 5:44 ` Sascha Hauer 2015-07-08 5:44 ` Sascha Hauer 2015-07-10 7:27 ` Eddie Huang 2015-07-10 7:27 ` Eddie Huang 2015-07-10 8:11 ` Daniel Kurtz 2015-07-10 8:11 ` Daniel Kurtz 2015-07-10 10:29 ` Eddie Huang 2015-07-10 10:29 ` Eddie Huang 2015-07-10 10:29 ` Eddie Huang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAGS+omBdz2df7ykYpx5Gh1B2Ym+XhpOPOOUu0a_qg7tJKqOy6A@mail.gmail.com \ --to=djkurtz@chromium.org \ --cc=devicetree@vger.kernel.org \ --cc=eddie.huang@mediatek.com \ --cc=heiko@sntech.de \ --cc=jamesjj.liao@mediatek.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=mturquette@baylibre.com \ --cc=s.hauer@pengutronix.de \ --cc=sboyd@codeaurora.org \ --cc=ted.lin@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.