From: Kees Cook <keescook@chromium.org>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: Paul Moore <paul@paul-moore.com>,
linux-integrity <linux-integrity@vger.kernel.org>,
linux-security-module <linux-security-module@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
"Luis R . Rodriguez" <mcgrof@kernel.org>,
Eric Biederman <ebiederm@xmission.com>,
Kexec Mailing List <kexec@lists.infradead.org>,
Andres Rodriguez <andresx7@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Jeff Vander Stoep <jeffv@google.com>,
Casey Schaufler <casey@schaufler-ca.com>,
James Morris <jmorris@namei.org>
Subject: Re: [PATCH v4a 8/8] module: replace the existing LSM hook in init_module
Date: Tue, 5 Jun 2018 15:26:32 -0700 [thread overview]
Message-ID: <CAGXu5j+9P9HLvwC4WfHoxXsz7vYA_raStVDPzA=tNR9f9vr9=Q@mail.gmail.com> (raw)
In-Reply-To: <1528234513.3557.16.camel@linux.vnet.ibm.com>
On Tue, Jun 5, 2018 at 2:35 PM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> On Tue, 2018-06-05 at 12:45 -0700, Kees Cook wrote:
>
>> And if you must have a separate enum, please change this to fail
>> closed instead of open (and mark the fall-through):
>>
>> int rc = -EPERM;
>>
>> switch (id) {
>> case LOADING_MODULE:
>> rc = loadpin_read_file(NULL, READING_MODULE);
>> /* Fall-through */
>> default:
>> break;
>> }
>
> This will fail the sysfs firmware fallback loading and the kexec_load
> syscall without any message, as you have for init_module. Is that
> what you want?
I'd prefer there be a full mapping of the enums so that everything
gets passed into loadpin_read_file() :)
Can the enum be shared or is that nonsensical?
-Kees
--
Kees Cook
Pixel Security
WARNING: multiple messages have this Message-ID (diff)
From: keescook@chromium.org (Kees Cook)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v4a 8/8] module: replace the existing LSM hook in init_module
Date: Tue, 5 Jun 2018 15:26:32 -0700 [thread overview]
Message-ID: <CAGXu5j+9P9HLvwC4WfHoxXsz7vYA_raStVDPzA=tNR9f9vr9=Q@mail.gmail.com> (raw)
In-Reply-To: <1528234513.3557.16.camel@linux.vnet.ibm.com>
On Tue, Jun 5, 2018 at 2:35 PM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> On Tue, 2018-06-05 at 12:45 -0700, Kees Cook wrote:
>
>> And if you must have a separate enum, please change this to fail
>> closed instead of open (and mark the fall-through):
>>
>> int rc = -EPERM;
>>
>> switch (id) {
>> case LOADING_MODULE:
>> rc = loadpin_read_file(NULL, READING_MODULE);
>> /* Fall-through */
>> default:
>> break;
>> }
>
> This will fail the sysfs firmware fallback loading and the kexec_load
> syscall without any message, as you have for init_module. Is that
> what you want?
I'd prefer there be a full mapping of the enums so that everything
gets passed into loadpin_read_file() :)
Can the enum be shared or is that nonsensical?
-Kees
--
Kees Cook
Pixel Security
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: Paul Moore <paul@paul-moore.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kexec Mailing List <kexec@lists.infradead.org>,
"Luis R . Rodriguez" <mcgrof@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
linux-security-module <linux-security-module@vger.kernel.org>,
Eric Biederman <ebiederm@xmission.com>,
Jeff Vander Stoep <jeffv@google.com>,
Casey Schaufler <casey@schaufler-ca.com>,
linux-integrity <linux-integrity@vger.kernel.org>,
James Morris <jmorris@namei.org>,
Andres Rodriguez <andresx7@gmail.com>
Subject: Re: [PATCH v4a 8/8] module: replace the existing LSM hook in init_module
Date: Tue, 5 Jun 2018 15:26:32 -0700 [thread overview]
Message-ID: <CAGXu5j+9P9HLvwC4WfHoxXsz7vYA_raStVDPzA=tNR9f9vr9=Q@mail.gmail.com> (raw)
In-Reply-To: <1528234513.3557.16.camel@linux.vnet.ibm.com>
On Tue, Jun 5, 2018 at 2:35 PM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> On Tue, 2018-06-05 at 12:45 -0700, Kees Cook wrote:
>
>> And if you must have a separate enum, please change this to fail
>> closed instead of open (and mark the fall-through):
>>
>> int rc = -EPERM;
>>
>> switch (id) {
>> case LOADING_MODULE:
>> rc = loadpin_read_file(NULL, READING_MODULE);
>> /* Fall-through */
>> default:
>> break;
>> }
>
> This will fail the sysfs firmware fallback loading and the kexec_load
> syscall without any message, as you have for init_module. Is that
> what you want?
I'd prefer there be a full mapping of the enums so that everything
gets passed into loadpin_read_file() :)
Can the enum be shared or is that nonsensical?
-Kees
--
Kees Cook
Pixel Security
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2018-06-05 22:26 UTC|newest]
Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 18:01 [PATCH v4 0/8] kexec/firmware: support system wide policy requiring signatures Mimi Zohar
2018-05-29 18:01 ` Mimi Zohar
2018-05-29 18:01 ` Mimi Zohar
2018-05-29 18:01 ` [PATCH v4 1/8] security: define new LSM hook named security_kernel_load_data Mimi Zohar
2018-05-29 18:01 ` Mimi Zohar
2018-05-29 18:01 ` Mimi Zohar
2018-06-04 19:59 ` Serge E. Hallyn
2018-06-04 19:59 ` Serge E. Hallyn
2018-06-04 19:59 ` Serge E. Hallyn
2018-05-29 18:01 ` [PATCH v4 2/8] kexec: add call to LSM hook in original kexec_load syscall Mimi Zohar
2018-05-29 18:01 ` Mimi Zohar
2018-05-29 18:01 ` Mimi Zohar
2018-06-04 20:00 ` Serge E. Hallyn
2018-06-04 20:00 ` Serge E. Hallyn
2018-06-04 20:00 ` Serge E. Hallyn
2018-05-29 18:01 ` [PATCH v4 3/8] ima: based on policy require signed kexec kernel images Mimi Zohar
2018-05-29 18:01 ` Mimi Zohar
2018-05-29 18:01 ` Mimi Zohar
2018-05-29 18:01 ` [PATCH v4 4/8] firmware: add call to LSM hook before firmware sysfs fallback Mimi Zohar
2018-05-29 18:01 ` Mimi Zohar
2018-05-29 18:01 ` Mimi Zohar
2018-06-01 18:19 ` Luis R. Rodriguez
2018-06-01 18:19 ` Luis R. Rodriguez
2018-06-01 18:19 ` Luis R. Rodriguez
2018-05-29 18:01 ` [PATCH v4 5/8] ima: based on policy require signed firmware (sysfs fallback) Mimi Zohar
2018-05-29 18:01 ` Mimi Zohar
2018-05-29 18:01 ` Mimi Zohar
2018-06-01 18:21 ` Luis R. Rodriguez
2018-06-01 18:21 ` Luis R. Rodriguez
2018-06-01 18:21 ` Luis R. Rodriguez
2018-06-01 22:39 ` Mimi Zohar
2018-06-01 22:39 ` Mimi Zohar
2018-06-01 22:39 ` Mimi Zohar
2018-06-01 22:39 ` Mimi Zohar
2018-06-01 22:46 ` Luis R. Rodriguez
2018-06-01 22:46 ` Luis R. Rodriguez
2018-06-01 22:46 ` Luis R. Rodriguez
2018-06-01 22:46 ` Luis R. Rodriguez
2018-06-01 23:04 ` Mimi Zohar
2018-06-01 23:04 ` Mimi Zohar
2018-06-01 23:04 ` Mimi Zohar
2018-06-01 23:04 ` Mimi Zohar
2018-05-29 18:01 ` [PATCH v4 6/8] ima: add build time policy Mimi Zohar
2018-05-29 18:01 ` Mimi Zohar
2018-05-29 18:01 ` Mimi Zohar
2018-05-29 18:01 ` [RFC PATCH v4 7/8] ima: based on policy prevent loading firmware (pre-allocated buffer) Mimi Zohar
2018-05-29 18:01 ` Mimi Zohar
2018-05-29 18:01 ` Mimi Zohar
2018-06-01 19:15 ` Luis R. Rodriguez
2018-06-01 19:15 ` Luis R. Rodriguez
2018-06-01 19:15 ` Luis R. Rodriguez
2018-06-01 19:25 ` Luis R. Rodriguez
2018-06-01 19:25 ` Luis R. Rodriguez
2018-06-01 19:25 ` Luis R. Rodriguez
2018-06-05 22:37 ` Kees Cook
2018-06-05 22:37 ` Kees Cook
2018-06-05 22:37 ` Kees Cook
2018-06-06 6:20 ` Ard Biesheuvel
2018-06-06 6:20 ` Ard Biesheuvel
2018-06-06 6:20 ` Ard Biesheuvel
2018-06-06 22:06 ` Luis R. Rodriguez
2018-06-06 22:06 ` Luis R. Rodriguez
2018-06-06 22:06 ` Luis R. Rodriguez
2018-05-29 18:02 ` [PATCH v4 8/8] module: replace the existing LSM hook in init_module Mimi Zohar
2018-05-29 18:02 ` Mimi Zohar
2018-05-29 18:02 ` Mimi Zohar
2018-05-29 22:39 ` Paul Moore
2018-05-29 22:39 ` Paul Moore
2018-05-29 22:39 ` Paul Moore
2018-05-29 23:14 ` Mimi Zohar
2018-05-29 23:14 ` Mimi Zohar
2018-05-29 23:14 ` Mimi Zohar
2018-05-29 23:14 ` Mimi Zohar
2018-05-30 21:00 ` Paul Moore
2018-05-30 21:00 ` Paul Moore
2018-05-30 21:00 ` Paul Moore
2018-05-31 15:23 ` [PATCH v4a " Mimi Zohar
2018-05-31 15:23 ` Mimi Zohar
2018-05-31 15:23 ` Mimi Zohar
2018-06-01 22:28 ` Paul Moore
2018-06-01 22:28 ` Paul Moore
2018-06-01 22:28 ` Paul Moore
2018-06-04 9:19 ` Jessica Yu
2018-06-04 9:19 ` Jessica Yu
2018-06-04 9:19 ` Jessica Yu
2018-06-05 19:45 ` Kees Cook
2018-06-05 19:45 ` Kees Cook
2018-06-05 19:45 ` Kees Cook
2018-06-05 21:35 ` Mimi Zohar
2018-06-05 21:35 ` Mimi Zohar
2018-06-05 21:35 ` Mimi Zohar
2018-06-05 21:35 ` Mimi Zohar
2018-06-05 22:26 ` Kees Cook [this message]
2018-06-05 22:26 ` Kees Cook
2018-06-05 22:26 ` Kees Cook
2018-06-05 22:40 ` Mimi Zohar
2018-06-05 22:40 ` Mimi Zohar
2018-06-05 22:40 ` Mimi Zohar
2018-06-05 22:40 ` Mimi Zohar
2018-05-29 23:25 ` [PATCH v4 " Mimi Zohar
2018-05-29 23:25 ` Mimi Zohar
2018-05-29 23:25 ` Mimi Zohar
2018-05-29 23:25 ` Mimi Zohar
2018-05-30 2:25 ` Eric W. Biederman
2018-05-30 2:25 ` Eric W. Biederman
2018-05-30 2:25 ` Eric W. Biederman
2018-05-30 21:09 ` Paul Moore
2018-05-30 21:09 ` Paul Moore
2018-05-30 21:09 ` Paul Moore
2018-06-04 14:03 ` [PATCH v4 0/8] kexec/firmware: support system wide policy requiring signatures Mimi Zohar
2018-06-04 14:03 ` Mimi Zohar
2018-06-04 14:03 ` Mimi Zohar
2018-06-04 14:03 ` Mimi Zohar
2018-06-04 19:32 ` Serge E. Hallyn
2018-06-04 19:32 ` Serge E. Hallyn
2018-06-04 19:32 ` Serge E. Hallyn
2018-06-04 19:32 ` Serge E. Hallyn
2018-06-04 19:53 ` Mimi Zohar
2018-06-04 19:53 ` Mimi Zohar
2018-06-04 19:53 ` Mimi Zohar
2018-06-04 19:53 ` Mimi Zohar
2018-06-04 22:03 ` Kees Cook
2018-06-04 22:03 ` Kees Cook
2018-06-04 22:03 ` Kees Cook
2018-06-05 4:09 ` Serge E. Hallyn
2018-06-05 4:09 ` Serge E. Hallyn
2018-06-05 4:09 ` Serge E. Hallyn
2018-06-05 12:19 ` Kees Cook
2018-06-05 12:19 ` Kees Cook
2018-06-05 12:19 ` Kees Cook
2018-06-05 13:25 ` Serge E. Hallyn
2018-06-05 13:25 ` Serge E. Hallyn
2018-06-05 13:25 ` Serge E. Hallyn
2018-06-05 13:43 ` Kees Cook
2018-06-05 13:43 ` Kees Cook
2018-06-05 13:43 ` Kees Cook
2018-06-05 14:05 ` Mimi Zohar
2018-06-05 14:05 ` Mimi Zohar
2018-06-05 14:05 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5j+9P9HLvwC4WfHoxXsz7vYA_raStVDPzA=tNR9f9vr9=Q@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=andresx7@gmail.com \
--cc=ard.biesheuvel@linaro.org \
--cc=casey@schaufler-ca.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeffv@google.com \
--cc=jmorris@namei.org \
--cc=kexec@lists.infradead.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=paul@paul-moore.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.