* [kernel-hardening] [RFC v2 PATCH 13.1/13] lkdtm: add tests for atomic over-/underflow
@ 2016-10-25 20:43 Kees Cook
2016-10-26 7:29 ` [kernel-hardening] " Reshetova, Elena
0 siblings, 1 reply; 8+ messages in thread
From: Kees Cook @ 2016-10-25 20:43 UTC (permalink / raw)
To: Hans Liljestrand; +Cc: Elena Reshetova, David Windsor, kernel-hardening
This adds additional tests for the remaining atomic functions. Since the
bulk of the logic is identical, the functions are generated with macros.
Based on work by Hans Liljestrand.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
This is a replacement for the 13/13 patch, using macros more extensively
and also ignores return values to avoid "calculated but unused" warnings.
---
drivers/misc/lkdtm.h | 24 +++++++++++++--
drivers/misc/lkdtm_bugs.c | 74 ++++++++++++++++++++++++++++++++---------------
drivers/misc/lkdtm_core.c | 24 +++++++++++++--
3 files changed, 95 insertions(+), 27 deletions(-)
diff --git a/drivers/misc/lkdtm.h b/drivers/misc/lkdtm.h
index fdf954c2107f..62a29b9cd767 100644
--- a/drivers/misc/lkdtm.h
+++ b/drivers/misc/lkdtm.h
@@ -19,8 +19,28 @@ void lkdtm_SOFTLOCKUP(void);
void lkdtm_HARDLOCKUP(void);
void lkdtm_SPINLOCKUP(void);
void lkdtm_HUNG_TASK(void);
-void lkdtm_ATOMIC_UNDERFLOW(void);
-void lkdtm_ATOMIC_OVERFLOW(void);
+void lkdtm_OVERFLOW_atomic_inc(void);
+void lkdtm_OVERFLOW_atomic_inc_return(void);
+void lkdtm_OVERFLOW_atomic_inc_and_test(void);
+void lkdtm_OVERFLOW_atomic_add(void);
+void lkdtm_OVERFLOW_atomic_add_return(void);
+void lkdtm_OVERFLOW_atomic_add_unless(void);
+void lkdtm_OVERFLOW_atomic_long_inc(void);
+void lkdtm_OVERFLOW_atomic_long_inc_return(void);
+void lkdtm_OVERFLOW_atomic_long_inc_and_test(void);
+void lkdtm_OVERFLOW_atomic_long_add(void);
+void lkdtm_OVERFLOW_atomic_long_add_return(void);
+void lkdtm_OVERFLOW_atomic_long_add_unless(void);
+void lkdtm_UNDERFLOW_atomic_dec(void);
+void lkdtm_UNDERFLOW_atomic_dec_return(void);
+void lkdtm_UNDERFLOW_atomic_sub(void);
+void lkdtm_UNDERFLOW_atomic_sub_return(void);
+void lkdtm_UNDERFLOW_atomic_sub_and_test(void);
+void lkdtm_UNDERFLOW_atomic_long_dec(void);
+void lkdtm_UNDERFLOW_atomic_long_dec_return(void);
+void lkdtm_UNDERFLOW_atomic_long_sub(void);
+void lkdtm_UNDERFLOW_atomic_long_sub_return(void);
+void lkdtm_UNDERFLOW_atomic_long_sub_and_test(void);
/* lkdtm_heap.c */
void lkdtm_OVERWRITE_ALLOCATION(void);
diff --git a/drivers/misc/lkdtm_bugs.c b/drivers/misc/lkdtm_bugs.c
index 182ae1894b32..2473bd275a87 100644
--- a/drivers/misc/lkdtm_bugs.c
+++ b/drivers/misc/lkdtm_bugs.c
@@ -123,26 +123,54 @@ void lkdtm_HUNG_TASK(void)
schedule();
}
-void lkdtm_ATOMIC_UNDERFLOW(void)
-{
- atomic_t under = ATOMIC_INIT(INT_MIN);
-
- pr_info("attempting good atomic increment\n");
- atomic_inc(&under);
- atomic_dec(&under);
-
- pr_info("attempting bad atomic underflow\n");
- atomic_dec(&under);
-}
-
-void lkdtm_ATOMIC_OVERFLOW(void)
-{
- atomic_t over = ATOMIC_INIT(INT_MAX);
-
- pr_info("attempting good atomic decrement\n");
- atomic_dec(&over);
- atomic_inc(&over);
-
- pr_info("attempting bad atomic overflow\n");
- atomic_inc(&over);
-}
+/*
+ * Handle the various atomic function prototypes (potentially ignoring
+ * return values).
+ */
+#define ATOMIC_ARG_X(func, x) func(x)
+#define ATOMIC_ARG_1_X(func, x) func(1, x)
+#define ATOMIC_RET_ARG_X(func, x) if (func(x)) ;
+#define ATOMIC_RET_ARG_1_X(func, x) if (func(1, x)) ;
+#define ATOMIC_RET_ARG_X_1_0(func, x) if (func(x, 1, 0)) ;
+
+#define ATOMIC_ANY(name, atomic_type, init_func, start, safe_func, \
+ test_func_proto, testfunc) \
+void lkdtm_##name##_##testfunc(void) \
+{ \
+ atomic_type atomic = init_func(start); \
+ \
+ pr_info("attempting good " #testfunc "\n"); \
+ safe_func(&atomic); \
+ test_func_proto(testfunc, &atomic); \
+ \
+ pr_info("attempting bad " #testfunc "\n"); \
+ test_func_proto(testfunc, &atomic); \
+}
+
+/* Declare underflow test functions for atomic_t and atomic_long_t types. */
+#define LKDTM_ATOMIC_UNDERFLOW(operation, test_func_proto) \
+ ATOMIC_ANY(UNDERFLOW, atomic_t, ATOMIC_INIT, INT_MIN, \
+ atomic_inc, test_func_proto, atomic_##operation) \
+ ATOMIC_ANY(UNDERFLOW, atomic_long_t, ATOMIC_LONG_INIT, \
+ LONG_MIN, atomic_long_inc, test_func_proto, \
+ atomic_long_##operation)
+
+/* Declare overflow test functions for atomic_t and atomic_long_t types. */
+#define LKDTM_ATOMIC_OVERFLOW(operation, test_func_proto) \
+ ATOMIC_ANY(OVERFLOW, atomic_t, ATOMIC_INIT, INT_MAX, \
+ atomic_dec, test_func_proto, atomic_##operation) \
+ ATOMIC_ANY(OVERFLOW, atomic_long_t, ATOMIC_LONG_INIT, \
+ LONG_MAX, atomic_long_dec, test_func_proto, \
+ atomic_long_##operation)
+
+LKDTM_ATOMIC_UNDERFLOW(dec, ATOMIC_ARG_X)
+LKDTM_ATOMIC_UNDERFLOW(dec_return, ATOMIC_RET_ARG_X)
+LKDTM_ATOMIC_UNDERFLOW(sub, ATOMIC_ARG_1_X)
+LKDTM_ATOMIC_UNDERFLOW(sub_return, ATOMIC_RET_ARG_1_X)
+LKDTM_ATOMIC_UNDERFLOW(sub_and_test, ATOMIC_RET_ARG_1_X)
+LKDTM_ATOMIC_OVERFLOW(inc, ATOMIC_ARG_X)
+LKDTM_ATOMIC_OVERFLOW(inc_return, ATOMIC_RET_ARG_X)
+LKDTM_ATOMIC_OVERFLOW(add, ATOMIC_ARG_1_X)
+LKDTM_ATOMIC_OVERFLOW(add_return, ATOMIC_RET_ARG_1_X)
+LKDTM_ATOMIC_OVERFLOW(add_unless, ATOMIC_RET_ARG_X_1_0)
+LKDTM_ATOMIC_OVERFLOW(inc_and_test, ATOMIC_RET_ARG_X)
diff --git a/drivers/misc/lkdtm_core.c b/drivers/misc/lkdtm_core.c
index f9154b8d67f6..05b097f02ce4 100644
--- a/drivers/misc/lkdtm_core.c
+++ b/drivers/misc/lkdtm_core.c
@@ -218,8 +218,28 @@ struct crashtype crashtypes[] = {
CRASHTYPE(WRITE_RO),
CRASHTYPE(WRITE_RO_AFTER_INIT),
CRASHTYPE(WRITE_KERN),
- CRASHTYPE(ATOMIC_UNDERFLOW),
- CRASHTYPE(ATOMIC_OVERFLOW),
+ CRASHTYPE(OVERFLOW_atomic_inc),
+ CRASHTYPE(OVERFLOW_atomic_inc_return),
+ CRASHTYPE(OVERFLOW_atomic_inc_and_test),
+ CRASHTYPE(OVERFLOW_atomic_add),
+ CRASHTYPE(OVERFLOW_atomic_add_return),
+ CRASHTYPE(OVERFLOW_atomic_add_unless),
+ CRASHTYPE(OVERFLOW_atomic_long_inc),
+ CRASHTYPE(OVERFLOW_atomic_long_inc_return),
+ CRASHTYPE(OVERFLOW_atomic_long_inc_and_test),
+ CRASHTYPE(OVERFLOW_atomic_long_add),
+ CRASHTYPE(OVERFLOW_atomic_long_add_return),
+ CRASHTYPE(OVERFLOW_atomic_long_add_unless),
+ CRASHTYPE(UNDERFLOW_atomic_dec),
+ CRASHTYPE(UNDERFLOW_atomic_dec_return),
+ CRASHTYPE(UNDERFLOW_atomic_sub),
+ CRASHTYPE(UNDERFLOW_atomic_sub_return),
+ CRASHTYPE(UNDERFLOW_atomic_sub_and_test),
+ CRASHTYPE(UNDERFLOW_atomic_long_dec),
+ CRASHTYPE(UNDERFLOW_atomic_long_dec_return),
+ CRASHTYPE(UNDERFLOW_atomic_long_sub),
+ CRASHTYPE(UNDERFLOW_atomic_long_sub_return),
+ CRASHTYPE(UNDERFLOW_atomic_long_sub_and_test),
CRASHTYPE(USERCOPY_HEAP_SIZE_TO),
CRASHTYPE(USERCOPY_HEAP_SIZE_FROM),
CRASHTYPE(USERCOPY_HEAP_FLAG_TO),
--
2.7.4
--
Kees Cook
Nexus Security
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [kernel-hardening] RE: [RFC v2 PATCH 13.1/13] lkdtm: add tests for atomic over-/underflow
2016-10-25 20:43 [kernel-hardening] [RFC v2 PATCH 13.1/13] lkdtm: add tests for atomic over-/underflow Kees Cook
@ 2016-10-26 7:29 ` Reshetova, Elena
2016-10-26 20:41 ` [kernel-hardening] " Kees Cook
0 siblings, 1 reply; 8+ messages in thread
From: Reshetova, Elena @ 2016-10-26 7:29 UTC (permalink / raw)
To: Kees Cook, Hans Liljestrand; +Cc: David Windsor, kernel-hardening
Thank you Kees! I applied the commit to our hardened_atomic_on_next branch and it will be included into the next rfc.
-----Original Message-----
From: Kees Cook [mailto:keescook@chromium.org]
Sent: Tuesday, October 25, 2016 11:43 PM
To: Hans Liljestrand <ishkamiel@gmail.com>
Cc: Reshetova, Elena <elena.reshetova@intel.com>; David Windsor <dwindsor@gmail.com>; kernel-hardening@lists.openwall.com
Subject: [RFC v2 PATCH 13.1/13] lkdtm: add tests for atomic over-/underflow
This adds additional tests for the remaining atomic functions. Since the bulk of the logic is identical, the functions are generated with macros.
Based on work by Hans Liljestrand.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
This is a replacement for the 13/13 patch, using macros more extensively and also ignores return values to avoid "calculated but unused" warnings.
---
drivers/misc/lkdtm.h | 24 +++++++++++++--
drivers/misc/lkdtm_bugs.c | 74 ++++++++++++++++++++++++++++++++---------------
drivers/misc/lkdtm_core.c | 24 +++++++++++++--
3 files changed, 95 insertions(+), 27 deletions(-)
diff --git a/drivers/misc/lkdtm.h b/drivers/misc/lkdtm.h index fdf954c2107f..62a29b9cd767 100644
--- a/drivers/misc/lkdtm.h
+++ b/drivers/misc/lkdtm.h
@@ -19,8 +19,28 @@ void lkdtm_SOFTLOCKUP(void); void lkdtm_HARDLOCKUP(void); void lkdtm_SPINLOCKUP(void); void lkdtm_HUNG_TASK(void); -void lkdtm_ATOMIC_UNDERFLOW(void); -void lkdtm_ATOMIC_OVERFLOW(void);
+void lkdtm_OVERFLOW_atomic_inc(void);
+void lkdtm_OVERFLOW_atomic_inc_return(void);
+void lkdtm_OVERFLOW_atomic_inc_and_test(void);
+void lkdtm_OVERFLOW_atomic_add(void);
+void lkdtm_OVERFLOW_atomic_add_return(void);
+void lkdtm_OVERFLOW_atomic_add_unless(void);
+void lkdtm_OVERFLOW_atomic_long_inc(void);
+void lkdtm_OVERFLOW_atomic_long_inc_return(void);
+void lkdtm_OVERFLOW_atomic_long_inc_and_test(void);
+void lkdtm_OVERFLOW_atomic_long_add(void);
+void lkdtm_OVERFLOW_atomic_long_add_return(void);
+void lkdtm_OVERFLOW_atomic_long_add_unless(void);
+void lkdtm_UNDERFLOW_atomic_dec(void);
+void lkdtm_UNDERFLOW_atomic_dec_return(void);
+void lkdtm_UNDERFLOW_atomic_sub(void);
+void lkdtm_UNDERFLOW_atomic_sub_return(void);
+void lkdtm_UNDERFLOW_atomic_sub_and_test(void);
+void lkdtm_UNDERFLOW_atomic_long_dec(void);
+void lkdtm_UNDERFLOW_atomic_long_dec_return(void);
+void lkdtm_UNDERFLOW_atomic_long_sub(void);
+void lkdtm_UNDERFLOW_atomic_long_sub_return(void);
+void lkdtm_UNDERFLOW_atomic_long_sub_and_test(void);
/* lkdtm_heap.c */
void lkdtm_OVERWRITE_ALLOCATION(void);
diff --git a/drivers/misc/lkdtm_bugs.c b/drivers/misc/lkdtm_bugs.c index 182ae1894b32..2473bd275a87 100644
--- a/drivers/misc/lkdtm_bugs.c
+++ b/drivers/misc/lkdtm_bugs.c
@@ -123,26 +123,54 @@ void lkdtm_HUNG_TASK(void)
schedule();
}
-void lkdtm_ATOMIC_UNDERFLOW(void)
-{
- atomic_t under = ATOMIC_INIT(INT_MIN);
-
- pr_info("attempting good atomic increment\n");
- atomic_inc(&under);
- atomic_dec(&under);
-
- pr_info("attempting bad atomic underflow\n");
- atomic_dec(&under);
-}
-
-void lkdtm_ATOMIC_OVERFLOW(void)
-{
- atomic_t over = ATOMIC_INIT(INT_MAX);
-
- pr_info("attempting good atomic decrement\n");
- atomic_dec(&over);
- atomic_inc(&over);
-
- pr_info("attempting bad atomic overflow\n");
- atomic_inc(&over);
-}
+/*
+ * Handle the various atomic function prototypes (potentially ignoring
+ * return values).
+ */
+#define ATOMIC_ARG_X(func, x) func(x)
+#define ATOMIC_ARG_1_X(func, x) func(1, x)
+#define ATOMIC_RET_ARG_X(func, x) if (func(x)) ;
+#define ATOMIC_RET_ARG_1_X(func, x) if (func(1, x)) ;
+#define ATOMIC_RET_ARG_X_1_0(func, x) if (func(x, 1, 0)) ;
+
+#define ATOMIC_ANY(name, atomic_type, init_func, start, safe_func, \
+ test_func_proto, testfunc) \
+void lkdtm_##name##_##testfunc(void) \
+{ \
+ atomic_type atomic = init_func(start); \
+ \
+ pr_info("attempting good " #testfunc "\n"); \
+ safe_func(&atomic); \
+ test_func_proto(testfunc, &atomic); \
+ \
+ pr_info("attempting bad " #testfunc "\n"); \
+ test_func_proto(testfunc, &atomic); \
+}
+
+/* Declare underflow test functions for atomic_t and atomic_long_t types. */
+#define LKDTM_ATOMIC_UNDERFLOW(operation, test_func_proto) \
+ ATOMIC_ANY(UNDERFLOW, atomic_t, ATOMIC_INIT, INT_MIN, \
+ atomic_inc, test_func_proto, atomic_##operation) \
+ ATOMIC_ANY(UNDERFLOW, atomic_long_t, ATOMIC_LONG_INIT, \
+ LONG_MIN, atomic_long_inc, test_func_proto, \
+ atomic_long_##operation)
+
+/* Declare overflow test functions for atomic_t and atomic_long_t types. */
+#define LKDTM_ATOMIC_OVERFLOW(operation, test_func_proto) \
+ ATOMIC_ANY(OVERFLOW, atomic_t, ATOMIC_INIT, INT_MAX, \
+ atomic_dec, test_func_proto, atomic_##operation) \
+ ATOMIC_ANY(OVERFLOW, atomic_long_t, ATOMIC_LONG_INIT, \
+ LONG_MAX, atomic_long_dec, test_func_proto, \
+ atomic_long_##operation)
+
+LKDTM_ATOMIC_UNDERFLOW(dec, ATOMIC_ARG_X)
+LKDTM_ATOMIC_UNDERFLOW(dec_return, ATOMIC_RET_ARG_X)
+LKDTM_ATOMIC_UNDERFLOW(sub, ATOMIC_ARG_1_X)
+LKDTM_ATOMIC_UNDERFLOW(sub_return, ATOMIC_RET_ARG_1_X)
+LKDTM_ATOMIC_UNDERFLOW(sub_and_test, ATOMIC_RET_ARG_1_X)
+LKDTM_ATOMIC_OVERFLOW(inc, ATOMIC_ARG_X)
+LKDTM_ATOMIC_OVERFLOW(inc_return, ATOMIC_RET_ARG_X)
+LKDTM_ATOMIC_OVERFLOW(add, ATOMIC_ARG_1_X)
+LKDTM_ATOMIC_OVERFLOW(add_return, ATOMIC_RET_ARG_1_X)
+LKDTM_ATOMIC_OVERFLOW(add_unless, ATOMIC_RET_ARG_X_1_0)
+LKDTM_ATOMIC_OVERFLOW(inc_and_test, ATOMIC_RET_ARG_X)
diff --git a/drivers/misc/lkdtm_core.c b/drivers/misc/lkdtm_core.c index f9154b8d67f6..05b097f02ce4 100644
--- a/drivers/misc/lkdtm_core.c
+++ b/drivers/misc/lkdtm_core.c
@@ -218,8 +218,28 @@ struct crashtype crashtypes[] = {
CRASHTYPE(WRITE_RO),
CRASHTYPE(WRITE_RO_AFTER_INIT),
CRASHTYPE(WRITE_KERN),
- CRASHTYPE(ATOMIC_UNDERFLOW),
- CRASHTYPE(ATOMIC_OVERFLOW),
+ CRASHTYPE(OVERFLOW_atomic_inc),
+ CRASHTYPE(OVERFLOW_atomic_inc_return),
+ CRASHTYPE(OVERFLOW_atomic_inc_and_test),
+ CRASHTYPE(OVERFLOW_atomic_add),
+ CRASHTYPE(OVERFLOW_atomic_add_return),
+ CRASHTYPE(OVERFLOW_atomic_add_unless),
+ CRASHTYPE(OVERFLOW_atomic_long_inc),
+ CRASHTYPE(OVERFLOW_atomic_long_inc_return),
+ CRASHTYPE(OVERFLOW_atomic_long_inc_and_test),
+ CRASHTYPE(OVERFLOW_atomic_long_add),
+ CRASHTYPE(OVERFLOW_atomic_long_add_return),
+ CRASHTYPE(OVERFLOW_atomic_long_add_unless),
+ CRASHTYPE(UNDERFLOW_atomic_dec),
+ CRASHTYPE(UNDERFLOW_atomic_dec_return),
+ CRASHTYPE(UNDERFLOW_atomic_sub),
+ CRASHTYPE(UNDERFLOW_atomic_sub_return),
+ CRASHTYPE(UNDERFLOW_atomic_sub_and_test),
+ CRASHTYPE(UNDERFLOW_atomic_long_dec),
+ CRASHTYPE(UNDERFLOW_atomic_long_dec_return),
+ CRASHTYPE(UNDERFLOW_atomic_long_sub),
+ CRASHTYPE(UNDERFLOW_atomic_long_sub_return),
+ CRASHTYPE(UNDERFLOW_atomic_long_sub_and_test),
CRASHTYPE(USERCOPY_HEAP_SIZE_TO),
CRASHTYPE(USERCOPY_HEAP_SIZE_FROM),
CRASHTYPE(USERCOPY_HEAP_FLAG_TO),
--
2.7.4
--
Kees Cook
Nexus Security
^ permalink raw reply [flat|nested] 8+ messages in thread
* [kernel-hardening] Re: [RFC v2 PATCH 13.1/13] lkdtm: add tests for atomic over-/underflow
2016-10-26 7:29 ` [kernel-hardening] " Reshetova, Elena
@ 2016-10-26 20:41 ` Kees Cook
2016-10-27 12:46 ` Hans Liljestrand
0 siblings, 1 reply; 8+ messages in thread
From: Kees Cook @ 2016-10-26 20:41 UTC (permalink / raw)
To: Reshetova, Elena; +Cc: Hans Liljestrand, David Windsor, kernel-hardening
On Wed, Oct 26, 2016 at 12:29 AM, Reshetova, Elena
<elena.reshetova@intel.com> wrote:
> Thank you Kees! I applied the commit to our hardened_atomic_on_next branch and it will be included into the next rfc.
Cool, thanks. I assume this should get atomic64_t and local_t tests as well?
-Kees
--
Kees Cook
Nexus Security
^ permalink raw reply [flat|nested] 8+ messages in thread
* [kernel-hardening] Re: [RFC v2 PATCH 13.1/13] lkdtm: add tests for atomic over-/underflow
2016-10-26 20:41 ` [kernel-hardening] " Kees Cook
@ 2016-10-27 12:46 ` Hans Liljestrand
2016-10-27 21:36 ` Kees Cook
0 siblings, 1 reply; 8+ messages in thread
From: Hans Liljestrand @ 2016-10-27 12:46 UTC (permalink / raw)
To: Kees Cook; +Cc: Reshetova, Elena, David Windsor, kernel-hardening
On Wed, Oct 26, 2016 at 01:41:34PM -0700, Kees Cook wrote:
> On Wed, Oct 26, 2016 at 12:29 AM, Reshetova, Elena
> <elena.reshetova@intel.com> wrote:
> > Thank you Kees! I applied the commit to our hardened_atomic_on_next branch and it will be included into the next rfc.
>
> Cool, thanks. I assume this should get atomic64_t and local_t tests as well?
>
Yes, I'm currently compiling a build with atomic64_t and local_t tests added.
With the improved lkdtm macros its much easier to add the extra types, thank
you Kees!
Regards,
-hans
^ permalink raw reply [flat|nested] 8+ messages in thread
* [kernel-hardening] Re: [RFC v2 PATCH 13.1/13] lkdtm: add tests for atomic over-/underflow
2016-10-27 12:46 ` Hans Liljestrand
@ 2016-10-27 21:36 ` Kees Cook
2016-10-28 2:30 ` AKASHI Takahiro
0 siblings, 1 reply; 8+ messages in thread
From: Kees Cook @ 2016-10-27 21:36 UTC (permalink / raw)
To: Hans Liljestrand; +Cc: Reshetova, Elena, David Windsor, kernel-hardening
On Thu, Oct 27, 2016 at 5:46 AM, Hans Liljestrand <ishkamiel@gmail.com> wrote:
> On Wed, Oct 26, 2016 at 01:41:34PM -0700, Kees Cook wrote:
>> On Wed, Oct 26, 2016 at 12:29 AM, Reshetova, Elena
>> <elena.reshetova@intel.com> wrote:
>> > Thank you Kees! I applied the commit to our hardened_atomic_on_next branch and it will be included into the next rfc.
>>
>> Cool, thanks. I assume this should get atomic64_t and local_t tests as well?
>>
>
> Yes, I'm currently compiling a build with atomic64_t and local_t tests added.
> With the improved lkdtm macros its much easier to add the extra types, thank
> you Kees!
Sure thing! I may have yet-another patch for this, as I didn't like
repeating the same things in three files whenever a new test was
added. Moar macro magick!
-Kees
--
Kees Cook
Nexus Security
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [kernel-hardening] Re: [RFC v2 PATCH 13.1/13] lkdtm: add tests for atomic over-/underflow
2016-10-27 21:36 ` Kees Cook
@ 2016-10-28 2:30 ` AKASHI Takahiro
2016-10-28 13:41 ` Hans Liljestrand
2016-10-28 17:21 ` Kees Cook
0 siblings, 2 replies; 8+ messages in thread
From: AKASHI Takahiro @ 2016-10-28 2:30 UTC (permalink / raw)
To: kernel-hardening
Cc: Kees Cook, Hans Liljestrand, Reshetova, Elena, David Windsor
On Thu, Oct 27, 2016 at 02:36:25PM -0700, Kees Cook wrote:
> On Thu, Oct 27, 2016 at 5:46 AM, Hans Liljestrand <ishkamiel@gmail.com> wrote:
> > On Wed, Oct 26, 2016 at 01:41:34PM -0700, Kees Cook wrote:
> >> On Wed, Oct 26, 2016 at 12:29 AM, Reshetova, Elena
> >> <elena.reshetova@intel.com> wrote:
> >> > Thank you Kees! I applied the commit to our hardened_atomic_on_next branch and it will be included into the next rfc.
> >>
> >> Cool, thanks. I assume this should get atomic64_t and local_t tests as well?
> >>
> >
> > Yes, I'm currently compiling a build with atomic64_t and local_t tests added.
> > With the improved lkdtm macros its much easier to add the extra types, thank
> > you Kees!
>
> Sure thing! I may have yet-another patch for this, as I didn't like
> repeating the same things in three files whenever a new test was
> added. Moar macro magick!
It would be nice to expose atomic* variables to userspace via debugfs
so that we can confirm that the values will not be changed if overflowed.
See the attached patch.
We will be able to check the test result:
# /bin/echo ATOMIC_ADD_OVERFLOW > /debug/provoke-crash/DIRECT
# echo $?
# if [ cat /debug/provoke-crash/atomic -eq INT_MAX ]; then
# echo PASS ; fi
Thanks,
-Takahiro AKASHI
>
> -Kees
>
> --
> Kees Cook
> Nexus Security
===8<===
>From c516b50b4764c5c1ba0dd39e3a5022d026e35514 Mon Sep 17 00:00:00 2001
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
Date: Fri, 28 Oct 2016 10:55:50 +0900
Subject: [PATCH] lkdtm: expose atomic variables via debugfs
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
drivers/misc/lkdtm.h | 2 ++
drivers/misc/lkdtm_bugs.c | 75 +++++++++++++++++++++++++++++++++++++----------
drivers/misc/lkdtm_core.c | 3 ++
3 files changed, 64 insertions(+), 16 deletions(-)
diff --git a/drivers/misc/lkdtm.h b/drivers/misc/lkdtm.h
index 0ef66ff..b4dd231 100644
--- a/drivers/misc/lkdtm.h
+++ b/drivers/misc/lkdtm.h
@@ -3,10 +3,12 @@
#define pr_fmt(fmt) "lkdtm: " fmt
+#include <linux/fs.h>
#include <linux/kernel.h>
/* lkdtm_bugs.c */
void __init lkdtm_bugs_init(int *recur_param);
+void __init lkdtm_bugs_init2(struct dentry *parent);
void lkdtm_PANIC(void);
void lkdtm_BUG(void);
void lkdtm_WARNING(void);
diff --git a/drivers/misc/lkdtm_bugs.c b/drivers/misc/lkdtm_bugs.c
index 7b4067b..dd5003f 100644
--- a/drivers/misc/lkdtm_bugs.c
+++ b/drivers/misc/lkdtm_bugs.c
@@ -5,6 +5,8 @@
* test source files.
*/
#include "lkdtm.h"
+#include <linux/debugfs.h>
+#include <linux/fs.h>
#include <linux/sched.h>
/*
@@ -35,6 +37,33 @@ static int recursive_loop(int remaining)
return recursive_loop(remaining - 1);
}
+/* from fs/debugfs/file.c */
+static int debugfs_atomic_long_t_set(void *data, u64 val)
+{
+ atomic_long_set((atomic_long_t *)data, val);
+ return 0;
+}
+
+static int debugfs_atomic_long_t_get(void *data, u64 *val)
+{
+ *val = atomic_long_read((atomic_long_t *)data);
+ return 0;
+}
+
+DEFINE_DEBUGFS_ATTRIBUTE(fops_atomic_long_t, debugfs_atomic_long_t_get,
+ debugfs_atomic_long_t_set, "%lld\n");
+
+static struct dentry *debugfs_create_atomic_long_t(const char *name,
+ umode_t mode,
+ struct dentry *parent, atomic_long_t *value)
+{
+ return debugfs_create_file_unsafe(name, mode, parent, value,
+ &fops_atomic_long_t);
+}
+
+static atomic_t atomic_var = ATOMIC_INIT(0);
+static atomic_long_t atomic_long_var = ATOMIC_LONG_INIT(0);
+
/* If the depth is negative, use the default, otherwise keep parameter. */
void __init lkdtm_bugs_init(int *recur_param)
{
@@ -44,6 +73,20 @@ void __init lkdtm_bugs_init(int *recur_param)
recur_count = *recur_param;
}
+void __init lkdtm_bugs_init2(struct dentry *parent)
+{
+ struct dentry *de;
+
+ de = debugfs_create_atomic_t("atomic", 0644, parent, &atomic_var);
+ if (de == NULL)
+ pr_err("could not create atomic dentry under debugfs\n");
+
+ de = debugfs_create_atomic_long_t("atomic-long", 0644, parent,
+ &atomic_long_var);
+ if (de == NULL)
+ pr_err("could not create atomic-long dentry under debugfs\n");
+}
+
void lkdtm_PANIC(void)
{
panic("dumptest");
@@ -125,53 +168,53 @@ void lkdtm_HUNG_TASK(void)
#define ATOMIC_LKDTM_MIN(tag,fun) void lkdtm_ATOMIC_##tag(void) \
{ \
- atomic_t atomic = ATOMIC_INIT(INT_MIN); \
+ atomic_set(&atomic_var, INT_MIN); \
\
pr_info("attempting good atomic_" #fun "\n"); \
- atomic_inc(&atomic); \
- TEST_FUNC(&atomic); \
+ atomic_inc(&atomic_var); \
+ TEST_FUNC(&atomic_var); \
\
pr_info("attempting bad atomic_" #fun "\n"); \
- TEST_FUNC(&atomic); \
+ TEST_FUNC(&atomic_var); \
}
#define ATOMIC_LKDTM_MAX(tag,fun,...) \
void lkdtm_ATOMIC_##tag(void) \
{ \
- atomic_t atomic = ATOMIC_INIT(INT_MAX); \
+ atomic_set(&atomic_var, INT_MAX); \
\
pr_info("attempting good atomic_" #fun "\n"); \
- atomic_dec(&atomic); \
- TEST_FUNC(&atomic); \
+ atomic_dec(&atomic_var); \
+ TEST_FUNC(&atomic_var); \
\
pr_info("attempting bad atomic_" #fun "\n"); \
- TEST_FUNC(&atomic); \
+ TEST_FUNC(&atomic_var); \
}
#define ATOMIC_LKDTM_LONG_MIN(tag,fun,...) \
void lkdtm_ATOMIC_LONG_##tag(void) \
{ \
- atomic_long_t atomic = ATOMIC_LONG_INIT(LONG_MIN); \
+ atomic_long_set(&atomic_long_var, LONG_MIN); \
\
pr_info("attempting good atomic_long_" #fun "\n"); \
- atomic_long_inc(&atomic); \
- TEST_FUNC(&atomic); \
+ atomic_long_inc(&atomic_long_var); \
+ TEST_FUNC(&atomic_long_var); \
\
pr_info("attempting bad atomic_long_" #fun "\n"); \
- TEST_FUNC(&atomic); \
+ TEST_FUNC(&atomic_long_var); \
}
#define ATOMIC_LKDTM_LONG_MAX(tag,fun,...) \
void lkdtm_ATOMIC_LONG_##tag(void) \
{ \
- atomic_long_t atomic = ATOMIC_LONG_INIT(LONG_MAX); \
+ atomic_long_set(&atomic_long_var, LONG_MAX); \
\
pr_info("attempting good atomic_long_" #fun "\n"); \
- atomic_long_dec(&atomic); \
- TEST_FUNC(&atomic); \
+ atomic_long_dec(&atomic_long_var); \
+ TEST_FUNC(&atomic_long_var); \
\
pr_info("attempting bad atomic_long_" #fun "\n"); \
- TEST_FUNC(&atomic); \
+ TEST_FUNC(&atomic_long_var); \
}
#define TEST_FUNC(x) atomic_dec(x)
diff --git a/drivers/misc/lkdtm_core.c b/drivers/misc/lkdtm_core.c
index 01d8540..6f5f9c2 100644
--- a/drivers/misc/lkdtm_core.c
+++ b/drivers/misc/lkdtm_core.c
@@ -536,6 +536,9 @@ static int __init lkdtm_module_init(void)
pr_info("No crash points registered, enable through debugfs\n");
}
+ /* misc setup */
+ lkdtm_bugs_init2(lkdtm_debugfs_root);
+
return 0;
out_err:
--
2.10.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [kernel-hardening] Re: [RFC v2 PATCH 13.1/13] lkdtm: add tests for atomic over-/underflow
2016-10-28 2:30 ` AKASHI Takahiro
@ 2016-10-28 13:41 ` Hans Liljestrand
2016-10-28 17:21 ` Kees Cook
1 sibling, 0 replies; 8+ messages in thread
From: Hans Liljestrand @ 2016-10-28 13:41 UTC (permalink / raw)
To: AKASHI Takahiro
Cc: kernel-hardening, Kees Cook, Reshetova, Elena, David Windsor
On Fri, Oct 28, 2016 at 11:30:28AM +0900, AKASHI Takahiro wrote:
> On Thu, Oct 27, 2016 at 02:36:25PM -0700, Kees Cook wrote:
> > On Thu, Oct 27, 2016 at 5:46 AM, Hans Liljestrand <ishkamiel@gmail.com> wrote:
> > > On Wed, Oct 26, 2016 at 01:41:34PM -0700, Kees Cook wrote:
> > >> On Wed, Oct 26, 2016 at 12:29 AM, Reshetova, Elena
> > >> <elena.reshetova@intel.com> wrote:
> > >> > Thank you Kees! I applied the commit to our hardened_atomic_on_next branch and it will be included into the next rfc.
> > >>
> > >> Cool, thanks. I assume this should get atomic64_t and local_t tests as well?
> > >>
> > >
> > > Yes, I'm currently compiling a build with atomic64_t and local_t tests added.
> > > With the improved lkdtm macros its much easier to add the extra types, thank
> > > you Kees!
> >
> > Sure thing! I may have yet-another patch for this, as I didn't like
> > repeating the same things in three files whenever a new test was
> > added. Moar macro magick!
>
> It would be nice to expose atomic* variables to userspace via debugfs
> so that we can confirm that the values will not be changed if overflowed.
> See the attached patch.
Yes, thanks! This definitely looks useful. I've been testing with a script that
parses the kernel logs, but that obviously doesn't test what the values end up
being. We actually just were troubleshooting an issue where this would have
helped greatly.
We can't unfortunately directly apply your patch since we just switched over to
using Kees' improved more-macros test implementation. We're currently furiously
trying to get a coherent next RFC together, but once I get the time I'll apply
the patch and rework it for the current test implementation.
Thanks,
-hans liljestrand
>
> We will be able to check the test result:
>
> # /bin/echo ATOMIC_ADD_OVERFLOW > /debug/provoke-crash/DIRECT
> # echo $?
> # if [ cat /debug/provoke-crash/atomic -eq INT_MAX ]; then
> # echo PASS ; fi
>
> Thanks,
> -Takahiro AKASHI
>
> >
> > -Kees
> >
> > --
> > Kees Cook
> > Nexus Security
> ===8<===
> From c516b50b4764c5c1ba0dd39e3a5022d026e35514 Mon Sep 17 00:00:00 2001
> From: AKASHI Takahiro <takahiro.akashi@linaro.org>
> Date: Fri, 28 Oct 2016 10:55:50 +0900
> Subject: [PATCH] lkdtm: expose atomic variables via debugfs
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
> drivers/misc/lkdtm.h | 2 ++
> drivers/misc/lkdtm_bugs.c | 75 +++++++++++++++++++++++++++++++++++++----------
> drivers/misc/lkdtm_core.c | 3 ++
> 3 files changed, 64 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/misc/lkdtm.h b/drivers/misc/lkdtm.h
> index 0ef66ff..b4dd231 100644
> --- a/drivers/misc/lkdtm.h
> +++ b/drivers/misc/lkdtm.h
> @@ -3,10 +3,12 @@
>
> #define pr_fmt(fmt) "lkdtm: " fmt
>
> +#include <linux/fs.h>
> #include <linux/kernel.h>
>
> /* lkdtm_bugs.c */
> void __init lkdtm_bugs_init(int *recur_param);
> +void __init lkdtm_bugs_init2(struct dentry *parent);
> void lkdtm_PANIC(void);
> void lkdtm_BUG(void);
> void lkdtm_WARNING(void);
> diff --git a/drivers/misc/lkdtm_bugs.c b/drivers/misc/lkdtm_bugs.c
> index 7b4067b..dd5003f 100644
> --- a/drivers/misc/lkdtm_bugs.c
> +++ b/drivers/misc/lkdtm_bugs.c
> @@ -5,6 +5,8 @@
> * test source files.
> */
> #include "lkdtm.h"
> +#include <linux/debugfs.h>
> +#include <linux/fs.h>
> #include <linux/sched.h>
>
> /*
> @@ -35,6 +37,33 @@ static int recursive_loop(int remaining)
> return recursive_loop(remaining - 1);
> }
>
> +/* from fs/debugfs/file.c */
> +static int debugfs_atomic_long_t_set(void *data, u64 val)
> +{
> + atomic_long_set((atomic_long_t *)data, val);
> + return 0;
> +}
> +
> +static int debugfs_atomic_long_t_get(void *data, u64 *val)
> +{
> + *val = atomic_long_read((atomic_long_t *)data);
> + return 0;
> +}
> +
> +DEFINE_DEBUGFS_ATTRIBUTE(fops_atomic_long_t, debugfs_atomic_long_t_get,
> + debugfs_atomic_long_t_set, "%lld\n");
> +
> +static struct dentry *debugfs_create_atomic_long_t(const char *name,
> + umode_t mode,
> + struct dentry *parent, atomic_long_t *value)
> +{
> + return debugfs_create_file_unsafe(name, mode, parent, value,
> + &fops_atomic_long_t);
> +}
> +
> +static atomic_t atomic_var = ATOMIC_INIT(0);
> +static atomic_long_t atomic_long_var = ATOMIC_LONG_INIT(0);
> +
> /* If the depth is negative, use the default, otherwise keep parameter. */
> void __init lkdtm_bugs_init(int *recur_param)
> {
> @@ -44,6 +73,20 @@ void __init lkdtm_bugs_init(int *recur_param)
> recur_count = *recur_param;
> }
>
> +void __init lkdtm_bugs_init2(struct dentry *parent)
> +{
> + struct dentry *de;
> +
> + de = debugfs_create_atomic_t("atomic", 0644, parent, &atomic_var);
> + if (de == NULL)
> + pr_err("could not create atomic dentry under debugfs\n");
> +
> + de = debugfs_create_atomic_long_t("atomic-long", 0644, parent,
> + &atomic_long_var);
> + if (de == NULL)
> + pr_err("could not create atomic-long dentry under debugfs\n");
> +}
> +
> void lkdtm_PANIC(void)
> {
> panic("dumptest");
> @@ -125,53 +168,53 @@ void lkdtm_HUNG_TASK(void)
>
> #define ATOMIC_LKDTM_MIN(tag,fun) void lkdtm_ATOMIC_##tag(void) \
> { \
> - atomic_t atomic = ATOMIC_INIT(INT_MIN); \
> + atomic_set(&atomic_var, INT_MIN); \
> \
> pr_info("attempting good atomic_" #fun "\n"); \
> - atomic_inc(&atomic); \
> - TEST_FUNC(&atomic); \
> + atomic_inc(&atomic_var); \
> + TEST_FUNC(&atomic_var); \
> \
> pr_info("attempting bad atomic_" #fun "\n"); \
> - TEST_FUNC(&atomic); \
> + TEST_FUNC(&atomic_var); \
> }
>
> #define ATOMIC_LKDTM_MAX(tag,fun,...) \
> void lkdtm_ATOMIC_##tag(void) \
> { \
> - atomic_t atomic = ATOMIC_INIT(INT_MAX); \
> + atomic_set(&atomic_var, INT_MAX); \
> \
> pr_info("attempting good atomic_" #fun "\n"); \
> - atomic_dec(&atomic); \
> - TEST_FUNC(&atomic); \
> + atomic_dec(&atomic_var); \
> + TEST_FUNC(&atomic_var); \
> \
> pr_info("attempting bad atomic_" #fun "\n"); \
> - TEST_FUNC(&atomic); \
> + TEST_FUNC(&atomic_var); \
> }
>
> #define ATOMIC_LKDTM_LONG_MIN(tag,fun,...) \
> void lkdtm_ATOMIC_LONG_##tag(void) \
> { \
> - atomic_long_t atomic = ATOMIC_LONG_INIT(LONG_MIN); \
> + atomic_long_set(&atomic_long_var, LONG_MIN); \
> \
> pr_info("attempting good atomic_long_" #fun "\n"); \
> - atomic_long_inc(&atomic); \
> - TEST_FUNC(&atomic); \
> + atomic_long_inc(&atomic_long_var); \
> + TEST_FUNC(&atomic_long_var); \
> \
> pr_info("attempting bad atomic_long_" #fun "\n"); \
> - TEST_FUNC(&atomic); \
> + TEST_FUNC(&atomic_long_var); \
> }
>
> #define ATOMIC_LKDTM_LONG_MAX(tag,fun,...) \
> void lkdtm_ATOMIC_LONG_##tag(void) \
> { \
> - atomic_long_t atomic = ATOMIC_LONG_INIT(LONG_MAX); \
> + atomic_long_set(&atomic_long_var, LONG_MAX); \
> \
> pr_info("attempting good atomic_long_" #fun "\n"); \
> - atomic_long_dec(&atomic); \
> - TEST_FUNC(&atomic); \
> + atomic_long_dec(&atomic_long_var); \
> + TEST_FUNC(&atomic_long_var); \
> \
> pr_info("attempting bad atomic_long_" #fun "\n"); \
> - TEST_FUNC(&atomic); \
> + TEST_FUNC(&atomic_long_var); \
> }
>
> #define TEST_FUNC(x) atomic_dec(x)
> diff --git a/drivers/misc/lkdtm_core.c b/drivers/misc/lkdtm_core.c
> index 01d8540..6f5f9c2 100644
> --- a/drivers/misc/lkdtm_core.c
> +++ b/drivers/misc/lkdtm_core.c
> @@ -536,6 +536,9 @@ static int __init lkdtm_module_init(void)
> pr_info("No crash points registered, enable through debugfs\n");
> }
>
> + /* misc setup */
> + lkdtm_bugs_init2(lkdtm_debugfs_root);
> +
> return 0;
>
> out_err:
> --
> 2.10.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [kernel-hardening] Re: [RFC v2 PATCH 13.1/13] lkdtm: add tests for atomic over-/underflow
2016-10-28 2:30 ` AKASHI Takahiro
2016-10-28 13:41 ` Hans Liljestrand
@ 2016-10-28 17:21 ` Kees Cook
1 sibling, 0 replies; 8+ messages in thread
From: Kees Cook @ 2016-10-28 17:21 UTC (permalink / raw)
To: AKASHI Takahiro
Cc: kernel-hardening, Hans Liljestrand, Reshetova, Elena, David Windsor
On Thu, Oct 27, 2016 at 7:30 PM, AKASHI Takahiro
<takahiro.akashi@linaro.org> wrote:
> On Thu, Oct 27, 2016 at 02:36:25PM -0700, Kees Cook wrote:
>> On Thu, Oct 27, 2016 at 5:46 AM, Hans Liljestrand <ishkamiel@gmail.com> wrote:
>> > On Wed, Oct 26, 2016 at 01:41:34PM -0700, Kees Cook wrote:
>> >> On Wed, Oct 26, 2016 at 12:29 AM, Reshetova, Elena
>> >> <elena.reshetova@intel.com> wrote:
>> >> > Thank you Kees! I applied the commit to our hardened_atomic_on_next branch and it will be included into the next rfc.
>> >>
>> >> Cool, thanks. I assume this should get atomic64_t and local_t tests as well?
>> >>
>> >
>> > Yes, I'm currently compiling a build with atomic64_t and local_t tests added.
>> > With the improved lkdtm macros its much easier to add the extra types, thank
>> > you Kees!
>>
>> Sure thing! I may have yet-another patch for this, as I didn't like
>> repeating the same things in three files whenever a new test was
>> added. Moar macro magick!
>
> It would be nice to expose atomic* variables to userspace via debugfs
> so that we can confirm that the values will not be changed if overflowed.
> See the attached patch.
>
> We will be able to check the test result:
>
> # /bin/echo ATOMIC_ADD_OVERFLOW > /debug/provoke-crash/DIRECT
> # echo $?
> # if [ cat /debug/provoke-crash/atomic -eq INT_MAX ]; then
> # echo PASS ; fi
>
> Thanks,
> -Takahiro AKASHI
>
>>
>> -Kees
>>
>> --
>> Kees Cook
>> Nexus Security
> ===8<===
> From c516b50b4764c5c1ba0dd39e3a5022d026e35514 Mon Sep 17 00:00:00 2001
> From: AKASHI Takahiro <takahiro.akashi@linaro.org>
> Date: Fri, 28 Oct 2016 10:55:50 +0900
> Subject: [PATCH] lkdtm: expose atomic variables via debugfs
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
> drivers/misc/lkdtm.h | 2 ++
> drivers/misc/lkdtm_bugs.c | 75 +++++++++++++++++++++++++++++++++++++----------
> drivers/misc/lkdtm_core.c | 3 ++
> 3 files changed, 64 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/misc/lkdtm.h b/drivers/misc/lkdtm.h
> index 0ef66ff..b4dd231 100644
> --- a/drivers/misc/lkdtm.h
> +++ b/drivers/misc/lkdtm.h
> @@ -3,10 +3,12 @@
>
> #define pr_fmt(fmt) "lkdtm: " fmt
>
> +#include <linux/fs.h>
> #include <linux/kernel.h>
>
> /* lkdtm_bugs.c */
> void __init lkdtm_bugs_init(int *recur_param);
> +void __init lkdtm_bugs_init2(struct dentry *parent);
> void lkdtm_PANIC(void);
> void lkdtm_BUG(void);
> void lkdtm_WARNING(void);
> diff --git a/drivers/misc/lkdtm_bugs.c b/drivers/misc/lkdtm_bugs.c
> index 7b4067b..dd5003f 100644
> --- a/drivers/misc/lkdtm_bugs.c
> +++ b/drivers/misc/lkdtm_bugs.c
> @@ -5,6 +5,8 @@
> * test source files.
> */
> #include "lkdtm.h"
> +#include <linux/debugfs.h>
> +#include <linux/fs.h>
> #include <linux/sched.h>
>
> /*
> @@ -35,6 +37,33 @@ static int recursive_loop(int remaining)
> return recursive_loop(remaining - 1);
> }
>
> +/* from fs/debugfs/file.c */
> +static int debugfs_atomic_long_t_set(void *data, u64 val)
> +{
> + atomic_long_set((atomic_long_t *)data, val);
> + return 0;
> +}
Ah yes! Thanks; I had been pondering how to correctly validate that
the values were correct after the protection triggered. Thanks!
I'll get a version of this into my hyper-macro-ized version of the
lkdtm patch and get it sent to Hans. :)
-Kees
--
Kees Cook
Nexus Security
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-10-28 17:21 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-25 20:43 [kernel-hardening] [RFC v2 PATCH 13.1/13] lkdtm: add tests for atomic over-/underflow Kees Cook
2016-10-26 7:29 ` [kernel-hardening] " Reshetova, Elena
2016-10-26 20:41 ` [kernel-hardening] " Kees Cook
2016-10-27 12:46 ` Hans Liljestrand
2016-10-27 21:36 ` Kees Cook
2016-10-28 2:30 ` AKASHI Takahiro
2016-10-28 13:41 ` Hans Liljestrand
2016-10-28 17:21 ` Kees Cook
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.