All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: PaX Team <pageexec@freemail.hu>,
	LKML <linux-kernel@vger.kernel.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Mathias Krause <minipli@googlemail.com>,
	Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"x86@kernel.org" <x86@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Emese Revfy <re.emese@gmail.com>,
	"kernel-hardening@lists.openwall.com" 
	<kernel-hardening@lists.openwall.com>,
	linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] introduce post-init read-only memory
Date: Wed, 9 Dec 2015 11:35:11 -0800	[thread overview]
Message-ID: <CAGXu5jLNpccwENe7c=uPeqFV+5ZFe+xOxS5djffPuEuCEw8gHQ@mail.gmail.com> (raw)
In-Reply-To: <565CCCBB.1070500@zytor.com>

On Mon, Nov 30, 2015 at 2:24 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 11/25/15 16:15, PaX Team wrote:
>> On 25 Nov 2015 at 15:31, Kees Cook wrote:
>>
>>> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
>>> index c4bd0e2c173c..772c784ba763 100644
>>> --- a/include/asm-generic/vmlinux.lds.h
>>> +++ b/include/asm-generic/vmlinux.lds.h
>>> @@ -256,6 +256,7 @@
>>>   .rodata           : AT(ADDR(.rodata) - LOAD_OFFSET) {              \
>>>    VMLINUX_SYMBOL(__start_rodata) = .;                       \
>>>    *(.rodata) *(.rodata.*)                                   \
>>> +            *(.data..ro_after_init) /* Read only after init */      \
>>    ^^^^^^^^^^^
>> looks like it's tabs vs. spaces...

Not sure what caused that, but I see it as tabs in my tree.

> One more thing... double dots I think has special meanings to gcc, so it
> might be better to avoid.

Hrm, I could find no information about this, so I've left it as-is.

-Kees

-- 
Kees Cook
Chrome OS & Brillo Security

WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: PaX Team <pageexec@freemail.hu>,
	LKML <linux-kernel@vger.kernel.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Mathias Krause <minipli@googlemail.com>,
	Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"x86@kernel.org" <x86@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Emese Revfy <re.emese@gmail.com>,
	"kernel-hardening@lists.openwall.com"
	<kernel-hardening@lists.openwall.com>,
	linux-arch <linux-arch@vger.kernel.org>
Subject: [kernel-hardening] Re: [PATCH v2 2/4] introduce post-init read-only memory
Date: Wed, 9 Dec 2015 11:35:11 -0800	[thread overview]
Message-ID: <CAGXu5jLNpccwENe7c=uPeqFV+5ZFe+xOxS5djffPuEuCEw8gHQ@mail.gmail.com> (raw)
In-Reply-To: <565CCCBB.1070500@zytor.com>

On Mon, Nov 30, 2015 at 2:24 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 11/25/15 16:15, PaX Team wrote:
>> On 25 Nov 2015 at 15:31, Kees Cook wrote:
>>
>>> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
>>> index c4bd0e2c173c..772c784ba763 100644
>>> --- a/include/asm-generic/vmlinux.lds.h
>>> +++ b/include/asm-generic/vmlinux.lds.h
>>> @@ -256,6 +256,7 @@
>>>   .rodata           : AT(ADDR(.rodata) - LOAD_OFFSET) {              \
>>>    VMLINUX_SYMBOL(__start_rodata) = .;                       \
>>>    *(.rodata) *(.rodata.*)                                   \
>>> +            *(.data..ro_after_init) /* Read only after init */      \
>>    ^^^^^^^^^^^
>> looks like it's tabs vs. spaces...

Not sure what caused that, but I see it as tabs in my tree.

> One more thing... double dots I think has special meanings to gcc, so it
> might be better to avoid.

Hrm, I could find no information about this, so I've left it as-is.

-Kees

-- 
Kees Cook
Chrome OS & Brillo Security

  reply	other threads:[~2015-12-09 19:35 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 23:31 [PATCH v2 0/4] introduce post-init read-only memory Kees Cook
2015-11-25 23:31 ` [kernel-hardening] " Kees Cook
2015-11-25 23:31 ` [PATCH v2 1/4] init: create cmdline param to disable readonly Kees Cook
2015-11-25 23:31   ` [kernel-hardening] " Kees Cook
2015-11-26  0:37   ` PaX Team
2015-11-26  0:37     ` [kernel-hardening] " PaX Team
2015-11-26  0:37     ` PaX Team
2015-11-26  0:37     ` PaX Team
2015-11-26  0:44   ` [kernel-hardening] " Greg KH
2015-11-26  0:44     ` Greg KH
2015-11-26  7:51   ` Ingo Molnar
2015-11-26  7:51     ` [kernel-hardening] " Ingo Molnar
2015-11-30 21:52     ` Kees Cook
2015-11-30 21:52       ` [kernel-hardening] " Kees Cook
2015-11-30 21:52       ` Kees Cook
2015-11-30 22:24       ` Russell King - ARM Linux
2015-11-30 22:24         ` [kernel-hardening] " Russell King - ARM Linux
2015-11-30 22:24         ` Russell King - ARM Linux
2015-11-30 22:34         ` Kees Cook
2015-11-30 22:34           ` [kernel-hardening] " Kees Cook
2015-11-30 22:34           ` Kees Cook
2015-12-01  7:24         ` Ingo Molnar
2015-12-01  7:24           ` [kernel-hardening] " Ingo Molnar
2015-12-01  7:24           ` Ingo Molnar
2015-12-01  7:19       ` Heiko Carstens
2015-12-01  7:19         ` [kernel-hardening] " Heiko Carstens
2015-12-01  7:19         ` Heiko Carstens
2015-11-25 23:31 ` [PATCH v2 2/4] introduce post-init read-only memory Kees Cook
2015-11-25 23:31   ` [kernel-hardening] " Kees Cook
2015-11-26  0:15   ` PaX Team
2015-11-26  0:15     ` [kernel-hardening] " PaX Team
2015-11-26  0:15     ` PaX Team
2015-11-26  0:15     ` PaX Team
2015-11-30 22:24     ` H. Peter Anvin
2015-11-30 22:24       ` [kernel-hardening] " H. Peter Anvin
2015-12-09 19:35       ` Kees Cook [this message]
2015-12-09 19:35         ` Kees Cook
2015-12-09 19:35         ` Kees Cook
2015-11-25 23:31 ` [PATCH v2 3/4] lkdtm: verify that __ro_after_init works correctly Kees Cook
2015-11-25 23:31   ` [kernel-hardening] " Kees Cook
2015-11-25 23:31 ` [PATCH v2 4/4] x86, vdso: mark vDSO read-only after init Kees Cook
2015-11-25 23:31   ` [kernel-hardening] " Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGXu5jLNpccwENe7c=uPeqFV+5ZFe+xOxS5djffPuEuCEw8gHQ@mail.gmail.com' \
    --to=keescook@chromium.org \
    --cc=arnd@arndb.de \
    --cc=hpa@zytor.com \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=minipli@googlemail.com \
    --cc=mpe@ellerman.id.au \
    --cc=pageexec@freemail.hu \
    --cc=re.emese@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.