All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@csie.org>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Lee Jones <lee.jones@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] [PATCH v3 09/12] mfd: axp20x: add axp20x-regulator cell for AXP803
Date: Tue, 18 Apr 2017 18:38:09 +0800	[thread overview]
Message-ID: <CAGb2v648fhGSjWoVYRxU+_kF5fhbnhmY2mQG16ORtBHf7pGx5w@mail.gmail.com> (raw)
In-Reply-To: <20170417115747.7300-10-icenowy@aosc.io>

On Mon, Apr 17, 2017 at 7:57 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
> As axp20x-regulator now supports AXP803, add a cell for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> Changes in v3:
> - Make the new cell one-liner.
>
>  drivers/mfd/axp20x.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 1dc6235778eb..431b7f118606 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -848,7 +848,8 @@ static struct mfd_cell axp803_cells[] = {
>                 .name                   = "axp20x-pek",
>                 .num_resources          = ARRAY_SIZE(axp803_pek_resources),
>                 .resources              = axp803_pek_resources,
> -       }
> +       },
> +       {       .name                   = "axp20x-regulator" }

It's best to have a trailing comma, so we don't have to change the line
again when we add more cells, like you just did with the previous line.

Otherwise,

Acked-by: Chen-Yu Tsai <wens@csie.org>

WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
To: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
Cc: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-arm-kernel
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: [linux-sunxi] [PATCH v3 09/12] mfd: axp20x: add axp20x-regulator cell for AXP803
Date: Tue, 18 Apr 2017 18:38:09 +0800	[thread overview]
Message-ID: <CAGb2v648fhGSjWoVYRxU+_kF5fhbnhmY2mQG16ORtBHf7pGx5w@mail.gmail.com> (raw)
In-Reply-To: <20170417115747.7300-10-icenowy-h8G6r0blFSE@public.gmane.org>

On Mon, Apr 17, 2017 at 7:57 PM, Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> wrote:
> As axp20x-regulator now supports AXP803, add a cell for it.
>
> Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
> ---
> Changes in v3:
> - Make the new cell one-liner.
>
>  drivers/mfd/axp20x.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 1dc6235778eb..431b7f118606 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -848,7 +848,8 @@ static struct mfd_cell axp803_cells[] = {
>                 .name                   = "axp20x-pek",
>                 .num_resources          = ARRAY_SIZE(axp803_pek_resources),
>                 .resources              = axp803_pek_resources,
> -       }
> +       },
> +       {       .name                   = "axp20x-regulator" }

It's best to have a trailing comma, so we don't have to change the line
again when we add more cells, like you just did with the previous line.

Otherwise,

Acked-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH v3 09/12] mfd: axp20x: add axp20x-regulator cell for AXP803
Date: Tue, 18 Apr 2017 18:38:09 +0800	[thread overview]
Message-ID: <CAGb2v648fhGSjWoVYRxU+_kF5fhbnhmY2mQG16ORtBHf7pGx5w@mail.gmail.com> (raw)
In-Reply-To: <20170417115747.7300-10-icenowy@aosc.io>

On Mon, Apr 17, 2017 at 7:57 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
> As axp20x-regulator now supports AXP803, add a cell for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> Changes in v3:
> - Make the new cell one-liner.
>
>  drivers/mfd/axp20x.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 1dc6235778eb..431b7f118606 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -848,7 +848,8 @@ static struct mfd_cell axp803_cells[] = {
>                 .name                   = "axp20x-pek",
>                 .num_resources          = ARRAY_SIZE(axp803_pek_resources),
>                 .resources              = axp803_pek_resources,
> -       }
> +       },
> +       {       .name                   = "axp20x-regulator" }

It's best to have a trailing comma, so we don't have to change the line
again when we add more cells, like you just did with the previous line.

Otherwise,

Acked-by: Chen-Yu Tsai <wens@csie.org>

  reply	other threads:[~2017-04-18 10:38 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17 11:57 [PATCH v3 00/12] AXP803 PMIC support for Pine64 Icenowy Zheng
2017-04-17 11:57 ` Icenowy Zheng
2017-04-17 11:57 ` Icenowy Zheng
2017-04-17 11:57 ` [PATCH v3 01/12] arm64: allwinner: a64: enable RSB on A64 Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-18  5:37   ` Maxime Ripard
2017-04-18  5:37     ` Maxime Ripard
2017-04-18  5:37     ` Maxime Ripard
2017-04-17 11:57 ` [PATCH v3 02/12] arm64: allwinner: a64: add NMI controller " Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-18  7:00   ` Maxime Ripard
2017-04-18  7:00     ` Maxime Ripard
2017-04-18  7:00     ` Maxime Ripard
2017-04-18 10:56     ` [linux-sunxi] " Icenowy Zheng
2017-04-18 10:56       ` Icenowy Zheng
2017-04-18 10:56       ` Icenowy Zheng
2017-04-20  5:58       ` [linux-sunxi] " Maxime Ripard
2017-04-20  5:58         ` Maxime Ripard
2017-04-20  5:58         ` Maxime Ripard
2017-04-20  7:03         ` [linux-sunxi] " icenowy
2017-04-20  7:03           ` icenowy at aosc.io
2017-04-20  7:03           ` icenowy-h8G6r0blFSE
2017-04-24  7:17           ` [linux-sunxi] " Maxime Ripard
2017-04-24  7:17             ` Maxime Ripard
2017-04-24  7:17             ` Maxime Ripard
2017-04-24 10:25             ` [linux-sunxi] " icenowy
2017-04-24 10:25               ` icenowy at aosc.io
2017-04-24 10:25               ` icenowy-h8G6r0blFSE
2017-04-17 11:57 ` [PATCH v3 03/12] dt-bindings: make AXP20X compatible strings one per line Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-18 10:35   ` [linux-sunxi] " Chen-Yu Tsai
2017-04-18 10:35     ` Chen-Yu Tsai
2017-04-18 10:35     ` Chen-Yu Tsai
2017-04-20 14:18   ` Rob Herring
2017-04-20 14:18     ` Rob Herring
2017-04-20 14:18     ` Rob Herring
2017-04-24 12:07   ` Lee Jones
2017-04-24 12:07     ` Lee Jones
2017-04-24 12:07     ` Lee Jones
2017-04-17 11:57 ` [PATCH v3 04/12] dt-bindings: add device tree binding for X-Powers AXP803 PMIC Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-24 12:08   ` Lee Jones
2017-04-24 12:08     ` Lee Jones
2017-04-24 12:08     ` Lee Jones
2017-04-17 11:57 ` [PATCH v3 05/12] mfd: axp20x: support AXP803 variant Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-24 12:09   ` Lee Jones
2017-04-24 12:09     ` Lee Jones
2017-04-24 12:09     ` Lee Jones
2017-04-17 11:57 ` [PATCH v3 06/12] arm64: allwinner: a64: add AXP803 node to Pine64 device tree Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-17 11:57 ` [PATCH v3 07/12] dt-bindings: add AXP803's regulator info Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-18 10:36   ` [linux-sunxi] " Chen-Yu Tsai
2017-04-18 10:36     ` Chen-Yu Tsai
2017-04-18 10:36     ` Chen-Yu Tsai
2017-04-24 12:09   ` Lee Jones
2017-04-24 12:09     ` Lee Jones
2017-04-24 12:09     ` Lee Jones
2017-04-17 11:57 ` [PATCH v3 08/12] regulator: axp20x-regulator: add support for AXP803 Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-18 12:07   ` [linux-sunxi] " Chen-Yu Tsai
2017-04-18 12:07     ` Chen-Yu Tsai
2017-04-18 12:07     ` Chen-Yu Tsai
2017-04-26 14:45   ` Mark Brown
2017-04-26 14:45     ` Mark Brown
2017-04-26 14:45     ` Mark Brown
2017-04-17 11:57 ` [PATCH v3 09/12] mfd: axp20x: add axp20x-regulator cell " Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-18 10:38   ` Chen-Yu Tsai [this message]
2017-04-18 10:38     ` [linux-sunxi] " Chen-Yu Tsai
2017-04-18 10:38     ` Chen-Yu Tsai
2017-04-18 10:55     ` Icenowy Zheng
2017-04-18 10:55       ` Icenowy Zheng
2017-04-18 10:55       ` Icenowy Zheng
2017-04-18 11:58       ` [linux-sunxi] " Chen-Yu Tsai
2017-04-18 11:58         ` Chen-Yu Tsai
2017-04-18 11:58         ` Chen-Yu Tsai
2017-04-17 11:57 ` [PATCH v3 10/12] arm64: allwinner: a64: add DTSI file for AXP803 PMIC Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-18  7:08   ` Maxime Ripard
2017-04-18  7:08     ` Maxime Ripard
2017-04-18  7:08     ` Maxime Ripard
2017-04-18  7:20   ` [linux-sunxi] " Chen-Yu Tsai
2017-04-18  7:20     ` Chen-Yu Tsai
2017-04-18  7:20     ` Chen-Yu Tsai
2017-04-17 11:57 ` [PATCH v3 11/12] arm64: allwinner: a64: enable AXP803 regulators for Pine64 Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-17 11:57 ` [PATCH v3 12/12] arm64: allwinner: a64: enable Wi-Fi " Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng
2017-04-17 11:57   ` Icenowy Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGb2v648fhGSjWoVYRxU+_kF5fhbnhmY2mQG16ORtBHf7pGx5w@mail.gmail.com \
    --to=wens@csie.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.io \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.