All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@csie.org>
To: "Mylène Josserand" <mylene.josserand@bootlin.com>
Cc: Russell King <linux@armlinux.org.uk>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	LABBE Corentin <clabbe.montjoie@gmail.com>,
	quentin.schulz@bootlin.com,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 01/13] ARM: move cputype definitions into another file
Date: Tue, 3 Apr 2018 14:52:45 +0800	[thread overview]
Message-ID: <CAGb2v64GL=1UcYs1tFp-mS07vbHBao82SEhyzUrUHB++2-EKBg@mail.gmail.com> (raw)
In-Reply-To: <20180403061836.3926-2-mylene.josserand@bootlin.com>

On Tue, Apr 3, 2018 at 2:18 PM, Mylène Josserand
<mylene.josserand@bootlin.com> wrote:
> To add the support for SMP on sun8i-a83t, we will use some
> definitions in an assembly file so move definitions into
> another file to separate C functions and macro defintions.

Instead of moving the definitions, you could guard all the C
stuff in "#ifndef __ASSEMBLY__". AFAIK a few header files do that.

ChenYu

> Signed-off-by: Mylène Josserand <mylene.josserand@bootlin.com>
> ---
>  arch/arm/include/asm/cputype.h     | 94 +-----------------------------------
>  arch/arm/include/asm/cputype_def.h | 98 ++++++++++++++++++++++++++++++++++++++

WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 01/13] ARM: move cputype definitions into another file
Date: Tue, 3 Apr 2018 14:52:45 +0800	[thread overview]
Message-ID: <CAGb2v64GL=1UcYs1tFp-mS07vbHBao82SEhyzUrUHB++2-EKBg@mail.gmail.com> (raw)
In-Reply-To: <20180403061836.3926-2-mylene.josserand@bootlin.com>

On Tue, Apr 3, 2018 at 2:18 PM, Myl?ne Josserand
<mylene.josserand@bootlin.com> wrote:
> To add the support for SMP on sun8i-a83t, we will use some
> definitions in an assembly file so move definitions into
> another file to separate C functions and macro defintions.

Instead of moving the definitions, you could guard all the C
stuff in "#ifndef __ASSEMBLY__". AFAIK a few header files do that.

ChenYu

> Signed-off-by: Myl?ne Josserand <mylene.josserand@bootlin.com>
> ---
>  arch/arm/include/asm/cputype.h     | 94 +-----------------------------------
>  arch/arm/include/asm/cputype_def.h | 98 ++++++++++++++++++++++++++++++++++++++

  reply	other threads:[~2018-04-03  6:53 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03  6:18 [PATCH v5 00/13] Sunxi: Add SMP support on A83T Mylène Josserand
2018-04-03  6:18 ` Mylène Josserand
2018-04-03  6:18 ` [PATCH v5 01/13] ARM: move cputype definitions into another file Mylène Josserand
2018-04-03  6:18   ` Mylène Josserand
2018-04-03  6:52   ` Chen-Yu Tsai [this message]
2018-04-03  6:52     ` Chen-Yu Tsai
2018-04-03  7:27     ` Mylène Josserand
2018-04-03  7:27       ` Mylène Josserand
2018-04-03  7:34       ` Chen-Yu Tsai
2018-04-03  7:34         ` Chen-Yu Tsai
2018-04-03 19:56     ` Florian Fainelli
2018-04-03 19:56       ` Florian Fainelli
2018-04-04 13:49       ` Mylène Josserand
2018-04-04 13:49         ` Mylène Josserand
2018-04-03  6:18 ` [PATCH v5 02/13] ARM: sunxi: smp: Move assembly code into a file Mylène Josserand
2018-04-03  6:18   ` Mylène Josserand
2018-04-03  6:18 ` [PATCH v5 03/13] ARM: sunxi: smp: Move cpu_resume assembly entry into file Mylène Josserand
2018-04-03  6:18   ` Mylène Josserand
2018-04-03  6:18 ` [PATCH v5 04/13] ARM: dts: sun8i: Add CPUCFG device node for A83T dtsi Mylène Josserand
2018-04-03  6:18   ` Mylène Josserand
2018-04-03  6:18   ` Mylène Josserand
2018-04-03  6:45   ` Chen-Yu Tsai
2018-04-03  6:45     ` Chen-Yu Tsai
2018-04-03  6:18 ` [PATCH v5 05/13] ARM: dts: sun8i: Add R_CPUCFG device node for the " Mylène Josserand
2018-04-03  6:18   ` Mylène Josserand
2018-04-03  9:07   ` Chen-Yu Tsai
2018-04-03  9:07     ` Chen-Yu Tsai
2018-04-03 19:52     ` Mylène Josserand
2018-04-03 19:52       ` Mylène Josserand
2018-04-03  6:18 ` [PATCH v5 06/13] ARM: dts: sun8i: a83t: Add CCI-400 node Mylène Josserand
2018-04-03  6:18   ` Mylène Josserand
2018-04-03  6:44   ` Chen-Yu Tsai
2018-04-03  6:44     ` Chen-Yu Tsai
2018-04-03  6:18 ` [PATCH v5 07/13] ARM: smp: Add initialization of CNTVOFF Mylène Josserand
2018-04-03  6:18   ` Mylène Josserand
2018-04-04 13:01   ` Marc Zyngier
2018-04-04 13:01     ` Marc Zyngier
2018-04-04 13:59     ` Mylène Josserand
2018-04-04 13:59       ` Mylène Josserand
2018-04-04 14:30       ` Marc Zyngier
2018-04-04 14:30         ` Marc Zyngier
2018-04-04 14:30         ` Marc Zyngier
2018-04-09  8:24         ` Geert Uytterhoeven
2018-04-09  8:24           ` Geert Uytterhoeven
2018-04-09  9:04           ` Marc Zyngier
2018-04-09  9:04             ` Marc Zyngier
2018-04-11  7:44           ` Mylène Josserand
2018-04-11  7:44             ` Mylène Josserand
2018-04-03  6:18 ` [PATCH v5 08/13] ARM: sunxi: " Mylène Josserand
2018-04-03  6:18   ` Mylène Josserand
2018-04-03  9:12   ` Maxime Ripard
2018-04-03  9:12     ` Maxime Ripard
2018-04-03 20:06     ` Mylène Josserand
2018-04-03 20:06       ` Mylène Josserand
2018-04-04  7:45       ` Maxime Ripard
2018-04-04  7:45         ` Maxime Ripard
2018-04-08  9:09         ` Mylène Josserand
2018-04-08  9:09           ` Mylène Josserand
2018-04-09  9:24           ` Maxime Ripard
2018-04-09  9:24             ` Maxime Ripard
2018-04-03 11:13   ` kbuild test robot
2018-04-03 11:13     ` kbuild test robot
2018-04-03 11:13     ` kbuild test robot
2018-04-03  6:18 ` [PATCH v5 09/13] ARM: sun9i: smp: Rename clusters's power-off Mylène Josserand
2018-04-03  6:18   ` Mylène Josserand
2018-04-03  9:06   ` Chen-Yu Tsai
2018-04-03  9:06     ` Chen-Yu Tsai
2018-04-03  6:18 ` [PATCH v5 10/13] ARM: sun9i: smp: Move structures Mylène Josserand
2018-04-03  6:18   ` Mylène Josserand
2018-04-03  8:47   ` Maxime Ripard
2018-04-03  8:47     ` Maxime Ripard
2018-04-03  8:51     ` Chen-Yu Tsai
2018-04-03  8:51       ` Chen-Yu Tsai
2018-04-03  6:18 ` [PATCH v5 11/13] ARM: sun9i: smp: Add is_sun9i field Mylène Josserand
2018-04-03  6:18   ` Mylène Josserand
2018-04-03  8:46   ` Maxime Ripard
2018-04-03  8:46     ` Maxime Ripard
2018-04-03  8:48     ` Chen-Yu Tsai
2018-04-03  8:48       ` Chen-Yu Tsai
2018-04-03 20:08       ` Mylène Josserand
2018-04-03 20:08         ` Mylène Josserand
2018-04-03  6:18 ` [PATCH v5 12/13] ARM: sun8i: smp: Add support for A83T Mylène Josserand
2018-04-03  6:18   ` Mylène Josserand
2018-04-03  8:47   ` Chen-Yu Tsai
2018-04-03  8:47     ` Chen-Yu Tsai
2018-04-03 20:21     ` Mylène Josserand
2018-04-03 20:21       ` Mylène Josserand
2018-04-03  6:18 ` [PATCH v5 13/13] ARM: dts: sun8i: Add enable-method for SMP support for the A83T SoC Mylène Josserand
2018-04-03  6:18   ` Mylène Josserand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGb2v64GL=1UcYs1tFp-mS07vbHBao82SEhyzUrUHB++2-EKBg@mail.gmail.com' \
    --to=wens@csie.org \
    --cc=clabbe.montjoie@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=mylene.josserand@bootlin.com \
    --cc=quentin.schulz@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.