All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@kernel.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: "open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"Heiko Stübner" <heiko@sntech.de>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Disable display for NanoPi R2S
Date: Thu, 21 Jan 2021 13:21:56 +0800	[thread overview]
Message-ID: <CAGb2v6630awuQy6hZAejDeUWFxV0q0t5Uhk5O2c0i8y8ThD-Mw@mail.gmail.com> (raw)
In-Reply-To: <c4553dfad1ad6792c4f22454c135ff55de77e2d6.1611186099.git.robin.murphy@arm.com>

On Thu, Jan 21, 2021 at 7:42 AM Robin Murphy <robin.murphy@arm.com> wrote:
>
> NanoPi R2S is headless, so rightly does not enable any of the display
> interface hardware, which currently provokes an obnoxious error in the
> boot log from the fake DRM device failing to find anything to bind to.
> It probably isn't *too* hard to obviate the fake device shenanigans
> entirely with a bit of driver reshuffling, but for now let's just
> disable it here to shut up the spurious error.

Maybe we should just drop the error message from the driver?

I should probably send a similar patch for the ROCK Pi E. :/

> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> index 2ee07d15a6e3..1eecad724f04 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> @@ -114,6 +114,10 @@
>         cpu-supply = <&vdd_arm>;
>  };
>
> +&display_subsystem {
> +       status = "disabled";
> +};
> +
>  &gmac2io {
>         assigned-clocks = <&cru SCLK_MAC2IO>, <&cru SCLK_MAC2IO_EXT>;
>         assigned-clock-parents = <&gmac_clk>, <&gmac_clk>;
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens@kernel.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: "open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"Heiko Stübner" <heiko@sntech.de>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Disable display for NanoPi R2S
Date: Thu, 21 Jan 2021 13:21:56 +0800	[thread overview]
Message-ID: <CAGb2v6630awuQy6hZAejDeUWFxV0q0t5Uhk5O2c0i8y8ThD-Mw@mail.gmail.com> (raw)
In-Reply-To: <c4553dfad1ad6792c4f22454c135ff55de77e2d6.1611186099.git.robin.murphy@arm.com>

On Thu, Jan 21, 2021 at 7:42 AM Robin Murphy <robin.murphy@arm.com> wrote:
>
> NanoPi R2S is headless, so rightly does not enable any of the display
> interface hardware, which currently provokes an obnoxious error in the
> boot log from the fake DRM device failing to find anything to bind to.
> It probably isn't *too* hard to obviate the fake device shenanigans
> entirely with a bit of driver reshuffling, but for now let's just
> disable it here to shut up the spurious error.

Maybe we should just drop the error message from the driver?

I should probably send a similar patch for the ROCK Pi E. :/

> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> index 2ee07d15a6e3..1eecad724f04 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> @@ -114,6 +114,10 @@
>         cpu-supply = <&vdd_arm>;
>  };
>
> +&display_subsystem {
> +       status = "disabled";
> +};
> +
>  &gmac2io {
>         assigned-clocks = <&cru SCLK_MAC2IO>, <&cru SCLK_MAC2IO_EXT>;
>         assigned-clock-parents = <&gmac_clk>, <&gmac_clk>;
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-21  5:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 23:41 [PATCH] arm64: dts: rockchip: Disable display for NanoPi R2S Robin Murphy
2021-01-20 23:41 ` Robin Murphy
2021-01-21  5:21 ` Chen-Yu Tsai [this message]
2021-01-21  5:21   ` Chen-Yu Tsai
2021-01-25 23:56 ` Heiko Stuebner
2021-01-25 23:56   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGb2v6630awuQy6hZAejDeUWFxV0q0t5Uhk5O2c0i8y8ThD-Mw@mail.gmail.com \
    --to=wens@kernel.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.