* [PATCH] arm64: dts: rockchip: Disable display for NanoPi R2S
@ 2021-01-20 23:41 ` Robin Murphy
0 siblings, 0 replies; 6+ messages in thread
From: Robin Murphy @ 2021-01-20 23:41 UTC (permalink / raw)
To: heiko; +Cc: linux-rockchip, linux-arm-kernel
NanoPi R2S is headless, so rightly does not enable any of the display
interface hardware, which currently provokes an obnoxious error in the
boot log from the fake DRM device failing to find anything to bind to.
It probably isn't *too* hard to obviate the fake device shenanigans
entirely with a bit of driver reshuffling, but for now let's just
disable it here to shut up the spurious error.
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
index 2ee07d15a6e3..1eecad724f04 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
@@ -114,6 +114,10 @@
cpu-supply = <&vdd_arm>;
};
+&display_subsystem {
+ status = "disabled";
+};
+
&gmac2io {
assigned-clocks = <&cru SCLK_MAC2IO>, <&cru SCLK_MAC2IO_EXT>;
assigned-clock-parents = <&gmac_clk>, <&gmac_clk>;
--
2.17.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] arm64: dts: rockchip: Disable display for NanoPi R2S
@ 2021-01-20 23:41 ` Robin Murphy
0 siblings, 0 replies; 6+ messages in thread
From: Robin Murphy @ 2021-01-20 23:41 UTC (permalink / raw)
To: heiko; +Cc: linux-rockchip, linux-arm-kernel
NanoPi R2S is headless, so rightly does not enable any of the display
interface hardware, which currently provokes an obnoxious error in the
boot log from the fake DRM device failing to find anything to bind to.
It probably isn't *too* hard to obviate the fake device shenanigans
entirely with a bit of driver reshuffling, but for now let's just
disable it here to shut up the spurious error.
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
index 2ee07d15a6e3..1eecad724f04 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
@@ -114,6 +114,10 @@
cpu-supply = <&vdd_arm>;
};
+&display_subsystem {
+ status = "disabled";
+};
+
&gmac2io {
assigned-clocks = <&cru SCLK_MAC2IO>, <&cru SCLK_MAC2IO_EXT>;
assigned-clock-parents = <&gmac_clk>, <&gmac_clk>;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Disable display for NanoPi R2S
2021-01-20 23:41 ` Robin Murphy
@ 2021-01-21 5:21 ` Chen-Yu Tsai
-1 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2021-01-21 5:21 UTC (permalink / raw)
To: Robin Murphy
Cc: open list:ARM/Rockchip SoC..., Heiko Stübner, linux-arm-kernel
On Thu, Jan 21, 2021 at 7:42 AM Robin Murphy <robin.murphy@arm.com> wrote:
>
> NanoPi R2S is headless, so rightly does not enable any of the display
> interface hardware, which currently provokes an obnoxious error in the
> boot log from the fake DRM device failing to find anything to bind to.
> It probably isn't *too* hard to obviate the fake device shenanigans
> entirely with a bit of driver reshuffling, but for now let's just
> disable it here to shut up the spurious error.
Maybe we should just drop the error message from the driver?
I should probably send a similar patch for the ROCK Pi E. :/
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> index 2ee07d15a6e3..1eecad724f04 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> @@ -114,6 +114,10 @@
> cpu-supply = <&vdd_arm>;
> };
>
> +&display_subsystem {
> + status = "disabled";
> +};
> +
> &gmac2io {
> assigned-clocks = <&cru SCLK_MAC2IO>, <&cru SCLK_MAC2IO_EXT>;
> assigned-clock-parents = <&gmac_clk>, <&gmac_clk>;
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Disable display for NanoPi R2S
@ 2021-01-21 5:21 ` Chen-Yu Tsai
0 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2021-01-21 5:21 UTC (permalink / raw)
To: Robin Murphy
Cc: open list:ARM/Rockchip SoC..., Heiko Stübner, linux-arm-kernel
On Thu, Jan 21, 2021 at 7:42 AM Robin Murphy <robin.murphy@arm.com> wrote:
>
> NanoPi R2S is headless, so rightly does not enable any of the display
> interface hardware, which currently provokes an obnoxious error in the
> boot log from the fake DRM device failing to find anything to bind to.
> It probably isn't *too* hard to obviate the fake device shenanigans
> entirely with a bit of driver reshuffling, but for now let's just
> disable it here to shut up the spurious error.
Maybe we should just drop the error message from the driver?
I should probably send a similar patch for the ROCK Pi E. :/
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> index 2ee07d15a6e3..1eecad724f04 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts
> @@ -114,6 +114,10 @@
> cpu-supply = <&vdd_arm>;
> };
>
> +&display_subsystem {
> + status = "disabled";
> +};
> +
> &gmac2io {
> assigned-clocks = <&cru SCLK_MAC2IO>, <&cru SCLK_MAC2IO_EXT>;
> assigned-clock-parents = <&gmac_clk>, <&gmac_clk>;
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Disable display for NanoPi R2S
2021-01-20 23:41 ` Robin Murphy
@ 2021-01-25 23:56 ` Heiko Stuebner
-1 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2021-01-25 23:56 UTC (permalink / raw)
To: Robin Murphy; +Cc: linux-rockchip, Heiko Stuebner, linux-arm-kernel
On Wed, 20 Jan 2021 23:41:39 +0000, Robin Murphy wrote:
> NanoPi R2S is headless, so rightly does not enable any of the display
> interface hardware, which currently provokes an obnoxious error in the
> boot log from the fake DRM device failing to find anything to bind to.
> It probably isn't *too* hard to obviate the fake device shenanigans
> entirely with a bit of driver reshuffling, but for now let's just
> disable it here to shut up the spurious error.
Applied, thanks!
[1/1] arm64: dts: rockchip: Disable display for NanoPi R2S
commit: 74532de460ec664e5a725507d1b59aa9e4d40776
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Disable display for NanoPi R2S
@ 2021-01-25 23:56 ` Heiko Stuebner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2021-01-25 23:56 UTC (permalink / raw)
To: Robin Murphy; +Cc: linux-rockchip, Heiko Stuebner, linux-arm-kernel
On Wed, 20 Jan 2021 23:41:39 +0000, Robin Murphy wrote:
> NanoPi R2S is headless, so rightly does not enable any of the display
> interface hardware, which currently provokes an obnoxious error in the
> boot log from the fake DRM device failing to find anything to bind to.
> It probably isn't *too* hard to obviate the fake device shenanigans
> entirely with a bit of driver reshuffling, but for now let's just
> disable it here to shut up the spurious error.
Applied, thanks!
[1/1] arm64: dts: rockchip: Disable display for NanoPi R2S
commit: 74532de460ec664e5a725507d1b59aa9e4d40776
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-25 23:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-20 23:41 [PATCH] arm64: dts: rockchip: Disable display for NanoPi R2S Robin Murphy
2021-01-20 23:41 ` Robin Murphy
2021-01-21 5:21 ` Chen-Yu Tsai
2021-01-21 5:21 ` Chen-Yu Tsai
2021-01-25 23:56 ` Heiko Stuebner
2021-01-25 23:56 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.