From: Chen-Yu Tsai <wens@kernel.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Chen-Yu Tsai <wens@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [linux-sunxi] Re: [PATCH v3 3/9] power: supply: axp20x_usb_power: allow disabling input current limiting
Date: Mon, 25 Mar 2019 10:45:01 +0800 [thread overview]
Message-ID: <CAGb2v66bh0UXcjScHRL5U4f_mBALDN6Vckt=9sjziz09qygcxA@mail.gmail.com> (raw)
In-Reply-To: <20190321093012.kg72voxs5kw5xtzu@flea>
On Thu, Mar 21, 2019 at 5:30 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Hi,
>
> The rest of the series is
> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
> On Thu, Mar 21, 2019 at 04:48:44PM +0800, Chen-Yu Tsai wrote:
> > From: Chen-Yu Tsai <wens@csie.org>
> >
> > The AXP PMICs allow the user to disable current limiting on the VBUS
> > input. While read-out of this setting was already supported by the
> > driver, it did not allow the user to configure the PMIC to disable
> > current limiting.
> >
> > Add support for this.
> >
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>
> Do we really want to do that though? That could have some pretty bad
> consequences.
If I understand the manual correctly, the PMIC has two mode of operation
with regards to VBUS. Normal operation means the PMIC will try to limit
the current draw to maintain VBUS above the set V_hold (defaults to 4.4V).
This is in addition to the current limit set in this patch.
The other mode of operation is bypass, where it ignores the voltage limit.
Not sure if it also ignores the current limit, but probably not. In any
case we don't support this mode in the driver.
So I can think of a few cases where this might be bad:
1. High current draw results in excessive voltage drop and heating over
line / traces due to insufficient conductor area. This should be covered
by the voltage holding mechanism.
2. Over taxing the external power supply. This should also result in some
voltage drop for simple power bricks. Advanced ones would either have
current limiting or over-current protection.
What bad consequences are you thinking of?
ChenYu
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
Cc: Chen-Yu Tsai <wens-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"open list:THERMAL"
<linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: Re: [PATCH v3 3/9] power: supply: axp20x_usb_power: allow disabling input current limiting
Date: Mon, 25 Mar 2019 10:45:01 +0800 [thread overview]
Message-ID: <CAGb2v66bh0UXcjScHRL5U4f_mBALDN6Vckt=9sjziz09qygcxA@mail.gmail.com> (raw)
In-Reply-To: <20190321093012.kg72voxs5kw5xtzu@flea>
On Thu, Mar 21, 2019 at 5:30 PM Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> wrote:
>
> Hi,
>
> The rest of the series is
> Acked-by: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
>
> On Thu, Mar 21, 2019 at 04:48:44PM +0800, Chen-Yu Tsai wrote:
> > From: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
> >
> > The AXP PMICs allow the user to disable current limiting on the VBUS
> > input. While read-out of this setting was already supported by the
> > driver, it did not allow the user to configure the PMIC to disable
> > current limiting.
> >
> > Add support for this.
> >
> > Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
>
> Do we really want to do that though? That could have some pretty bad
> consequences.
If I understand the manual correctly, the PMIC has two mode of operation
with regards to VBUS. Normal operation means the PMIC will try to limit
the current draw to maintain VBUS above the set V_hold (defaults to 4.4V).
This is in addition to the current limit set in this patch.
The other mode of operation is bypass, where it ignores the voltage limit.
Not sure if it also ignores the current limit, but probably not. In any
case we don't support this mode in the driver.
So I can think of a few cases where this might be bad:
1. High current draw results in excessive voltage drop and heating over
line / traces due to insufficient conductor area. This should be covered
by the voltage holding mechanism.
2. Over taxing the external power supply. This should also result in some
voltage drop for simple power bricks. Advanced ones would either have
current limiting or over-current protection.
What bad consequences are you thinking of?
ChenYu
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens@kernel.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: devicetree <devicetree@vger.kernel.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
Sebastian Reichel <sre@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
linux-sunxi <linux-sunxi@googlegroups.com>,
Chen-Yu Tsai <wens@kernel.org>, Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [linux-sunxi] Re: [PATCH v3 3/9] power: supply: axp20x_usb_power: allow disabling input current limiting
Date: Mon, 25 Mar 2019 10:45:01 +0800 [thread overview]
Message-ID: <CAGb2v66bh0UXcjScHRL5U4f_mBALDN6Vckt=9sjziz09qygcxA@mail.gmail.com> (raw)
In-Reply-To: <20190321093012.kg72voxs5kw5xtzu@flea>
On Thu, Mar 21, 2019 at 5:30 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> Hi,
>
> The rest of the series is
> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
> On Thu, Mar 21, 2019 at 04:48:44PM +0800, Chen-Yu Tsai wrote:
> > From: Chen-Yu Tsai <wens@csie.org>
> >
> > The AXP PMICs allow the user to disable current limiting on the VBUS
> > input. While read-out of this setting was already supported by the
> > driver, it did not allow the user to configure the PMIC to disable
> > current limiting.
> >
> > Add support for this.
> >
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>
> Do we really want to do that though? That could have some pretty bad
> consequences.
If I understand the manual correctly, the PMIC has two mode of operation
with regards to VBUS. Normal operation means the PMIC will try to limit
the current draw to maintain VBUS above the set V_hold (defaults to 4.4V).
This is in addition to the current limit set in this patch.
The other mode of operation is bypass, where it ignores the voltage limit.
Not sure if it also ignores the current limit, but probably not. In any
case we don't support this mode in the driver.
So I can think of a few cases where this might be bad:
1. High current draw results in excessive voltage drop and heating over
line / traces due to insufficient conductor area. This should be covered
by the voltage holding mechanism.
2. Over taxing the external power supply. This should also result in some
voltage drop for simple power bricks. Advanced ones would either have
current limiting or over-current protection.
What bad consequences are you thinking of?
ChenYu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-25 2:45 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 8:48 [PATCH v3 0/9] ARM: sun8i: a83t: Enable USB OTG Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-03-21 8:48 ` [PATCH v3 1/9] dt-bindings: power: supply: axp20x_usb_power: add axp813 compatible Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-03-21 8:48 ` [PATCH v3 2/9] power: supply: axp20x_usb_power: Fix typo in VBUS current limit macros Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-03-21 8:48 ` [PATCH v3 3/9] power: supply: axp20x_usb_power: allow disabling input current limiting Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-03-21 9:30 ` Maxime Ripard
2019-03-21 9:30 ` Maxime Ripard
2019-03-21 9:30 ` Maxime Ripard
2019-03-25 2:45 ` Chen-Yu Tsai [this message]
2019-03-25 2:45 ` [linux-sunxi] " Chen-Yu Tsai
2019-03-25 2:45 ` Chen-Yu Tsai
2019-03-25 8:58 ` [linux-sunxi] " Hans de Goede
2019-03-25 8:58 ` Hans de Goede
2019-03-25 8:58 ` Hans de Goede
2019-03-25 10:12 ` [linux-sunxi] " Chen-Yu Tsai
2019-03-25 10:12 ` Chen-Yu Tsai
2019-03-21 8:48 ` [PATCH v3 4/9] power: supply: axp20x_usb_power: use polling to detect vbus status change Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-03-21 8:48 ` [PATCH v3 5/9] power: supply: axp20x_usb_power: add function to get max current Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-03-21 8:48 ` [PATCH v3 6/9] power: supply: axp20x_usb_power: add support for AXP813 Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-03-21 8:48 ` [PATCH v3 7/9] mfd: axp20x: add USB power supply mfd cell to AXP813 Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-04-02 3:15 ` Lee Jones
2019-04-02 3:15 ` Lee Jones
2019-04-02 3:15 ` Lee Jones
2019-03-21 8:48 ` [PATCH v3 8/9] ARM: dtsi: axp81x: add USB power supply node Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-03-21 8:48 ` [PATCH v3 9/9] ARM: dts: sun8i: a83t: Enable USB OTG controller on some boards Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
2019-03-21 8:48 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v66bh0UXcjScHRL5U4f_mBALDN6Vckt=9sjziz09qygcxA@mail.gmail.com' \
--to=wens@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@bootlin.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.