Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.

From: Xinliang Liu <xinliang.liu@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>, seanpaul@google.com
Cc: Guodong Xu <guodong.xu@linaro.org>,
	Feng Chen <puck.chen@hisilicon.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"Liuxinliang (Matthew Liu)" <z.liuxinliang@hisilicon.com>,
	XinWei Kong <kong.kongxinwei@hisilicon.com>,
	stable@vger.kernel.org, Rongrong Zou <zourongrong@gmail.com>,
	Andrey Konovalov <andrey.konovalov@linaro.org>,
	LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
Date: Mon, 28 Aug 2017 16:44:30 +0800	[thread overview]
Message-ID: <CAGd==07ygp97ggXSAK5JCYweRZPFwjqa2WNV3g1fdyY6736pPw@mail.gmail.com> (raw)
In-Reply-To: <1502806465-17772-1-git-send-email-peter.griffin@linaro.org>

[-- Attachment #1.1: Type: text/plain, Size: 2008 bytes --]

Hi,

On 15 August 2017 at 22:14, Peter Griffin <peter.griffin@linaro.org> wrote:

> This patch fixes the following soft lockup:
>   BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>
> On weston idle-timeout the IP is powered down and reset
> asserted. On weston resume we get a massive vblank
> IRQ storm due to the LDI registers having lost some state.
>
> This state loss is caused by ade_crtc_atomic_begin() not
> calling ade_ldi_set_mode(). With this patch applied
> resuming from Weston idle-timeout works well.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Tested-by: John Stultz <john.stultz@linaro.org>
>

Thanks Peter,
This patch looks good to me.
Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org>

@Sean, could you please help to apply to drm-misc if others has no more
comments, thanks.

Thanks,
Xinliang

> Cc: stable@vger.kernel.org
> ---
>  drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> index c96c228..72c6357 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> @@ -519,9 +519,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc
> *crtc,
>  {
>         struct ade_crtc *acrtc = to_ade_crtc(crtc);
>         struct ade_hw_ctx *ctx = acrtc->ctx;
> +       struct drm_display_mode *mode = &crtc->state->mode;
> +       struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode;
>
>         if (!ctx->power_on)
>                 (void)ade_power_up(ctx);
> +       ade_ldi_set_mode(acrtc, mode, adj_mode);
>  }
>
>  static void ade_crtc_atomic_flush(struct drm_crtc *crtc,
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>

[-- Attachment #1.2: Type: text/html, Size: 4365 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel