Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.

From: liuxinliang <z.liuxinliang@hisilicon.com>
To: Peter Griffin <peter.griffin@linaro.org>,
	Xinliang Liu <xinliang.liu@linaro.org>
Cc: seanpaul@google.com, Guodong Xu <guodong.xu@linaro.org>,
	Feng Chen <puck.chen@hisilicon.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	XinWei Kong <kong.kongxinwei@hisilicon.com>,
	stable@vger.kernel.org, Rongrong Zou <zourongrong@gmail.com>,
	Andrey Konovalov <andrey.konovalov@linaro.org>,
	LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
Date: Wed, 25 Oct 2017 09:00:38 +0800	[thread overview]
Message-ID: <b4088051-d81d-d22c-12df-ed496558517a@hisilicon.com> (raw)
In-Reply-To: <CADrjBPpwz6zWJozPKHXgC4p+xnuWjZR+sc=DnjxzEVpBJE901Q@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 2491 bytes --]

Hi Peter,

On 2017/10/24 1:34, Peter Griffin wrote:
> Hi Xinliang,
>
> On 28 August 2017 at 10:27, Xinliang Liu <xinliang.liu@linaro.org 
> <mailto:xinliang.liu@linaro.org>> wrote:
>
>     Hi Daniel,
>
>     On 28 August 2017 at 16:51, Daniel Vetter <daniel@ffwll.ch
>     <mailto:daniel@ffwll.ch>> wrote:
>     > On Mon, Aug 28, 2017 at 04:44:30PM +0800, Xinliang Liu wrote:
>     >> Hi,
>     >>
>     >> On 15 August 2017 at 22:14, Peter Griffin
>     <peter.griffin@linaro.org <mailto:peter.griffin@linaro.org>> wrote:
>     >>
>     >> > This patch fixes the following soft lockup:
>     >> >   BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>     >> >
>     >> > On weston idle-timeout the IP is powered down and reset
>     >> > asserted. On weston resume we get a massive vblank
>     >> > IRQ storm due to the LDI registers having lost some state.
>     >> >
>     >> > This state loss is caused by ade_crtc_atomic_begin() not
>     >> > calling ade_ldi_set_mode(). With this patch applied
>     >> > resuming from Weston idle-timeout works well.
>     >> >
>     >> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org
>     <mailto:peter.griffin@linaro.org>>
>     >> > Tested-by: John Stultz <john.stultz@linaro.org
>     <mailto:john.stultz@linaro.org>>
>     >> >
>     >>
>     >> Thanks Peter,
>     >> This patch looks good to me.
>     >> Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org
>     <mailto:xinliang.liu@linaro.org>>
>     >>
>     >> @Sean, could you please help to apply to drm-misc if others has
>     no more
>     >> comments, thanks.
>     >
>     > hisilicon isn't maintained in drm-misc, and you're the
>     maintainer. This is
>     > not how it works. So either
>     > a) pick up the patch and send out a pull request to Dave Airlie
>     > b) move hisilicon over to drm-misc and become a drm-misc maintainer
>     > yourself. This needs a MAINTAINERS update to point the git tree at
>     > drm-misc.
>     >
>     > drm-misc maintainers don't maintain everyone else's driver as a
>     service,
>     > that simply doesn't scale.
>
>     Sorry for my misunderstanding and thanks for pointing out that how
>     drm-misc works.
>     So I will pick up the patch and send a pull request.
>
>
> Did you send the pull request?
>
> I still can't see this patch in the latest kernel RC.
I have sent in last cycle, it seems it didn't catch last cycle. Maybe I 
need to resend again this cycle.
Will send soon.

Thanks,
Xinliang
>
> Peter.

[-- Attachment #1.2: Type: text/html, Size: 5482 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel