All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	lkml <linux-kernel@vger.kernel.org>,
	"Liuxinliang (Matthew Liu)" <z.liuxinliang@hisilicon.com>,
	Rongrong Zou <zourongrong@gmail.com>,
	XinWei Kong <kong.kongxinwei@hisilicon.com>,
	Feng Chen <puck.chen@hisilicon.com>,
	David Airlie <airlied@linux.ie>, stable <stable@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Andrey Konovalov <andrey.konovalov@linaro.org>,
	Fathi Boudra <fathi.boudra@linaro.org>
Subject: Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
Date: Thu, 29 Jun 2017 14:10:16 -0700	[thread overview]
Message-ID: <CALAqxLX4FAA+USVqV2rnTWr3oQg57rWJK6z2OsyDuXdfEN9ihw@mail.gmail.com> (raw)
In-Reply-To: <1498769678-12155-1-git-send-email-peter.griffin@linaro.org>

On Thu, Jun 29, 2017 at 1:54 PM, Peter Griffin <peter.griffin@linaro.org> wrote:
> This patch fixes the following soft lockup:
>   BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>
> On weston idle-timeout the IP is powered down and reset
> asserted. On weston resume we get a massive vblank
> IRQ storm due to the LDI registers having lost some state.
>
> This state loss is caused by ade_crtc_atomic_begin() not
> calling ade_ldi_set_mode(). With this patch applied
> resuming from Weston idle-timeout works well.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>

While the issue hasn't seemingly come up with Android, I've been
running with this patch in my tree for a while without issue. So..
Tested-by: John Stultz <john.stultz@linaro.org>

thanks
-john

WARNING: multiple messages have this Message-ID (diff)
From: john.stultz@linaro.org (John Stultz)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
Date: Thu, 29 Jun 2017 14:10:16 -0700	[thread overview]
Message-ID: <CALAqxLX4FAA+USVqV2rnTWr3oQg57rWJK6z2OsyDuXdfEN9ihw@mail.gmail.com> (raw)
In-Reply-To: <1498769678-12155-1-git-send-email-peter.griffin@linaro.org>

On Thu, Jun 29, 2017 at 1:54 PM, Peter Griffin <peter.griffin@linaro.org> wrote:
> This patch fixes the following soft lockup:
>   BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>
> On weston idle-timeout the IP is powered down and reset
> asserted. On weston resume we get a massive vblank
> IRQ storm due to the LDI registers having lost some state.
>
> This state loss is caused by ade_crtc_atomic_begin() not
> calling ade_ldi_set_mode(). With this patch applied
> resuming from Weston idle-timeout works well.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>

While the issue hasn't seemingly come up with Android, I've been
running with this patch in my tree for a while without issue. So..
Tested-by: John Stultz <john.stultz@linaro.org>

thanks
-john

WARNING: multiple messages have this Message-ID (diff)
From: John Stultz <john.stultz@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: Feng Chen <puck.chen@hisilicon.com>,
	lkml <linux-kernel@vger.kernel.org>,
	stable <stable@vger.kernel.org>,
	"Liuxinliang (Matthew Liu)" <z.liuxinliang@hisilicon.com>,
	XinWei Kong <kong.kongxinwei@hisilicon.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Rongrong Zou <zourongrong@gmail.com>,
	Fathi Boudra <fathi.boudra@linaro.org>,
	Andrey Konovalov <andrey.konovalov@linaro.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.
Date: Thu, 29 Jun 2017 14:10:16 -0700	[thread overview]
Message-ID: <CALAqxLX4FAA+USVqV2rnTWr3oQg57rWJK6z2OsyDuXdfEN9ihw@mail.gmail.com> (raw)
In-Reply-To: <1498769678-12155-1-git-send-email-peter.griffin@linaro.org>

On Thu, Jun 29, 2017 at 1:54 PM, Peter Griffin <peter.griffin@linaro.org> wrote:
> This patch fixes the following soft lockup:
>   BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>
> On weston idle-timeout the IP is powered down and reset
> asserted. On weston resume we get a massive vblank
> IRQ storm due to the LDI registers having lost some state.
>
> This state loss is caused by ade_crtc_atomic_begin() not
> calling ade_ldi_set_mode(). With this patch applied
> resuming from Weston idle-timeout works well.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>

While the issue hasn't seemingly come up with Android, I've been
running with this patch in my tree for a while without issue. So..
Tested-by: John Stultz <john.stultz@linaro.org>

thanks
-john
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-06-29 21:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29 20:54 [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured Peter Griffin
2017-06-29 20:54 ` Peter Griffin
2017-06-29 21:10 ` John Stultz [this message]
2017-06-29 21:10   ` John Stultz
2017-06-29 21:10   ` John Stultz
2017-06-29 21:10   ` John Stultz
2017-06-30  5:55 ` Greg KH
2017-06-30  5:55   ` Greg KH
2017-06-30  5:55   ` Greg KH
2017-08-15 14:14 Peter Griffin
2017-08-15 14:14 ` Peter Griffin
2017-08-28  8:44 ` Xinliang Liu
2017-08-28  8:51   ` Daniel Vetter
2017-08-28  8:51     ` Daniel Vetter
2017-08-28  8:51     ` Daniel Vetter
2017-08-28  9:27     ` Xinliang Liu
2017-08-28  9:27       ` Xinliang Liu
2017-10-23 17:34       ` Peter Griffin
2017-10-25  1:00         ` liuxinliang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALAqxLX4FAA+USVqV2rnTWr3oQg57rWJK6z2OsyDuXdfEN9ihw@mail.gmail.com \
    --to=john.stultz@linaro.org \
    --cc=airlied@linux.ie \
    --cc=andrey.konovalov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fathi.boudra@linaro.org \
    --cc=kong.kongxinwei@hisilicon.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=puck.chen@hisilicon.com \
    --cc=stable@vger.kernel.org \
    --cc=z.liuxinliang@hisilicon.com \
    --cc=zourongrong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.