All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm: snapdragon: Use correct GICC register on APQ8016
@ 2021-06-14  4:27 Sheep Sun
  2021-06-14  5:59 ` Ramon Fried
  0 siblings, 1 reply; 2+ messages in thread
From: Sheep Sun @ 2021-06-14  4:27 UTC (permalink / raw)
  To: u-boot; +Cc: Sheep Sun, Mateusz Kulikowski, Ramon Fried, Tom Rini

The GICC register used by u-boot is 0x0a20c000, which is actually a GICC
for WCNSS, the WLAN processor. U-boot runs on the Application Processor,
therefore it should use APCS GICC instead. Hence, correct it with APCS GICC
register address.

Signed-off-by: Sheep Sun <sunxiaoyang2003@gmail.com>
---

 arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h b/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h
index 520e2e6bd7..d9a3b1af98 100644
--- a/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h
+++ b/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h
@@ -8,7 +8,7 @@
 #define _MACH_SYSMAP_APQ8016_H
 
 #define GICD_BASE			(0x0b000000)
-#define GICC_BASE			(0x0a20c000)
+#define GICC_BASE			(0x0b002000)
 
 /* Clocks: (from CLK_CTL_BASE)  */
 #define GPLL0_STATUS			(0x2101C)
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm: snapdragon: Use correct GICC register on APQ8016
  2021-06-14  4:27 [PATCH] arm: snapdragon: Use correct GICC register on APQ8016 Sheep Sun
@ 2021-06-14  5:59 ` Ramon Fried
  0 siblings, 0 replies; 2+ messages in thread
From: Ramon Fried @ 2021-06-14  5:59 UTC (permalink / raw)
  To: Sheep Sun; +Cc: U-Boot Mailing List, Mateusz Kulikowski, Tom Rini

On Mon, Jun 14, 2021 at 7:27 AM Sheep Sun <sunxiaoyang2003@gmail.com> wrote:
>
> The GICC register used by u-boot is 0x0a20c000, which is actually a GICC
> for WCNSS, the WLAN processor. U-boot runs on the Application Processor,
> therefore it should use APCS GICC instead. Hence, correct it with APCS GICC
> register address.
>
> Signed-off-by: Sheep Sun <sunxiaoyang2003@gmail.com>
> ---
>
>  arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h b/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h
> index 520e2e6bd7..d9a3b1af98 100644
> --- a/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h
> +++ b/arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h
> @@ -8,7 +8,7 @@
>  #define _MACH_SYSMAP_APQ8016_H
>
>  #define GICD_BASE                      (0x0b000000)
> -#define GICC_BASE                      (0x0a20c000)
> +#define GICC_BASE                      (0x0b002000)
>
>  /* Clocks: (from CLK_CTL_BASE)  */
>  #define GPLL0_STATUS                   (0x2101C)
> --
> 2.30.2
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-14 12:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-14  4:27 [PATCH] arm: snapdragon: Use correct GICC register on APQ8016 Sheep Sun
2021-06-14  5:59 ` Ramon Fried

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.