* [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c
@ 2019-05-17 17:49 Oscar Gomez Fuente
2019-05-20 18:35 ` Sven Van Asbroeck
2019-05-21 14:13 ` Sven Van Asbroeck
0 siblings, 2 replies; 10+ messages in thread
From: Oscar Gomez Fuente @ 2019-05-17 17:49 UTC (permalink / raw)
To: oscargomezf; +Cc: gregkh, thesven73, devel, linux-kernel
These changes solve a warning realated to an incorrect type inilizer in the function
fieldbus_poll.
Signed-off-by: Oscar Gomez Fuente <oscargomezf@gmail.com>
---
drivers/staging/fieldbus/dev_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fieldbus/dev_core.c b/drivers/staging/fieldbus/dev_core.c
index 60b851406..f6f5b92 100644
--- a/drivers/staging/fieldbus/dev_core.c
+++ b/drivers/staging/fieldbus/dev_core.c
@@ -211,16 +211,16 @@ static ssize_t fieldbus_write(struct file *filp, const char __user *buf,
return fbdev->write_area(fbdev, buf, size, offset);
}
-static unsigned int fieldbus_poll(struct file *filp, poll_table *wait)
+static __poll_t fieldbus_poll(struct file *filp, poll_table *wait)
{
struct fb_open_file *of = filp->private_data;
struct fieldbus_dev *fbdev = of->fbdev;
- unsigned int mask = POLLIN | POLLRDNORM | POLLOUT | POLLWRNORM;
+ __poll_t mask = EPOLLIN | EPOLLRDNORM | EPOLLOUT | EPOLLWRNORM;
poll_wait(filp, &fbdev->dc_wq, wait);
/* data changed ? */
if (fbdev->dc_event != of->dc_event)
- mask |= POLLPRI | POLLERR;
+ mask |= EPOLLPRI | EPOLLERR;
return mask;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c
2019-05-17 17:49 [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c Oscar Gomez Fuente
@ 2019-05-20 18:35 ` Sven Van Asbroeck
2019-05-20 19:39 ` Sven Van Asbroeck
2019-05-21 14:13 ` Sven Van Asbroeck
1 sibling, 1 reply; 10+ messages in thread
From: Sven Van Asbroeck @ 2019-05-20 18:35 UTC (permalink / raw)
To: Oscar Gomez Fuente; +Cc: Greg KH, devel, Linux Kernel Mailing List
Hi Oscar, thank you for your contribution! I have a question, see inline.
On Fri, May 17, 2019 at 1:50 PM Oscar Gomez Fuente
<oscargomezf@gmail.com> wrote:
>
> These changes solve a warning realated to an incorrect type inilizer in the function
> fieldbus_poll.
>
Where is this warning generated? Could you provide some brief instructions on
how to reproduce this warning?
Thanks,
Sven
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c
2019-05-20 18:35 ` Sven Van Asbroeck
@ 2019-05-20 19:39 ` Sven Van Asbroeck
2019-05-20 19:59 ` Oscar Gomez Fuente
0 siblings, 1 reply; 10+ messages in thread
From: Sven Van Asbroeck @ 2019-05-20 19:39 UTC (permalink / raw)
To: Oscar Gomez Fuente; +Cc: Greg KH, devel, Linux Kernel Mailing List
On Mon, May 20, 2019 at 2:35 PM Sven Van Asbroeck <thesven73@gmail.com> wrote:
>
> Hi Oscar, thank you for your contribution! I have a question, see inline.
>
> On Fri, May 17, 2019 at 1:50 PM Oscar Gomez Fuente
> <oscargomezf@gmail.com> wrote:
> >
> > These changes solve a warning realated to an incorrect type inilizer in the function
> > fieldbus_poll.
> >
This warning was generated by sparse, right?
$ make C=2 drivers/staging/fieldbus/
<snip>
CHECK drivers/staging/fieldbus/dev_core.c
drivers/staging/fieldbus/dev_core.c:232:27: warning: incorrect type in
initializer (different base types)
drivers/staging/fieldbus/dev_core.c:232:27: expected restricted
__poll_t ( *poll )( ... )
drivers/staging/fieldbus/dev_core.c:232:27: got unsigned int (
*<noident> )( ... )
<snip>
I will test your patch on actual h/w, probably tomorrow.
I don't expect to see any problems.
Sven
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c
2019-05-20 19:39 ` Sven Van Asbroeck
@ 2019-05-20 19:59 ` Oscar Gomez Fuente
0 siblings, 0 replies; 10+ messages in thread
From: Oscar Gomez Fuente @ 2019-05-20 19:59 UTC (permalink / raw)
To: Sven Van Asbroeck; +Cc: Greg KH, devel, Linux Kernel Mailing List
Hi Sven,
Yes.
Oscar Gomez Fuente
Óscar Gómez Fuente
Electronic Engineer & Degree in Physical Sciences
Mobile: 659.28.97.90
Email: oscargomezf@gmail.com
Website: www.oscargomezf.com
On Mon, 20 May 2019 at 21:39, Sven Van Asbroeck <thesven73@gmail.com> wrote:
>
> On Mon, May 20, 2019 at 2:35 PM Sven Van Asbroeck <thesven73@gmail.com> wrote:
> >
> > Hi Oscar, thank you for your contribution! I have a question, see inline.
> >
> > On Fri, May 17, 2019 at 1:50 PM Oscar Gomez Fuente
> > <oscargomezf@gmail.com> wrote:
> > >
> > > These changes solve a warning realated to an incorrect type inilizer in the function
> > > fieldbus_poll.
> > >
>
> This warning was generated by sparse, right?
>
> $ make C=2 drivers/staging/fieldbus/
> <snip>
> CHECK drivers/staging/fieldbus/dev_core.c
> drivers/staging/fieldbus/dev_core.c:232:27: warning: incorrect type in
> initializer (different base types)
> drivers/staging/fieldbus/dev_core.c:232:27: expected restricted
> __poll_t ( *poll )( ... )
> drivers/staging/fieldbus/dev_core.c:232:27: got unsigned int (
> *<noident> )( ... )
> <snip>
>
> I will test your patch on actual h/w, probably tomorrow.
> I don't expect to see any problems.
>
> Sven
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c
2019-05-17 17:49 [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c Oscar Gomez Fuente
2019-05-20 18:35 ` Sven Van Asbroeck
@ 2019-05-21 14:13 ` Sven Van Asbroeck
2019-05-21 14:17 ` Greg KH
1 sibling, 1 reply; 10+ messages in thread
From: Sven Van Asbroeck @ 2019-05-21 14:13 UTC (permalink / raw)
To: Oscar Gomez Fuente; +Cc: Greg KH, devel, Linux Kernel Mailing List
On Fri, May 17, 2019 at 1:50 PM Oscar Gomez Fuente
<oscargomezf@gmail.com> wrote:
>
> These changes solve a warning realated to an incorrect type inilizer in the function
> fieldbus_poll.
>
> Signed-off-by: Oscar Gomez Fuente <oscargomezf@gmail.com>
> ---
I've reviewed your patch and tested it on a live system. Everything looks good.
However, I believe that your commit message could be improved.
I am going to re-post this patch as v3 (keeping you as the author) but with
a (hopefully) improved commit message. If you provide positive feedback,
and nobody else has any comments, I will tag it with my Reviewed-by,
which will hopefully be Greg's cue to take the patch.
In the future you could perhaps run your patch through ./scripts/checkpatch.pl
before you post it? This should pick up missing commit messages, lines in the
commit msg that are too long, etc.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c
2019-05-21 14:13 ` Sven Van Asbroeck
@ 2019-05-21 14:17 ` Greg KH
2019-05-21 14:24 ` Sven Van Asbroeck
0 siblings, 1 reply; 10+ messages in thread
From: Greg KH @ 2019-05-21 14:17 UTC (permalink / raw)
To: Sven Van Asbroeck; +Cc: Oscar Gomez Fuente, devel, Linux Kernel Mailing List
On Tue, May 21, 2019 at 10:13:58AM -0400, Sven Van Asbroeck wrote:
> On Fri, May 17, 2019 at 1:50 PM Oscar Gomez Fuente
> <oscargomezf@gmail.com> wrote:
> >
> > These changes solve a warning realated to an incorrect type inilizer in the function
> > fieldbus_poll.
> >
> > Signed-off-by: Oscar Gomez Fuente <oscargomezf@gmail.com>
> > ---
>
> I've reviewed your patch and tested it on a live system. Everything looks good.
> However, I believe that your commit message could be improved.
>
> I am going to re-post this patch as v3 (keeping you as the author) but with
> a (hopefully) improved commit message. If you provide positive feedback,
> and nobody else has any comments, I will tag it with my Reviewed-by,
> which will hopefully be Greg's cue to take the patch.
Greg already took this patch a while ago :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c
2019-05-21 14:17 ` Greg KH
@ 2019-05-21 14:24 ` Sven Van Asbroeck
2019-05-21 14:51 ` Oscar Gomez Fuente
0 siblings, 1 reply; 10+ messages in thread
From: Sven Van Asbroeck @ 2019-05-21 14:24 UTC (permalink / raw)
To: Greg KH; +Cc: Oscar Gomez Fuente, devel, Linux Kernel Mailing List
On Tue, May 21, 2019 at 10:17 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
>
> Greg already took this patch a while ago :)
>
Thanks for bringing that up Greg, I'll double-check your tree next time.
Oscar, please ignore the v3 patch I posted.
Sven
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c
2019-05-21 14:24 ` Sven Van Asbroeck
@ 2019-05-21 14:51 ` Oscar Gomez Fuente
0 siblings, 0 replies; 10+ messages in thread
From: Oscar Gomez Fuente @ 2019-05-21 14:51 UTC (permalink / raw)
To: Sven Van Asbroeck; +Cc: Greg KH, devel, Linux Kernel Mailing List
Ok, perfect!
Oscar Gomez Fuente
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c
2019-05-17 16:53 Oscar Gomez Fuente
@ 2019-05-17 17:08 ` Greg KH
0 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2019-05-17 17:08 UTC (permalink / raw)
To: Oscar Gomez Fuente; +Cc: devel, linux-kernel, thesven73
On Fri, May 17, 2019 at 06:53:11PM +0200, Oscar Gomez Fuente wrote:
> Signed-off-by: Oscar Gomez Fuente <oscargomezf@gmail.com>
> ---
> drivers/staging/fieldbus/dev_core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
I don't take patches without any changelog text, sorry.
Please fix and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c
@ 2019-05-17 16:53 Oscar Gomez Fuente
2019-05-17 17:08 ` Greg KH
0 siblings, 1 reply; 10+ messages in thread
From: Oscar Gomez Fuente @ 2019-05-17 16:53 UTC (permalink / raw)
To: oscargomezf; +Cc: gregkh, thesven73, devel, linux-kernel
Signed-off-by: Oscar Gomez Fuente <oscargomezf@gmail.com>
---
drivers/staging/fieldbus/dev_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fieldbus/dev_core.c b/drivers/staging/fieldbus/dev_core.c
index 60b851406..f6f5b92 100644
--- a/drivers/staging/fieldbus/dev_core.c
+++ b/drivers/staging/fieldbus/dev_core.c
@@ -211,16 +211,16 @@ static ssize_t fieldbus_write(struct file *filp, const char __user *buf,
return fbdev->write_area(fbdev, buf, size, offset);
}
-static unsigned int fieldbus_poll(struct file *filp, poll_table *wait)
+static __poll_t fieldbus_poll(struct file *filp, poll_table *wait)
{
struct fb_open_file *of = filp->private_data;
struct fieldbus_dev *fbdev = of->fbdev;
- unsigned int mask = POLLIN | POLLRDNORM | POLLOUT | POLLWRNORM;
+ __poll_t mask = EPOLLIN | EPOLLRDNORM | EPOLLOUT | EPOLLWRNORM;
poll_wait(filp, &fbdev->dc_wq, wait);
/* data changed ? */
if (fbdev->dc_event != of->dc_event)
- mask |= POLLPRI | POLLERR;
+ mask |= EPOLLPRI | EPOLLERR;
return mask;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-05-21 14:52 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-17 17:49 [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c Oscar Gomez Fuente
2019-05-20 18:35 ` Sven Van Asbroeck
2019-05-20 19:39 ` Sven Van Asbroeck
2019-05-20 19:59 ` Oscar Gomez Fuente
2019-05-21 14:13 ` Sven Van Asbroeck
2019-05-21 14:17 ` Greg KH
2019-05-21 14:24 ` Sven Van Asbroeck
2019-05-21 14:51 ` Oscar Gomez Fuente
-- strict thread matches above, loose matches on Subject: below --
2019-05-17 16:53 Oscar Gomez Fuente
2019-05-17 17:08 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.