From: Sven Van Asbroeck <thesven73@gmail.com>
To: Andy Duan <fugang.duan@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH v1] ARM: imx6plus: enable internal routing of clk_enet_ref where possible
Date: Tue, 23 Jun 2020 22:56:21 -0400 [thread overview]
Message-ID: <CAGngYiWJ+0PVyNcvTSX+MXdKnO-=_w=jPtoaKZoAAExrXwxOyQ@mail.gmail.com> (raw)
In-Reply-To: <AM6PR0402MB3607AD6AA7968D3A93D93007FF950@AM6PR0402MB3607.eurprd04.prod.outlook.com>
Hi Andy,
On Tue, Jun 23, 2020 at 9:40 PM Andy Duan <fugang.duan@nxp.com> wrote:
>
> The patch looks good.
> Reviewed-by: Fugang Duan <fugang.duan@nxp.com>
Thank you !
To check we're on a plus, the patch uses:
cpu_is_imx6q() && imx_get_soc_revision() >= IMX_CHIP_REVISION_2_0
Fabio Estevam suggested that perhaps checking
of_machine_is_compatible("fsl,imx6qp")
might be preferable. What is your opinion on this?
WARNING: multiple messages have this Message-ID (diff)
From: Sven Van Asbroeck <thesven73@gmail.com>
To: Andy Duan <fugang.duan@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [PATCH v1] ARM: imx6plus: enable internal routing of clk_enet_ref where possible
Date: Tue, 23 Jun 2020 22:56:21 -0400 [thread overview]
Message-ID: <CAGngYiWJ+0PVyNcvTSX+MXdKnO-=_w=jPtoaKZoAAExrXwxOyQ@mail.gmail.com> (raw)
In-Reply-To: <AM6PR0402MB3607AD6AA7968D3A93D93007FF950@AM6PR0402MB3607.eurprd04.prod.outlook.com>
Hi Andy,
On Tue, Jun 23, 2020 at 9:40 PM Andy Duan <fugang.duan@nxp.com> wrote:
>
> The patch looks good.
> Reviewed-by: Fugang Duan <fugang.duan@nxp.com>
Thank you !
To check we're on a plus, the patch uses:
cpu_is_imx6q() && imx_get_soc_revision() >= IMX_CHIP_REVISION_2_0
Fabio Estevam suggested that perhaps checking
of_machine_is_compatible("fsl,imx6qp")
might be preferable. What is your opinion on this?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-24 2:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-13 20:17 [PATCH v1] ARM: imx6plus: enable internal routing of clk_enet_ref where possible Sven Van Asbroeck
2020-06-13 20:17 ` Sven Van Asbroeck
2020-06-23 11:53 ` Shawn Guo
2020-06-24 1:40 ` [EXT] " Andy Duan
2020-06-24 1:40 ` Andy Duan
2020-06-24 2:56 ` Sven Van Asbroeck [this message]
2020-06-24 2:56 ` Sven Van Asbroeck
2020-06-24 3:46 ` Andy Duan
2020-06-24 3:46 ` Andy Duan
2020-06-23 14:19 ` Fabio Estevam
2020-06-23 15:00 ` Sven Van Asbroeck
2020-06-23 15:00 ` Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGngYiWJ+0PVyNcvTSX+MXdKnO-=_w=jPtoaKZoAAExrXwxOyQ@mail.gmail.com' \
--to=thesven73@gmail.com \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.