* [PATCH v1] mtd: spi-nor: Add support for Winbond w25q64jv spi flash
@ 2020-06-13 23:53 ` Sven Van Asbroeck
0 siblings, 0 replies; 10+ messages in thread
From: Sven Van Asbroeck @ 2020-06-13 23:53 UTC (permalink / raw)
To: Tudor Ambarus, Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
Cc: linux-mtd, linux-kernel
This chip is (nearly) identical to the Winbond w25q64 which is
already supported by Linux. Compared to the w25q64, the 'jv'
does not support Quad SPI mode, and has a different JEDEC ID.
To: Tudor Ambarus <tudor.ambarus@microchip.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
---
Tree: next-20200613
drivers/mtd/spi-nor/winbond.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 5062af10f138..18bdff02f57f 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -65,6 +65,7 @@ static const struct flash_info winbond_parts[] = {
SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
{ "w25x64", INFO(0xef3017, 0, 64 * 1024, 128, SECT_4K) },
{ "w25q64", INFO(0xef4017, 0, 64 * 1024, 128, SECT_4K) },
+ { "w25q64jv", INFO(0xef7017, 0, 64 * 1024, 128, SECT_4K) },
{ "w25q64dw", INFO(0xef6017, 0, 64 * 1024, 128,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
--
2.17.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v1] mtd: spi-nor: Add support for Winbond w25q64jv spi flash
2020-06-13 23:53 ` Sven Van Asbroeck
@ 2020-06-24 17:15 ` Sven Van Asbroeck
-1 siblings, 0 replies; 10+ messages in thread
From: Sven Van Asbroeck @ 2020-06-24 17:15 UTC (permalink / raw)
To: Tudor Ambarus, Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
Cc: linux-mtd, Linux Kernel Mailing List
Is there any way I can help to get this patch into mainline?
Thank you,
Sven
On Sat, Jun 13, 2020 at 7:53 PM Sven Van Asbroeck <thesven73@gmail.com> wrote:
>
> This chip is (nearly) identical to the Winbond w25q64 which is
> already supported by Linux. Compared to the w25q64, the 'jv'
> does not support Quad SPI mode, and has a different JEDEC ID.
>
> To: Tudor Ambarus <tudor.ambarus@microchip.com>
> To: Miquel Raynal <miquel.raynal@bootlin.com>
> To: Richard Weinberger <richard@nod.at>
> To: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: linux-mtd@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
> ---
>
> Tree: next-20200613
>
> drivers/mtd/spi-nor/winbond.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 5062af10f138..18bdff02f57f 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -65,6 +65,7 @@ static const struct flash_info winbond_parts[] = {
> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> { "w25x64", INFO(0xef3017, 0, 64 * 1024, 128, SECT_4K) },
> { "w25q64", INFO(0xef4017, 0, 64 * 1024, 128, SECT_4K) },
> + { "w25q64jv", INFO(0xef7017, 0, 64 * 1024, 128, SECT_4K) },
> { "w25q64dw", INFO(0xef6017, 0, 64 * 1024, 128,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v1] mtd: spi-nor: Add support for Winbond w25q64jv spi flash
@ 2020-06-24 17:15 ` Sven Van Asbroeck
0 siblings, 0 replies; 10+ messages in thread
From: Sven Van Asbroeck @ 2020-06-24 17:15 UTC (permalink / raw)
To: Tudor Ambarus, Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
Cc: linux-mtd, Linux Kernel Mailing List
Is there any way I can help to get this patch into mainline?
Thank you,
Sven
On Sat, Jun 13, 2020 at 7:53 PM Sven Van Asbroeck <thesven73@gmail.com> wrote:
>
> This chip is (nearly) identical to the Winbond w25q64 which is
> already supported by Linux. Compared to the w25q64, the 'jv'
> does not support Quad SPI mode, and has a different JEDEC ID.
>
> To: Tudor Ambarus <tudor.ambarus@microchip.com>
> To: Miquel Raynal <miquel.raynal@bootlin.com>
> To: Richard Weinberger <richard@nod.at>
> To: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: linux-mtd@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
> ---
>
> Tree: next-20200613
>
> drivers/mtd/spi-nor/winbond.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 5062af10f138..18bdff02f57f 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -65,6 +65,7 @@ static const struct flash_info winbond_parts[] = {
> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> { "w25x64", INFO(0xef3017, 0, 64 * 1024, 128, SECT_4K) },
> { "w25q64", INFO(0xef4017, 0, 64 * 1024, 128, SECT_4K) },
> + { "w25q64jv", INFO(0xef7017, 0, 64 * 1024, 128, SECT_4K) },
> { "w25q64dw", INFO(0xef6017, 0, 64 * 1024, 128,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> --
> 2.17.1
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1] mtd: spi-nor: Add support for Winbond w25q64jv spi flash
2020-06-13 23:53 ` Sven Van Asbroeck
@ 2020-06-29 12:50 ` Tudor.Ambarus
-1 siblings, 0 replies; 10+ messages in thread
From: Tudor.Ambarus @ 2020-06-29 12:50 UTC (permalink / raw)
To: thesven73, miquel.raynal, richard, vigneshr; +Cc: linux-mtd, linux-kernel
Hi, Sven,
On 6/14/20 2:53 AM, Sven Van Asbroeck wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> This chip is (nearly) identical to the Winbond w25q64 which is
> already supported by Linux. Compared to the w25q64, the 'jv'
> does not support Quad SPI mode, and has a different JEDEC ID.
I'm reading the following datasheet:
https://www.winbond.com/resource-files/w25q64jv%20revj%2003272018%20plus.pdf
w25q64jvm (0xef7017) comes with QE bit set to a 0 state, but can be
set to 1, so Quad mode can be supported. Would you please set SPI_NOR_DUAL_READ
and SPI_NOR_QUAD_READ flags and test and see if Quad works? If all good,
please specify in the commit message with which controller you did the tests.
>
> To: Tudor Ambarus <tudor.ambarus@microchip.com>
> To: Miquel Raynal <miquel.raynal@bootlin.com>
> To: Richard Weinberger <richard@nod.at>
> To: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: linux-mtd@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
Are these tags really necessary? Would you drop them?
> Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
> ---
>
> Tree: next-20200613
>
> drivers/mtd/spi-nor/winbond.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 5062af10f138..18bdff02f57f 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -65,6 +65,7 @@ static const struct flash_info winbond_parts[] = {
> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> { "w25x64", INFO(0xef3017, 0, 64 * 1024, 128, SECT_4K) },
> { "w25q64", INFO(0xef4017, 0, 64 * 1024, 128, SECT_4K) },
> + { "w25q64jv", INFO(0xef7017, 0, 64 * 1024, 128, SECT_4K) },
I would name it "w25q64jvm". Check "11.ORDERING INFORMATION". Although the
datasheet refers to these flashes as "W25Q64JV-IQ/JQ" and "W25Q64JV-IM/JM",
I find that the temperature range is not a differentiator in the flash ID,
so I would drop it.
Cheers,
ta
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v1] mtd: spi-nor: Add support for Winbond w25q64jv spi flash
@ 2020-06-29 12:50 ` Tudor.Ambarus
0 siblings, 0 replies; 10+ messages in thread
From: Tudor.Ambarus @ 2020-06-29 12:50 UTC (permalink / raw)
To: thesven73, miquel.raynal, richard, vigneshr; +Cc: linux-mtd, linux-kernel
Hi, Sven,
On 6/14/20 2:53 AM, Sven Van Asbroeck wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> This chip is (nearly) identical to the Winbond w25q64 which is
> already supported by Linux. Compared to the w25q64, the 'jv'
> does not support Quad SPI mode, and has a different JEDEC ID.
I'm reading the following datasheet:
https://www.winbond.com/resource-files/w25q64jv%20revj%2003272018%20plus.pdf
w25q64jvm (0xef7017) comes with QE bit set to a 0 state, but can be
set to 1, so Quad mode can be supported. Would you please set SPI_NOR_DUAL_READ
and SPI_NOR_QUAD_READ flags and test and see if Quad works? If all good,
please specify in the commit message with which controller you did the tests.
>
> To: Tudor Ambarus <tudor.ambarus@microchip.com>
> To: Miquel Raynal <miquel.raynal@bootlin.com>
> To: Richard Weinberger <richard@nod.at>
> To: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: linux-mtd@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
Are these tags really necessary? Would you drop them?
> Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
> ---
>
> Tree: next-20200613
>
> drivers/mtd/spi-nor/winbond.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 5062af10f138..18bdff02f57f 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -65,6 +65,7 @@ static const struct flash_info winbond_parts[] = {
> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> { "w25x64", INFO(0xef3017, 0, 64 * 1024, 128, SECT_4K) },
> { "w25q64", INFO(0xef4017, 0, 64 * 1024, 128, SECT_4K) },
> + { "w25q64jv", INFO(0xef7017, 0, 64 * 1024, 128, SECT_4K) },
I would name it "w25q64jvm". Check "11.ORDERING INFORMATION". Although the
datasheet refers to these flashes as "W25Q64JV-IQ/JQ" and "W25Q64JV-IM/JM",
I find that the temperature range is not a differentiator in the flash ID,
so I would drop it.
Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v1] mtd: spi-nor: Add support for Winbond w25q64jv spi flash
2020-06-29 12:50 ` Tudor.Ambarus
@ 2020-06-29 14:53 ` Sven Van Asbroeck
-1 siblings, 0 replies; 10+ messages in thread
From: Sven Van Asbroeck @ 2020-06-29 14:53 UTC (permalink / raw)
To: Tudor Ambarus
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
linux-mtd, Linux Kernel Mailing List
Hi Tudor,
On Mon, Jun 29, 2020 at 8:50 AM <Tudor.Ambarus@microchip.com> wrote:
>
> I'm reading the following datasheet:
> https://www.winbond.com/resource-files/w25q64jv%20revj%2003272018%20plus.pdf
>
> w25q64jvm (0xef7017) comes with QE bit set to a 0 state, but can be
> set to 1, so Quad mode can be supported. Would you please set SPI_NOR_DUAL_READ
> and SPI_NOR_QUAD_READ flags and test and see if Quad works? If all good,
> please specify in the commit message with which controller you did the tests.
>
Good point !
Unfortunately I'm using the spi controller on an imx6 ("fsl,imx51-ecspi") which
does not support dual or quad mode. So I cannot possibly test this :)
How would you like to proceed? Should I keep this as a private patch, and
wait until someone comes along who can test this on more capable
controller h/w ?
Or should I re-spin the patch without the flags?
Cheers,
Sven
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v1] mtd: spi-nor: Add support for Winbond w25q64jv spi flash
@ 2020-06-29 14:53 ` Sven Van Asbroeck
0 siblings, 0 replies; 10+ messages in thread
From: Sven Van Asbroeck @ 2020-06-29 14:53 UTC (permalink / raw)
To: Tudor Ambarus
Cc: Richard Weinberger, linux-mtd, Vignesh Raghavendra,
Linux Kernel Mailing List, Miquel Raynal
Hi Tudor,
On Mon, Jun 29, 2020 at 8:50 AM <Tudor.Ambarus@microchip.com> wrote:
>
> I'm reading the following datasheet:
> https://www.winbond.com/resource-files/w25q64jv%20revj%2003272018%20plus.pdf
>
> w25q64jvm (0xef7017) comes with QE bit set to a 0 state, but can be
> set to 1, so Quad mode can be supported. Would you please set SPI_NOR_DUAL_READ
> and SPI_NOR_QUAD_READ flags and test and see if Quad works? If all good,
> please specify in the commit message with which controller you did the tests.
>
Good point !
Unfortunately I'm using the spi controller on an imx6 ("fsl,imx51-ecspi") which
does not support dual or quad mode. So I cannot possibly test this :)
How would you like to proceed? Should I keep this as a private patch, and
wait until someone comes along who can test this on more capable
controller h/w ?
Or should I re-spin the patch without the flags?
Cheers,
Sven
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v1] mtd: spi-nor: Add support for Winbond w25q64jv spi flash
2020-06-29 14:53 ` Sven Van Asbroeck
@ 2020-06-29 19:01 ` Tudor.Ambarus
-1 siblings, 0 replies; 10+ messages in thread
From: Tudor.Ambarus @ 2020-06-29 19:01 UTC (permalink / raw)
To: thesven73; +Cc: miquel.raynal, richard, vigneshr, linux-mtd, linux-kernel
On 6/29/20 5:53 PM, Sven Van Asbroeck wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Hi Tudor,
>
> On Mon, Jun 29, 2020 at 8:50 AM <Tudor.Ambarus@microchip.com> wrote:
>>
>> I'm reading the following datasheet:
>> https://www.winbond.com/resource-files/w25q64jv%20revj%2003272018%20plus.pdf
>>
>> w25q64jvm (0xef7017) comes with QE bit set to a 0 state, but can be
>> set to 1, so Quad mode can be supported. Would you please set SPI_NOR_DUAL_READ
>> and SPI_NOR_QUAD_READ flags and test and see if Quad works? If all good,
>> please specify in the commit message with which controller you did the tests.
>>
>
> Good point !
>
> Unfortunately I'm using the spi controller on an imx6 ("fsl,imx51-ecspi") which
> does not support dual or quad mode. So I cannot possibly test this :)
>
> How would you like to proceed? Should I keep this as a private patch, and
> wait until someone comes along who can test this on more capable
> controller h/w ?
>
> Or should I re-spin the patch without the flags?
>
Re-spin the patch without the flags. We can add them later on, when someone can
test them.
Cheers,
ta
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v1] mtd: spi-nor: Add support for Winbond w25q64jv spi flash
@ 2020-06-29 19:01 ` Tudor.Ambarus
0 siblings, 0 replies; 10+ messages in thread
From: Tudor.Ambarus @ 2020-06-29 19:01 UTC (permalink / raw)
To: thesven73; +Cc: richard, linux-mtd, vigneshr, linux-kernel, miquel.raynal
On 6/29/20 5:53 PM, Sven Van Asbroeck wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Hi Tudor,
>
> On Mon, Jun 29, 2020 at 8:50 AM <Tudor.Ambarus@microchip.com> wrote:
>>
>> I'm reading the following datasheet:
>> https://www.winbond.com/resource-files/w25q64jv%20revj%2003272018%20plus.pdf
>>
>> w25q64jvm (0xef7017) comes with QE bit set to a 0 state, but can be
>> set to 1, so Quad mode can be supported. Would you please set SPI_NOR_DUAL_READ
>> and SPI_NOR_QUAD_READ flags and test and see if Quad works? If all good,
>> please specify in the commit message with which controller you did the tests.
>>
>
> Good point !
>
> Unfortunately I'm using the spi controller on an imx6 ("fsl,imx51-ecspi") which
> does not support dual or quad mode. So I cannot possibly test this :)
>
> How would you like to proceed? Should I keep this as a private patch, and
> wait until someone comes along who can test this on more capable
> controller h/w ?
>
> Or should I re-spin the patch without the flags?
>
Re-spin the patch without the flags. We can add them later on, when someone can
test them.
Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 10+ messages in thread