Applying patches to U-boot 2019.04

Applying patches to U-boot 2019.04

[logananth hcl]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

Hai all,
I'm trying to port the u-boot to the 2019.04-aspeed-openbmc,
Here trying to apply *.patch file and also applying the defconfig for the
u-boot from the specific meta-layer.

In this case, the defconfig file changes have been applied clearly to
u-boot in tmp, but those patch files are copying to the machine tmp folder
but not applied to the code!

Is there any restriction for applying patches to the 2019.04-aspeed openbmc
?
If not, is there any other suggestion for applying patches.

[-- Attachment #2: Type: text/html, Size: 576 bytes --]

Re: Applying patches to U-boot 2019.04

[Andrew Jeffery]

On Wed, 23 Mar 2022, at 01:13, logananth hcl wrote:
> Hai all,
> I'm trying to port the u-boot to the 2019.04-aspeed-openbmc,
> Here trying to apply *.patch file and also applying the defconfig for the
> u-boot from the specific meta-layer.
>
> In this case, the defconfig file changes have been applied clearly to
> u-boot in tmp, but those patch files are copying to the machine tmp folder
> but not applied to the code!
>
> Is there any restriction for applying patches to the 2019.04-aspeed openbmc
> ?
> If not, is there any other suggestion for applying patches.

Send them to this list so we can apply them to the openbmc/u-boot tree :)

Andrew

Re: Applying patches to U-boot 2019.04

[logananth hcl]

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]

I have pushed the related machine layer u-boot patch files,
in the following gerrit link,

https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/52263

Suggest me to add these patch files to the list.

In the local build itself, u-boot bb_patches are not applied during
bitbake(copied to the build's u-boot folder), is there any restriction on
this to apply bb_patch files.
I'm facing repotest failure, I think that will be resolved once it is added
in the repotest.

On Wed, Mar 23, 2022 at 9:35 AM Andrew Jeffery <andrew@aj.id.au> wrote:

>
>
> On Wed, 23 Mar 2022, at 01:13, logananth hcl wrote:
> > Hai all,
> > I'm trying to port the u-boot to the 2019.04-aspeed-openbmc,
> > Here trying to apply *.patch file and also applying the defconfig for the
> > u-boot from the specific meta-layer.
> >
> > In this case, the defconfig file changes have been applied clearly to
> > u-boot in tmp, but those patch files are copying to the machine tmp
> folder
> > but not applied to the code!
> >
> > Is there any restriction for applying patches to the 2019.04-aspeed
> openbmc
> > ?
> > If not, is there any other suggestion for applying patches.
>
> Send them to this list so we can apply them to the openbmc/u-boot tree :)
>
> Andrew
>

[-- Attachment #2: Type: text/html, Size: 1724 bytes --]

Re: Applying patches to U-boot 2019.04

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

On Wed, Mar 23, 2022 at 08:25:18PM +0530, logananth hcl wrote:
> I have pushed the related machine layer u-boot patch files,
> in the following gerrit link,
> 
> https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/52263
> 
> Suggest me to add these patch files to the list.
> 
> In the local build itself, u-boot bb_patches are not applied during
> bitbake(copied to the build's u-boot folder), is there any restriction on
> this to apply bb_patch files.

I don't see this behavior.  I downloaded your patch and see the correct
modifications in my build directory.  I checked this file and see the
'console_slotN' modifications from patch 0002 being applied.  Are you
certain they are not applying for you?

.../lf-build-yosemitev2/tmp/work/yosemitev2-openbmc-linux-gnueabi/u-boot-aspeed-sdk/1_v2019.04+gitAUTOINC+ed55c4e7c3-r0/git/arch/arm/mach-aspeed/ast2500/platform.S

> I'm facing repotest failure, I think that will be resolved once it is added
> in the repotest.

I made the same comment in the commit, but we can simply update the
paths in repotest.  You've only renamed the files so we can move the
paths in repotest at the same time (with the same commit).  We just
don't want to add new patches.

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Applying patches to U-boot 2019.04

[logananth hcl]

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

Thank you for your suggestions,

The problem is basically from my local build, now it's resolved and copied
to the path as mentioned,

Then updated the paths in the repotest and pushed the patch within the same
commit.

Thank you.


On Thu, Mar 24, 2022 at 9:30 PM Patrick Williams <patrick@stwcx.xyz> wrote:

> On Wed, Mar 23, 2022 at 08:25:18PM +0530, logananth hcl wrote:
> > I have pushed the related machine layer u-boot patch files,
> > in the following gerrit link,
> >
> > https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/52263
> >
> > Suggest me to add these patch files to the list.
> >
> > In the local build itself, u-boot bb_patches are not applied during
> > bitbake(copied to the build's u-boot folder), is there any restriction on
> > this to apply bb_patch files.
>
> I don't see this behavior.  I downloaded your patch and see the correct
> modifications in my build directory.  I checked this file and see the
> 'console_slotN' modifications from patch 0002 being applied.  Are you
> certain they are not applying for you?
>
>
> .../lf-build-yosemitev2/tmp/work/yosemitev2-openbmc-linux-gnueabi/u-boot-aspeed-sdk/1_v2019.04+gitAUTOINC+ed55c4e7c3-r0/git/arch/arm/mach-aspeed/ast2500/platform.S
>
> > I'm facing repotest failure, I think that will be resolved once it is
> added
> > in the repotest.
>
> I made the same comment in the commit, but we can simply update the
> paths in repotest.  You've only renamed the files so we can move the
> paths in repotest at the same time (with the same commit).  We just
> don't want to add new patches.
>
> --
> Patrick Williams
>

[-- Attachment #2: Type: text/html, Size: 2229 bytes --]