From: "Fernando Apesteguía" <fernando.apesteguia@gmail.com> To: Greg KH <gregkh@linuxfoundation.org> Cc: Lidza Louina <lidza.louina@gmail.com>, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: dgnc: replace DGNC_VERIFY_BOARD macro Date: Mon, 17 Oct 2016 23:46:36 +0200 [thread overview] Message-ID: <CAGwOe2YfAKsifsjXr9fydMfVV+Obv-1mBebXwXAWrNHSNJt+mg@mail.gmail.com> (raw) In-Reply-To: <20161017082931.GA17106@kroah.com> On Mon, Oct 17, 2016 at 10:29 AM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Fri, Oct 14, 2016 at 07:22:57PM +0200, Fernando Apesteguia wrote: >> The patch replaces the macro with a function (dgnc_get_board) and >> substitutes the macro statement with a call to that function and a >> comparison on the returned value. >> >> This removes a checkpatch warning. >> >> Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com> >> --- >> drivers/staging/dgnc/dgnc_sysfs.c | 74 +++++++++++++++++++++++++++------------ >> 1 file changed, 51 insertions(+), 23 deletions(-) >> >> diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c >> index 290bf6e..3ea23a9 100644 >> --- a/drivers/staging/dgnc/dgnc_sysfs.c >> +++ b/drivers/staging/dgnc/dgnc_sysfs.c >> @@ -90,17 +90,21 @@ void dgnc_remove_driver_sysfiles(struct pci_driver *dgnc_driver) >> driver_remove_file(driverfs, &driver_attr_pollrate); >> } >> >> -#define DGNC_VERIFY_BOARD(p, bd) \ >> - do { \ >> - if (!p) \ >> - return 0; \ >> - \ >> - bd = dev_get_drvdata(p); \ >> - if (!bd || bd->magic != DGNC_BOARD_MAGIC) \ >> - return 0; \ >> - if (bd->state != BOARD_READY) \ >> - return 0; \ >> - } while (0) >> +static struct dgnc_board *dgnc_get_board(struct device *p) >> +{ >> + struct dgnc_board *bd; >> + >> + if (!p) >> + return NULL; >> + >> + bd = dev_get_drvdata(p); >> + if (!bd || bd->magic != DGNC_BOARD_MAGIC) >> + return NULL; >> + if (bd->state != BOARD_READY) >> + return NULL; >> + >> + return bd; >> +} > > No, this macro should be removed entirely as what it does is pointless > in some parts, wrong in others, and not needed at all in the rest :( > > I've asked others to fix this up properly in the past, but it doesn't > seem like anyone wants to do the work... > I tried to find the discussion the relevant mails in lkml.org but couldn't find them. Could you point me to them so I can have a look? Thanks. > I don't want to take this patch as it will hide the real issues here. > > thanks, > > greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: "Fernando Apesteguía" <fernando.apesteguia@gmail.com> To: Greg KH <gregkh@linuxfoundation.org> Cc: devel@driverdev.osuosl.org, Lidza Louina <lidza.louina@gmail.com>, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: dgnc: replace DGNC_VERIFY_BOARD macro Date: Mon, 17 Oct 2016 23:46:36 +0200 [thread overview] Message-ID: <CAGwOe2YfAKsifsjXr9fydMfVV+Obv-1mBebXwXAWrNHSNJt+mg@mail.gmail.com> (raw) In-Reply-To: <20161017082931.GA17106@kroah.com> On Mon, Oct 17, 2016 at 10:29 AM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Fri, Oct 14, 2016 at 07:22:57PM +0200, Fernando Apesteguia wrote: >> The patch replaces the macro with a function (dgnc_get_board) and >> substitutes the macro statement with a call to that function and a >> comparison on the returned value. >> >> This removes a checkpatch warning. >> >> Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com> >> --- >> drivers/staging/dgnc/dgnc_sysfs.c | 74 +++++++++++++++++++++++++++------------ >> 1 file changed, 51 insertions(+), 23 deletions(-) >> >> diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c >> index 290bf6e..3ea23a9 100644 >> --- a/drivers/staging/dgnc/dgnc_sysfs.c >> +++ b/drivers/staging/dgnc/dgnc_sysfs.c >> @@ -90,17 +90,21 @@ void dgnc_remove_driver_sysfiles(struct pci_driver *dgnc_driver) >> driver_remove_file(driverfs, &driver_attr_pollrate); >> } >> >> -#define DGNC_VERIFY_BOARD(p, bd) \ >> - do { \ >> - if (!p) \ >> - return 0; \ >> - \ >> - bd = dev_get_drvdata(p); \ >> - if (!bd || bd->magic != DGNC_BOARD_MAGIC) \ >> - return 0; \ >> - if (bd->state != BOARD_READY) \ >> - return 0; \ >> - } while (0) >> +static struct dgnc_board *dgnc_get_board(struct device *p) >> +{ >> + struct dgnc_board *bd; >> + >> + if (!p) >> + return NULL; >> + >> + bd = dev_get_drvdata(p); >> + if (!bd || bd->magic != DGNC_BOARD_MAGIC) >> + return NULL; >> + if (bd->state != BOARD_READY) >> + return NULL; >> + >> + return bd; >> +} > > No, this macro should be removed entirely as what it does is pointless > in some parts, wrong in others, and not needed at all in the rest :( > > I've asked others to fix this up properly in the past, but it doesn't > seem like anyone wants to do the work... > I tried to find the discussion the relevant mails in lkml.org but couldn't find them. Could you point me to them so I can have a look? Thanks. > I don't want to take this patch as it will hide the real issues here. > > thanks, > > greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2016-10-17 21:46 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-14 17:22 [PATCH] staging: dgnc: replace DGNC_VERIFY_BOARD macro Fernando Apesteguia 2016-10-14 17:22 ` Fernando Apesteguia 2016-10-17 8:29 ` Greg KH 2016-10-17 8:29 ` Greg KH 2016-10-17 21:46 ` Fernando Apesteguía [this message] 2016-10-17 21:46 ` Fernando Apesteguía 2016-10-18 6:40 ` Greg KH 2016-10-18 6:40 ` Greg KH
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAGwOe2YfAKsifsjXr9fydMfVV+Obv-1mBebXwXAWrNHSNJt+mg@mail.gmail.com \ --to=fernando.apesteguia@gmail.com \ --cc=devel@driverdev.osuosl.org \ --cc=driverdev-devel@linuxdriverproject.org \ --cc=gregkh@linuxfoundation.org \ --cc=lidza.louina@gmail.com \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.