Re: [PATCH 2/3] ARM: dts: imx7: add support for kamstrup flex concentrator

From: Bruno Thomsen <bruno.thomsen@gmail.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: open list <linux-kernel@vger.kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
	<linux-arm-kernel@lists.infradead.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Bruno Thomsen <bth@kamstrup.com>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: [PATCH 2/3] ARM: dts: imx7: add support for kamstrup flex concentrator
Date: Tue, 14 Jul 2020 12:03:16 +0200	[thread overview]
Message-ID: <CAH+2xPAHKY6YfhO-jXfKN+TRN5LDT1Kkn8a8HUj_EOqFt=75nQ@mail.gmail.com> (raw)
In-Reply-To: <20200713025246.GY21277@dragon>

Den man. 13. jul. 2020 kl. 04.52 skrev Shawn Guo <shawnguo@kernel.org>:
>
> On Mon, Jun 29, 2020 at 01:49:26PM +0200, Bruno Thomsen wrote:
> > +&fec1 {
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_enet1>;
> > +     phy-mode = "rmii";
> > +     phy-reset-gpios = <&gpio7 15 GPIO_ACTIVE_LOW>;
> > +     phy-reset-duration = <100>;
> > +     phy-reset-post-delay = <1000>;
>
> These properties are deprecated.

Thanks for review Shawn.

I have not yet been successful in converting the deprecated properties
to generic phy properties, so hoping I could get a hit.

Kernel error messages:
mdio_bus 30be0000.ethernet-1: MDIO device at address 1 is missing.
fec 30be0000.ethernet eth0: Unable to connect to phy

Updated device tree section:
&fec1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_enet1>;
        phy-mode = "rmii";
        phy-handle = <&ethphy>;
        status = "okay";

        mdio {
                #address-cells = <1>;
                #size-cells = <0>;

                ethphy: ethernet-phy@1 {
                        /* Micrel KSZ8051RNLV */
                        compatible = "ethernet-phy-ieee802.3-c22";
                        reg = <1>;
                        max-speed = <100>;

                        reset-assert-us = <100000>;
                        reset-deassert-us = <1000000>;
                        reset-gpios = <&gpio7 15 GPIO_ACTIVE_LOW>;
                };
        };
};

/Bruno

> > +     phy-handle = <&ethphy>;
> > +     status = "okay";
> > +
> > +     mdio {
> > +             #address-cells = <1>;
> > +             #size-cells = <0>;
> > +             ethphy: ethernet-phy@1 {
> > +                     /* Micrel KSZ8051RNLV */
> > +                     compatible = "ethernet-phy-ieee802.3-c22";
> > +                     reg = <1>;
> > +             };
> > +     };
> > +};