From: Joe Perches <joe@perches.com> To: Shawn Guo <shawnguo@kernel.org>, Bruno Thomsen <bruno.thomsen@gmail.com>, Andrew Morton <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, bth@kamstrup.com, Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Subject: Re: [PATCH 3/3] MAINTAINERS: Add Bruno Thomsen as reviewer of Kamstrup DTS Date: Sun, 12 Jul 2020 22:22:50 -0700 [thread overview] Message-ID: <da52724655ff2161add7fb27fea8fc673028b9fc.camel@perches.com> (raw) In-Reply-To: <20200713025559.GZ21277@dragon> On Mon, 2020-07-13 at 10:56 +0800, Shawn Guo wrote: > On Mon, Jun 29, 2020 at 01:49:27PM +0200, Bruno Thomsen wrote: > > Add myself as reviewer of device trees for Kamstrup > > Concentrators. > > > > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com> > > --- > > MAINTAINERS | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 496fd4eafb68..97fc112309af 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -9282,6 +9282,11 @@ S: Maintained > > F: Documentation/hwmon/k8temp.rst > > F: drivers/hwmon/k8temp.c > > > > +KAMSTRUP CONCENTRATORS > > +R: Bruno Thomsen <bruno.thomsen@gmail.com> > > +S: Maintained > > +F: arch/arm/boot/dts/imx7d-flex-concentrator*.dts > > + > > I guess get_maintainer.pl should list you for patches touching the > files, so it's not really required? I'm worried about that MAINTAINERS > file will get bloated quickly if we patch it for every single DTS > file. Right now, a little less than half of the .dts* files have an author or other email address in them. $ git ls-files arch/arm/boot/dts/*.dts* | wc -l 2105 $ git grep -P --name-only '<\S+@\S+>' arch/arm/boot/dts/*.dts* | wc -l 997 Some have multiple email addresses: $ git grep -P '<\S+@\S+>' arch/arm/boot/dts/*.dts* | wc -l 1240 (and there are a few false positives in that regex) I suppose that get_maintainer could handle .dts* files the same way .yaml files are handled so any email address in the file is added to patches that touch the file. This is the commit that added the .yaml file handling: commit 0c78c013762142bfe8fce34e7e968f83f0a4b891 Author: Joe Perches <joe@perches.com> Date: Thu Jun 4 16:50:01 2020 -0700 get_maintainer: add email addresses from .yaml files .yaml files can contain maintainer/author addresses and it seems unlikely or unnecessary that individual MAINTAINER file section entries for each .yaml file will be created. So add the email addresses found in .yaml files to the default get_maintainer output. The email addresses are marked with "(in file)" when using the "--roles" or "--rolestats" options. So something like: --- scripts/get_maintainer.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 484d2fbf5921..4c3c69d7bed0 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -436,7 +436,7 @@ sub maintainers_in_file { return if ($file =~ m@\bMAINTAINERS$@); - if (-f $file && ($email_file_emails || $file =~ /\.yaml$/)) { + if (-f $file && ($email_file_emails || $file =~ /\.(?:yaml|dtsi?)$/)) { open(my $f, '<', $file) or die "$P: Can't open $file: $!\n"; my $text = do { local($/) ; <$f> };
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com> To: Shawn Guo <shawnguo@kernel.org>, Bruno Thomsen <bruno.thomsen@gmail.com>, Andrew Morton <akpm@linux-foundation.org> Cc: devicetree@vger.kernel.org, Mauro Carvalho Chehab <mchehab+huawei@kernel.org>, linux-kernel@vger.kernel.org, bth@kamstrup.com, Rob Herring <robh+dt@kernel.org>, NXP Linux Team <linux-imx@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] MAINTAINERS: Add Bruno Thomsen as reviewer of Kamstrup DTS Date: Sun, 12 Jul 2020 22:22:50 -0700 [thread overview] Message-ID: <da52724655ff2161add7fb27fea8fc673028b9fc.camel@perches.com> (raw) In-Reply-To: <20200713025559.GZ21277@dragon> On Mon, 2020-07-13 at 10:56 +0800, Shawn Guo wrote: > On Mon, Jun 29, 2020 at 01:49:27PM +0200, Bruno Thomsen wrote: > > Add myself as reviewer of device trees for Kamstrup > > Concentrators. > > > > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com> > > --- > > MAINTAINERS | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 496fd4eafb68..97fc112309af 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -9282,6 +9282,11 @@ S: Maintained > > F: Documentation/hwmon/k8temp.rst > > F: drivers/hwmon/k8temp.c > > > > +KAMSTRUP CONCENTRATORS > > +R: Bruno Thomsen <bruno.thomsen@gmail.com> > > +S: Maintained > > +F: arch/arm/boot/dts/imx7d-flex-concentrator*.dts > > + > > I guess get_maintainer.pl should list you for patches touching the > files, so it's not really required? I'm worried about that MAINTAINERS > file will get bloated quickly if we patch it for every single DTS > file. Right now, a little less than half of the .dts* files have an author or other email address in them. $ git ls-files arch/arm/boot/dts/*.dts* | wc -l 2105 $ git grep -P --name-only '<\S+@\S+>' arch/arm/boot/dts/*.dts* | wc -l 997 Some have multiple email addresses: $ git grep -P '<\S+@\S+>' arch/arm/boot/dts/*.dts* | wc -l 1240 (and there are a few false positives in that regex) I suppose that get_maintainer could handle .dts* files the same way .yaml files are handled so any email address in the file is added to patches that touch the file. This is the commit that added the .yaml file handling: commit 0c78c013762142bfe8fce34e7e968f83f0a4b891 Author: Joe Perches <joe@perches.com> Date: Thu Jun 4 16:50:01 2020 -0700 get_maintainer: add email addresses from .yaml files .yaml files can contain maintainer/author addresses and it seems unlikely or unnecessary that individual MAINTAINER file section entries for each .yaml file will be created. So add the email addresses found in .yaml files to the default get_maintainer output. The email addresses are marked with "(in file)" when using the "--roles" or "--rolestats" options. So something like: --- scripts/get_maintainer.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 484d2fbf5921..4c3c69d7bed0 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -436,7 +436,7 @@ sub maintainers_in_file { return if ($file =~ m@\bMAINTAINERS$@); - if (-f $file && ($email_file_emails || $file =~ /\.yaml$/)) { + if (-f $file && ($email_file_emails || $file =~ /\.(?:yaml|dtsi?)$/)) { open(my $f, '<', $file) or die "$P: Can't open $file: $!\n"; my $text = do { local($/) ; <$f> }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-13 5:23 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-29 11:49 [PATCH 1/3] dt-bindings: ARM: imx: add kamstrup flex concentrator to schema Bruno Thomsen 2020-06-29 11:49 ` Bruno Thomsen 2020-06-29 11:49 ` [PATCH 2/3] ARM: dts: imx7: add support for kamstrup flex concentrator Bruno Thomsen 2020-06-29 11:49 ` Bruno Thomsen 2020-07-13 2:52 ` Shawn Guo 2020-07-13 2:52 ` Shawn Guo 2020-07-14 10:03 ` Bruno Thomsen 2020-07-14 10:03 ` Bruno Thomsen 2020-07-14 11:54 ` Fabio Estevam 2020-07-14 11:54 ` Fabio Estevam 2020-07-15 14:21 ` Bruno Thomsen 2020-07-15 14:21 ` Bruno Thomsen 2020-07-15 20:28 ` Fabio Estevam 2020-07-15 20:28 ` Fabio Estevam 2020-06-29 11:49 ` [PATCH 3/3] MAINTAINERS: Add Bruno Thomsen as reviewer of Kamstrup DTS Bruno Thomsen 2020-06-29 11:49 ` Bruno Thomsen 2020-07-13 2:56 ` Shawn Guo 2020-07-13 2:56 ` Shawn Guo 2020-07-13 5:22 ` Joe Perches [this message] 2020-07-13 5:22 ` Joe Perches 2020-07-13 7:13 ` Shawn Guo 2020-07-13 7:13 ` Shawn Guo 2020-07-13 7:26 ` Joe Perches 2020-07-13 7:26 ` Joe Perches 2020-07-13 7:31 ` Bruno Thomsen 2020-07-13 7:31 ` Bruno Thomsen 2020-07-13 2:32 ` [PATCH 1/3] dt-bindings: ARM: imx: add kamstrup flex concentrator to schema Shawn Guo 2020-07-13 2:32 ` Shawn Guo 2020-07-15 20:26 ` Rob Herring 2020-07-15 20:26 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=da52724655ff2161add7fb27fea8fc673028b9fc.camel@perches.com \ --to=joe@perches.com \ --cc=akpm@linux-foundation.org \ --cc=bruno.thomsen@gmail.com \ --cc=bth@kamstrup.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mchehab+huawei@kernel.org \ --cc=robh+dt@kernel.org \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.