* smb3 mount fix for Macs @ 2017-05-04 2:23 Steve French [not found] ` <CAH2r5mtm7mJn7V5qiP6Xz3PW-+d_j02idQcsZkgfS3Gqw4=92g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Steve French @ 2017-05-04 2:23 UTC (permalink / raw) To: linux-cifs-u79uwXL29TY76Z2rM5mHXA pushed patch to workaround smb3 mount failure to Mac (we had to relax our length checks on the response to smb2 ioctl for validate negotiate since they pad in order to return the maximum buffer allowed - 16K for what is normally a rather small ioctl response). smb3 mounts now work to Macs again (smb2.1 mounts to Mac had always been find - it only failed to smb3 due to the validate negotiate ioctl) https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=be60379eac1c023f9b77565060414e5b122de766 -- Thanks, Steve ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <CAH2r5mtm7mJn7V5qiP6Xz3PW-+d_j02idQcsZkgfS3Gqw4=92g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: smb3 mount fix for Macs [not found] ` <CAH2r5mtm7mJn7V5qiP6Xz3PW-+d_j02idQcsZkgfS3Gqw4=92g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2017-05-04 2:25 ` Steve French [not found] ` <CAH2r5mtrghs-cnnxDvwtSzz5orUxNU-xpwFxJ0GVCr2BCeDOWg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Steve French @ 2017-05-04 2:25 UTC (permalink / raw) To: linux-cifs-u79uwXL29TY76Z2rM5mHXA Minor update and added cc:stable https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=7db0a6efdc3e990cdfd4b24820d010e9eb7890ad On Wed, May 3, 2017 at 9:23 PM, Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > pushed patch to workaround smb3 mount failure to Mac > > (we had to relax our length checks on the response to smb2 ioctl for > validate negotiate since they pad in order to return the maximum > buffer allowed - 16K for what is normally a rather small ioctl > response). > > smb3 mounts now work to Macs again (smb2.1 mounts to Mac had always > been find - it only failed to smb3 due to the validate negotiate > ioctl) > > https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=be60379eac1c023f9b77565060414e5b122de766 > > > > -- > Thanks, > > Steve -- Thanks, Steve ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <CAH2r5mtrghs-cnnxDvwtSzz5orUxNU-xpwFxJ0GVCr2BCeDOWg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: smb3 mount fix for Macs [not found] ` <CAH2r5mtrghs-cnnxDvwtSzz5orUxNU-xpwFxJ0GVCr2BCeDOWg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2017-05-04 10:24 ` David Disseldorp [not found] ` <20170504122447.03f54767-l3A5Bk7waGM@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: David Disseldorp @ 2017-05-04 10:24 UTC (permalink / raw) To: Steve French; +Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA On Wed, 3 May 2017 21:25:50 -0500, Steve French wrote: > Minor update and added cc:stable > > https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=7db0a6efdc3e990cdfd4b24820d010e9eb7890ad The relaxed validate negotiate rsplen check looks okay, but I think the reduced MaxOutputResponse change should probably be split out into a separate commit, as it affects all other ioctls. Given that the response size is known in advance, couldn't we have the validate_negotiate caller pass in the desired MaxOutputResponse value? Cheers, David ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20170504122447.03f54767-l3A5Bk7waGM@public.gmane.org>]
* Re: smb3 mount fix for Macs [not found] ` <20170504122447.03f54767-l3A5Bk7waGM@public.gmane.org> @ 2017-05-04 10:30 ` Steve French [not found] ` <CAH2r5mvt2MKaeMC7zJ+xX5jXpEMGWP6ja4F-BmwPq8q=TdNGOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Steve French @ 2017-05-04 10:30 UTC (permalink / raw) To: David Disseldorp; +Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA On Thu, May 4, 2017 at 5:24 AM, David Disseldorp <ddiss-l3A5Bk7waGM@public.gmane.org> wrote: > On Wed, 3 May 2017 21:25:50 -0500, Steve French wrote: > >> Minor update and added cc:stable >> >> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=7db0a6efdc3e990cdfd4b24820d010e9eb7890ad > > The relaxed validate negotiate rsplen check looks okay, but I think the > reduced MaxOutputResponse change should probably be split out into a > separate commit, as it affects all other ioctls. That is a good thing in a way - because we don't want any ioctls to send more than maxbufsize until we can handle this. > Given that the response size is known in advance, couldn't we have the > validate_negotiate caller pass in the desired MaxOutputResponse value? Perhaps - but I don't know if that makes sense until we have way of handling more than max buf size (defaults to 16K payload) in smb2 ioctl/fsctl response. My gut reaction is to change the code to allow passing in maxoutput for response on ioctl when we have a way of handling 'very large' ioctl responses in demultiplexing in smb2 transport layer. -- Thanks, Steve ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <CAH2r5mvt2MKaeMC7zJ+xX5jXpEMGWP6ja4F-BmwPq8q=TdNGOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: smb3 mount fix for Macs [not found] ` <CAH2r5mvt2MKaeMC7zJ+xX5jXpEMGWP6ja4F-BmwPq8q=TdNGOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2017-05-04 18:43 ` Pavel Shilovsky 0 siblings, 0 replies; 5+ messages in thread From: Pavel Shilovsky @ 2017-05-04 18:43 UTC (permalink / raw) To: Steve French; +Cc: David Disseldorp, linux-cifs-u79uwXL29TY76Z2rM5mHXA 2017-05-04 3:30 GMT-07:00 Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>: > On Thu, May 4, 2017 at 5:24 AM, David Disseldorp <ddiss-l3A5Bk7waGM@public.gmane.org> wrote: >> On Wed, 3 May 2017 21:25:50 -0500, Steve French wrote: >> >>> Minor update and added cc:stable >>> >>> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=7db0a6efdc3e990cdfd4b24820d010e9eb7890ad >> >> The relaxed validate negotiate rsplen check looks okay, but I think the >> reduced MaxOutputResponse change should probably be split out into a >> separate commit, as it affects all other ioctls. > > That is a good thing in a way - because we don't want any ioctls to > send more than maxbufsize until we can handle this. > I agree that we need to split the patch into two because it is targeted to stable. SMB2_ioctl() and smb3_validate_negotiate() were introduced in different times, so the single patch won't be applied properly on some stable kernel versions. -- Best regards, Pavel Shilovsky ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-04 18:43 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-05-04 2:23 smb3 mount fix for Macs Steve French [not found] ` <CAH2r5mtm7mJn7V5qiP6Xz3PW-+d_j02idQcsZkgfS3Gqw4=92g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-05-04 2:25 ` Steve French [not found] ` <CAH2r5mtrghs-cnnxDvwtSzz5orUxNU-xpwFxJ0GVCr2BCeDOWg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-05-04 10:24 ` David Disseldorp [not found] ` <20170504122447.03f54767-l3A5Bk7waGM@public.gmane.org> 2017-05-04 10:30 ` Steve French [not found] ` <CAH2r5mvt2MKaeMC7zJ+xX5jXpEMGWP6ja4F-BmwPq8q=TdNGOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-05-04 18:43 ` Pavel Shilovsky
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.