All of lore.kernel.org
 help / color / mirror / Atom feed
From: Justin Green <greenjustin@chromium.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-mediatek@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	 angelogioacchino.delregno@collabora.com,
	jason-jh.lin@mediatek.com,  justin.yeh@mediatek.com,
	wenst@chromium.org, chunkuang.hu@kernel.org,
	 p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch,
	 daniel@fooishbar.org
Subject: Re: [PATCH 1/3] drm/mediatek: Refactor pixel format logic
Date: Thu, 2 Feb 2023 13:59:21 -0500	[thread overview]
Message-ID: <CAHC42Rf8+yS45VBUc_dDuvCydg4ttKYuGwdgFshZRUZWzGiXRQ@mail.gmail.com> (raw)
In-Reply-To: <e96bd735-cf36-0dbd-cf93-446c1ab28778@gmail.com>

Hi Matthias,

> mt8173_formats are the same as the old struct formats. Maybe we should use that
> and only overwrite where we actually use a different array.
I think this was sort of how the original patch worked, but we wanted
to add some flexibility to allow different components to support
different formats. In patch 3 of the series, we actually overwrite
this field with mt8195_formats.

> Why can't we use ARRAY_SIZE(formats) here like we did before?
I think ARRAY_SIZE is just a macro for getting the length of
statically allocated arrays. Because we won't know until runtime which
list of pixel formats we will be using, I'm not sure we can use that
in this circumstance?

Regards,
Justin


WARNING: multiple messages have this Message-ID (diff)
From: Justin Green <greenjustin@chromium.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: chunkuang.hu@kernel.org, airlied@linux.ie,
	jason-jh.lin@mediatek.com, justin.yeh@mediatek.com,
	dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org, wenst@chromium.org,
	angelogioacchino.delregno@collabora.com
Subject: Re: [PATCH 1/3] drm/mediatek: Refactor pixel format logic
Date: Thu, 2 Feb 2023 13:59:21 -0500	[thread overview]
Message-ID: <CAHC42Rf8+yS45VBUc_dDuvCydg4ttKYuGwdgFshZRUZWzGiXRQ@mail.gmail.com> (raw)
In-Reply-To: <e96bd735-cf36-0dbd-cf93-446c1ab28778@gmail.com>

Hi Matthias,

> mt8173_formats are the same as the old struct formats. Maybe we should use that
> and only overwrite where we actually use a different array.
I think this was sort of how the original patch worked, but we wanted
to add some flexibility to allow different components to support
different formats. In patch 3 of the series, we actually overwrite
this field with mt8195_formats.

> Why can't we use ARRAY_SIZE(formats) here like we did before?
I think ARRAY_SIZE is just a macro for getting the length of
statically allocated arrays. Because we won't know until runtime which
list of pixel formats we will be using, I'm not sure we can use that
in this circumstance?

Regards,
Justin

  reply	other threads:[~2023-02-02 18:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-01 17:02 [PATCH 0/3 v7] drm/mediatek: Add support for 10-bit overlays Justin Green
2023-02-01 17:02 ` Justin Green
2023-02-01 17:02 ` [PATCH 1/3] drm/mediatek: Refactor pixel format logic Justin Green
2023-02-01 17:02   ` Justin Green
2023-02-02 10:11   ` Matthias Brugger
2023-02-02 10:11     ` Matthias Brugger
2023-02-02 18:59     ` Justin Green [this message]
2023-02-02 18:59       ` Justin Green
2023-02-02 20:16       ` Matthias Brugger
2023-02-02 20:16         ` Matthias Brugger
2023-02-02 20:41         ` Justin Green
2023-02-02 20:41           ` Justin Green
2023-02-03  7:29           ` Matthias Brugger
2023-02-03  7:29             ` Matthias Brugger
2023-02-01 17:02 ` [PATCH 2/3] drm/mediatek: Add support for AR30 and BA30 overlays Justin Green
2023-02-01 17:02   ` Justin Green
2023-02-01 17:02 ` [PATCH 3/3] drm/mediatek: Enable AR30 and BA30 overlays on MT8195 Justin Green
2023-02-01 17:02   ` Justin Green
2023-02-02 10:12   ` Matthias Brugger
2023-02-02 10:12     ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHC42Rf8+yS45VBUc_dDuvCydg4ttKYuGwdgFshZRUZWzGiXRQ@mail.gmail.com \
    --to=greenjustin@chromium.org \
    --cc=airlied@linux.ie \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=daniel@fooishbar.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jason-jh.lin@mediatek.com \
    --cc=justin.yeh@mediatek.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.