From: Paul Moore <paul@paul-moore.com> To: David Herrmann <dh.herrmann@gmail.com> Cc: linux-kernel@vger.kernel.org, James Morris <jmorris@namei.org>, teg@jklm.no, Stephen Smalley <sds@tycho.nsa.gov>, selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org, Eric Paris <eparis@parisplace.org>, serge@hallyn.com, davem@davemloft.net, netdev@vger.kernel.org Subject: Re: [PATCH 2/3] net/unix: hook unix_socketpair() into LSM Date: Tue, 24 Apr 2018 13:55:31 -0400 [thread overview] Message-ID: <CAHC9VhSv6tacFb+nEs1cCUOj52Vu+wXD6ZPZ1r1W4pYXo0VJMQ@mail.gmail.com> (raw) In-Reply-To: <20180423133015.5455-3-dh.herrmann@gmail.com> On Mon, Apr 23, 2018 at 9:30 AM, David Herrmann <dh.herrmann@gmail.com> wrote: > Use the newly created LSM-hook for unix_socketpair(). The default hook > return-value is 0, so behavior stays the same unless LSMs start using > this hook. > > Signed-off-by: David Herrmann <dh.herrmann@gmail.com> > --- > net/unix/af_unix.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c > index 68bb70a62afe..bc9705ace9b1 100644 > --- a/net/unix/af_unix.c > +++ b/net/unix/af_unix.c > @@ -1371,6 +1371,11 @@ static int unix_stream_connect(struct socket *sock, struct sockaddr *uaddr, > static int unix_socketpair(struct socket *socka, struct socket *sockb) > { > struct sock *ska = socka->sk, *skb = sockb->sk; > + int err; > + > + err = security_unix_stream_socketpair(ska, skb); > + if (err) > + return err; I recognize that AF_UNIX is really the only protocol that supports socketpair(2) at the moment, but I like to avoid protocol specific LSM hooks whenever possible. Unless someone can think of a good objection, I would prefer to see the hook placed in __sys_socketpair() instead (and obviously drop the "unix_stream" portion from the hook name). > /* Join our sockets back to back */ > sock_hold(ska); > -- > 2.17.0 -- paul moore www.paul-moore.com
WARNING: multiple messages have this Message-ID (diff)
From: paul@paul-moore.com (Paul Moore) To: linux-security-module@vger.kernel.org Subject: [PATCH 2/3] net/unix: hook unix_socketpair() into LSM Date: Tue, 24 Apr 2018 13:55:31 -0400 [thread overview] Message-ID: <CAHC9VhSv6tacFb+nEs1cCUOj52Vu+wXD6ZPZ1r1W4pYXo0VJMQ@mail.gmail.com> (raw) In-Reply-To: <20180423133015.5455-3-dh.herrmann@gmail.com> On Mon, Apr 23, 2018 at 9:30 AM, David Herrmann <dh.herrmann@gmail.com> wrote: > Use the newly created LSM-hook for unix_socketpair(). The default hook > return-value is 0, so behavior stays the same unless LSMs start using > this hook. > > Signed-off-by: David Herrmann <dh.herrmann@gmail.com> > --- > net/unix/af_unix.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c > index 68bb70a62afe..bc9705ace9b1 100644 > --- a/net/unix/af_unix.c > +++ b/net/unix/af_unix.c > @@ -1371,6 +1371,11 @@ static int unix_stream_connect(struct socket *sock, struct sockaddr *uaddr, > static int unix_socketpair(struct socket *socka, struct socket *sockb) > { > struct sock *ska = socka->sk, *skb = sockb->sk; > + int err; > + > + err = security_unix_stream_socketpair(ska, skb); > + if (err) > + return err; I recognize that AF_UNIX is really the only protocol that supports socketpair(2) at the moment, but I like to avoid protocol specific LSM hooks whenever possible. Unless someone can think of a good objection, I would prefer to see the hook placed in __sys_socketpair() instead (and obviously drop the "unix_stream" portion from the hook name). > /* Join our sockets back to back */ > sock_hold(ska); > -- > 2.17.0 -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-04-24 17:55 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-23 13:30 [PATCH 0/3] Introduce LSM-hook for socketpair(2) David Herrmann 2018-04-23 13:30 ` David Herrmann 2018-04-23 13:30 ` [PATCH 1/3] security: add hook for socketpair(AF_UNIX, ...) David Herrmann 2018-04-23 13:30 ` David Herrmann 2018-04-23 13:30 ` [PATCH 2/3] net/unix: hook unix_socketpair() into LSM David Herrmann 2018-04-23 13:30 ` David Herrmann 2018-04-24 17:55 ` Paul Moore [this message] 2018-04-24 17:55 ` Paul Moore 2018-04-24 17:56 ` David Miller 2018-04-24 17:56 ` David Miller 2018-04-24 17:58 ` Paul Moore 2018-04-24 17:58 ` Paul Moore 2018-04-23 13:30 ` [PATCH 3/3] selinux: provide unix_stream_socketpair callback David Herrmann 2018-04-23 13:30 ` David Herrmann 2018-04-23 16:48 ` Stephen Smalley 2018-04-23 16:48 ` Stephen Smalley 2018-04-23 17:04 ` [PATCH 0/3] Introduce LSM-hook for socketpair(2) Casey Schaufler 2018-04-23 17:04 ` Casey Schaufler 2018-04-23 17:52 ` Serge E. Hallyn 2018-04-23 17:52 ` Serge E. Hallyn 2018-04-25 18:44 ` James Morris 2018-04-25 18:44 ` James Morris 2018-04-25 18:48 ` David Miller 2018-04-25 18:48 ` David Miller 2018-04-25 18:51 ` Paul Moore 2018-04-25 18:51 ` Paul Moore 2018-04-25 19:02 ` James Morris 2018-04-25 19:02 ` James Morris 2018-05-04 14:29 ` David Herrmann 2018-05-04 14:29 ` David Herrmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAHC9VhSv6tacFb+nEs1cCUOj52Vu+wXD6ZPZ1r1W4pYXo0VJMQ@mail.gmail.com \ --to=paul@paul-moore.com \ --cc=davem@davemloft.net \ --cc=dh.herrmann@gmail.com \ --cc=eparis@parisplace.org \ --cc=jmorris@namei.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=sds@tycho.nsa.gov \ --cc=selinux@tycho.nsa.gov \ --cc=serge@hallyn.com \ --cc=teg@jklm.no \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.