All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Herrmann <dh.herrmann@gmail.com>
To: James Morris <jmorris@namei.org>
Cc: Paul Moore <paul@paul-moore.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Tom Gundersen <teg@jklm.no>, Stephen Smalley <sds@tycho.nsa.gov>,
	selinux@tycho.nsa.gov,
	LSM <linux-security-module@vger.kernel.org>,
	Eric Paris <eparis@parisplace.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 0/3] Introduce LSM-hook for socketpair(2)
Date: Fri, 4 May 2018 16:29:14 +0200	[thread overview]
Message-ID: <CANq1E4QgRUvG4WJ_XZoWpvegE-TRF5CddiSptNUFQkURJr5Znw@mail.gmail.com> (raw)
In-Reply-To: <alpine.LRH.2.21.1804260502030.12534@namei.org>

Hey

On Wed, Apr 25, 2018 at 9:02 PM, James Morris <jmorris@namei.org> wrote:
> On Wed, 25 Apr 2018, Paul Moore wrote:
>
>> On Wed, Apr 25, 2018 at 2:44 PM, James Morris <jmorris@namei.org> wrote:
>> > On Mon, 23 Apr 2018, David Herrmann wrote:
>> >> This patch series tries to close this gap and makes both behave the
>> >> same. A new LSM-hook is added which allows LSMs to cache the correct
>> >> peer information on newly created socket-pairs.
>> >
>> > Looks okay to me.
>> >
>> > Once it's respun with the Smack backend and maybe the hook name change,
>> > I'll merge this unless DaveM wants it to go in via his networking tree.
>>
>> Note my objection to the hook placement in patch 2/3; I think we
>> should move the hook out of the AF_UNIX layer and up into the socket
>> layer.
>
> I vote for this as it maintains the intended abstraction of the socket
> API.

Sounds good, I changed it. I will send v2 shortly.

Thanks
David

WARNING: multiple messages have this Message-ID (diff)
From: dh.herrmann@gmail.com (David Herrmann)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 0/3] Introduce LSM-hook for socketpair(2)
Date: Fri, 4 May 2018 16:29:14 +0200	[thread overview]
Message-ID: <CANq1E4QgRUvG4WJ_XZoWpvegE-TRF5CddiSptNUFQkURJr5Znw@mail.gmail.com> (raw)
In-Reply-To: <alpine.LRH.2.21.1804260502030.12534@namei.org>

Hey

On Wed, Apr 25, 2018 at 9:02 PM, James Morris <jmorris@namei.org> wrote:
> On Wed, 25 Apr 2018, Paul Moore wrote:
>
>> On Wed, Apr 25, 2018 at 2:44 PM, James Morris <jmorris@namei.org> wrote:
>> > On Mon, 23 Apr 2018, David Herrmann wrote:
>> >> This patch series tries to close this gap and makes both behave the
>> >> same. A new LSM-hook is added which allows LSMs to cache the correct
>> >> peer information on newly created socket-pairs.
>> >
>> > Looks okay to me.
>> >
>> > Once it's respun with the Smack backend and maybe the hook name change,
>> > I'll merge this unless DaveM wants it to go in via his networking tree.
>>
>> Note my objection to the hook placement in patch 2/3; I think we
>> should move the hook out of the AF_UNIX layer and up into the socket
>> layer.
>
> I vote for this as it maintains the intended abstraction of the socket
> API.

Sounds good, I changed it. I will send v2 shortly.

Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-05-04 14:29 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23 13:30 [PATCH 0/3] Introduce LSM-hook for socketpair(2) David Herrmann
2018-04-23 13:30 ` David Herrmann
2018-04-23 13:30 ` [PATCH 1/3] security: add hook for socketpair(AF_UNIX, ...) David Herrmann
2018-04-23 13:30   ` David Herrmann
2018-04-23 13:30 ` [PATCH 2/3] net/unix: hook unix_socketpair() into LSM David Herrmann
2018-04-23 13:30   ` David Herrmann
2018-04-24 17:55   ` Paul Moore
2018-04-24 17:55     ` Paul Moore
2018-04-24 17:56     ` David Miller
2018-04-24 17:56       ` David Miller
2018-04-24 17:58       ` Paul Moore
2018-04-24 17:58         ` Paul Moore
2018-04-23 13:30 ` [PATCH 3/3] selinux: provide unix_stream_socketpair callback David Herrmann
2018-04-23 13:30   ` David Herrmann
2018-04-23 16:48   ` Stephen Smalley
2018-04-23 16:48     ` Stephen Smalley
2018-04-23 17:04 ` [PATCH 0/3] Introduce LSM-hook for socketpair(2) Casey Schaufler
2018-04-23 17:04   ` Casey Schaufler
2018-04-23 17:52 ` Serge E. Hallyn
2018-04-23 17:52   ` Serge E. Hallyn
2018-04-25 18:44 ` James Morris
2018-04-25 18:44   ` James Morris
2018-04-25 18:48   ` David Miller
2018-04-25 18:48     ` David Miller
2018-04-25 18:51   ` Paul Moore
2018-04-25 18:51     ` Paul Moore
2018-04-25 19:02     ` James Morris
2018-04-25 19:02       ` James Morris
2018-05-04 14:29       ` David Herrmann [this message]
2018-05-04 14:29         ` David Herrmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANq1E4QgRUvG4WJ_XZoWpvegE-TRF5CddiSptNUFQkURJr5Znw@mail.gmail.com \
    --to=dh.herrmann@gmail.com \
    --cc=davem@davemloft.net \
    --cc=eparis@parisplace.org \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    --cc=serge@hallyn.com \
    --cc=teg@jklm.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.