* [PATCH V2] dt-bindings: bridge: samsung-dsim: Make some flags optional
@ 2023-05-28 13:27 ` Adam Ford
0 siblings, 0 replies; 10+ messages in thread
From: Adam Ford @ 2023-05-28 13:27 UTC (permalink / raw)
To: dri-devel
Cc: Neil Armstrong, Conor Dooley, Robert Foss, Krzysztof Kozlowski,
Jonas Karlman, Laurent Pinchart, aford, Jernej Skrabec,
linux-kernel, Conor Dooley, Rob Herring, Jagan Teki,
Andrzej Hajda, Adam Ford, devicetree, Marek Szyprowski
In the event a device is connected to the samsung-dsim
controller that doesn't support the burst-clock, the
driver is able to get the requested pixel clock from the
attached device or bridge. In these instances, the
samsung,burst-clock-frequency isn't needed, so remove
it from the required list.
The pll-clock frequency can be set by the device tree entry
for samsung,pll-clock-frequency, but in some cases, the
pll-clock may have the same clock rate as sclk_mipi clock.
If they are equal, this flag is not needed since the driver
will use the sclk_mipi rate as a fallback.
Signed-off-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
---
V2: Split from driver series. Re-word updates for burst
and pll-clock frequency.
diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
index 9f61ebdfefa8..06b6c44d4641 100644
--- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
@@ -70,7 +70,9 @@ properties:
samsung,burst-clock-frequency:
$ref: /schemas/types.yaml#/definitions/uint32
description:
- DSIM high speed burst mode frequency.
+ DSIM high speed burst mode frequency. If absent,
+ the pixel clock from the attached device or bridge
+ will be used instead.
samsung,esc-clock-frequency:
$ref: /schemas/types.yaml#/definitions/uint32
@@ -80,7 +82,8 @@ properties:
samsung,pll-clock-frequency:
$ref: /schemas/types.yaml#/definitions/uint32
description:
- DSIM oscillator clock frequency.
+ DSIM oscillator clock frequency. If absent, the clock frequency
+ of sclk_mipi will be used instead.
phys:
maxItems: 1
@@ -134,9 +137,7 @@ required:
- compatible
- interrupts
- reg
- - samsung,burst-clock-frequency
- samsung,esc-clock-frequency
- - samsung,pll-clock-frequency
allOf:
- $ref: ../dsi-controller.yaml#
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH V2] dt-bindings: bridge: samsung-dsim: Make some flags optional
2023-05-28 13:27 ` Adam Ford
@ 2023-05-28 13:34 ` Jagan Teki
-1 siblings, 0 replies; 10+ messages in thread
From: Jagan Teki @ 2023-05-28 13:34 UTC (permalink / raw)
To: Adam Ford
Cc: dri-devel, aford, Conor Dooley, Inki Dae, Marek Szyprowski,
Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-kernel
On Sun, May 28, 2023 at 6:57 PM Adam Ford <aford173@gmail.com> wrote:
>
> In the event a device is connected to the samsung-dsim
> controller that doesn't support the burst-clock, the
> driver is able to get the requested pixel clock from the
> attached device or bridge. In these instances, the
> samsung,burst-clock-frequency isn't needed, so remove
> it from the required list.
>
> The pll-clock frequency can be set by the device tree entry
> for samsung,pll-clock-frequency, but in some cases, the
> pll-clock may have the same clock rate as sclk_mipi clock.
> If they are equal, this flag is not needed since the driver
> will use the sclk_mipi rate as a fallback.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> V2: Split from driver series. Re-word updates for burst
> and pll-clock frequency.
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> index 9f61ebdfefa8..06b6c44d4641 100644
> --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> @@ -70,7 +70,9 @@ properties:
> samsung,burst-clock-frequency:
> $ref: /schemas/types.yaml#/definitions/uint32
> description:
> - DSIM high speed burst mode frequency.
> + DSIM high speed burst mode frequency. If absent,
> + the pixel clock from the attached device or bridge
> + will be used instead.
>
> samsung,esc-clock-frequency:
> $ref: /schemas/types.yaml#/definitions/uint32
> @@ -80,7 +82,8 @@ properties:
> samsung,pll-clock-frequency:
> $ref: /schemas/types.yaml#/definitions/uint32
> description:
> - DSIM oscillator clock frequency.
> + DSIM oscillator clock frequency. If absent, the clock frequency
> + of sclk_mipi will be used instead.
Maybe this explicit comment won't require as it is not listed in "required"
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2] dt-bindings: bridge: samsung-dsim: Make some flags optional
@ 2023-05-28 13:34 ` Jagan Teki
0 siblings, 0 replies; 10+ messages in thread
From: Jagan Teki @ 2023-05-28 13:34 UTC (permalink / raw)
To: Adam Ford
Cc: Neil Armstrong, Conor Dooley, Jernej Skrabec, Robert Foss,
Krzysztof Kozlowski, Jonas Karlman, aford, dri-devel,
linux-kernel, Conor Dooley, Rob Herring, Laurent Pinchart,
Andrzej Hajda, devicetree, Marek Szyprowski
On Sun, May 28, 2023 at 6:57 PM Adam Ford <aford173@gmail.com> wrote:
>
> In the event a device is connected to the samsung-dsim
> controller that doesn't support the burst-clock, the
> driver is able to get the requested pixel clock from the
> attached device or bridge. In these instances, the
> samsung,burst-clock-frequency isn't needed, so remove
> it from the required list.
>
> The pll-clock frequency can be set by the device tree entry
> for samsung,pll-clock-frequency, but in some cases, the
> pll-clock may have the same clock rate as sclk_mipi clock.
> If they are equal, this flag is not needed since the driver
> will use the sclk_mipi rate as a fallback.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> V2: Split from driver series. Re-word updates for burst
> and pll-clock frequency.
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> index 9f61ebdfefa8..06b6c44d4641 100644
> --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> @@ -70,7 +70,9 @@ properties:
> samsung,burst-clock-frequency:
> $ref: /schemas/types.yaml#/definitions/uint32
> description:
> - DSIM high speed burst mode frequency.
> + DSIM high speed burst mode frequency. If absent,
> + the pixel clock from the attached device or bridge
> + will be used instead.
>
> samsung,esc-clock-frequency:
> $ref: /schemas/types.yaml#/definitions/uint32
> @@ -80,7 +82,8 @@ properties:
> samsung,pll-clock-frequency:
> $ref: /schemas/types.yaml#/definitions/uint32
> description:
> - DSIM oscillator clock frequency.
> + DSIM oscillator clock frequency. If absent, the clock frequency
> + of sclk_mipi will be used instead.
Maybe this explicit comment won't require as it is not listed in "required"
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2] dt-bindings: bridge: samsung-dsim: Make some flags optional
2023-05-28 13:34 ` Jagan Teki
@ 2023-05-28 18:14 ` Adam Ford
-1 siblings, 0 replies; 10+ messages in thread
From: Adam Ford @ 2023-05-28 18:14 UTC (permalink / raw)
To: Jagan Teki
Cc: dri-devel, aford, Conor Dooley, Inki Dae, Marek Szyprowski,
Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-kernel
On Sun, May 28, 2023 at 8:34 AM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Sun, May 28, 2023 at 6:57 PM Adam Ford <aford173@gmail.com> wrote:
> >
> > In the event a device is connected to the samsung-dsim
> > controller that doesn't support the burst-clock, the
> > driver is able to get the requested pixel clock from the
> > attached device or bridge. In these instances, the
> > samsung,burst-clock-frequency isn't needed, so remove
> > it from the required list.
> >
> > The pll-clock frequency can be set by the device tree entry
> > for samsung,pll-clock-frequency, but in some cases, the
> > pll-clock may have the same clock rate as sclk_mipi clock.
> > If they are equal, this flag is not needed since the driver
> > will use the sclk_mipi rate as a fallback.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> > ---
> > V2: Split from driver series. Re-word updates for burst
> > and pll-clock frequency.
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> > index 9f61ebdfefa8..06b6c44d4641 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> > @@ -70,7 +70,9 @@ properties:
> > samsung,burst-clock-frequency:
> > $ref: /schemas/types.yaml#/definitions/uint32
> > description:
> > - DSIM high speed burst mode frequency.
> > + DSIM high speed burst mode frequency. If absent,
> > + the pixel clock from the attached device or bridge
> > + will be used instead.
> >
> > samsung,esc-clock-frequency:
> > $ref: /schemas/types.yaml#/definitions/uint32
> > @@ -80,7 +82,8 @@ properties:
> > samsung,pll-clock-frequency:
> > $ref: /schemas/types.yaml#/definitions/uint32
> > description:
> > - DSIM oscillator clock frequency.
> > + DSIM oscillator clock frequency. If absent, the clock frequency
> > + of sclk_mipi will be used instead.
>
> Maybe this explicit comment won't require as it is not listed in "required"
I mostly listed it here to explain why it's being removed from the
required list and what happens if it's missing.
>
> Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2] dt-bindings: bridge: samsung-dsim: Make some flags optional
@ 2023-05-28 18:14 ` Adam Ford
0 siblings, 0 replies; 10+ messages in thread
From: Adam Ford @ 2023-05-28 18:14 UTC (permalink / raw)
To: Jagan Teki
Cc: Neil Armstrong, Conor Dooley, Jernej Skrabec, Robert Foss,
Krzysztof Kozlowski, Jonas Karlman, aford, dri-devel,
linux-kernel, Conor Dooley, Rob Herring, Laurent Pinchart,
Andrzej Hajda, devicetree, Marek Szyprowski
On Sun, May 28, 2023 at 8:34 AM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Sun, May 28, 2023 at 6:57 PM Adam Ford <aford173@gmail.com> wrote:
> >
> > In the event a device is connected to the samsung-dsim
> > controller that doesn't support the burst-clock, the
> > driver is able to get the requested pixel clock from the
> > attached device or bridge. In these instances, the
> > samsung,burst-clock-frequency isn't needed, so remove
> > it from the required list.
> >
> > The pll-clock frequency can be set by the device tree entry
> > for samsung,pll-clock-frequency, but in some cases, the
> > pll-clock may have the same clock rate as sclk_mipi clock.
> > If they are equal, this flag is not needed since the driver
> > will use the sclk_mipi rate as a fallback.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> > ---
> > V2: Split from driver series. Re-word updates for burst
> > and pll-clock frequency.
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> > index 9f61ebdfefa8..06b6c44d4641 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> > @@ -70,7 +70,9 @@ properties:
> > samsung,burst-clock-frequency:
> > $ref: /schemas/types.yaml#/definitions/uint32
> > description:
> > - DSIM high speed burst mode frequency.
> > + DSIM high speed burst mode frequency. If absent,
> > + the pixel clock from the attached device or bridge
> > + will be used instead.
> >
> > samsung,esc-clock-frequency:
> > $ref: /schemas/types.yaml#/definitions/uint32
> > @@ -80,7 +82,8 @@ properties:
> > samsung,pll-clock-frequency:
> > $ref: /schemas/types.yaml#/definitions/uint32
> > description:
> > - DSIM oscillator clock frequency.
> > + DSIM oscillator clock frequency. If absent, the clock frequency
> > + of sclk_mipi will be used instead.
>
> Maybe this explicit comment won't require as it is not listed in "required"
I mostly listed it here to explain why it's being removed from the
required list and what happens if it's missing.
>
> Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2] dt-bindings: bridge: samsung-dsim: Make some flags optional
2023-05-28 13:27 ` Adam Ford
@ 2023-05-28 22:33 ` Fabio Estevam
-1 siblings, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2023-05-28 22:33 UTC (permalink / raw)
To: Adam Ford
Cc: dri-devel, Neil Armstrong, Conor Dooley, Robert Foss,
Krzysztof Kozlowski, Jonas Karlman, Laurent Pinchart, aford,
Jernej Skrabec, linux-kernel, Conor Dooley, Rob Herring,
Jagan Teki, Andrzej Hajda, devicetree, Marek Szyprowski
On Sun, May 28, 2023 at 10:27 AM Adam Ford <aford173@gmail.com> wrote:
>
> In the event a device is connected to the samsung-dsim
> controller that doesn't support the burst-clock, the
> driver is able to get the requested pixel clock from the
> attached device or bridge. In these instances, the
> samsung,burst-clock-frequency isn't needed, so remove
> it from the required list.
>
> The pll-clock frequency can be set by the device tree entry
> for samsung,pll-clock-frequency, but in some cases, the
> pll-clock may have the same clock rate as sclk_mipi clock.
> If they are equal, this flag is not needed since the driver
> will use the sclk_mipi rate as a fallback.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> V2: Split from driver series. Re-word updates for burst
> and pll-clock frequency.
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2] dt-bindings: bridge: samsung-dsim: Make some flags optional
@ 2023-05-28 22:33 ` Fabio Estevam
0 siblings, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2023-05-28 22:33 UTC (permalink / raw)
To: Adam Ford
Cc: Neil Armstrong, Conor Dooley, Jernej Skrabec, Robert Foss,
Andrzej Hajda, Jonas Karlman, aford, dri-devel, linux-kernel,
Conor Dooley, Rob Herring, Laurent Pinchart, Krzysztof Kozlowski,
Marek Szyprowski, devicetree, Jagan Teki
On Sun, May 28, 2023 at 10:27 AM Adam Ford <aford173@gmail.com> wrote:
>
> In the event a device is connected to the samsung-dsim
> controller that doesn't support the burst-clock, the
> driver is able to get the requested pixel clock from the
> attached device or bridge. In these instances, the
> samsung,burst-clock-frequency isn't needed, so remove
> it from the required list.
>
> The pll-clock frequency can be set by the device tree entry
> for samsung,pll-clock-frequency, but in some cases, the
> pll-clock may have the same clock rate as sclk_mipi clock.
> If they are equal, this flag is not needed since the driver
> will use the sclk_mipi rate as a fallback.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> V2: Split from driver series. Re-word updates for burst
> and pll-clock frequency.
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2] dt-bindings: bridge: samsung-dsim: Make some flags optional
2023-05-28 13:27 ` Adam Ford
@ 2023-05-30 8:06 ` Neil Armstrong
-1 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2023-05-30 8:06 UTC (permalink / raw)
To: dri-devel, Adam Ford
Cc: aford, Conor Dooley, Inki Dae, Jagan Teki, Marek Szyprowski,
Andrzej Hajda, Robert Foss, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, devicetree, linux-kernel
Hi,
On Sun, 28 May 2023 08:27:27 -0500, Adam Ford wrote:
> In the event a device is connected to the samsung-dsim
> controller that doesn't support the burst-clock, the
> driver is able to get the requested pixel clock from the
> attached device or bridge. In these instances, the
> samsung,burst-clock-frequency isn't needed, so remove
> it from the required list.
>
> [...]
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
[1/1] dt-bindings: bridge: samsung-dsim: Make some flags optional
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=5769b45abedca0b9d14145e156c180af36139416
--
Neil
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH V2] dt-bindings: bridge: samsung-dsim: Make some flags optional
@ 2023-05-30 8:06 ` Neil Armstrong
0 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2023-05-30 8:06 UTC (permalink / raw)
To: dri-devel, Adam Ford
Cc: devicetree, Conor Dooley, Robert Foss, Krzysztof Kozlowski,
Jonas Karlman, Laurent Pinchart, aford, Jernej Skrabec,
linux-kernel, Conor Dooley, Rob Herring, Jagan Teki,
Andrzej Hajda, Marek Szyprowski
Hi,
On Sun, 28 May 2023 08:27:27 -0500, Adam Ford wrote:
> In the event a device is connected to the samsung-dsim
> controller that doesn't support the burst-clock, the
> driver is able to get the requested pixel clock from the
> attached device or bridge. In these instances, the
> samsung,burst-clock-frequency isn't needed, so remove
> it from the required list.
>
> [...]
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
[1/1] dt-bindings: bridge: samsung-dsim: Make some flags optional
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=5769b45abedca0b9d14145e156c180af36139416
--
Neil
^ permalink raw reply [flat|nested] 10+ messages in thread