From: Adam Ford <aford173@gmail.com> To: Lucas Stach <l.stach@pengutronix.de> Cc: Rob Herring <robh@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Fabio Estevam <festevam@gmail.com>, Marek Vasut <marex@denx.de>, Frieder Schrempf <frieder.schrempf@kontron.de>, NXP Linux Team <linux-imx@nxp.com>, Sascha Hauer <kernel@pengutronix.de>, patchwork-lst@pengutronix.de, devicetree <devicetree@vger.kernel.org>, arm-soc <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v2 08/13] dt-bindings: imx: gpcv2: add support for optional resets Date: Mon, 22 Mar 2021 13:19:37 -0500 [thread overview] Message-ID: <CAHCN7xLdkEd0G3fa9gAp-xvKZ-bYmvcyn-8OEbgNjBJyCCOs9g@mail.gmail.com> (raw) In-Reply-To: <5b6c97dc74ccb38107a50972427d091cdb114209.camel@pengutronix.de> On Tue, Nov 17, 2020 at 8:11 AM Lucas Stach <l.stach@pengutronix.de> wrote: > > Am Montag, den 09.11.2020, 14:15 -0600 schrieb Rob Herring: > > On Thu, Nov 05, 2020 at 06:44:29PM +0100, Lucas Stach wrote: > > > For some domains the resets of the devices in the domain are not > > > automatically triggered. Add an optional resets property to allow > > > the GPC driver to trigger those resets explicitly. > > > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > > --- > > > Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > > > index a96e6dbf1858..4330c73a2c30 100644 > > > --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > > > +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > > > @@ -66,6 +66,13 @@ properties: > > > > > > power-supply: true > > > > > > + resets: > > > + description: | > > > + A number of phandles to resets that need to be asserted during > > > + power-up sequencing of the domain. > > > + minItems: 1 > > > + maxItems: 4 > > > > You need to define what each reset is. > > I can't. The resets belong to devices located inside the power domain, > which need to be held in reset across the power-up sequence. So I have > no means to specify what each reset is in a generic power-domain > binding. Same situation as with the clocks in this binding actually. > Rob, Do you have any guidance on how we might be able to give you want you want so we can move forward? This power-domain driver will be used for a variety of Freescale/NXP IMX SoC's, and looking at other power domain controllers [1], they don't explicitly define what each reset is. Since the resets for this family vary from SoC to SoC, the number of resets will change from one SoC to another. If you could give us a suggestion or an example of a board that has the power-domain resets do what you ask, it would help move this forward. Without this driver, several boards are unable to use a significant number of peripherals. adam [1] - https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.yaml?h=v5.12-rc4 > Regards, > Lucas >
WARNING: multiple messages have this Message-ID (diff)
From: Adam Ford <aford173@gmail.com> To: Lucas Stach <l.stach@pengutronix.de> Cc: Rob Herring <robh@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Fabio Estevam <festevam@gmail.com>, Marek Vasut <marex@denx.de>, Frieder Schrempf <frieder.schrempf@kontron.de>, NXP Linux Team <linux-imx@nxp.com>, Sascha Hauer <kernel@pengutronix.de>, patchwork-lst@pengutronix.de, devicetree <devicetree@vger.kernel.org>, arm-soc <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v2 08/13] dt-bindings: imx: gpcv2: add support for optional resets Date: Mon, 22 Mar 2021 13:19:37 -0500 [thread overview] Message-ID: <CAHCN7xLdkEd0G3fa9gAp-xvKZ-bYmvcyn-8OEbgNjBJyCCOs9g@mail.gmail.com> (raw) In-Reply-To: <5b6c97dc74ccb38107a50972427d091cdb114209.camel@pengutronix.de> On Tue, Nov 17, 2020 at 8:11 AM Lucas Stach <l.stach@pengutronix.de> wrote: > > Am Montag, den 09.11.2020, 14:15 -0600 schrieb Rob Herring: > > On Thu, Nov 05, 2020 at 06:44:29PM +0100, Lucas Stach wrote: > > > For some domains the resets of the devices in the domain are not > > > automatically triggered. Add an optional resets property to allow > > > the GPC driver to trigger those resets explicitly. > > > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > > --- > > > Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > > > index a96e6dbf1858..4330c73a2c30 100644 > > > --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > > > +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > > > @@ -66,6 +66,13 @@ properties: > > > > > > power-supply: true > > > > > > + resets: > > > + description: | > > > + A number of phandles to resets that need to be asserted during > > > + power-up sequencing of the domain. > > > + minItems: 1 > > > + maxItems: 4 > > > > You need to define what each reset is. > > I can't. The resets belong to devices located inside the power domain, > which need to be held in reset across the power-up sequence. So I have > no means to specify what each reset is in a generic power-domain > binding. Same situation as with the clocks in this binding actually. > Rob, Do you have any guidance on how we might be able to give you want you want so we can move forward? This power-domain driver will be used for a variety of Freescale/NXP IMX SoC's, and looking at other power domain controllers [1], they don't explicitly define what each reset is. Since the resets for this family vary from SoC to SoC, the number of resets will change from one SoC to another. If you could give us a suggestion or an example of a board that has the power-domain resets do what you ask, it would help move this forward. Without this driver, several boards are unable to use a significant number of peripherals. adam [1] - https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.yaml?h=v5.12-rc4 > Regards, > Lucas > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-22 18:20 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-05 17:44 [PATCH v2 00/13] i.MX8MM power domain support Lucas Stach 2020-11-05 17:44 ` Lucas Stach 2020-11-05 17:44 ` [PATCH v2 01/13] soc: imx: gpcv2: move to more ideomatic error handling in probe Lucas Stach 2020-11-05 17:44 ` Lucas Stach 2020-11-16 14:10 ` Adam Ford 2020-11-16 14:10 ` Adam Ford 2020-11-05 17:44 ` [PATCH v2 02/13] soc: imx: gpcv2: move domain mapping to domain driver probe Lucas Stach 2020-11-05 17:44 ` Lucas Stach 2020-11-05 17:44 ` [PATCH v2 03/13] soc: imx: gpcv2: switch to clk_bulk_* API Lucas Stach 2020-11-05 17:44 ` Lucas Stach 2020-11-05 17:44 ` [PATCH v2 04/13] soc: imx: gpcv2: split power up and power down sequence control Lucas Stach 2020-11-05 17:44 ` Lucas Stach 2020-11-05 17:44 ` [PATCH v2 05/13] soc: imx: gpcv2: wait for ADB400 handshake Lucas Stach 2020-11-05 17:44 ` Lucas Stach 2020-11-05 17:44 ` [PATCH v2 06/13] soc: imx: gpcv2: add runtime PM support for power-domains Lucas Stach 2020-11-05 17:44 ` Lucas Stach 2020-11-05 17:44 ` [PATCH v2 07/13] soc: imx: gpcv2: allow domains without power-sequence control Lucas Stach 2020-11-05 17:44 ` Lucas Stach 2020-11-05 17:44 ` [PATCH v2 08/13] dt-bindings: imx: gpcv2: add support for optional resets Lucas Stach 2020-11-05 17:44 ` Lucas Stach 2020-11-09 20:15 ` Rob Herring 2020-11-09 20:15 ` Rob Herring 2020-11-17 14:11 ` Lucas Stach 2020-11-17 14:11 ` Lucas Stach 2020-11-30 9:57 ` Lucas Stach 2020-11-30 9:57 ` Lucas Stach 2021-02-10 14:35 ` Lucas Stach 2021-02-10 14:35 ` Lucas Stach 2021-02-10 14:42 ` Marek Vasut 2021-02-10 14:42 ` Marek Vasut 2021-04-26 9:24 ` Frieder Schrempf 2021-04-26 9:24 ` Frieder Schrempf 2021-04-29 14:38 ` Frieder Schrempf 2021-04-29 14:38 ` Frieder Schrempf 2021-03-22 18:19 ` Adam Ford [this message] 2021-03-22 18:19 ` Adam Ford 2020-11-05 17:44 ` [PATCH v2 09/13] soc: " Lucas Stach 2020-11-05 17:44 ` Lucas Stach 2020-11-05 17:44 ` [PATCH v2 10/13] dt-bindings: add defines for i.MX8MM power domains Lucas Stach 2020-11-05 17:44 ` Lucas Stach 2020-11-09 20:34 ` Rob Herring 2020-11-09 20:34 ` Rob Herring 2020-11-05 17:44 ` [PATCH v2 11/13] soc: imx: gpcv2: add support " Lucas Stach 2020-11-05 17:44 ` Lucas Stach 2020-11-05 17:44 ` [PATCH v2 12/13] arm64: dts: imx8mm: add GPC node and " Lucas Stach 2020-11-05 17:44 ` Lucas Stach 2020-12-09 15:26 ` Frieder Schrempf 2020-12-09 15:26 ` Frieder Schrempf 2021-01-14 10:39 ` Frieder Schrempf 2021-02-18 12:54 ` Adam Ford 2021-02-18 15:19 ` Adam Ford 2021-03-02 15:01 ` Frieder Schrempf 2021-03-02 16:46 ` Adam Ford 2020-11-05 17:44 ` [PATCH v2 13/13] arm64: dts: imx8mm: put USB controllers into power-domains Lucas Stach 2020-11-05 17:44 ` Lucas Stach 2021-05-06 1:04 [PATCH V2 00/13] soc: imx: gpcv2: support i.MX8MM Peng Fan (OSS) 2021-05-06 1:04 ` [PATCH V2 08/13] dt-bindings: imx: gpcv2: add support for optional resets Peng Fan (OSS) 2021-05-06 1:04 ` Peng Fan (OSS) 2021-05-06 6:43 ` Frieder Schrempf 2021-05-06 6:43 ` Frieder Schrempf 2021-05-07 21:16 ` Rob Herring 2021-05-07 21:16 ` Rob Herring 2021-05-08 0:50 ` Peng Fan 2021-05-08 0:50 ` Peng Fan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAHCN7xLdkEd0G3fa9gAp-xvKZ-bYmvcyn-8OEbgNjBJyCCOs9g@mail.gmail.com \ --to=aford173@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=frieder.schrempf@kontron.de \ --cc=kernel@pengutronix.de \ --cc=l.stach@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=marex@denx.de \ --cc=patchwork-lst@pengutronix.de \ --cc=robh@kernel.org \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.