From: Amit Kucheria <amit.kucheria@linaro.org> To: Ilia Lin <ilialin@codeaurora.org> Cc: Michael Turquette <mturquette@baylibre.com>, sboyd@kernel.org, Rob Herring <robh@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Viresh Kumar <viresh.kumar@linaro.org>, nm@ti.com, lgirdwood@gmail.com, broonie@kernel.org, Andy Gross <andy.gross@linaro.org>, David Brown <david.brown@linaro.org>, catalin.marinas@arm.com, will.deacon@arm.com, "Rafael J. Wysocki" <rjw@rjwysocki.net>, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, Linux PM list <linux-pm@vger.kernel.org>, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, lakml <linux-arm-kernel@lists.infradead.org>, Rajendra Nayak <rnayak@codeaurora.org>, nicolas.dechesne@linaro.org, celster@codeaurora.org, tfinkel@codeaurora.org Subject: Re: [PATCH v7 00/14] CPU scaling support for msm8996 Date: Wed, 16 May 2018 16:11:52 +0300 [thread overview] Message-ID: <CAHLCerOL1R=8jaHT-dKx3xwXVOZhCZMjZwqWYeQtYQsnUZ-NbQ@mail.gmail.com> (raw) In-Reply-To: <1526375616-16904-1-git-send-email-ilialin@codeaurora.org> On Tue, May 15, 2018 at 12:13 PM, Ilia Lin <ilialin@codeaurora.org> wrote: > [v7] > * Addressed comments from Viresh about resourses deallocation > and DT compatible Hi Ilia, Thanks for working on this series. Here a few comments regarding the series as a whole. - The series could use a better cover letter describing how the various patches are grouped. e.g. 1-7 are clock related and probably will get merged through the clk maintainers tree. The regulator bits might get merged through the regulator maintainer tree and so forth. If there are any dependencies, please outline those as well so maintainers can decide how best to merge this. - Please describe what features this series adds - just frequency scaling or more. Please describe in more detail what the dependency on the SAW regulator changes is. - Please get rid of the GPL boiler plate since you already have the SPDX tags. See comments on patch 1 for what I'm referring to. - You also mention that ACD is not implemented in the earlier patches and then there is a patch that seems to add ACD related features (7/14). A few other comments follow across the individual patches. Regards, Amit > [v6] > * Addressed comments from Viresh about: > ** Comments style > ** Kconfig bool instead of tristate > ** DT and documentation style > ** Resourses deallocation on an error > ** Typos > > [v5] > * Rebased > * Addressed comments from Bjorn about SPDX style, > functions and parameters naming > * Addressed comments from Viresh DT properties and style, comments style, > resourses deallocation, documentation placement > * Addressed comments from Sricharan about unnessesary include > * Addressed comments from Nicolas > * Addressed comments from Rob about the commit messages and acks > * Addressed comments from Mark > > [v4] > * Adressed all comments from Stephen > * Added CPU regulator support > * Added qcom-cpufreq-kryo driver > > [v3] > * Rebased on top of the latest PLL driver changes > * Addressed comment from Rob Herring for bindings > > [v2] > * Addressed comments from Rob Herring for bindings > * Addressed comments from Mark Rutland for memory barrier > * Addressed comments from Julien Thierry for clock reenabling condition > * Tuned the HW configuration for clock frequencies below 600MHz > > Clocks: > This series adds support for the CPU clocks on msm8996 devices. > The driver uses the existing PLL drivers and is required to control > the CPU frequency scaling on the MSM8996. > > Regulators: > Added SAW regulator support to the SPMI regulator driver. The SAW regulators > will be controlled through special CPU registers instead of direct > SPMI accesses. > > Cpufreq: > The qcom-cpufreq-kryo driver is aimed to support different SOC versions. > The driver reads eFuse information and chooses the required OPP subset > by passing the OPP supported-hw parameter. > > A previous post of RFC can be found here: > https://patchwork.kernel.org/patch/10398455/ > > Ilia Lin (11): > soc: qcom: Separate kryo l2 accessors from PMU driver > clk: qcom: Add CPU clock driver for msm8996 > clk: qcom: Add DT bindings for CPU clock driver for msm8996 > clk: qcom: Add ACD path to CPU clock driver for msm8996 > dt: qcom: Add opp and thermal to the msm8996 > regulator: qcom_spmi: Add support for SAW > dt-bindings: qcom_spmi: Add support for SAW documentation > dt: qcom: Add SAW regulator for 8x96 CPUs > cpufreq: Add Kryo CPU scaling driver > dt-bindings: cpufreq: Document operating-points-v2-kryo-cpu > dt: qcom: Add qcom-cpufreq-kryo driver configuration > > Rajendra Nayak (3): > clk: qcom: Make clk_alpha_pll_configure available to modules > clk: qcom: cpu-8996: Add support to switch to alternate PLL > clk: qcom: cpu-8996: Add support to switch below 600Mhz > > .../devicetree/bindings/clock/qcom,kryocc.txt | 17 + > .../devicetree/bindings/opp/kryo-cpufreq.txt | 680 +++++++++++++++++++++ > .../bindings/regulator/qcom,spmi-regulator.txt | 45 ++ > arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 2 +- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 651 +++++++++++++++++++- > drivers/clk/clk-fixed-factor.c | 2 +- > drivers/clk/qcom/Kconfig | 9 + > drivers/clk/qcom/Makefile | 1 + > drivers/clk/qcom/clk-alpha-pll.c | 1 + > drivers/clk/qcom/clk-alpha-pll.h | 6 + > drivers/clk/qcom/clk-cpu-8996.c | 519 ++++++++++++++++ > drivers/cpufreq/Kconfig.arm | 11 + > drivers/cpufreq/Makefile | 1 + > drivers/cpufreq/cpufreq-dt-platdev.c | 3 + > drivers/cpufreq/qcom-cpufreq-kryo.c | 150 +++++ > drivers/perf/Kconfig | 1 + > drivers/perf/qcom_l2_pmu.c | 90 +-- > drivers/regulator/qcom_spmi-regulator.c | 133 +++- > drivers/soc/qcom/Kconfig | 3 + > drivers/soc/qcom/Makefile | 1 + > drivers/soc/qcom/kryo-l2-accessors.c | 65 ++ > include/soc/qcom/kryo-l2-accessors.h | 21 + > 22 files changed, 2332 insertions(+), 80 deletions(-) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,kryocc.txt > create mode 100644 Documentation/devicetree/bindings/opp/kryo-cpufreq.txt > create mode 100644 drivers/clk/qcom/clk-cpu-8996.c > create mode 100644 drivers/cpufreq/qcom-cpufreq-kryo.c > create mode 100644 drivers/soc/qcom/kryo-l2-accessors.c > create mode 100644 include/soc/qcom/kryo-l2-accessors.h > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: amit.kucheria@linaro.org (Amit Kucheria) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v7 00/14] CPU scaling support for msm8996 Date: Wed, 16 May 2018 16:11:52 +0300 [thread overview] Message-ID: <CAHLCerOL1R=8jaHT-dKx3xwXVOZhCZMjZwqWYeQtYQsnUZ-NbQ@mail.gmail.com> (raw) In-Reply-To: <1526375616-16904-1-git-send-email-ilialin@codeaurora.org> On Tue, May 15, 2018 at 12:13 PM, Ilia Lin <ilialin@codeaurora.org> wrote: > [v7] > * Addressed comments from Viresh about resourses deallocation > and DT compatible Hi Ilia, Thanks for working on this series. Here a few comments regarding the series as a whole. - The series could use a better cover letter describing how the various patches are grouped. e.g. 1-7 are clock related and probably will get merged through the clk maintainers tree. The regulator bits might get merged through the regulator maintainer tree and so forth. If there are any dependencies, please outline those as well so maintainers can decide how best to merge this. - Please describe what features this series adds - just frequency scaling or more. Please describe in more detail what the dependency on the SAW regulator changes is. - Please get rid of the GPL boiler plate since you already have the SPDX tags. See comments on patch 1 for what I'm referring to. - You also mention that ACD is not implemented in the earlier patches and then there is a patch that seems to add ACD related features (7/14). A few other comments follow across the individual patches. Regards, Amit > [v6] > * Addressed comments from Viresh about: > ** Comments style > ** Kconfig bool instead of tristate > ** DT and documentation style > ** Resourses deallocation on an error > ** Typos > > [v5] > * Rebased > * Addressed comments from Bjorn about SPDX style, > functions and parameters naming > * Addressed comments from Viresh DT properties and style, comments style, > resourses deallocation, documentation placement > * Addressed comments from Sricharan about unnessesary include > * Addressed comments from Nicolas > * Addressed comments from Rob about the commit messages and acks > * Addressed comments from Mark > > [v4] > * Adressed all comments from Stephen > * Added CPU regulator support > * Added qcom-cpufreq-kryo driver > > [v3] > * Rebased on top of the latest PLL driver changes > * Addressed comment from Rob Herring for bindings > > [v2] > * Addressed comments from Rob Herring for bindings > * Addressed comments from Mark Rutland for memory barrier > * Addressed comments from Julien Thierry for clock reenabling condition > * Tuned the HW configuration for clock frequencies below 600MHz > > Clocks: > This series adds support for the CPU clocks on msm8996 devices. > The driver uses the existing PLL drivers and is required to control > the CPU frequency scaling on the MSM8996. > > Regulators: > Added SAW regulator support to the SPMI regulator driver. The SAW regulators > will be controlled through special CPU registers instead of direct > SPMI accesses. > > Cpufreq: > The qcom-cpufreq-kryo driver is aimed to support different SOC versions. > The driver reads eFuse information and chooses the required OPP subset > by passing the OPP supported-hw parameter. > > A previous post of RFC can be found here: > https://patchwork.kernel.org/patch/10398455/ > > Ilia Lin (11): > soc: qcom: Separate kryo l2 accessors from PMU driver > clk: qcom: Add CPU clock driver for msm8996 > clk: qcom: Add DT bindings for CPU clock driver for msm8996 > clk: qcom: Add ACD path to CPU clock driver for msm8996 > dt: qcom: Add opp and thermal to the msm8996 > regulator: qcom_spmi: Add support for SAW > dt-bindings: qcom_spmi: Add support for SAW documentation > dt: qcom: Add SAW regulator for 8x96 CPUs > cpufreq: Add Kryo CPU scaling driver > dt-bindings: cpufreq: Document operating-points-v2-kryo-cpu > dt: qcom: Add qcom-cpufreq-kryo driver configuration > > Rajendra Nayak (3): > clk: qcom: Make clk_alpha_pll_configure available to modules > clk: qcom: cpu-8996: Add support to switch to alternate PLL > clk: qcom: cpu-8996: Add support to switch below 600Mhz > > .../devicetree/bindings/clock/qcom,kryocc.txt | 17 + > .../devicetree/bindings/opp/kryo-cpufreq.txt | 680 +++++++++++++++++++++ > .../bindings/regulator/qcom,spmi-regulator.txt | 45 ++ > arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 2 +- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 651 +++++++++++++++++++- > drivers/clk/clk-fixed-factor.c | 2 +- > drivers/clk/qcom/Kconfig | 9 + > drivers/clk/qcom/Makefile | 1 + > drivers/clk/qcom/clk-alpha-pll.c | 1 + > drivers/clk/qcom/clk-alpha-pll.h | 6 + > drivers/clk/qcom/clk-cpu-8996.c | 519 ++++++++++++++++ > drivers/cpufreq/Kconfig.arm | 11 + > drivers/cpufreq/Makefile | 1 + > drivers/cpufreq/cpufreq-dt-platdev.c | 3 + > drivers/cpufreq/qcom-cpufreq-kryo.c | 150 +++++ > drivers/perf/Kconfig | 1 + > drivers/perf/qcom_l2_pmu.c | 90 +-- > drivers/regulator/qcom_spmi-regulator.c | 133 +++- > drivers/soc/qcom/Kconfig | 3 + > drivers/soc/qcom/Makefile | 1 + > drivers/soc/qcom/kryo-l2-accessors.c | 65 ++ > include/soc/qcom/kryo-l2-accessors.h | 21 + > 22 files changed, 2332 insertions(+), 80 deletions(-) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,kryocc.txt > create mode 100644 Documentation/devicetree/bindings/opp/kryo-cpufreq.txt > create mode 100644 drivers/clk/qcom/clk-cpu-8996.c > create mode 100644 drivers/cpufreq/qcom-cpufreq-kryo.c > create mode 100644 drivers/soc/qcom/kryo-l2-accessors.c > create mode 100644 include/soc/qcom/kryo-l2-accessors.h > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-16 13:11 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-15 9:13 [PATCH v7 00/14] CPU scaling support for msm8996 Ilia Lin 2018-05-15 9:13 ` Ilia Lin 2018-05-15 9:13 ` [PATCH v7 01/14] soc: qcom: Separate kryo l2 accessors from PMU driver Ilia Lin 2018-05-15 9:13 ` Ilia Lin 2018-05-16 13:12 ` Amit Kucheria 2018-05-16 13:12 ` Amit Kucheria 2018-05-15 9:13 ` [PATCH v7 02/14] clk: qcom: Make clk_alpha_pll_configure available to modules Ilia Lin 2018-05-15 9:13 ` Ilia Lin 2018-05-15 9:13 ` [PATCH v7 03/14] clk: qcom: Add CPU clock driver for msm8996 Ilia Lin 2018-05-15 9:13 ` Ilia Lin 2018-05-16 13:12 ` Amit Kucheria 2018-05-16 13:12 ` Amit Kucheria 2018-05-17 16:31 ` kbuild test robot 2018-05-17 16:31 ` kbuild test robot 2018-05-17 16:31 ` kbuild test robot 2018-05-17 16:51 ` kbuild test robot 2018-05-17 16:51 ` kbuild test robot 2018-05-17 16:51 ` kbuild test robot 2018-05-15 9:13 ` [PATCH v7 04/14] clk: qcom: Add DT bindings for " Ilia Lin 2018-05-15 9:13 ` Ilia Lin 2018-05-15 9:13 ` [PATCH v7 05/14] clk: qcom: cpu-8996: Add support to switch to alternate PLL Ilia Lin 2018-05-15 9:13 ` Ilia Lin 2018-05-15 9:13 ` [PATCH v7 06/14] clk: qcom: cpu-8996: Add support to switch below 600Mhz Ilia Lin 2018-05-15 9:13 ` Ilia Lin 2018-05-15 9:13 ` [PATCH v7 07/14] clk: qcom: Add ACD path to CPU clock driver for msm8996 Ilia Lin 2018-05-15 9:13 ` Ilia Lin 2018-05-15 9:13 ` [PATCH v7 08/14] dt: qcom: Add opp and thermal to the msm8996 Ilia Lin 2018-05-15 9:13 ` Ilia Lin 2018-05-15 9:13 ` [PATCH v7 09/14] regulator: qcom_spmi: Add support for SAW Ilia Lin 2018-05-15 9:13 ` Ilia Lin 2018-05-15 9:13 ` [PATCH v7 10/14] dt-bindings: qcom_spmi: Add support for SAW documentation Ilia Lin 2018-05-15 9:13 ` Ilia Lin 2018-05-16 13:12 ` Amit Kucheria 2018-05-16 13:12 ` Amit Kucheria 2018-05-17 7:24 ` ilialin 2018-05-17 7:24 ` ilialin at codeaurora.org 2018-05-17 7:24 ` ilialin 2018-05-17 7:24 ` ilialin 2018-05-15 9:13 ` [PATCH v7 11/14] dt: qcom: Add SAW regulator for 8x96 CPUs Ilia Lin 2018-05-15 9:13 ` Ilia Lin 2018-05-15 9:13 ` [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver Ilia Lin 2018-05-15 9:13 ` Ilia Lin 2018-05-15 9:19 ` Viresh Kumar 2018-05-15 9:19 ` Viresh Kumar 2018-05-15 9:28 ` Rafael J. Wysocki 2018-05-15 9:28 ` Rafael J. Wysocki 2018-05-16 4:13 ` kbuild test robot 2018-05-16 4:13 ` kbuild test robot 2018-05-16 4:13 ` kbuild test robot 2018-05-16 13:12 ` Amit Kucheria 2018-05-16 13:12 ` Amit Kucheria 2018-05-16 14:11 ` Viresh Kumar 2018-05-16 14:11 ` Viresh Kumar 2018-05-16 14:13 ` Amit Kucheria 2018-05-16 14:13 ` Amit Kucheria 2018-05-16 14:13 ` Amit Kucheria 2018-05-17 7:50 ` ilialin 2018-05-17 7:50 ` ilialin at codeaurora.org 2018-05-17 7:50 ` ilialin 2018-05-17 8:20 ` ilialin 2018-05-17 8:20 ` ilialin at codeaurora.org 2018-05-17 8:20 ` ilialin 2018-05-16 15:45 ` Ilia Lin 2018-05-16 15:45 ` Ilia Lin 2018-05-17 7:19 ` ilialin 2018-05-17 7:19 ` ilialin at codeaurora.org 2018-05-17 7:19 ` ilialin 2018-05-17 7:19 ` ilialin 2018-05-15 9:13 ` [PATCH v7 13/14] dt-bindings: cpufreq: Document operating-points-v2-kryo-cpu Ilia Lin 2018-05-15 9:13 ` Ilia Lin 2018-05-16 13:12 ` Amit Kucheria 2018-05-16 13:12 ` Amit Kucheria 2018-05-15 9:13 ` [PATCH v7 14/14] dt: qcom: Add qcom-cpufreq-kryo driver configuration Ilia Lin 2018-05-15 9:13 ` Ilia Lin 2018-05-15 9:19 ` Viresh Kumar 2018-05-15 9:19 ` Viresh Kumar 2018-05-16 13:12 ` Amit Kucheria 2018-05-16 13:12 ` Amit Kucheria 2018-05-16 13:11 ` Amit Kucheria [this message] 2018-05-16 13:11 ` [PATCH v7 00/14] CPU scaling support for msm8996 Amit Kucheria
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHLCerOL1R=8jaHT-dKx3xwXVOZhCZMjZwqWYeQtYQsnUZ-NbQ@mail.gmail.com' \ --to=amit.kucheria@linaro.org \ --cc=andy.gross@linaro.org \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=celster@codeaurora.org \ --cc=david.brown@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=ilialin@codeaurora.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mturquette@baylibre.com \ --cc=nicolas.dechesne@linaro.org \ --cc=nm@ti.com \ --cc=rjw@rjwysocki.net \ --cc=rnayak@codeaurora.org \ --cc=robh@kernel.org \ --cc=sboyd@kernel.org \ --cc=tfinkel@codeaurora.org \ --cc=viresh.kumar@linaro.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.