All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Kucheria <amit.kucheria@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>, Andy Gross <agross@kernel.org>
Cc: Matthias Kaehlcke <mka@chromium.org>,
	David Brown <david.brown@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	Douglas Anderson <dianders@chromium.org>,
	Rajendra Nayak <rnayak@codeaurora.org>
Subject: Re: [PATCH] arm64: dts: sdm845: Add CPU topology
Date: Thu, 16 May 2019 17:24:45 +0530	[thread overview]
Message-ID: <CAHLCerP69Jw27VyO+ek4Fe3-2fDiOejtz6XZPykPSRA2G1831w@mail.gmail.com> (raw)
In-Reply-To: <155786856719.14659.2902538189660269078@swboyd.mtv.corp.google.com>

(cc'ing Andy's correct email address)

On Wed, May 15, 2019 at 2:46 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Amit Kucheria (2019-05-13 04:54:12)
> > On Mon, May 13, 2019 at 4:31 PM Amit Kucheria <amit.kucheria@linaro.org> wrote:
> > >
> > > On Tue, Jan 15, 2019 at 12:13 AM Matthias Kaehlcke <mka@chromium.org> wrote:
> > > >
> > > > The 8 CPU cores of the SDM845 are organized in two clusters of 4 big
> > > > ("gold") and 4 little ("silver") cores. Add a cpu-map node to the DT
> > > > that describes this topology.
> > >
> > > This is partly true. There are two groups of gold and silver cores,
> > > but AFAICT they are in a single cluster, not two separate ones. SDM845
> > > is one of the early examples of ARM's Dynamiq architecture.
> > >
> > > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > >
> > > I noticed that this patch sneaked through for this merge window but
> > > perhaps we can whip up a quick fix for -rc2?
> > >
> >
> > And please find attached a patch to fix this up. Andy, since this
> > hasn't landed yet (can we still squash this into the original patch?),
> > I couldn't add a Fixes tag.
> >
>
> I had the same concern. Thanks for catching this. I suspect this must
> cause some problem for IPA given that it can't discern between the big
> and little "power clusters"?

Both EAS and IPA, I believe. It influences the scheduler's view of the
the topology.

> Either way,
>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>

Thanks.

Andy/Bjorn, can we squeeze this in for -rc2 as a bugfix?

Regards,
Amit

  reply	other threads:[~2019-05-16 11:54 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14 18:42 [PATCH] arm64: dts: sdm845: Add CPU topology Matthias Kaehlcke
2019-01-18  2:50 ` Doug Anderson
2019-05-13 11:01 ` Amit Kucheria
2019-05-13 11:01   ` Amit Kucheria
2019-05-13 11:54   ` Amit Kucheria
2019-05-13 11:54     ` Amit Kucheria
2019-05-14 21:16     ` Stephen Boyd
2019-05-14 21:16       ` Stephen Boyd
2019-05-16 11:54       ` Amit Kucheria [this message]
2019-05-16 11:54         ` Amit Kucheria
2019-05-17 21:55         ` Stephen Boyd
2019-05-17 21:55           ` Stephen Boyd
2019-06-05 17:20           ` Quentin Perret
2019-06-05 17:20             ` Quentin Perret
2019-06-06  7:05             ` Vincent Guittot
2019-06-06  7:05               ` Vincent Guittot
2019-06-06  7:49               ` Quentin Perret
2019-06-06  7:49                 ` Quentin Perret
2019-06-06  8:20                 ` Vincent Guittot
2019-06-06  8:20                   ` Vincent Guittot
2019-06-06  8:29                   ` Quentin Perret
2019-06-06  8:29                     ` Quentin Perret
2019-06-06  8:34                   ` Dietmar Eggemann
2019-06-06  8:34                     ` Dietmar Eggemann
2019-06-06  8:44                     ` Vincent Guittot
2019-06-06  8:44                       ` Vincent Guittot
2019-06-06 10:50                       ` Morten Rasmussen
2019-06-06 10:50                         ` Morten Rasmussen
2019-05-22  4:03         ` Bjorn Andersson
2019-05-22  4:03           ` Bjorn Andersson
2019-05-16 13:22     ` Sudeep Holla
2019-05-16 13:22       ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHLCerP69Jw27VyO+ek4Fe3-2fDiOejtz6XZPykPSRA2G1831w@mail.gmail.com \
    --to=amit.kucheria@linaro.org \
    --cc=agross@kernel.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mka@chromium.org \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.