From: Andrey Smirnov <andrew.smirnov@gmail.com> To: Trent Piepho <tpiepho@impinj.com> Cc: linux-kernel <linux-kernel@vger.kernel.org>, linux-imx@nxp.com, Richard Zhu <hongxing.zhu@nxp.com>, Chris Healy <cphealy@gmail.com>, Dong Aisheng <aisheng.dong@nxp.com>, Fabio Estevam <fabio.estevam@nxp.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Bjorn Helgaas <bhelgaas@google.com>, Lucas Stach <l.stach@pengutronix.de>, Leonard Crestez <leonard.crestez@nxp.com>, linux-pci@vger.kernel.org Subject: Re: [PATCH 2/3] PCI: imx: No-op imx6_pcie_reset_phy() on i.MX7D Date: Mon, 26 Nov 2018 10:32:12 -0800 [thread overview] Message-ID: <CAHQ1cqG0oVWQw9NC_22f7bZMfX11wwuvO2_x8P3GJYsb-ecGvQ@mail.gmail.com> (raw) In-Reply-To: <1542676938.30311.581.camel@impinj.com> On Mon, Nov 19, 2018 at 5:22 PM Trent Piepho <tpiepho@impinj.com> wrote: > > On Sat, 2018-11-17 at 10:12 -0800, Andrey Smirnov wrote: > > PCIE PHY IP block on i.MX7D differs from the one used on i.MX6 family, > > so none of the code in current implementation of imx6_pcie_reset_phy() > > is applicable. > > Tested on IMX7d, still appears to work. > Thanks for testing! Unless you object, I'll add your Tested-by tag to this patch. > Note that your patches will collide with Stefan Agner's patch, "PCI: > imx6: limit DBI register length", which was recently posted. > > He changed the way the variants are handled. That method would allow > some of the IMX7D || IMX8MQ checks to be re-written as > > imx6_pcie->drvdata->boolean_attribute > > Where the attribute can be set in a table and be re-used in every place > it comes into play and updated for new devices in one spot, instead of > keeping piles of this version or that version or this other version > checks up to date. Thanks for the heads up! I am expecting that I'd have to re-base this series on "next" in PCI tree before it can be applied. This should provide for a good opportunity to discover and resolve all of the conflicts, I think. Thanks, Andrey Smirnov
WARNING: multiple messages have this Message-ID (diff)
From: andrew.smirnov@gmail.com (Andrey Smirnov) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] PCI: imx: No-op imx6_pcie_reset_phy() on i.MX7D Date: Mon, 26 Nov 2018 10:32:12 -0800 [thread overview] Message-ID: <CAHQ1cqG0oVWQw9NC_22f7bZMfX11wwuvO2_x8P3GJYsb-ecGvQ@mail.gmail.com> (raw) In-Reply-To: <1542676938.30311.581.camel@impinj.com> On Mon, Nov 19, 2018 at 5:22 PM Trent Piepho <tpiepho@impinj.com> wrote: > > On Sat, 2018-11-17 at 10:12 -0800, Andrey Smirnov wrote: > > PCIE PHY IP block on i.MX7D differs from the one used on i.MX6 family, > > so none of the code in current implementation of imx6_pcie_reset_phy() > > is applicable. > > Tested on IMX7d, still appears to work. > Thanks for testing! Unless you object, I'll add your Tested-by tag to this patch. > Note that your patches will collide with Stefan Agner's patch, "PCI: > imx6: limit DBI register length", which was recently posted. > > He changed the way the variants are handled. That method would allow > some of the IMX7D || IMX8MQ checks to be re-written as > > imx6_pcie->drvdata->boolean_attribute > > Where the attribute can be set in a table and be re-used in every place > it comes into play and updated for new devices in one spot, instead of > keeping piles of this version or that version or this other version > checks up to date. Thanks for the heads up! I am expecting that I'd have to re-base this series on "next" in PCI tree before it can be applied. This should provide for a good opportunity to discover and resolve all of the conflicts, I think. Thanks, Andrey Smirnov
next prev parent reply other threads:[~2018-11-26 18:32 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-17 18:12 [PATCH 0/3] PCIE support for i.MX8MQ Andrey Smirnov 2018-11-17 18:12 ` Andrey Smirnov 2018-11-17 18:12 ` [PATCH 1/3] PCI: imx: No-op imx6_setup_phy_mpll() on i.MX7D Andrey Smirnov 2018-11-17 18:12 ` Andrey Smirnov 2018-11-17 18:12 ` [PATCH 2/3] PCI: imx: No-op imx6_pcie_reset_phy() " Andrey Smirnov 2018-11-17 18:12 ` Andrey Smirnov 2018-11-20 1:22 ` Trent Piepho 2018-11-20 1:22 ` Trent Piepho 2018-11-26 18:32 ` Andrey Smirnov [this message] 2018-11-26 18:32 ` Andrey Smirnov 2018-11-17 18:12 ` [PATCH 3/3] PCI: imx: Add support for i.MX8MQ Andrey Smirnov 2018-11-17 18:12 ` Andrey Smirnov 2018-11-19 7:07 ` Richard Zhu 2018-11-19 7:07 ` Richard Zhu 2018-11-26 18:09 ` Andrey Smirnov 2018-11-26 18:09 ` Andrey Smirnov 2018-11-29 10:52 ` Richard Zhu 2018-11-29 10:52 ` Richard Zhu 2018-11-20 10:48 ` Leonard Crestez 2018-11-20 10:48 ` Leonard Crestez 2018-11-20 10:48 ` Leonard Crestez 2018-11-26 18:24 ` Andrey Smirnov 2018-11-26 18:24 ` Andrey Smirnov 2018-11-26 18:24 ` Andrey Smirnov 2018-11-27 10:06 ` Lucas Stach 2018-11-27 10:06 ` Lucas Stach 2018-11-27 10:06 ` Lucas Stach 2018-11-27 10:46 ` Leonard Crestez 2018-11-27 10:46 ` Leonard Crestez 2018-11-27 10:46 ` Leonard Crestez 2018-11-27 21:14 ` Andrey Smirnov 2018-11-27 21:14 ` Andrey Smirnov 2018-11-27 21:14 ` Andrey Smirnov 2018-11-28 10:55 ` Leonard Crestez 2018-11-28 10:55 ` Leonard Crestez 2018-11-28 10:55 ` Leonard Crestez 2018-11-29 11:15 ` Lucas Stach 2018-11-29 11:15 ` Lucas Stach 2018-11-29 11:15 ` Lucas Stach 2018-11-29 11:12 ` Lucas Stach 2018-11-29 11:12 ` Lucas Stach 2018-11-29 11:12 ` Lucas Stach 2018-11-27 10:16 ` Leonard Crestez 2018-11-27 10:16 ` Leonard Crestez 2018-11-27 10:16 ` Leonard Crestez 2018-11-27 21:03 ` Andrey Smirnov 2018-11-27 21:03 ` Andrey Smirnov 2018-11-27 21:03 ` Andrey Smirnov 2018-12-03 12:20 ` [PATCH 0/3] PCIE " Lorenzo Pieralisi 2018-12-03 12:20 ` Lorenzo Pieralisi 2018-12-07 11:37 ` Lorenzo Pieralisi 2018-12-07 11:37 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAHQ1cqG0oVWQw9NC_22f7bZMfX11wwuvO2_x8P3GJYsb-ecGvQ@mail.gmail.com \ --to=andrew.smirnov@gmail.com \ --cc=aisheng.dong@nxp.com \ --cc=bhelgaas@google.com \ --cc=cphealy@gmail.com \ --cc=fabio.estevam@nxp.com \ --cc=hongxing.zhu@nxp.com \ --cc=l.stach@pengutronix.de \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=tpiepho@impinj.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.