* nfsd bug fixes for 3.15
@ 2014-04-24 6:25 ` J. Bruce Fields
0 siblings, 0 replies; 7+ messages in thread
From: J. Bruce Fields @ 2014-04-24 6:25 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-nfs, linux-fsdevel, linux-kernel, jlayton
Please pull the following bug fixes for 3.15 from:
git://linux-nfs.org/~bfields/linux.git for-3.15
Three small nfsd bugfixes (including one locks.c fix for a bug triggered
only from nfsd).
Jeff's patches are for long-existing problems that became easier to
trigger since the addition of vfs delegation support.
--b.
----------------------------------------------------------------
J. Bruce Fields (1):
Revert "nfsd4: fix nfs4err_resource in 4.1 case"
Jeff Layton (2):
locks: allow __break_lease to sleep even when break_time is 0
nfsd: set timeparms.to_maxval in setup_callback_client
fs/locks.c | 7 +++----
fs/nfsd/nfs4callback.c | 4 +++-
fs/nfsd/nfs4xdr.c | 8 --------
3 files changed, 6 insertions(+), 13 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread* nfsd bug fixes for 3.15 @ 2014-04-24 6:25 ` J. Bruce Fields 0 siblings, 0 replies; 7+ messages in thread From: J. Bruce Fields @ 2014-04-24 6:25 UTC (permalink / raw) To: Linus Torvalds Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, jlayton-H+wXaHxf7aLQT0dZR+AlfA Please pull the following bug fixes for 3.15 from: git://linux-nfs.org/~bfields/linux.git for-3.15 Three small nfsd bugfixes (including one locks.c fix for a bug triggered only from nfsd). Jeff's patches are for long-existing problems that became easier to trigger since the addition of vfs delegation support. --b. ---------------------------------------------------------------- J. Bruce Fields (1): Revert "nfsd4: fix nfs4err_resource in 4.1 case" Jeff Layton (2): locks: allow __break_lease to sleep even when break_time is 0 nfsd: set timeparms.to_maxval in setup_callback_client fs/locks.c | 7 +++---- fs/nfsd/nfs4callback.c | 4 +++- fs/nfsd/nfs4xdr.c | 8 -------- 3 files changed, 6 insertions(+), 13 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: nfsd bug fixes for 3.15 2014-04-24 6:25 ` J. Bruce Fields (?) @ 2014-04-24 10:51 ` Trond Myklebust 2014-04-24 15:31 ` J. Bruce Fields -1 siblings, 1 reply; 7+ messages in thread From: Trond Myklebust @ 2014-04-24 10:51 UTC (permalink / raw) To: J. Bruce Fields Cc: Linus Torvalds, Linux NFS Mailing List, Devel FS Linux, Linux Kernel mailing list, Layton Jeff Hi Bruce, On Thu, Apr 24, 2014 at 2:25 AM, J. Bruce Fields <bfields@fieldses.org> wrote: > Please pull the following bug fixes for 3.15 from: > > git://linux-nfs.org/~bfields/linux.git for-3.15 > > Three small nfsd bugfixes (including one locks.c fix for a bug triggered > only from nfsd). > > Jeff's patches are for long-existing problems that became easier to > trigger since the addition of vfs delegation support. > > --b. > > ---------------------------------------------------------------- > J. Bruce Fields (1): > Revert "nfsd4: fix nfs4err_resource in 4.1 case" > Wait. Why? NFS4ERR_RESOURCE breaks the Linux client. -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@primarydata.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: nfsd bug fixes for 3.15 2014-04-24 10:51 ` Trond Myklebust @ 2014-04-24 15:31 ` J. Bruce Fields 2014-04-24 16:34 ` J. Bruce Fields 0 siblings, 1 reply; 7+ messages in thread From: J. Bruce Fields @ 2014-04-24 15:31 UTC (permalink / raw) To: Trond Myklebust Cc: Linus Torvalds, Linux NFS Mailing List, Devel FS Linux, Linux Kernel mailing list, Layton Jeff On Thu, Apr 24, 2014 at 06:51:03AM -0400, Trond Myklebust wrote: > Hi Bruce, > > On Thu, Apr 24, 2014 at 2:25 AM, J. Bruce Fields <bfields@fieldses.org> wrote: > > Please pull the following bug fixes for 3.15 from: > > > > git://linux-nfs.org/~bfields/linux.git for-3.15 > > > > Three small nfsd bugfixes (including one locks.c fix for a bug triggered > > only from nfsd). > > > > Jeff's patches are for long-existing problems that became easier to > > trigger since the addition of vfs delegation support. > > > > --b. > > > > ---------------------------------------------------------------- > > J. Bruce Fields (1): > > Revert "nfsd4: fix nfs4err_resource in 4.1 case" > > > > Wait. Why? Have you changed your mind since our previous discussion, or just forgotten it? (Or did I screw up and revert the wrong commit?) See http://mid.gmane.org/<BAD6904F-A82A-4FBC-807F-16560B2A23E0@primarydata.com> > NFS4ERR_RESOURCE breaks the Linux client. This returns us to pre-3.15 behavior so shouldn't introduce any new breakage. Fundamentally the problem is that we're returning an error in cases that shouldn't succeed, and rather than replacing one incorrect error by another it seemed better to wait for a proper fix. --b. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: nfsd bug fixes for 3.15 2014-04-24 15:31 ` J. Bruce Fields @ 2014-04-24 16:34 ` J. Bruce Fields 2014-04-24 16:46 ` Trond Myklebust 0 siblings, 1 reply; 7+ messages in thread From: J. Bruce Fields @ 2014-04-24 16:34 UTC (permalink / raw) To: Trond Myklebust Cc: Linus Torvalds, Linux NFS Mailing List, Devel FS Linux, Linux Kernel mailing list, Layton Jeff On Thu, Apr 24, 2014 at 11:31:16AM -0400, J. Bruce Fields wrote: > On Thu, Apr 24, 2014 at 06:51:03AM -0400, Trond Myklebust wrote: > > Hi Bruce, > > > > On Thu, Apr 24, 2014 at 2:25 AM, J. Bruce Fields <bfields@fieldses.org> wrote: > > > Please pull the following bug fixes for 3.15 from: > > > > > > git://linux-nfs.org/~bfields/linux.git for-3.15 > > > > > > Three small nfsd bugfixes (including one locks.c fix for a bug triggered > > > only from nfsd). > > > > > > Jeff's patches are for long-existing problems that became easier to > > > trigger since the addition of vfs delegation support. > > > > > > --b. > > > > > > ---------------------------------------------------------------- > > > J. Bruce Fields (1): > > > Revert "nfsd4: fix nfs4err_resource in 4.1 case" > > > > > > > Wait. Why? > > Have you changed your mind since our previous discussion, or just > forgotten it? (Or did I screw up and revert the wrong commit?) See > > http://mid.gmane.org/<BAD6904F-A82A-4FBC-807F-16560B2A23E0@primarydata.com> > > > NFS4ERR_RESOURCE breaks the Linux client. > > This returns us to pre-3.15 behavior so shouldn't introduce any new > breakage. > > Fundamentally the problem is that we're returning an error in cases that > shouldn't succeed, and rather than replacing one incorrect error by s/shouldn't/should/, apologies!--b. > another it seemed better to wait for a proper fix. > > --b. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: nfsd bug fixes for 3.15 2014-04-24 16:34 ` J. Bruce Fields @ 2014-04-24 16:46 ` Trond Myklebust 2014-04-25 7:39 ` J. Bruce Fields 0 siblings, 1 reply; 7+ messages in thread From: Trond Myklebust @ 2014-04-24 16:46 UTC (permalink / raw) To: J. Bruce Fields Cc: Linus Torvalds, Linux NFS Mailing List, Devel FS Linux, Linux Kernel mailing list, Layton Jeff On Thu, Apr 24, 2014 at 12:34 PM, J. Bruce Fields <bfields@fieldses.org> wrote: > On Thu, Apr 24, 2014 at 11:31:16AM -0400, J. Bruce Fields wrote: >> On Thu, Apr 24, 2014 at 06:51:03AM -0400, Trond Myklebust wrote: >> > Hi Bruce, >> > >> > On Thu, Apr 24, 2014 at 2:25 AM, J. Bruce Fields <bfields@fieldses.org> wrote: >> > > Please pull the following bug fixes for 3.15 from: >> > > >> > > git://linux-nfs.org/~bfields/linux.git for-3.15 >> > > >> > > Three small nfsd bugfixes (including one locks.c fix for a bug triggered >> > > only from nfsd). >> > > >> > > Jeff's patches are for long-existing problems that became easier to >> > > trigger since the addition of vfs delegation support. >> > > >> > > --b. >> > > >> > > ---------------------------------------------------------------- >> > > J. Bruce Fields (1): >> > > Revert "nfsd4: fix nfs4err_resource in 4.1 case" >> > > >> > >> > Wait. Why? >> >> Have you changed your mind since our previous discussion, or just >> forgotten it? (Or did I screw up and revert the wrong commit?) See >> >> http://mid.gmane.org/<BAD6904F-A82A-4FBC-807F-16560B2A23E0@primarydata.com> >> >> > NFS4ERR_RESOURCE breaks the Linux client. >> >> This returns us to pre-3.15 behavior so shouldn't introduce any new >> breakage. >> >> Fundamentally the problem is that we're returning an error in cases that >> shouldn't succeed, and rather than replacing one incorrect error by > > s/shouldn't/should/, apologies!--b. > >> another it seemed better to wait for a proper fix. >> >> --b. I really shouldn't try to read my email before 8am (or at least not before my third espresso). I was confusing this with the NFS4ERR_STALE_STATEID problem that was merged as part of the same pull. Reverting the NFS4ERR_RESOURCE patch is fine. Apologies, Trond -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@primarydata.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: nfsd bug fixes for 3.15 2014-04-24 16:46 ` Trond Myklebust @ 2014-04-25 7:39 ` J. Bruce Fields 0 siblings, 0 replies; 7+ messages in thread From: J. Bruce Fields @ 2014-04-25 7:39 UTC (permalink / raw) To: Trond Myklebust Cc: Linus Torvalds, Linux NFS Mailing List, Devel FS Linux, Linux Kernel mailing list, Layton Jeff On Thu, Apr 24, 2014 at 12:46:36PM -0400, Trond Myklebust wrote: > On Thu, Apr 24, 2014 at 12:34 PM, J. Bruce Fields <bfields@fieldses.org> wrote: > > On Thu, Apr 24, 2014 at 11:31:16AM -0400, J. Bruce Fields wrote: > >> On Thu, Apr 24, 2014 at 06:51:03AM -0400, Trond Myklebust wrote: > >> > Hi Bruce, > >> > > >> > On Thu, Apr 24, 2014 at 2:25 AM, J. Bruce Fields <bfields@fieldses.org> wrote: > >> > > Please pull the following bug fixes for 3.15 from: > >> > > > >> > > git://linux-nfs.org/~bfields/linux.git for-3.15 > >> > > > >> > > Three small nfsd bugfixes (including one locks.c fix for a bug triggered > >> > > only from nfsd). > >> > > > >> > > Jeff's patches are for long-existing problems that became easier to > >> > > trigger since the addition of vfs delegation support. > >> > > > >> > > --b. > >> > > > >> > > ---------------------------------------------------------------- > >> > > J. Bruce Fields (1): > >> > > Revert "nfsd4: fix nfs4err_resource in 4.1 case" > >> > > > >> > > >> > Wait. Why? > >> > >> Have you changed your mind since our previous discussion, or just > >> forgotten it? (Or did I screw up and revert the wrong commit?) See > >> > >> http://mid.gmane.org/<BAD6904F-A82A-4FBC-807F-16560B2A23E0@primarydata.com> > >> > >> > NFS4ERR_RESOURCE breaks the Linux client. > >> > >> This returns us to pre-3.15 behavior so shouldn't introduce any new > >> breakage. > >> > >> Fundamentally the problem is that we're returning an error in cases that > >> shouldn't succeed, and rather than replacing one incorrect error by > > > > s/shouldn't/should/, apologies!--b. > > > >> another it seemed better to wait for a proper fix. > >> > >> --b. > > I really shouldn't try to read my email before 8am (or at least not > before my third espresso). I was confusing this with the > NFS4ERR_STALE_STATEID problem that was merged as part of the same > pull. > Reverting the NFS4ERR_RESOURCE patch is fine. Great, thanks.--b. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-04-25 7:39 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-04-24 6:25 nfsd bug fixes for 3.15 J. Bruce Fields 2014-04-24 6:25 ` J. Bruce Fields 2014-04-24 10:51 ` Trond Myklebust 2014-04-24 15:31 ` J. Bruce Fields 2014-04-24 16:34 ` J. Bruce Fields 2014-04-24 16:46 ` Trond Myklebust 2014-04-25 7:39 ` J. Bruce Fields
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.