From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Keith Packard <keithpac@amazon.com>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Paul Mackerras <paulus@samba.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Peter Zijlstra <peterz@infradead.org>,
Kees Cook <keescook@chromium.org>,
Andy Lutomirski <luto@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [RFC PATCH 1/8] arm64: add CPU field to struct thread_info
Date: Tue, 14 Sep 2021 08:41:13 -0700 [thread overview]
Message-ID: <CAHk-=whkCzP-wyZ08r9RDJRx9cbANVHy-jy=vJAGTkSbXm50iA@mail.gmail.com> (raw)
In-Reply-To: <20210914121036.3975026-2-ardb@kernel.org>
On Tue, Sep 14, 2021 at 5:10 AM Ard Biesheuvel <ardb@kernel.org> wrote:
>
> The CPU field will be moved back into thread_info even when
> THREAD_INFO_IN_TASK is enabled, so add it back to arm64's definition of
> struct thread_info.
The series looks sane to me, but it strikes me that it's inconsistent
- here for arm64, you make it unconditional, but for the other
architectures you end up putting it inside a #ifdef CONFIG_SMP.
Was there some reason for this odd behavior?
Linus
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Keith Packard <keithpac@amazon.com>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Paul Mackerras <paulus@samba.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Peter Zijlstra <peterz@infradead.org>,
Kees Cook <keescook@chromium.org>,
Andy Lutomirski <luto@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [RFC PATCH 1/8] arm64: add CPU field to struct thread_info
Date: Tue, 14 Sep 2021 08:41:13 -0700 [thread overview]
Message-ID: <CAHk-=whkCzP-wyZ08r9RDJRx9cbANVHy-jy=vJAGTkSbXm50iA@mail.gmail.com> (raw)
In-Reply-To: <20210914121036.3975026-2-ardb@kernel.org>
On Tue, Sep 14, 2021 at 5:10 AM Ard Biesheuvel <ardb@kernel.org> wrote:
>
> The CPU field will be moved back into thread_info even when
> THREAD_INFO_IN_TASK is enabled, so add it back to arm64's definition of
> struct thread_info.
The series looks sane to me, but it strikes me that it's inconsistent
- here for arm64, you make it unconditional, but for the other
architectures you end up putting it inside a #ifdef CONFIG_SMP.
Was there some reason for this odd behavior?
Linus
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Paul Mackerras <paulus@samba.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
Will Deacon <will@kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Ingo Molnar <mingo@redhat.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Kees Cook <keescook@chromium.org>,
Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Keith Packard <keithpac@amazon.com>,
Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Thomas Gleixner <tglx@linutronix.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [RFC PATCH 1/8] arm64: add CPU field to struct thread_info
Date: Tue, 14 Sep 2021 08:41:13 -0700 [thread overview]
Message-ID: <CAHk-=whkCzP-wyZ08r9RDJRx9cbANVHy-jy=vJAGTkSbXm50iA@mail.gmail.com> (raw)
In-Reply-To: <20210914121036.3975026-2-ardb@kernel.org>
On Tue, Sep 14, 2021 at 5:10 AM Ard Biesheuvel <ardb@kernel.org> wrote:
>
> The CPU field will be moved back into thread_info even when
> THREAD_INFO_IN_TASK is enabled, so add it back to arm64's definition of
> struct thread_info.
The series looks sane to me, but it strikes me that it's inconsistent
- here for arm64, you make it unconditional, but for the other
architectures you end up putting it inside a #ifdef CONFIG_SMP.
Was there some reason for this odd behavior?
Linus
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Keith Packard <keithpac@amazon.com>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Paul Mackerras <paulus@samba.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Peter Zijlstra <peterz@infradead.org>,
Kees Cook <keescook@chromium.org>,
Andy Lutomirski <luto@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [RFC PATCH 1/8] arm64: add CPU field to struct thread_info
Date: Tue, 14 Sep 2021 08:41:13 -0700 [thread overview]
Message-ID: <CAHk-=whkCzP-wyZ08r9RDJRx9cbANVHy-jy=vJAGTkSbXm50iA@mail.gmail.com> (raw)
In-Reply-To: <20210914121036.3975026-2-ardb@kernel.org>
On Tue, Sep 14, 2021 at 5:10 AM Ard Biesheuvel <ardb@kernel.org> wrote:
>
> The CPU field will be moved back into thread_info even when
> THREAD_INFO_IN_TASK is enabled, so add it back to arm64's definition of
> struct thread_info.
The series looks sane to me, but it strikes me that it's inconsistent
- here for arm64, you make it unconditional, but for the other
architectures you end up putting it inside a #ifdef CONFIG_SMP.
Was there some reason for this odd behavior?
Linus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-14 15:41 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 12:10 [RFC PATCH 0/8] Move task_struct::cpu back into thread_info Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` [RFC PATCH 1/8] arm64: add CPU field to struct thread_info Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 15:41 ` Linus Torvalds [this message]
2021-09-14 15:41 ` Linus Torvalds
2021-09-14 15:41 ` Linus Torvalds
2021-09-14 15:41 ` Linus Torvalds
2021-09-14 15:42 ` Ard Biesheuvel
2021-09-14 15:42 ` Ard Biesheuvel
2021-09-14 15:42 ` Ard Biesheuvel
2021-09-14 15:42 ` Ard Biesheuvel
2021-09-16 14:41 ` Catalin Marinas
2021-09-16 14:41 ` Catalin Marinas
2021-09-16 14:41 ` Catalin Marinas
2021-09-16 14:41 ` Catalin Marinas
2021-09-21 12:04 ` Ard Biesheuvel
2021-09-21 12:04 ` Ard Biesheuvel
2021-09-21 12:04 ` Ard Biesheuvel
2021-09-21 12:04 ` Ard Biesheuvel
2021-09-14 12:10 ` [RFC PATCH 2/8] x86: " Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-21 12:54 ` Borislav Petkov
2021-09-21 12:54 ` Borislav Petkov
2021-09-21 12:54 ` Borislav Petkov
2021-09-21 12:54 ` Borislav Petkov
2021-09-14 12:10 ` [RFC PATCH 3/8] s390: " Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-28 13:52 ` Ard Biesheuvel
2021-09-28 13:52 ` Ard Biesheuvel
2021-09-28 13:52 ` Ard Biesheuvel
2021-09-28 13:52 ` Ard Biesheuvel
2021-09-14 12:10 ` [RFC PATCH 4/8] powerpc: " Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-27 15:12 ` Ard Biesheuvel
2021-09-27 15:12 ` Ard Biesheuvel
2021-09-27 15:12 ` Ard Biesheuvel
2021-09-27 15:12 ` Ard Biesheuvel
2021-09-27 23:13 ` Michael Ellerman
2021-09-27 23:13 ` Michael Ellerman
2021-09-27 23:13 ` Michael Ellerman
2021-09-27 23:13 ` Michael Ellerman
2021-09-28 0:16 ` Michael Ellerman
2021-09-28 0:16 ` Michael Ellerman
2021-09-28 0:16 ` Michael Ellerman
2021-09-28 0:16 ` Michael Ellerman
2021-09-28 13:18 ` Ard Biesheuvel
2021-09-28 13:18 ` Ard Biesheuvel
2021-09-28 13:18 ` Ard Biesheuvel
2021-09-28 13:18 ` Ard Biesheuvel
2021-09-29 22:46 ` Michael Ellerman
2021-09-29 22:46 ` Michael Ellerman
2021-09-29 22:46 ` Michael Ellerman
2021-09-29 22:46 ` Michael Ellerman
2021-09-29 23:10 ` Kees Cook
2021-09-29 23:10 ` Kees Cook
2021-09-29 23:10 ` Kees Cook
2021-09-29 23:10 ` Kees Cook
2021-09-30 17:47 ` Kees Cook
2021-09-30 17:47 ` Kees Cook
2021-09-30 17:47 ` Kees Cook
2021-09-30 17:47 ` Kees Cook
2021-10-05 1:55 ` Michael Ellerman
2021-10-05 1:55 ` Michael Ellerman
2021-10-05 1:55 ` Michael Ellerman
2021-10-05 1:55 ` Michael Ellerman
2021-09-14 12:10 ` [RFC PATCH 5/8] sched: move CPU field back into thread_info if THREAD_INFO_IN_TASK=y Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 15:46 ` Linus Torvalds
2021-09-14 15:46 ` Linus Torvalds
2021-09-14 15:46 ` Linus Torvalds
2021-09-14 15:46 ` Linus Torvalds
2021-09-14 15:52 ` Ard Biesheuvel
2021-09-14 15:52 ` Ard Biesheuvel
2021-09-14 15:52 ` Ard Biesheuvel
2021-09-14 15:52 ` Ard Biesheuvel
2021-09-14 15:58 ` Linus Torvalds
2021-09-14 15:58 ` Linus Torvalds
2021-09-14 15:58 ` Linus Torvalds
2021-09-14 15:58 ` Linus Torvalds
2021-09-14 16:10 ` Ard Biesheuvel
2021-09-14 16:10 ` Ard Biesheuvel
2021-09-14 16:10 ` Ard Biesheuvel
2021-09-14 16:10 ` Ard Biesheuvel
2021-09-21 13:12 ` Catalin Marinas
2021-09-21 13:12 ` Catalin Marinas
2021-09-21 13:12 ` Catalin Marinas
2021-09-21 13:12 ` Catalin Marinas
2021-09-14 12:10 ` [RFC PATCH 6/8] powerpc: smp: remove hack to obtain offset of task_struct::cpu Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` [RFC PATCH 7/8] riscv: rely on core code to keep thread_info::cpu updated Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-28 22:07 ` Palmer Dabbelt
2021-09-28 22:07 ` Palmer Dabbelt
2021-09-28 22:07 ` Palmer Dabbelt
2021-09-28 22:07 ` Palmer Dabbelt
2021-09-14 12:10 ` [RFC PATCH 8/8] ARM: " Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 12:10 ` Ard Biesheuvel
2021-09-14 13:49 ` [RFC PATCH 0/8] Move task_struct::cpu back into thread_info Christophe Leroy
2021-09-14 13:49 ` Christophe Leroy
2021-09-14 13:49 ` Christophe Leroy
2021-09-14 13:49 ` Christophe Leroy
2021-09-14 13:55 ` Mark Rutland
2021-09-14 13:55 ` Mark Rutland
2021-09-14 13:55 ` Mark Rutland
2021-09-14 13:55 ` Mark Rutland
2021-09-21 12:06 ` Ard Biesheuvel
2021-09-21 12:06 ` Ard Biesheuvel
2021-09-21 12:06 ` Ard Biesheuvel
2021-09-21 12:06 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whkCzP-wyZ08r9RDJRx9cbANVHy-jy=vJAGTkSbXm50iA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=keescook@chromium.org \
--cc=keithpac@amazon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.