From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Chris Blake <chrisrblake93@gmail.com>
Cc: ptyser@xes-inc.com, Lee Jones <lee.jones@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christian Lamparter <chunkeey@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v2] mfd: lpc_ich: Enable GPIO driver for DH89xxCC
Date: Mon, 7 Jun 2021 14:57:45 +0300 [thread overview]
Message-ID: <CAHp75VchKgVwxKq5OP=LrLaDhg-_rpwYnYz2Op9PQm4+N9Tn7g@mail.gmail.com> (raw)
In-Reply-To: <20210606225037.26130-1-chrisrblake93@gmail.com>
On Mon, Jun 7, 2021 at 1:52 AM Chris Blake <chrisrblake93@gmail.com> wrote:
>
> Based on the Intel Datasheet for the DH89xxCC PCH, the GPIO driver
> is the same as ICH_v5_GPIO, minus the fact the DH89xxCC also has
> blink support. However, blink support isn't supported by the GPIO
> driver so we should use ICH_v5_GPIO. Tested and working on a Meraki
> MX100-HW.
Thanks for your contribution!
> V2: Updated commit message, and added Christian Lamparter as a
> contributor.
First of all, changelog is placed after the cutter '---' line below.
> Signed-off-by: Chris Blake <chrisrblake93@gmail.com>
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
Second, please utilize the Co-developed-by tag.
> ---
(changelog)
> drivers/mfd/lpc_ich.c | 1 +
> 1 file changed, 1 insertion(+)
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-06-07 11:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-06 22:50 [PATCH v2] mfd: lpc_ich: Enable GPIO driver for DH89xxCC Chris Blake
2021-06-07 11:57 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VchKgVwxKq5OP=LrLaDhg-_rpwYnYz2Op9PQm4+N9Tn7g@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=chrisrblake93@gmail.com \
--cc=chunkeey@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ptyser@xes-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.