* [PATCH v2] mfd: lpc_ich: Enable GPIO driver for DH89xxCC
@ 2021-06-06 22:50 Chris Blake
2021-06-07 11:57 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Chris Blake @ 2021-06-06 22:50 UTC (permalink / raw)
To: ptyser, lee.jones, linux-kernel, chunkeey, linux-gpio; +Cc: Chris Blake
Based on the Intel Datasheet for the DH89xxCC PCH, the GPIO driver
is the same as ICH_v5_GPIO, minus the fact the DH89xxCC also has
blink support. However, blink support isn't supported by the GPIO
driver so we should use ICH_v5_GPIO. Tested and working on a Meraki
MX100-HW.
V2: Updated commit message, and added Christian Lamparter as a
contributor.
Signed-off-by: Chris Blake <chrisrblake93@gmail.com>
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
---
drivers/mfd/lpc_ich.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index 3bbb29a7e7a5..f10e53187f67 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
@@ -489,6 +489,7 @@ static struct lpc_ich_info lpc_chipset_info[] = {
[LPC_DH89XXCC] = {
.name = "DH89xxCC",
.iTCO_version = 2,
+ .gpio_version = ICH_V5_GPIO,
},
[LPC_PPT] = {
.name = "Panther Point",
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mfd: lpc_ich: Enable GPIO driver for DH89xxCC
2021-06-06 22:50 [PATCH v2] mfd: lpc_ich: Enable GPIO driver for DH89xxCC Chris Blake
@ 2021-06-07 11:57 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2021-06-07 11:57 UTC (permalink / raw)
To: Chris Blake
Cc: ptyser, Lee Jones, Linux Kernel Mailing List,
Christian Lamparter, open list:GPIO SUBSYSTEM
On Mon, Jun 7, 2021 at 1:52 AM Chris Blake <chrisrblake93@gmail.com> wrote:
>
> Based on the Intel Datasheet for the DH89xxCC PCH, the GPIO driver
> is the same as ICH_v5_GPIO, minus the fact the DH89xxCC also has
> blink support. However, blink support isn't supported by the GPIO
> driver so we should use ICH_v5_GPIO. Tested and working on a Meraki
> MX100-HW.
Thanks for your contribution!
> V2: Updated commit message, and added Christian Lamparter as a
> contributor.
First of all, changelog is placed after the cutter '---' line below.
> Signed-off-by: Chris Blake <chrisrblake93@gmail.com>
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
Second, please utilize the Co-developed-by tag.
> ---
(changelog)
> drivers/mfd/lpc_ich.c | 1 +
> 1 file changed, 1 insertion(+)
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-07 11:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-06 22:50 [PATCH v2] mfd: lpc_ich: Enable GPIO driver for DH89xxCC Chris Blake
2021-06-07 11:57 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.