[PATCH v2] mfd: lpc_ich: Enable GPIO driver for DH89xxCC

[PATCH v2] mfd: lpc_ich: Enable GPIO driver for DH89xxCC

[Chris Blake]

Based on the Intel Datasheet for the DH89xxCC PCH, the GPIO driver
is the same as ICH_v5_GPIO, minus the fact the DH89xxCC also has
blink support. However, blink support isn't supported by the GPIO
driver so we should use ICH_v5_GPIO. Tested and working on a Meraki
MX100-HW.

V2: Updated commit message, and added Christian Lamparter as a
contributor.

Signed-off-by: Chris Blake <chrisrblake93@gmail.com>
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
---
 drivers/mfd/lpc_ich.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index 3bbb29a7e7a5..f10e53187f67 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
@@ -489,6 +489,7 @@ static struct lpc_ich_info lpc_chipset_info[] = {
 	[LPC_DH89XXCC] = {
 		.name = "DH89xxCC",
 		.iTCO_version = 2,
+		.gpio_version = ICH_V5_GPIO,
 	},
 	[LPC_PPT] = {
 		.name = "Panther Point",
-- 
2.25.1

Re: [PATCH v2] mfd: lpc_ich: Enable GPIO driver for DH89xxCC

[Andy Shevchenko]

On Mon, Jun 7, 2021 at 1:52 AM Chris Blake <chrisrblake93@gmail.com> wrote:
>
> Based on the Intel Datasheet for the DH89xxCC PCH, the GPIO driver
> is the same as ICH_v5_GPIO, minus the fact the DH89xxCC also has
> blink support. However, blink support isn't supported by the GPIO
> driver so we should use ICH_v5_GPIO. Tested and working on a Meraki
> MX100-HW.

Thanks for your contribution!

> V2: Updated commit message, and added Christian Lamparter as a
> contributor.

First of all, changelog is placed after the cutter '---' line below.

> Signed-off-by: Chris Blake <chrisrblake93@gmail.com>
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>

Second, please utilize the Co-developed-by tag.

> ---

(changelog)

>  drivers/mfd/lpc_ich.c | 1 +
>  1 file changed, 1 insertion(+)

-- 
With Best Regards,
Andy Shevchenko