From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: ChiaEn Wu <peterwu.pub@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>,
Helge Deller <deller@gmx.de>, ChiaEn Wu <chiaen_wu@richtek.com>,
Alice Chen <alice_chen@richtek.com>,
cy_huang <cy_huang@richtek.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
USB <linux-usb@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
szuni chen <szunichen@gmail.com>
Subject: Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support
Date: Fri, 15 Jul 2022 15:05:40 +0200 [thread overview]
Message-ID: <CAHp75VdzG4hjcMDv5Qro25gJx+adO-rNTiCx9ez30uVoUX-odg@mail.gmail.com> (raw)
In-Reply-To: <d7157483-a6c6-1883-6fc1-d518c7095288@collabora.com>
On Fri, Jul 15, 2022 at 2:40 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
> Il 15/07/22 13:26, ChiaEn Wu ha scritto:
...
> > +#define STATE_OFF 0
> > +#define STATE_KEEP 1
> > +#define STATE_ON 2
>
> I propose, instead:
>
> enum mt6370_state {
> STATE_OFF = 0,
> STATE_KEEP,
> STATE_ON,
> STATE_MAX,
Usually we don't put commas at the terminator entries.
> };
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: ChiaEn Wu <peterwu.pub@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>,
Helge Deller <deller@gmx.de>, ChiaEn Wu <chiaen_wu@richtek.com>,
Alice Chen <alice_chen@richtek.com>,
cy_huang <cy_huang@richtek.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
USB <linux-usb@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
szuni chen <szunichen@gmail.com>
Subject: Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support
Date: Fri, 15 Jul 2022 15:05:40 +0200 [thread overview]
Message-ID: <CAHp75VdzG4hjcMDv5Qro25gJx+adO-rNTiCx9ez30uVoUX-odg@mail.gmail.com> (raw)
In-Reply-To: <d7157483-a6c6-1883-6fc1-d518c7095288@collabora.com>
On Fri, Jul 15, 2022 at 2:40 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
> Il 15/07/22 13:26, ChiaEn Wu ha scritto:
...
> > +#define STATE_OFF 0
> > +#define STATE_KEEP 1
> > +#define STATE_ON 2
>
> I propose, instead:
>
> enum mt6370_state {
> STATE_OFF = 0,
> STATE_KEEP,
> STATE_ON,
> STATE_MAX,
Usually we don't put commas at the terminator entries.
> };
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: "open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>,
Pavel Machek <pavel@ucw.cz>, Alice Chen <alice_chen@richtek.com>,
linux-iio <linux-iio@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Liam Girdwood <lgirdwood@gmail.com>,
cy_huang <cy_huang@richtek.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Helge Deller <deller@gmx.de>, Rob Herring <robh+dt@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Guenter Roeck <linux@roeck-us.net>,
devicetree <devicetree@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
szuni chen <szunichen@gmail.com>, Mark Brown <broonie@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
ChiaEn Wu <peterwu.pub@gmail.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Jingoo Han <jingoohan1@gmail.com>,
USB <linux-usb@vger.kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ChiaEn Wu <chiaen_wu@richtek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support
Date: Fri, 15 Jul 2022 15:05:40 +0200 [thread overview]
Message-ID: <CAHp75VdzG4hjcMDv5Qro25gJx+adO-rNTiCx9ez30uVoUX-odg@mail.gmail.com> (raw)
In-Reply-To: <d7157483-a6c6-1883-6fc1-d518c7095288@collabora.com>
On Fri, Jul 15, 2022 at 2:40 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
> Il 15/07/22 13:26, ChiaEn Wu ha scritto:
...
> > +#define STATE_OFF 0
> > +#define STATE_KEEP 1
> > +#define STATE_ON 2
>
> I propose, instead:
>
> enum mt6370_state {
> STATE_OFF = 0,
> STATE_KEEP,
> STATE_ON,
> STATE_MAX,
Usually we don't put commas at the terminator entries.
> };
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-07-15 13:06 UTC|newest]
Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 11:25 [PATCH v5 00/13] Add MediaTek MT6370 PMIC support ChiaEn Wu
2022-07-15 11:25 ` ChiaEn Wu
2022-07-15 11:25 ` ChiaEn Wu
2022-07-15 11:25 ` [PATCH v5 01/13] dt-bindings: usb: Add MediaTek MT6370 TCPC ChiaEn Wu
2022-07-15 11:25 ` ChiaEn Wu
2022-07-15 11:25 ` ChiaEn Wu
2022-07-15 11:25 ` [PATCH v5 02/13] dt-bindings: power: supply: Add MediaTek MT6370 Charger ChiaEn Wu
2022-07-15 11:25 ` ChiaEn Wu
2022-07-15 11:25 ` ChiaEn Wu
2022-07-15 11:25 ` [PATCH v5 03/13] dt-bindings: leds: mt6370: Add MediaTek MT6370 current sink type LED indicator ChiaEn Wu
2022-07-15 11:25 ` ChiaEn Wu
2022-07-15 11:25 ` ChiaEn Wu
2022-07-15 11:25 ` [PATCH v5 04/13] dt-bindings: leds: Add MediaTek MT6370 flashlight ChiaEn Wu
2022-07-15 11:25 ` ChiaEn Wu
2022-07-15 11:25 ` ChiaEn Wu
2022-07-15 11:25 ` [PATCH v5 05/13] dt-bindings: backlight: Add MediaTek MT6370 backlight ChiaEn Wu
2022-07-15 11:25 ` ChiaEn Wu
2022-07-15 11:25 ` ChiaEn Wu
2022-07-15 11:26 ` [PATCH v5 06/13] dt-bindings: mfd: Add MediaTek MT6370 ChiaEn Wu
2022-07-15 11:26 ` ChiaEn Wu
2022-07-15 11:26 ` ChiaEn Wu
2022-07-15 13:42 ` Rob Herring
2022-07-15 13:42 ` Rob Herring
2022-07-15 13:42 ` Rob Herring
2022-07-15 11:26 ` [PATCH v5 07/13] mfd: mt6370: Add MediaTek MT6370 support ChiaEn Wu
2022-07-15 11:26 ` ChiaEn Wu
2022-07-15 11:26 ` ChiaEn Wu
2022-07-15 13:02 ` Andy Shevchenko
2022-07-15 13:02 ` Andy Shevchenko
2022-07-15 13:02 ` Andy Shevchenko
2022-07-15 11:26 ` [PATCH v5 08/13] usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver ChiaEn Wu
2022-07-15 11:26 ` ChiaEn Wu
2022-07-15 11:26 ` ChiaEn Wu
2022-07-15 12:38 ` AngeloGioacchino Del Regno
2022-07-15 12:38 ` AngeloGioacchino Del Regno
2022-07-15 12:38 ` AngeloGioacchino Del Regno
2022-07-15 13:10 ` Andy Shevchenko
2022-07-15 13:10 ` Andy Shevchenko
2022-07-15 13:10 ` Andy Shevchenko
2022-07-18 8:08 ` ChiYuan Huang
2022-07-18 8:08 ` ChiYuan Huang
2022-07-18 8:08 ` ChiYuan Huang
2022-07-18 11:38 ` Andy Shevchenko
2022-07-18 11:38 ` Andy Shevchenko
2022-07-18 11:38 ` Andy Shevchenko
2022-07-18 13:56 ` ChiYuan Huang
2022-07-18 13:56 ` ChiYuan Huang
2022-07-18 13:56 ` ChiYuan Huang
2022-07-15 11:26 ` [PATCH v5 09/13] iio: adc: mt6370: Add MediaTek MT6370 support ChiaEn Wu
2022-07-15 11:26 ` ChiaEn Wu
2022-07-15 11:26 ` ChiaEn Wu
2022-07-15 12:38 ` AngeloGioacchino Del Regno
2022-07-15 12:38 ` AngeloGioacchino Del Regno
2022-07-15 12:38 ` AngeloGioacchino Del Regno
2022-07-15 13:18 ` Andy Shevchenko
2022-07-15 13:18 ` Andy Shevchenko
2022-07-15 13:18 ` Andy Shevchenko
2022-07-15 11:26 ` [PATCH v5 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver ChiaEn Wu
2022-07-15 11:26 ` ChiaEn Wu
2022-07-15 11:26 ` ChiaEn Wu
2022-07-15 16:51 ` Andy Shevchenko
2022-07-15 16:51 ` Andy Shevchenko
2022-07-15 16:51 ` Andy Shevchenko
2022-07-16 21:37 ` Sebastian Reichel
2022-07-16 21:37 ` Sebastian Reichel
2022-07-16 21:37 ` Sebastian Reichel
2022-07-15 11:26 ` [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support ChiaEn Wu
2022-07-15 11:26 ` ChiaEn Wu
2022-07-15 11:26 ` ChiaEn Wu
2022-07-15 12:38 ` AngeloGioacchino Del Regno
2022-07-15 12:38 ` AngeloGioacchino Del Regno
2022-07-15 12:38 ` AngeloGioacchino Del Regno
2022-07-15 13:05 ` Andy Shevchenko [this message]
2022-07-15 13:05 ` Andy Shevchenko
2022-07-15 13:05 ` Andy Shevchenko
2022-07-15 18:29 ` Andy Shevchenko
2022-07-15 18:29 ` Andy Shevchenko
2022-07-15 18:29 ` Andy Shevchenko
2022-07-20 9:45 ` ChiYuan Huang
2022-07-20 9:45 ` ChiYuan Huang
2022-07-20 9:45 ` ChiYuan Huang
2022-07-20 9:48 ` ChiYuan Huang
2022-07-20 9:48 ` ChiYuan Huang
2022-07-20 9:48 ` ChiYuan Huang
2022-07-21 9:31 ` ChiYuan Huang
2022-07-21 9:31 ` ChiYuan Huang
2022-07-21 9:31 ` ChiYuan Huang
2022-07-17 8:46 ` Pavel Machek
2022-07-17 8:46 ` Pavel Machek
2022-07-17 8:46 ` Pavel Machek
2022-07-21 10:09 ` ChiYuan Huang
2022-07-21 10:09 ` ChiYuan Huang
2022-07-21 10:09 ` ChiYuan Huang
2022-07-15 11:26 ` [PATCH v5 12/13] leds: flashlight: mt6370: Add MediaTek MT6370 flashlight support ChiaEn Wu
2022-07-15 11:26 ` ChiaEn Wu
2022-07-15 11:26 ` ChiaEn Wu
2022-07-15 18:13 ` Andy Shevchenko
2022-07-15 18:13 ` Andy Shevchenko
2022-07-15 18:13 ` Andy Shevchenko
2022-07-15 11:26 ` [PATCH v5 13/13] video: backlight: mt6370: Add MediaTek MT6370 support ChiaEn Wu
2022-07-15 11:26 ` ChiaEn Wu
2022-07-15 11:26 ` ChiaEn Wu
2022-07-15 12:38 ` AngeloGioacchino Del Regno
2022-07-15 12:38 ` AngeloGioacchino Del Regno
2022-07-15 12:38 ` AngeloGioacchino Del Regno
2022-07-15 16:29 ` Daniel Thompson
2022-07-15 16:29 ` Daniel Thompson
2022-07-15 16:29 ` Daniel Thompson
2022-07-18 8:27 ` AngeloGioacchino Del Regno
2022-07-18 8:27 ` AngeloGioacchino Del Regno
2022-07-18 8:27 ` AngeloGioacchino Del Regno
2022-07-18 11:17 ` ChiaEn Wu
2022-07-18 11:17 ` ChiaEn Wu
2022-07-18 11:17 ` ChiaEn Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdzG4hjcMDv5Qro25gJx+adO-rNTiCx9ez30uVoUX-odg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alice_chen@richtek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=chiaen_wu@richtek.com \
--cc=chunfeng.yun@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=peterwu.pub@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=szunichen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.