From: Andy Shevchenko <andy.shevchenko@gmail.com> To: William Breathitt Gray <vilhelm.gray@gmail.com> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Phil Reid <preid@electromag.com.au>, Linus Walleij <linus.walleij@linaro.org>, Andrew Morton <akpm@linux-foundation.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, Linux-Arch <linux-arch@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, Masahiro Yamada <yamada.masahiro@socionext.com>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v10 00/10] Introduce the for_each_set_clump8 macro Date: Sun, 24 Mar 2019 14:08:29 +0200 [thread overview] Message-ID: <CAHp75Ve2zR9uZE6c42gY6xcruEEfaS5gv7gD1gr_GR-DgZ2vrA@mail.gmail.com> (raw) In-Reply-To: <20190324040704.GA8285@icarus> On Sun, Mar 24, 2019 at 6:12 AM William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > > On Fri, Mar 22, 2019 at 09:12:02PM +0200, Andy Shevchenko wrote: > > On Thu, Mar 14, 2019 at 09:29:32PM +0900, William Breathitt Gray wrote: > > > Changes in v10: > > > - Fix off-by-one error in bitmap initialization in the > > > test_for_each_set_clump8 function > > > - Fix typos in clump_exp array definition in test_bitmap.c ("0x28" > > > should have been "0x38") > > > - Utilize for_each_set_clump8 macro in intel_soc_dts_iosf.c > > > > One more, can you look at gen_74x164_set_multiple() ? It seems a candidate as > > well, if I'm not mistaken. > > We can utilize the for_each_set_clump8 macro in the > gen_74x164_set_multiple function, but I skipped over it earlier since I > noticed it used the BITS_PER_BYTE define rather than a hardcoded 8. If > it always loops 8 bits at a time, then we can use the > for_each_set_clump8 macro; Yes, see below. > otherwise we would need the more generic > for_each_set_clump macro to handle the non-8-bit looping cases. > Will BITS_PER_BYTE always be defined as 8 bits? It's not correct question, the right one "is the hardware always in 8-bit chunks". And datasheet is crystal clear about this. This very old and famous IC has 8-bit from the 70-s (IIRC the epoch of the design). So, it is always in 8-bit chunks. -- With Best Regards, Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com> To: William Breathitt Gray <vilhelm.gray@gmail.com> Cc: Linux-Arch <linux-arch@vger.kernel.org>, Phil Reid <preid@electromag.com.au>, Geert Uytterhoeven <geert+renesas@glider.be>, Masahiro Yamada <yamada.masahiro@socionext.com>, Linus Walleij <linus.walleij@linaro.org>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Andrew Morton <akpm@linux-foundation.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v10 00/10] Introduce the for_each_set_clump8 macro Date: Sun, 24 Mar 2019 14:08:29 +0200 [thread overview] Message-ID: <CAHp75Ve2zR9uZE6c42gY6xcruEEfaS5gv7gD1gr_GR-DgZ2vrA@mail.gmail.com> (raw) In-Reply-To: <20190324040704.GA8285@icarus> On Sun, Mar 24, 2019 at 6:12 AM William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > > On Fri, Mar 22, 2019 at 09:12:02PM +0200, Andy Shevchenko wrote: > > On Thu, Mar 14, 2019 at 09:29:32PM +0900, William Breathitt Gray wrote: > > > Changes in v10: > > > - Fix off-by-one error in bitmap initialization in the > > > test_for_each_set_clump8 function > > > - Fix typos in clump_exp array definition in test_bitmap.c ("0x28" > > > should have been "0x38") > > > - Utilize for_each_set_clump8 macro in intel_soc_dts_iosf.c > > > > One more, can you look at gen_74x164_set_multiple() ? It seems a candidate as > > well, if I'm not mistaken. > > We can utilize the for_each_set_clump8 macro in the > gen_74x164_set_multiple function, but I skipped over it earlier since I > noticed it used the BITS_PER_BYTE define rather than a hardcoded 8. If > it always loops 8 bits at a time, then we can use the > for_each_set_clump8 macro; Yes, see below. > otherwise we would need the more generic > for_each_set_clump macro to handle the non-8-bit looping cases. > Will BITS_PER_BYTE always be defined as 8 bits? It's not correct question, the right one "is the hardware always in 8-bit chunks". And datasheet is crystal clear about this. This very old and famous IC has 8-bit from the 70-s (IIRC the epoch of the design). So, it is always in 8-bit chunks. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-24 12:08 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-14 12:29 [PATCH v10 00/10] Introduce the for_each_set_clump8 macro William Breathitt Gray 2019-03-14 12:29 ` William Breathitt Gray 2019-03-14 12:30 ` [PATCH v10 01/10] bitops: " William Breathitt Gray 2019-03-14 12:30 ` William Breathitt Gray 2019-03-22 18:22 ` Andy Shevchenko 2019-03-22 18:22 ` Andy Shevchenko 2019-03-14 12:30 ` [PATCH v10 02/10] lib/test_bitmap.c: Add for_each_set_clump8 test cases William Breathitt Gray 2019-03-14 12:30 ` William Breathitt Gray 2019-03-14 12:30 ` [PATCH v10 03/10] gpio: 104-dio-48e: Utilize for_each_set_clump8 macro William Breathitt Gray 2019-03-14 12:30 ` William Breathitt Gray 2019-03-14 12:30 ` [PATCH v10 04/10] gpio: 104-idi-48: " William Breathitt Gray 2019-03-14 12:30 ` William Breathitt Gray 2019-03-14 12:31 ` [PATCH v10 05/10] gpio: gpio-mm: " William Breathitt Gray 2019-03-14 12:31 ` William Breathitt Gray 2019-03-14 12:31 ` [PATCH v10 06/10] gpio: ws16c48: " William Breathitt Gray 2019-03-14 12:31 ` William Breathitt Gray 2019-03-14 12:31 ` [PATCH v10 07/10] gpio: pci-idio-16: " William Breathitt Gray 2019-03-14 12:31 ` William Breathitt Gray 2019-03-14 12:32 ` [PATCH v10 08/10] gpio: pcie-idio-24: " William Breathitt Gray 2019-03-14 12:32 ` William Breathitt Gray 2019-03-14 12:32 ` [PATCH v10 09/10] gpio: uniphier: " William Breathitt Gray 2019-03-14 12:32 ` William Breathitt Gray 2019-03-14 12:53 ` William Breathitt Gray 2019-03-14 12:53 ` William Breathitt Gray 2019-03-14 12:32 ` [PATCH v10 10/10] thermal: intel: intel_soc_dts_iosf: " William Breathitt Gray 2019-03-14 12:32 ` William Breathitt Gray 2019-03-14 14:26 ` Andy Shevchenko 2019-03-14 14:26 ` Andy Shevchenko 2019-03-14 14:39 ` William Breathitt Gray 2019-03-14 14:39 ` William Breathitt Gray 2019-03-22 19:02 ` Andy Shevchenko 2019-03-22 19:02 ` Andy Shevchenko 2019-03-24 3:38 ` William Breathitt Gray 2019-03-24 3:38 ` William Breathitt Gray 2019-03-24 13:52 ` Andy Shevchenko 2019-03-24 13:52 ` Andy Shevchenko 2019-03-24 13:52 ` Andy Shevchenko 2019-03-22 19:12 ` [PATCH v10 00/10] Introduce the " Andy Shevchenko 2019-03-22 19:12 ` Andy Shevchenko 2019-03-24 4:08 ` William Breathitt Gray 2019-03-24 4:08 ` William Breathitt Gray 2019-03-24 4:08 ` William Breathitt Gray 2019-03-24 8:53 ` Geert Uytterhoeven 2019-03-24 8:53 ` Geert Uytterhoeven 2019-03-24 12:08 ` Andy Shevchenko [this message] 2019-03-24 12:08 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAHp75Ve2zR9uZE6c42gY6xcruEEfaS5gv7gD1gr_GR-DgZ2vrA@mail.gmail.com \ --to=andy.shevchenko@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=bgolaszewski@baylibre.com \ --cc=geert+renesas@glider.be \ --cc=linus.walleij@linaro.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@rasmusvillemoes.dk \ --cc=preid@electromag.com.au \ --cc=vilhelm.gray@gmail.com \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.