From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Stable <stable@vger.kernel.org>, Len Brown <lenb@kernel.org>,
Borislav Petkov <bp@alien8.de>, James Morse <james.morse@arm.com>,
Erik Kaneda <erik.kaneda@intel.com>,
Myron Stowe <myron.stowe@redhat.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
linux-nvdimm@lists.01.org
Subject: Re: [RFT][PATCH] ACPI: OSL: Use rwlock instead of RCU for memory management
Date: Fri, 5 Jun 2020 22:40:36 +0300 [thread overview]
Message-ID: <CAHp75Ve8A373Cbw6RiKTtkhj9jsxZ9dBY8ELtntk0B=yXxOCUg@mail.gmail.com> (raw)
In-Reply-To: <2643462.teTRrieJB7@kreacher>
On Fri, Jun 5, 2020 at 5:11 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
...
> + if (!refcount) {
> + write_lock_irq(&acpi_ioremaps_list_lock);
> +
> + list_del(&map->list);
> +
> + write_unlock_irq(&acpi_ioremaps_list_lock);
> + }
> return refcount;
It seems we can decrease indentation level at the same time:
if (refcount)
return refcount;
...
return 0;
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Dan Williams <dan.j.williams@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Stable <stable@vger.kernel.org>, Len Brown <lenb@kernel.org>,
Borislav Petkov <bp@alien8.de>, Ira Weiny <ira.weiny@intel.com>,
James Morse <james.morse@arm.com>,
Erik Kaneda <erik.kaneda@intel.com>,
Myron Stowe <myron.stowe@redhat.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
linux-nvdimm@lists.01.org
Subject: Re: [RFT][PATCH] ACPI: OSL: Use rwlock instead of RCU for memory management
Date: Fri, 5 Jun 2020 22:40:36 +0300 [thread overview]
Message-ID: <CAHp75Ve8A373Cbw6RiKTtkhj9jsxZ9dBY8ELtntk0B=yXxOCUg@mail.gmail.com> (raw)
In-Reply-To: <2643462.teTRrieJB7@kreacher>
On Fri, Jun 5, 2020 at 5:11 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
...
> + if (!refcount) {
> + write_lock_irq(&acpi_ioremaps_list_lock);
> +
> + list_del(&map->list);
> +
> + write_unlock_irq(&acpi_ioremaps_list_lock);
> + }
> return refcount;
It seems we can decrease indentation level at the same time:
if (refcount)
return refcount;
...
return 0;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-06-05 19:40 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 23:39 [PATCH v2] ACPI: Drop rcu usage for MMIO mappings Dan Williams
2020-05-07 23:39 ` Dan Williams
2020-05-09 12:30 ` Sasha Levin
2020-05-13 8:52 ` [ACPI] 5a91d41f89: BUG:sleeping_function_called_from_invalid_context_at_kernel/locking/mutex.c kernel test robot
2020-05-13 8:52 ` kernel test robot
2020-05-13 8:52 ` kernel test robot
2020-06-05 13:32 ` [PATCH v2] ACPI: Drop rcu usage for MMIO mappings Rafael J. Wysocki
2020-06-05 13:32 ` Rafael J. Wysocki
2020-06-05 16:18 ` Dan Williams
2020-06-05 16:18 ` Dan Williams
2020-06-05 16:21 ` Rafael J. Wysocki
2020-06-05 16:21 ` Rafael J. Wysocki
2020-06-05 16:39 ` Dan Williams
2020-06-05 16:39 ` Dan Williams
2020-06-05 17:02 ` Rafael J. Wysocki
2020-06-05 17:02 ` Rafael J. Wysocki
2020-06-05 14:06 ` [RFT][PATCH] ACPI: OSL: Use rwlock instead of RCU for memory management Rafael J. Wysocki
2020-06-05 14:06 ` Rafael J. Wysocki
2020-06-05 17:08 ` Dan Williams
2020-06-05 17:08 ` Dan Williams
2020-06-06 6:56 ` Rafael J. Wysocki
2020-06-06 6:56 ` Rafael J. Wysocki
2020-06-08 15:33 ` Rafael J. Wysocki
2020-06-08 15:33 ` Rafael J. Wysocki
2020-06-08 16:29 ` Rafael J. Wysocki
2020-06-08 16:29 ` Rafael J. Wysocki
2020-06-05 19:40 ` Andy Shevchenko [this message]
2020-06-05 19:40 ` Andy Shevchenko
2020-06-06 6:48 ` Rafael J. Wysocki
2020-06-06 6:48 ` Rafael J. Wysocki
2020-06-10 12:17 ` [RFT][PATCH 0/3] ACPI: ACPICA / OSL: Avoid unmapping ACPI memory inside of the AML interpreter Rafael J. Wysocki
2020-06-10 12:17 ` Rafael J. Wysocki
2020-06-10 12:20 ` [RFT][PATCH 1/3] ACPICA: Defer unmapping of memory used in memory opregions Rafael J. Wysocki
2020-06-10 12:20 ` Rafael J. Wysocki
2020-06-10 12:21 ` [RFT][PATCH 2/3] ACPICA: Remove unused memory mappings on interpreter exit Rafael J. Wysocki
2020-06-10 12:21 ` Rafael J. Wysocki
2020-06-12 0:12 ` Kaneda, Erik
2020-06-12 0:12 ` Kaneda, Erik
2020-06-12 12:05 ` Rafael J. Wysocki
2020-06-12 12:05 ` Rafael J. Wysocki
2020-06-13 19:28 ` Rafael J. Wysocki
2020-06-13 19:28 ` Rafael J. Wysocki
2020-06-15 19:06 ` Dan Williams
2020-06-15 19:06 ` Dan Williams
2020-06-10 12:22 ` [RFT][PATCH 3/3] ACPI: OSL: Define ACPI_OS_MAP_MEMORY_FAST_PATH() Rafael J. Wysocki
2020-06-10 12:22 ` Rafael J. Wysocki
2020-06-13 19:19 ` [RFT][PATCH 0/3] ACPI: ACPICA / OSL: Avoid unmapping ACPI memory inside of the AML interpreter Rafael J. Wysocki
2020-06-13 19:19 ` Rafael J. Wysocki
2020-06-22 13:50 ` [RFT][PATCH v2 0/4] " Rafael J. Wysocki
2020-06-22 13:50 ` Rafael J. Wysocki
2020-06-22 13:52 ` [RFT][PATCH v2 1/4] ACPICA: Defer unmapping of opregion memory if supported by OS Rafael J. Wysocki
2020-06-22 13:52 ` Rafael J. Wysocki
2020-06-22 13:53 ` [RFT][PATCH v2 2/4] ACPI: OSL: Add support for deferred unmapping of ACPI memory Rafael J. Wysocki
2020-06-22 13:53 ` Rafael J. Wysocki
2020-06-22 14:56 ` Andy Shevchenko
2020-06-22 14:56 ` Andy Shevchenko
2020-06-22 15:27 ` Rafael J. Wysocki
2020-06-22 15:27 ` Rafael J. Wysocki
2020-06-22 15:46 ` Andy Shevchenko
2020-06-22 15:46 ` Andy Shevchenko
2020-06-22 14:01 ` [RFT][PATCH v2 3/4] ACPICA: Preserve memory opregion mappings if supported by OS Rafael J. Wysocki
2020-06-22 14:01 ` Rafael J. Wysocki
2020-06-26 22:53 ` Kaneda, Erik
2020-06-26 22:53 ` Kaneda, Erik
2020-06-29 13:02 ` Rafael J. Wysocki
2020-06-29 13:02 ` Rafael J. Wysocki
2020-06-22 14:02 ` [RFT][PATCH v2 4/4] ACPI: OSL: Implement acpi_os_map_memory_fast_path() Rafael J. Wysocki
2020-06-22 14:02 ` Rafael J. Wysocki
2020-06-26 17:28 ` [RFT][PATCH v3 0/4] ACPI: ACPICA / OSL: Avoid unmapping ACPI memory inside of the AML interpreter Rafael J. Wysocki
2020-06-26 17:28 ` Rafael J. Wysocki
2020-06-26 17:31 ` [RFT][PATCH v3 1/4] ACPICA: Take deferred unmapping of memory into account Rafael J. Wysocki
2020-06-26 17:31 ` Rafael J. Wysocki
2020-06-26 17:31 ` [RFT][PATCH v3 2/4] ACPI: OSL: Implement deferred unmapping of ACPI memory Rafael J. Wysocki
2020-06-26 17:31 ` Rafael J. Wysocki
2020-06-27 11:32 ` kernel test robot
2020-06-26 17:32 ` [RFT][PATCH v3 3/4] ACPICA: Preserve memory opregion mappings if supported by OS Rafael J. Wysocki
2020-06-26 17:32 ` Rafael J. Wysocki
2020-06-26 17:33 ` [RFT][PATCH v3 4/4] ACPI: OSL: Implement acpi_os_map_memory_fast_path() Rafael J. Wysocki
2020-06-26 17:33 ` Rafael J. Wysocki
2020-06-26 18:41 ` [RFT][PATCH v3 0/4] ACPI: ACPICA / OSL: Avoid unmapping ACPI memory inside of the AML interpreter Dan Williams
2020-06-26 18:41 ` Dan Williams
2020-06-28 17:09 ` Rafael J. Wysocki
2020-06-28 17:09 ` Rafael J. Wysocki
2020-06-29 20:46 ` Dan Williams
2020-06-29 20:46 ` Dan Williams
2020-06-30 11:04 ` Rafael J. Wysocki
2020-06-30 11:04 ` Rafael J. Wysocki
2020-06-29 16:31 ` [PATCH v4 0/2] " Rafael J. Wysocki
2020-06-29 16:31 ` Rafael J. Wysocki
2020-06-29 16:33 ` [PATCH v4 1/2] ACPI: OSL: Implement deferred unmapping of ACPI memory Rafael J. Wysocki
2020-06-29 16:33 ` Rafael J. Wysocki
2020-06-29 16:33 ` [PATCH v4 2/2] ACPICA: Preserve memory opregion mappings Rafael J. Wysocki
2020-06-29 16:33 ` Rafael J. Wysocki
2020-06-29 20:57 ` Al Stone
2020-06-29 20:57 ` Al Stone
2020-06-30 11:44 ` Rafael J. Wysocki
2020-06-30 11:44 ` Rafael J. Wysocki
2020-06-30 15:31 ` Al Stone
2020-06-30 15:31 ` Al Stone
2020-06-30 15:52 ` Rafael J. Wysocki
2020-06-30 15:52 ` Rafael J. Wysocki
2020-06-30 19:57 ` Al Stone
2020-06-30 19:57 ` Al Stone
2020-07-16 19:22 ` Verma, Vishal L
2020-07-16 19:22 ` Verma, Vishal L
2020-07-19 19:14 ` Rafael J. Wysocki
2020-07-19 19:14 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Ve8A373Cbw6RiKTtkhj9jsxZ9dBY8ELtntk0B=yXxOCUg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=erik.kaneda@intel.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=myron.stowe@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.