From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Alejandro Tafalla <atafalla@dnyon.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Rob Herring <robh+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] ASoC: max98927: Handle reset gpio when probing i2c
Date: Mon, 30 Aug 2021 13:56:23 +0300 [thread overview]
Message-ID: <CAHp75VfgbA0upoHyDLPCRGrN+7H5mZiDu-GbQPxHid++Z9UqQA@mail.gmail.com> (raw)
In-Reply-To: <20210830104426.487246-2-atafalla@dnyon.com>
On Mon, Aug 30, 2021 at 1:48 PM Alejandro Tafalla <atafalla@dnyon.com> wrote:
>
> Drive the reset gpio if defined in the DTS node.
...
> + reset_gpio
> + = devm_gpiod_get_optional(&i2c->dev, "reset", GPIOD_OUT_LOW);
A bit of a strange indentation, shouldn't it be one line?
> + if (IS_ERR(reset_gpio)) {
> + ret = PTR_ERR(reset_gpio);
> + return dev_err_probe(&i2c->dev, ret,
> + "failed to request GPIO reset pin");
It simply as
return dev_err_probe(&i2c->dev, PTR_ERR(reset_gpio),
"failed to request GPIO reset pin");
> + }
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Alejandro Tafalla <atafalla@dnyon.com>
Cc: devicetree <devicetree@vger.kernel.org>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v2 1/2] ASoC: max98927: Handle reset gpio when probing i2c
Date: Mon, 30 Aug 2021 13:56:23 +0300 [thread overview]
Message-ID: <CAHp75VfgbA0upoHyDLPCRGrN+7H5mZiDu-GbQPxHid++Z9UqQA@mail.gmail.com> (raw)
In-Reply-To: <20210830104426.487246-2-atafalla@dnyon.com>
On Mon, Aug 30, 2021 at 1:48 PM Alejandro Tafalla <atafalla@dnyon.com> wrote:
>
> Drive the reset gpio if defined in the DTS node.
...
> + reset_gpio
> + = devm_gpiod_get_optional(&i2c->dev, "reset", GPIOD_OUT_LOW);
A bit of a strange indentation, shouldn't it be one line?
> + if (IS_ERR(reset_gpio)) {
> + ret = PTR_ERR(reset_gpio);
> + return dev_err_probe(&i2c->dev, ret,
> + "failed to request GPIO reset pin");
It simply as
return dev_err_probe(&i2c->dev, PTR_ERR(reset_gpio),
"failed to request GPIO reset pin");
> + }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-08-30 10:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 10:44 [PATCH v2 0/2] Add reset-gpios handling for max98927 Alejandro Tafalla
2021-08-30 10:44 ` Alejandro Tafalla
2021-08-30 10:44 ` [PATCH v2 1/2] ASoC: max98927: Handle reset gpio when probing i2c Alejandro Tafalla
2021-08-30 10:44 ` Alejandro Tafalla
2021-08-30 10:56 ` Andy Shevchenko [this message]
2021-08-30 10:56 ` Andy Shevchenko
2021-09-01 17:00 ` Alejandro Tafalla
2021-09-01 17:00 ` Alejandro Tafalla
2021-08-30 10:44 ` [PATCH v2 2/2] dt-bindings: sound: max98927: Add reset-gpios optional property Alejandro Tafalla
2021-08-30 10:44 ` Alejandro Tafalla
2021-09-01 1:32 ` Rob Herring
2021-09-01 1:32 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfgbA0upoHyDLPCRGrN+7H5mZiDu-GbQPxHid++Z9UqQA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=atafalla@dnyon.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.