From: Andy Shevchenko <andy.shevchenko@gmail.com> To: Colin Foster <colin.foster@in-advantage.com> Cc: linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, netdev <netdev@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, Terry Bowman <terry.bowman@amd.com>, Vladimir Oltean <vladimir.oltean@nxp.com>, Wolfram Sang <wsa@kernel.org>, Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>, Steen Hegelund <Steen.Hegelund@microchip.com>, Lars Povlsen <lars.povlsen@microchip.com>, Linus Walleij <linus.walleij@linaro.org>, Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>, Eric Dumazet <edumazet@google.com>, "David S. Miller" <davem@davemloft.net>, Russell King <linux@armlinux.org.uk>, Heiner Kallweit <hkallweit1@gmail.com>, Andrew Lunn <andrew@lunn.ch>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org>, Lee Jones <lee.jones@linaro.org>, katie.morris@in-advantage.com Subject: Re: [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi Date: Fri, 5 Aug 2022 20:14:52 +0200 [thread overview] Message-ID: <CAHp75Vftx=uF4Y-PCutjVSFYEdT3PrDVu=Vc3AX+hJaKE80LoA@mail.gmail.com> (raw) In-Reply-To: <Yu1cSLlkXAr/t5ho@euler> On Fri, Aug 5, 2022 at 8:07 PM Colin Foster <colin.foster@in-advantage.com> wrote: > On Fri, Aug 05, 2022 at 07:58:06PM +0200, Andy Shevchenko wrote: > > On Fri, Aug 5, 2022 at 7:44 PM Colin Foster > > <colin.foster@in-advantage.com> wrote: > > > On Tue, Aug 02, 2022 at 10:47:28PM -0700, Colin Foster wrote: ... > > > > +int ocelot_chip_reset(struct device *dev) > > > > > > #include <linux/device.h> > > > > Nope, > > > > struct device; ... > > > > +static int ocelot_spi_initialize(struct device *dev) > > > > > > #include <linux/device.h> > > > > Ditto. > > ocelot-spi.c uses devm_kzalloc, so that should still be included. > > ocelot-core.c uses dev_get_drvdata. > > So I think I still want the includes... but for different reasons. Yes in this case. -- With Best Regards, Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com> To: Colin Foster <colin.foster@in-advantage.com> Cc: linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, netdev <netdev@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, Terry Bowman <terry.bowman@amd.com>, Vladimir Oltean <vladimir.oltean@nxp.com>, Wolfram Sang <wsa@kernel.org>, Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>, Steen Hegelund <Steen.Hegelund@microchip.com>, Lars Povlsen <lars.povlsen@microchip.com>, Linus Walleij <linus.walleij@linaro.org>, Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>, Eric Dumazet <edumazet@google.com>, "David S. Miller" <davem@davemloft.net>, Russell King <linux@armlinux.org.uk>, Heiner Kallweit <hkallweit1@gmail.com>, Andrew Lunn <andrew@lunn.ch>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org>, Lee Jones <lee.jones@linaro.org>, katie.morris@in-advantage.com Subject: Re: [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi Date: Fri, 5 Aug 2022 20:14:52 +0200 [thread overview] Message-ID: <CAHp75Vftx=uF4Y-PCutjVSFYEdT3PrDVu=Vc3AX+hJaKE80LoA@mail.gmail.com> (raw) In-Reply-To: <Yu1cSLlkXAr/t5ho@euler> On Fri, Aug 5, 2022 at 8:07 PM Colin Foster <colin.foster@in-advantage.com> wrote: > On Fri, Aug 05, 2022 at 07:58:06PM +0200, Andy Shevchenko wrote: > > On Fri, Aug 5, 2022 at 7:44 PM Colin Foster > > <colin.foster@in-advantage.com> wrote: > > > On Tue, Aug 02, 2022 at 10:47:28PM -0700, Colin Foster wrote: ... > > > > +int ocelot_chip_reset(struct device *dev) > > > > > > #include <linux/device.h> > > > > Nope, > > > > struct device; ... > > > > +static int ocelot_spi_initialize(struct device *dev) > > > > > > #include <linux/device.h> > > > > Ditto. > > ocelot-spi.c uses devm_kzalloc, so that should still be included. > > ocelot-core.c uses dev_get_drvdata. > > So I think I still want the includes... but for different reasons. Yes in this case. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-05 18:15 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-03 5:47 [PATCH v15 mfd 0/9] add support for VSC7512 control over SPI Colin Foster 2022-08-03 5:47 ` Colin Foster 2022-08-03 5:47 ` [PATCH v15 mfd 1/9] mfd: ocelot: add helper to get regmap from a resource Colin Foster 2022-08-03 5:47 ` Colin Foster 2022-08-03 11:31 ` Andy Shevchenko 2022-08-03 11:31 ` Andy Shevchenko 2022-08-03 5:47 ` [PATCH v15 mfd 2/9] net: mdio: mscc-miim: add ability to be used in a non-mmio configuration Colin Foster 2022-08-03 5:47 ` Colin Foster 2022-08-03 11:31 ` Andy Shevchenko 2022-08-03 11:31 ` Andy Shevchenko 2022-08-03 5:47 ` [PATCH v15 mfd 3/9] pinctrl: ocelot: allow pinctrl-ocelot to be loaded as a module Colin Foster 2022-08-03 5:47 ` Colin Foster 2022-08-03 11:32 ` Andy Shevchenko 2022-08-03 11:32 ` Andy Shevchenko 2022-08-03 5:47 ` [PATCH v15 mfd 4/9] pinctrl: ocelot: add ability to be used in a non-mmio configuration Colin Foster 2022-08-03 5:47 ` Colin Foster 2022-08-03 11:32 ` Andy Shevchenko 2022-08-03 11:32 ` Andy Shevchenko 2022-08-03 5:47 ` [PATCH v15 mfd 5/9] pinctrl: microchip-sgpio: allow sgpio driver to be used as a module Colin Foster 2022-08-03 5:47 ` Colin Foster 2022-08-03 11:32 ` Andy Shevchenko 2022-08-03 11:32 ` Andy Shevchenko 2022-08-03 5:47 ` [PATCH v15 mfd 6/9] pinctrl: microchip-sgpio: add ability to be used in a non-mmio configuration Colin Foster 2022-08-03 5:47 ` Colin Foster 2022-08-03 11:32 ` Andy Shevchenko 2022-08-03 11:32 ` Andy Shevchenko 2022-08-03 5:47 ` [PATCH v15 mfd 7/9] resource: add define macro for register address resources Colin Foster 2022-08-03 5:47 ` Colin Foster 2022-08-03 11:33 ` Andy Shevchenko 2022-08-03 11:33 ` Andy Shevchenko 2022-08-03 5:47 ` [PATCH v15 mfd 8/9] dt-bindings: mfd: ocelot: add bindings for VSC7512 Colin Foster 2022-08-03 5:47 ` Colin Foster 2022-08-03 5:47 ` [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi Colin Foster 2022-08-03 5:47 ` Colin Foster 2022-08-03 11:45 ` Andy Shevchenko 2022-08-03 11:45 ` Andy Shevchenko 2022-08-03 15:56 ` Colin Foster 2022-08-03 15:56 ` Colin Foster 2022-08-03 17:10 ` Andy Shevchenko 2022-08-03 17:10 ` Andy Shevchenko 2022-08-03 17:31 ` Colin Foster 2022-08-03 17:31 ` Colin Foster 2022-08-05 17:44 ` Colin Foster 2022-08-05 17:44 ` Colin Foster 2022-08-05 17:58 ` Andy Shevchenko 2022-08-05 17:58 ` Andy Shevchenko 2022-08-05 18:07 ` Colin Foster 2022-08-05 18:07 ` Colin Foster 2022-08-05 18:14 ` Andy Shevchenko [this message] 2022-08-05 18:14 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHp75Vftx=uF4Y-PCutjVSFYEdT3PrDVu=Vc3AX+hJaKE80LoA@mail.gmail.com' \ --to=andy.shevchenko@gmail.com \ --cc=Steen.Hegelund@microchip.com \ --cc=UNGLinuxDriver@microchip.com \ --cc=andrew@lunn.ch \ --cc=colin.foster@in-advantage.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=edumazet@google.com \ --cc=hkallweit1@gmail.com \ --cc=katie.morris@in-advantage.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=kuba@kernel.org \ --cc=lars.povlsen@microchip.com \ --cc=lee.jones@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=robh+dt@kernel.org \ --cc=terry.bowman@amd.com \ --cc=vladimir.oltean@nxp.com \ --cc=wsa@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.