From: Zhi Li <lznuaa@gmail.com> To: Will Deacon <will.deacon@arm.com> Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>, Aisheng Dong <aisheng.dong@nxp.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>, "festevam@gmail.com" <festevam@gmail.com>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, Frank Li <frank.li@nxp.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH V12 2/4] drivers/perf: imx_ddr: Add ddr performance counter support Date: Thu, 13 Jun 2019 14:13:20 -0500 [thread overview] Message-ID: <CAHrpEqS9GEC9Shf-6xLL0_+WJNuwYOdKe=5jtUogLajfcWYMew@mail.gmail.com> (raw) In-Reply-To: <20190613174436.GG18966@fuggles.cambridge.arm.com> On Thu, Jun 13, 2019 at 12:44 PM Will Deacon <will.deacon@arm.com> wrote: > > On Thu, Jun 13, 2019 at 12:04:37PM -0500, Zhi Li wrote: > > On Thu, Jun 13, 2019 at 6:23 AM Will Deacon <will.deacon@arm.com> wrote: > > > > > > On Wed, May 01, 2019 at 06:43:29PM +0000, Frank Li wrote: > > > > Add ddr performance monitor support for iMX8QXP > > > > > > > > There are 4 counters for ddr perfomance events. > > > > counter 0 is dedicated for cycles. > > > > you choose any up to 3 no cycles events. > > > > > > > > for example: > > > > > > > > perf stat -a -e imx8_ddr0/read-cycles/,imx8_ddr0/write-cycles/,imx8_ddr0/precharge/ ls > > > > perf stat -a -e imx8_ddr0/cycles/,imx8_ddr0/read-access/,imx8_ddr0/write-access/ ls > > > > > > I've pushed patches 1, 2 and 4 out with some minor tweaks to: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/log/?h=for-next/perf > > > > > > I'll leave the actual .dts change to go via the soc tree, since last time > > > I took one of those it just resulted in conflicts. > > > > > > Frank, Andrey: Please could you try to run the perf fuzzer on this before > > > it lands in mainline? It has a good track record of finding nasty PMU driver > > > bugs, but it obviously requires access to hardware which implements the PMU: > > > > > > http://web.eece.maine.edu/~vweaver/projects/perf_events/fuzzer/ > > > > Okay, how long should be run generally? > > I need make sure it can pass without my patches at our platform. > > As you long as you can really, but if it survives a few hours that's usually > a good sign. Overnight is even better. Base on commit f2c7c76c5d0a443053e94adb9f0918fa2fb85c3a Author: Linus Torvalds <torvalds@linux-foundation.org> Date: Sun Jun 2 13:55:33 2019 -0700 Linux 5.2-rc3 RCU report problem: [ 6048.741784] rcu: INFO: rcu_preempt self-detected stall on CPU [ 6048.747550] rcu: 1-....: (5249 ticks this GP) idle=c5a/1/0x4000000000000004 softirq=503121/503121 fqs=2425 [ 6048.757384] (t=5253 jiffies g=1416105 q=117) [ 6048.761745] Task dump for CPU 1: [ 6048.764977] perf_fuzzer R running task 0 32520 426 0x00000202 [ 6048.772030] Call trace: [ 6048.774493] dump_backtrace+0x0/0x130 [ 6048.778159] show_stack+0x14/0x20 [ 6048.781477] sched_show_task+0x108/0x138 [ 6048.785401] dump_cpu_task+0x40/0x4c [ 6048.788983] rcu_dump_cpu_stacks+0x94/0xd0 [ 6048.793082] rcu_sched_clock_irq+0x5e0/0x918 [ 6048.797357] update_process_times+0x2c/0x70 [ 6048.801545] tick_sched_handle.isra.6+0x3c/0x50 [ 6048.806076] tick_sched_timer+0x48/0x98 [ 6048.809918] __hrtimer_run_queues+0x118/0x1a8 [ 6048.814277] hrtimer_interrupt+0xe4/0x238 [ 6048.818296] arch_timer_handler_phys+0x2c/0x38 [ 6048.822743] handle_percpu_devid_irq+0x80/0x140 [ 6048.827277] generic_handle_irq+0x24/0x38 Only armv8_pmuv3 and basic perf event enabled. perf list List of pre-defined events (to be used in -e): branch-instructions OR branches [Hardware event] branch-misses [Hardware event] bus-cycles [Hardware event] cache-misses [Hardware event] cache-references [Hardware event] cpu-cycles OR cycles [Hardware event] instructions [Hardware event] alignment-faults [Software event] bpf-output [Software event] context-switches OR cs [Software event] cpu-clock [Software event] cpu-migrations OR migrations [Software event] dummy [Software event] emulation-faults [Software event] major-faults [Software event] minor-faults [Software event] page-faults OR faults [Software event] task-clock [Software event] L1-dcache-load-misses [Hardware cache event] L1-dcache-loads [Hardware cache event] L1-icache-load-misses [Hardware cache event] L1-icache-loads [Hardware cache event] branch-load-misses [Hardware cache event] branch-loads [Hardware cache event] dTLB-load-misses [Hardware cache event] iTLB-load-misses [Hardware cache event] armv8_pmuv3/br_immed_retired/ [Kernel PMU event] armv8_pmuv3/br_mis_pred/ [Kernel PMU event] ****8 > > Will
WARNING: multiple messages have this Message-ID (diff)
From: Zhi Li <lznuaa@gmail.com> To: Will Deacon <will.deacon@arm.com> Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>, Aisheng Dong <aisheng.dong@nxp.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>, "festevam@gmail.com" <festevam@gmail.com>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, Frank Li <frank.li@nxp.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH V12 2/4] drivers/perf: imx_ddr: Add ddr performance counter support Date: Thu, 13 Jun 2019 14:13:20 -0500 [thread overview] Message-ID: <CAHrpEqS9GEC9Shf-6xLL0_+WJNuwYOdKe=5jtUogLajfcWYMew@mail.gmail.com> (raw) In-Reply-To: <20190613174436.GG18966@fuggles.cambridge.arm.com> On Thu, Jun 13, 2019 at 12:44 PM Will Deacon <will.deacon@arm.com> wrote: > > On Thu, Jun 13, 2019 at 12:04:37PM -0500, Zhi Li wrote: > > On Thu, Jun 13, 2019 at 6:23 AM Will Deacon <will.deacon@arm.com> wrote: > > > > > > On Wed, May 01, 2019 at 06:43:29PM +0000, Frank Li wrote: > > > > Add ddr performance monitor support for iMX8QXP > > > > > > > > There are 4 counters for ddr perfomance events. > > > > counter 0 is dedicated for cycles. > > > > you choose any up to 3 no cycles events. > > > > > > > > for example: > > > > > > > > perf stat -a -e imx8_ddr0/read-cycles/,imx8_ddr0/write-cycles/,imx8_ddr0/precharge/ ls > > > > perf stat -a -e imx8_ddr0/cycles/,imx8_ddr0/read-access/,imx8_ddr0/write-access/ ls > > > > > > I've pushed patches 1, 2 and 4 out with some minor tweaks to: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/log/?h=for-next/perf > > > > > > I'll leave the actual .dts change to go via the soc tree, since last time > > > I took one of those it just resulted in conflicts. > > > > > > Frank, Andrey: Please could you try to run the perf fuzzer on this before > > > it lands in mainline? It has a good track record of finding nasty PMU driver > > > bugs, but it obviously requires access to hardware which implements the PMU: > > > > > > http://web.eece.maine.edu/~vweaver/projects/perf_events/fuzzer/ > > > > Okay, how long should be run generally? > > I need make sure it can pass without my patches at our platform. > > As you long as you can really, but if it survives a few hours that's usually > a good sign. Overnight is even better. Base on commit f2c7c76c5d0a443053e94adb9f0918fa2fb85c3a Author: Linus Torvalds <torvalds@linux-foundation.org> Date: Sun Jun 2 13:55:33 2019 -0700 Linux 5.2-rc3 RCU report problem: [ 6048.741784] rcu: INFO: rcu_preempt self-detected stall on CPU [ 6048.747550] rcu: 1-....: (5249 ticks this GP) idle=c5a/1/0x4000000000000004 softirq=503121/503121 fqs=2425 [ 6048.757384] (t=5253 jiffies g=1416105 q=117) [ 6048.761745] Task dump for CPU 1: [ 6048.764977] perf_fuzzer R running task 0 32520 426 0x00000202 [ 6048.772030] Call trace: [ 6048.774493] dump_backtrace+0x0/0x130 [ 6048.778159] show_stack+0x14/0x20 [ 6048.781477] sched_show_task+0x108/0x138 [ 6048.785401] dump_cpu_task+0x40/0x4c [ 6048.788983] rcu_dump_cpu_stacks+0x94/0xd0 [ 6048.793082] rcu_sched_clock_irq+0x5e0/0x918 [ 6048.797357] update_process_times+0x2c/0x70 [ 6048.801545] tick_sched_handle.isra.6+0x3c/0x50 [ 6048.806076] tick_sched_timer+0x48/0x98 [ 6048.809918] __hrtimer_run_queues+0x118/0x1a8 [ 6048.814277] hrtimer_interrupt+0xe4/0x238 [ 6048.818296] arch_timer_handler_phys+0x2c/0x38 [ 6048.822743] handle_percpu_devid_irq+0x80/0x140 [ 6048.827277] generic_handle_irq+0x24/0x38 Only armv8_pmuv3 and basic perf event enabled. perf list List of pre-defined events (to be used in -e): branch-instructions OR branches [Hardware event] branch-misses [Hardware event] bus-cycles [Hardware event] cache-misses [Hardware event] cache-references [Hardware event] cpu-cycles OR cycles [Hardware event] instructions [Hardware event] alignment-faults [Software event] bpf-output [Software event] context-switches OR cs [Software event] cpu-clock [Software event] cpu-migrations OR migrations [Software event] dummy [Software event] emulation-faults [Software event] major-faults [Software event] minor-faults [Software event] page-faults OR faults [Software event] task-clock [Software event] L1-dcache-load-misses [Hardware cache event] L1-dcache-loads [Hardware cache event] L1-icache-load-misses [Hardware cache event] L1-icache-loads [Hardware cache event] branch-load-misses [Hardware cache event] branch-loads [Hardware cache event] dTLB-load-misses [Hardware cache event] iTLB-load-misses [Hardware cache event] armv8_pmuv3/br_immed_retired/ [Kernel PMU event] armv8_pmuv3/br_mis_pred/ [Kernel PMU event] ****8 > > Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-13 19:13 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-01 18:43 [PATCH V12 1/4] dt-bindings: perf: imx8-ddr: add imx8qxp ddr performance monitor Frank Li 2019-05-01 18:43 ` Frank Li 2019-05-01 18:43 ` [PATCH V12 2/4] drivers/perf: imx_ddr: Add ddr performance counter support Frank Li 2019-05-01 18:43 ` Frank Li 2019-05-07 19:30 ` Andrey Smirnov 2019-05-07 19:30 ` Andrey Smirnov 2019-05-14 13:53 ` Zhi Li 2019-05-14 13:53 ` Zhi Li 2019-05-14 14:55 ` Will Deacon 2019-05-14 14:55 ` Will Deacon 2019-06-13 11:23 ` Will Deacon 2019-06-13 11:23 ` Will Deacon 2019-06-13 17:04 ` Zhi Li 2019-06-13 17:04 ` Zhi Li 2019-06-13 17:44 ` Will Deacon 2019-06-13 17:44 ` Will Deacon 2019-06-13 19:13 ` Zhi Li [this message] 2019-06-13 19:13 ` Zhi Li 2019-06-14 10:23 ` Will Deacon 2019-06-14 10:23 ` Will Deacon 2019-06-18 17:24 ` Zhi Li 2019-06-18 17:24 ` Zhi Li 2019-06-18 17:58 ` Will Deacon 2019-06-18 17:58 ` Will Deacon 2019-05-01 18:43 ` [PATCH V12 3/4] arm64: dts: imx8qxp: added ddr performance monitor nodes Frank Li 2019-05-01 18:43 ` Frank Li 2019-06-18 6:37 ` Shawn Guo 2019-06-18 6:37 ` Shawn Guo 2019-05-01 18:43 ` [PATCH V12 4/4] MAINTAINERS: Added imx DDR performonitor driver maintainer information Frank Li 2019-05-01 18:43 ` Frank Li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHrpEqS9GEC9Shf-6xLL0_+WJNuwYOdKe=5jtUogLajfcWYMew@mail.gmail.com' \ --to=lznuaa@gmail.com \ --cc=aisheng.dong@nxp.com \ --cc=andrew.smirnov@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=frank.li@nxp.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.