All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhi Li <lznuaa@gmail.com>
To: Will Deacon <will.deacon@arm.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	Frank Li <frank.li@nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V12 2/4] drivers/perf: imx_ddr: Add ddr performance counter support
Date: Thu, 13 Jun 2019 12:04:37 -0500	[thread overview]
Message-ID: <CAHrpEqRZ0YL9SFk6o7iebJ+diJVMTtyba_9GtujL7H7e4G8qQA@mail.gmail.com> (raw)
In-Reply-To: <20190613112320.GA18966@fuggles.cambridge.arm.com>

On Thu, Jun 13, 2019 at 6:23 AM Will Deacon <will.deacon@arm.com> wrote:
>
> On Wed, May 01, 2019 at 06:43:29PM +0000, Frank Li wrote:
> > Add ddr performance monitor support for iMX8QXP
> >
> > There are 4 counters for ddr perfomance events.
> > counter 0 is dedicated for cycles.
> > you choose any up to 3 no cycles events.
> >
> > for example:
> >
> > perf stat -a -e imx8_ddr0/read-cycles/,imx8_ddr0/write-cycles/,imx8_ddr0/precharge/ ls
> > perf stat -a -e imx8_ddr0/cycles/,imx8_ddr0/read-access/,imx8_ddr0/write-access/ ls
>
> I've pushed patches 1, 2 and 4 out with some minor tweaks to:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/log/?h=for-next/perf
>
> I'll leave the actual .dts change to go via the soc tree, since last time
> I took one of those it just resulted in conflicts.
>
> Frank, Andrey: Please could you try to run the perf fuzzer on this before
> it lands in mainline? It has a good track record of finding nasty PMU driver
> bugs, but it obviously requires access to hardware which implements the PMU:
>
> http://web.eece.maine.edu/~vweaver/projects/perf_events/fuzzer/

Okay, how long should be run generally?
I need make sure it can pass without my patches at our platform.

Best regards
Frank Li

>
> Cheers,
>
> Will

WARNING: multiple messages have this Message-ID (diff)
From: Zhi Li <lznuaa@gmail.com>
To: Will Deacon <will.deacon@arm.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	Frank Li <frank.li@nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V12 2/4] drivers/perf: imx_ddr: Add ddr performance counter support
Date: Thu, 13 Jun 2019 12:04:37 -0500	[thread overview]
Message-ID: <CAHrpEqRZ0YL9SFk6o7iebJ+diJVMTtyba_9GtujL7H7e4G8qQA@mail.gmail.com> (raw)
In-Reply-To: <20190613112320.GA18966@fuggles.cambridge.arm.com>

On Thu, Jun 13, 2019 at 6:23 AM Will Deacon <will.deacon@arm.com> wrote:
>
> On Wed, May 01, 2019 at 06:43:29PM +0000, Frank Li wrote:
> > Add ddr performance monitor support for iMX8QXP
> >
> > There are 4 counters for ddr perfomance events.
> > counter 0 is dedicated for cycles.
> > you choose any up to 3 no cycles events.
> >
> > for example:
> >
> > perf stat -a -e imx8_ddr0/read-cycles/,imx8_ddr0/write-cycles/,imx8_ddr0/precharge/ ls
> > perf stat -a -e imx8_ddr0/cycles/,imx8_ddr0/read-access/,imx8_ddr0/write-access/ ls
>
> I've pushed patches 1, 2 and 4 out with some minor tweaks to:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/log/?h=for-next/perf
>
> I'll leave the actual .dts change to go via the soc tree, since last time
> I took one of those it just resulted in conflicts.
>
> Frank, Andrey: Please could you try to run the perf fuzzer on this before
> it lands in mainline? It has a good track record of finding nasty PMU driver
> bugs, but it obviously requires access to hardware which implements the PMU:
>
> http://web.eece.maine.edu/~vweaver/projects/perf_events/fuzzer/

Okay, how long should be run generally?
I need make sure it can pass without my patches at our platform.

Best regards
Frank Li

>
> Cheers,
>
> Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-06-13 17:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-01 18:43 [PATCH V12 1/4] dt-bindings: perf: imx8-ddr: add imx8qxp ddr performance monitor Frank Li
2019-05-01 18:43 ` Frank Li
2019-05-01 18:43 ` [PATCH V12 2/4] drivers/perf: imx_ddr: Add ddr performance counter support Frank Li
2019-05-01 18:43   ` Frank Li
2019-05-07 19:30   ` Andrey Smirnov
2019-05-07 19:30     ` Andrey Smirnov
2019-05-14 13:53     ` Zhi Li
2019-05-14 13:53       ` Zhi Li
2019-05-14 14:55       ` Will Deacon
2019-05-14 14:55         ` Will Deacon
2019-06-13 11:23   ` Will Deacon
2019-06-13 11:23     ` Will Deacon
2019-06-13 17:04     ` Zhi Li [this message]
2019-06-13 17:04       ` Zhi Li
2019-06-13 17:44       ` Will Deacon
2019-06-13 17:44         ` Will Deacon
2019-06-13 19:13         ` Zhi Li
2019-06-13 19:13           ` Zhi Li
2019-06-14 10:23           ` Will Deacon
2019-06-14 10:23             ` Will Deacon
2019-06-18 17:24             ` Zhi Li
2019-06-18 17:24               ` Zhi Li
2019-06-18 17:58               ` Will Deacon
2019-06-18 17:58                 ` Will Deacon
2019-05-01 18:43 ` [PATCH V12 3/4] arm64: dts: imx8qxp: added ddr performance monitor nodes Frank Li
2019-05-01 18:43   ` Frank Li
2019-06-18  6:37   ` Shawn Guo
2019-06-18  6:37     ` Shawn Guo
2019-05-01 18:43 ` [PATCH V12 4/4] MAINTAINERS: Added imx DDR performonitor driver maintainer information Frank Li
2019-05-01 18:43   ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHrpEqRZ0YL9SFk6o7iebJ+diJVMTtyba_9GtujL7H7e4G8qQA@mail.gmail.com \
    --to=lznuaa@gmail.com \
    --cc=aisheng.dong@nxp.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frank.li@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.