All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Harvey <tharvey@gateworks.com>
To: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
Cc: Stefano Babic <sbabic@denx.de>,
	Fabio Estevam <festevam@gmail.com>,
	 "NXP i . MX U-Boot Team" <uboot-imx@nxp.com>,
	u-boot <u-boot@lists.denx.de>
Subject: Re: [PATCH v2] board: gateworks: venice: enable DM_SERIAL
Date: Wed, 13 Apr 2022 09:08:55 -0700	[thread overview]
Message-ID: <CAJ+vNU1WYENWqs+nfYSbkbrAwcnVYaitZCeEb0ZcqN4J-=Cc+g@mail.gmail.com> (raw)
In-Reply-To: <CAOf5uwmc0uqKHgHHKJjt1CR-Uwg67dB0mHZUEimugtH896-wRA@mail.gmail.com>

On Wed, Apr 13, 2022 at 8:56 AM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:
>
> Hi Tim
>
> On Wed, Apr 13, 2022 at 5:47 PM Tim Harvey <tharvey@gateworks.com> wrote:
> >
> > Enable DM_SERIAL.
> >
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > ---
> > v2: rebase on imx/master
> > ---
> >  configs/imx8mm_venice_defconfig | 2 ++
> >  configs/imx8mn_venice_defconfig | 2 ++
> >  2 files changed, 4 insertions(+)
> >
> > diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig
> > index dd61ec9b70fb..09f7d8a58ca7 100644
> > --- a/configs/imx8mm_venice_defconfig
> > +++ b/configs/imx8mm_venice_defconfig
> > @@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
> >  CONFIG_DM_REGULATOR=y
> >  CONFIG_DM_REGULATOR_FIXED=y
> >  CONFIG_DM_REGULATOR_GPIO=y
> > +CONFIG_DM_SERIAL=y
> > +# CONFIG_SPL_DM_SERIAL is not set
> >  CONFIG_MXC_UART=y
> >  CONFIG_SYSRESET=y
> >  CONFIG_SPL_SYSRESET=y
> > diff --git a/configs/imx8mn_venice_defconfig b/configs/imx8mn_venice_defconfig
> > index c3a96a378553..41898da4aecf 100644
> > --- a/configs/imx8mn_venice_defconfig
> > +++ b/configs/imx8mn_venice_defconfig
> > @@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
> >  CONFIG_DM_REGULATOR=y
> >  CONFIG_DM_REGULATOR_FIXED=y
> >  CONFIG_DM_REGULATOR_GPIO=y
> > +CONFIG_DM_SERIAL=y
> > +# CONFIG_SPL_DM_SERIAL is not set
> >  CONFIG_MXC_UART=y
> >  CONFIG_SYSRESET=y
> >  CONFIG_SPL_SYSRESET=y
> > --
> > 2.17.1
> >
>
> Should not select in your board kconfig?
>

Michael,

I don't think it really matters. The other conversions to DM_SERIAL
are going in defconfigs as well.

Best Regards,

Tim

  reply	other threads:[~2022-04-13 16:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13 15:47 [PATCH v2] board: gateworks: venice: enable DM_SERIAL Tim Harvey
2022-04-13 15:56 ` Michael Nazzareno Trimarchi
2022-04-13 16:08   ` Tim Harvey [this message]
2022-04-13 17:20     ` Michael Nazzareno Trimarchi
2022-04-14 16:10       ` Tim Harvey
2022-04-14 17:42         ` Tim Harvey
2022-04-21 12:27 ` sbabic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ+vNU1WYENWqs+nfYSbkbrAwcnVYaitZCeEb0ZcqN4J-=Cc+g@mail.gmail.com' \
    --to=tharvey@gateworks.com \
    --cc=festevam@gmail.com \
    --cc=michael@amarulasolutions.com \
    --cc=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.