Re: [PATCH v2] board: gateworks: venice: enable DM_SERIAL

From: Tim Harvey <tharvey@gateworks.com>
To: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
Cc: Stefano Babic <sbabic@denx.de>,
	Fabio Estevam <festevam@gmail.com>,
	 "NXP i . MX U-Boot Team" <uboot-imx@nxp.com>,
	u-boot <u-boot@lists.denx.de>
Subject: Re: [PATCH v2] board: gateworks: venice: enable DM_SERIAL
Date: Thu, 14 Apr 2022 10:42:07 -0700	[thread overview]
Message-ID: <CAJ+vNU2xeiWEU4apaPFW1QGucKBrUcK4g+za-o1Ecxf8r9dCZw@mail.gmail.com> (raw)
In-Reply-To: <CAJ+vNU0aaZsOqdoBkK2hr-c0peZLNe2OHtfX-2+TWb5YCJVVPQ@mail.gmail.com>

On Thu, Apr 14, 2022 at 9:10 AM Tim Harvey <tharvey@gateworks.com> wrote:
>
> On Wed, Apr 13, 2022 at 10:21 AM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
> >
> > Hi
> >
> > On Wed, Apr 13, 2022 at 6:09 PM Tim Harvey <tharvey@gateworks.com> wrote:
> > >
> > > On Wed, Apr 13, 2022 at 8:56 AM Michael Nazzareno Trimarchi
> > > <michael@amarulasolutions.com> wrote:
> > > >
> > > > Hi Tim
> > > >
> > > > On Wed, Apr 13, 2022 at 5:47 PM Tim Harvey <tharvey@gateworks.com> wrote:
> > > > >
> > > > > Enable DM_SERIAL.
> > > > >
> > > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > > > > ---
> > > > > v2: rebase on imx/master
> > > > > ---
> > > > >  configs/imx8mm_venice_defconfig | 2 ++
> > > > >  configs/imx8mn_venice_defconfig | 2 ++
> > > > >  2 files changed, 4 insertions(+)
> > > > >
> > > > > diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig
> > > > > index dd61ec9b70fb..09f7d8a58ca7 100644
> > > > > --- a/configs/imx8mm_venice_defconfig
> > > > > +++ b/configs/imx8mm_venice_defconfig
> > > > > @@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
> > > > >  CONFIG_DM_REGULATOR=y
> > > > >  CONFIG_DM_REGULATOR_FIXED=y
> > > > >  CONFIG_DM_REGULATOR_GPIO=y
> > > > > +CONFIG_DM_SERIAL=y
> > > > > +# CONFIG_SPL_DM_SERIAL is not set
> > > > >  CONFIG_MXC_UART=y
> > > > >  CONFIG_SYSRESET=y
> > > > >  CONFIG_SPL_SYSRESET=y
> > > > > diff --git a/configs/imx8mn_venice_defconfig b/configs/imx8mn_venice_defconfig
> > > > > index c3a96a378553..41898da4aecf 100644
> > > > > --- a/configs/imx8mn_venice_defconfig
> > > > > +++ b/configs/imx8mn_venice_defconfig
> > > > > @@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
> > > > >  CONFIG_DM_REGULATOR=y
> > > > >  CONFIG_DM_REGULATOR_FIXED=y
> > > > >  CONFIG_DM_REGULATOR_GPIO=y
> > > > > +CONFIG_DM_SERIAL=y
> > > > > +# CONFIG_SPL_DM_SERIAL is not set
> > > > >  CONFIG_MXC_UART=y
> > > > >  CONFIG_SYSRESET=y
> > > > >  CONFIG_SPL_SYSRESET=y
> > > > > --
> > > > > 2.17.1
> > > > >
> > > >
> > > > Should not select in your board kconfig?
> > > >
> > >
> > > Michael,
> > >
> > > I don't think it really matters. The other conversions to DM_SERIAL
> > > are going in defconfigs as well.
> >
> > Do we know why without # CONFIG_SPL_DM_SERIAL is not set
> >
> > board hang?
> >
>
> Michael,
>
> yes, if I also enable CONFIG_SPL_DM_SERIAL I get no serial output and
> the board hangs even if I add 'u-boot,dm-pre-proper' to
> uart2/pinctrl_uart2 nodes.

I see that Peng has a series [1] that moves imx8mn_evk, imx8mm_evk,
imx8mp_evk to DM_SERIAL and has figured out the hang.

I will re-submit the patch also enabling DM_SERIAL for SPL.

Best Regards,

Tim
[1] https://patchwork.ozlabs.org/project/uboot/list/?series=294869

>
> The requirement is to use DM_SERIAL in U-Boot, not in the SPL. I'm
> doing the same as was done for imx8mn-evk in ff1c7961d813 ("ARM: imx:
> imx8mn-evk: enable DM_SERIAL").
>
> Thus far, no ARCH_IMX8M boards have enabled CONFIG_SPL_DM_SERIAL so I
> suppose others have run into this as well but again the requirement is
> to enable CONFIG_DM_SERIAL not necessarily the SPL.
>
> Best Regards,
>
> Tim