From: Tim Harvey <tharvey@gateworks.com>
To: Shawn Guo <shawnguo@kernel.org>, Guenter Roeck <linux@roeck-us.net>
Cc: Akshay Bhat <akshay.bhat@timesys.com>,
Fabio Estevam <festevam@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Justin Waters <justin.waters@timesys.com>,
Lucas Stach <l.stach@pengutronix.de>, Stefan Roese <sr@denx.de>
Subject: Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop
Date: Thu, 31 Mar 2016 11:01:58 -0700 [thread overview]
Message-ID: <CAJ+vNU2zBCAF8hJfmSa31CyD9XcOCxYWqH9LKRm1S_sunqkgOg@mail.gmail.com> (raw)
In-Reply-To: <20160331015714.GM28207@tiger>
On Wed, Mar 30, 2016 at 6:57 PM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote:
>> The question was if the property name should be ext-reset-output or
>> fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output
>> because it is not a generic property. Tim disagrees.
>>
Guenter,
My issue regarding the vendor prefix was not a hard dissagreement but
was more about me understanding the rational behind using vendor
prefixes. In this case the imx2_wdt driver 'is' a vendor specific
driver as its compatible strings are prefixed with 'fsl,' so isn't
'any' property added to devicetree/bindings/watchdog/fsl-imx-wdt.txt
inherently a vendor specific properly already? I assume that is why
the 'big-endian' property isn't 'fsl,big-endian'.
Maybe it's more about if it 'is' marked as a vendor specific property
its much easier to get approval and accepted by a vendor-specific
maintainer?
>> So we have two options: Change the property name to fsl,ext-reset-output,
>> which I would accept, or wait for a devicetree maintainer to make a decision.
>
> Guenter,
>
> I agree with you on this point. Before everyone agrees that this is a
> generic binding, we should have vendor prefix for the property.
>
> Tim,
>
> This is a small change which, IMO, shouldn't hold an useful patch from being
> merged. Care to resend with the suggested change?
>
> Shawn
Shawn,
Sure - I'll rebase and re-submit.
Tim
WARNING: multiple messages have this Message-ID (diff)
From: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
To: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Cc: Akshay Bhat <akshay.bhat-jEh4hwF5bVhBDgjK7y7TUQ@public.gmane.org>,
Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Russell King - ARM Linux
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Justin Waters
<justin.waters-jEh4hwF5bVhBDgjK7y7TUQ@public.gmane.org>,
Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>
Subject: Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop
Date: Thu, 31 Mar 2016 11:01:58 -0700 [thread overview]
Message-ID: <CAJ+vNU2zBCAF8hJfmSa31CyD9XcOCxYWqH9LKRm1S_sunqkgOg@mail.gmail.com> (raw)
In-Reply-To: <20160331015714.GM28207@tiger>
On Wed, Mar 30, 2016 at 6:57 PM, Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote:
>> The question was if the property name should be ext-reset-output or
>> fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output
>> because it is not a generic property. Tim disagrees.
>>
Guenter,
My issue regarding the vendor prefix was not a hard dissagreement but
was more about me understanding the rational behind using vendor
prefixes. In this case the imx2_wdt driver 'is' a vendor specific
driver as its compatible strings are prefixed with 'fsl,' so isn't
'any' property added to devicetree/bindings/watchdog/fsl-imx-wdt.txt
inherently a vendor specific properly already? I assume that is why
the 'big-endian' property isn't 'fsl,big-endian'.
Maybe it's more about if it 'is' marked as a vendor specific property
its much easier to get approval and accepted by a vendor-specific
maintainer?
>> So we have two options: Change the property name to fsl,ext-reset-output,
>> which I would accept, or wait for a devicetree maintainer to make a decision.
>
> Guenter,
>
> I agree with you on this point. Before everyone agrees that this is a
> generic binding, we should have vendor prefix for the property.
>
> Tim,
>
> This is a small change which, IMO, shouldn't hold an useful patch from being
> merged. Care to resend with the suggested change?
>
> Shawn
Shawn,
Sure - I'll rebase and re-submit.
Tim
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tharvey@gateworks.com (Tim Harvey)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop
Date: Thu, 31 Mar 2016 11:01:58 -0700 [thread overview]
Message-ID: <CAJ+vNU2zBCAF8hJfmSa31CyD9XcOCxYWqH9LKRm1S_sunqkgOg@mail.gmail.com> (raw)
In-Reply-To: <20160331015714.GM28207@tiger>
On Wed, Mar 30, 2016 at 6:57 PM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote:
>> The question was if the property name should be ext-reset-output or
>> fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output
>> because it is not a generic property. Tim disagrees.
>>
Guenter,
My issue regarding the vendor prefix was not a hard dissagreement but
was more about me understanding the rational behind using vendor
prefixes. In this case the imx2_wdt driver 'is' a vendor specific
driver as its compatible strings are prefixed with 'fsl,' so isn't
'any' property added to devicetree/bindings/watchdog/fsl-imx-wdt.txt
inherently a vendor specific properly already? I assume that is why
the 'big-endian' property isn't 'fsl,big-endian'.
Maybe it's more about if it 'is' marked as a vendor specific property
its much easier to get approval and accepted by a vendor-specific
maintainer?
>> So we have two options: Change the property name to fsl,ext-reset-output,
>> which I would accept, or wait for a devicetree maintainer to make a decision.
>
> Guenter,
>
> I agree with you on this point. Before everyone agrees that this is a
> generic binding, we should have vendor prefix for the property.
>
> Tim,
>
> This is a small change which, IMO, shouldn't hold an useful patch from being
> merged. Care to resend with the suggested change?
>
> Shawn
Shawn,
Sure - I'll rebase and re-submit.
Tim
next prev parent reply other threads:[~2016-03-31 18:02 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 21:19 [PATCH v4 0/2] imx6: Implement external watchdog reset Akshay Bhat
2015-11-05 21:19 ` Akshay Bhat
2015-11-05 21:19 ` [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop Akshay Bhat
2015-11-05 21:19 ` Akshay Bhat
2015-11-05 22:23 ` Guenter Roeck
2015-11-05 22:23 ` Guenter Roeck
2015-11-05 22:23 ` Guenter Roeck
2015-11-06 19:53 ` Tim Harvey
2015-11-06 19:53 ` Tim Harvey
2015-11-06 19:53 ` Tim Harvey
2015-11-06 22:02 ` Guenter Roeck
2015-11-06 22:02 ` Guenter Roeck
2015-11-06 22:02 ` Guenter Roeck
2015-11-06 22:02 ` Guenter Roeck
2015-12-02 19:11 ` Akshay Bhat
2015-12-02 19:11 ` Akshay Bhat
2015-12-02 19:11 ` Akshay Bhat
2015-12-02 19:11 ` Akshay Bhat
2015-12-02 20:54 ` Tim Harvey
2015-12-02 20:54 ` Tim Harvey
2015-12-02 20:54 ` Tim Harvey
2015-12-02 20:54 ` Tim Harvey
2015-12-17 15:02 ` Tim Harvey
2015-12-17 15:02 ` Tim Harvey
2015-12-17 15:02 ` Tim Harvey
2015-12-17 15:02 ` Tim Harvey
2015-12-17 15:32 ` Guenter Roeck
2015-12-17 15:32 ` Guenter Roeck
2015-12-17 15:32 ` Guenter Roeck
2015-12-17 15:32 ` Guenter Roeck
2015-12-28 16:29 ` Wim Van Sebroeck
2015-12-28 16:29 ` Wim Van Sebroeck
2015-12-28 16:29 ` Wim Van Sebroeck
2016-01-28 20:28 ` Akshay Bhat
2016-01-28 20:28 ` Akshay Bhat
2016-01-28 20:28 ` Akshay Bhat
2016-01-28 20:28 ` Akshay Bhat
2016-02-28 13:56 ` Fabio Estevam
2016-02-28 13:56 ` Fabio Estevam
2016-02-28 13:56 ` Fabio Estevam
2016-02-28 13:56 ` Fabio Estevam
2016-03-28 20:19 ` Akshay Bhat
2016-03-28 20:19 ` Akshay Bhat
2016-03-28 20:19 ` Akshay Bhat
2016-03-28 20:19 ` Akshay Bhat
2016-03-30 1:22 ` Shawn Guo
2016-03-30 1:22 ` Shawn Guo
2016-03-30 1:22 ` Shawn Guo
2016-03-30 21:09 ` Guenter Roeck
2016-03-30 21:09 ` Guenter Roeck
2016-03-30 21:09 ` Guenter Roeck
2016-03-30 21:09 ` Guenter Roeck
2016-03-31 1:57 ` Shawn Guo
2016-03-31 1:57 ` Shawn Guo
2016-03-31 1:57 ` Shawn Guo
2016-03-31 18:01 ` Tim Harvey [this message]
2016-03-31 18:01 ` Tim Harvey
2016-03-31 18:01 ` Tim Harvey
2016-03-31 18:01 ` Tim Harvey
2016-04-01 1:39 ` Shawn Guo
2016-04-01 1:39 ` Shawn Guo
2016-04-01 1:39 ` Shawn Guo
2016-04-01 1:39 ` Shawn Guo
2015-11-05 21:19 ` [PATCH v4 2/2] ARM: dts: ventana: Add ext-reset support Akshay Bhat
2015-11-05 21:19 ` Akshay Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ+vNU2zBCAF8hJfmSa31CyD9XcOCxYWqH9LKRm1S_sunqkgOg@mail.gmail.com \
--to=tharvey@gateworks.com \
--cc=akshay.bhat@timesys.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=justin.waters@timesys.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=sr@denx.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.