All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Leach <mike.leach@linaro.org>
To: Tanmay Jagdale <tanmay@marvell.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
	"Suzuki K. Poulose" <suzuki.poulose@arm.com>,
	Leo Yan <leo.yan@linaro.org>, Rob Herring <robh+dt@kernel.org>,
	Coresight ML <coresight@lists.linaro.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	devicetree@vger.kernel.org, Al Grant <al.grant@arm.com>,
	Sunil Kovvuri Goutham <sgoutham@marvell.com>,
	Linu Cherian <lcherian@marvell.com>,
	Bharat Bhushan <bbhushan2@marvell.com>
Subject: Re: [PATCH 0/2] coresight: tmc: Add support to configure AXI burst size
Date: Thu, 2 Sep 2021 17:32:24 +0100	[thread overview]
Message-ID: <CAJ9a7VhJ-KC3VPCbgw8nqsZNMypsEACxyZstF9hinWYL+xa-tQ@mail.gmail.com> (raw)
In-Reply-To: <20210901131049.1365367-1-tanmay@marvell.com>

Hi

Looks good from a driver  / hw perspective.
As long as the device tree people are happy with the binding then this
set seems OK to me.

Regards

Mike

On Wed, 1 Sept 2021 at 14:11, Tanmay Jagdale <tanmay@marvell.com> wrote:
>
> Add a new device tree parameter, "arm,max-burst-size" to configure
> the max burst size that can be initiated by TMC-ETR on the AXI bus.
>
> Also add description of this property in coresight documentation.
>
> This patch series applies on top of the coresight next branch [1].
> https://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git/log/?h=next
>
> Tanmay Jagdale (2):
>   dt-bindings: coresight: Add burst size for TMC
>   coresight: tmc: Configure AXI write burst size
>
>  .../devicetree/bindings/arm/coresight.txt     |  5 +++++
>  .../hwtracing/coresight/coresight-tmc-core.c  | 21 +++++++++++++++++--
>  .../hwtracing/coresight/coresight-tmc-etr.c   |  3 ++-
>  drivers/hwtracing/coresight/coresight-tmc.h   |  6 +++++-
>  4 files changed, 31 insertions(+), 4 deletions(-)
>
> --
> 2.25.1
>


-- 
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK

WARNING: multiple messages have this Message-ID (diff)
From: Mike Leach <mike.leach@linaro.org>
To: Tanmay Jagdale <tanmay@marvell.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
	 "Suzuki K. Poulose" <suzuki.poulose@arm.com>,
	Leo Yan <leo.yan@linaro.org>,  Rob Herring <robh+dt@kernel.org>,
	Coresight ML <coresight@lists.linaro.org>,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	devicetree@vger.kernel.org,  Al Grant <al.grant@arm.com>,
	Sunil Kovvuri Goutham <sgoutham@marvell.com>,
	 Linu Cherian <lcherian@marvell.com>,
	Bharat Bhushan <bbhushan2@marvell.com>
Subject: Re: [PATCH 0/2] coresight: tmc: Add support to configure AXI burst size
Date: Thu, 2 Sep 2021 17:32:24 +0100	[thread overview]
Message-ID: <CAJ9a7VhJ-KC3VPCbgw8nqsZNMypsEACxyZstF9hinWYL+xa-tQ@mail.gmail.com> (raw)
In-Reply-To: <20210901131049.1365367-1-tanmay@marvell.com>

Hi

Looks good from a driver  / hw perspective.
As long as the device tree people are happy with the binding then this
set seems OK to me.

Regards

Mike

On Wed, 1 Sept 2021 at 14:11, Tanmay Jagdale <tanmay@marvell.com> wrote:
>
> Add a new device tree parameter, "arm,max-burst-size" to configure
> the max burst size that can be initiated by TMC-ETR on the AXI bus.
>
> Also add description of this property in coresight documentation.
>
> This patch series applies on top of the coresight next branch [1].
> https://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git/log/?h=next
>
> Tanmay Jagdale (2):
>   dt-bindings: coresight: Add burst size for TMC
>   coresight: tmc: Configure AXI write burst size
>
>  .../devicetree/bindings/arm/coresight.txt     |  5 +++++
>  .../hwtracing/coresight/coresight-tmc-core.c  | 21 +++++++++++++++++--
>  .../hwtracing/coresight/coresight-tmc-etr.c   |  3 ++-
>  drivers/hwtracing/coresight/coresight-tmc.h   |  6 +++++-
>  4 files changed, 31 insertions(+), 4 deletions(-)
>
> --
> 2.25.1
>


-- 
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-09-02 16:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01 13:10 [PATCH 0/2] coresight: tmc: Add support to configure AXI burst size Tanmay Jagdale
2021-09-01 13:10 ` Tanmay Jagdale
2021-09-01 13:10 ` [PATCH 1/2] dt-bindings: coresight: Add burst size for TMC Tanmay Jagdale
2021-09-01 13:10   ` Tanmay Jagdale
2021-09-02 16:27   ` Mike Leach
2021-09-02 16:27     ` Mike Leach
2021-09-03 19:54   ` Rob Herring
2021-09-03 19:54     ` Rob Herring
2021-09-01 13:10 ` [PATCH 2/2] coresight: tmc: Configure AXI write burst size Tanmay Jagdale
2021-09-01 13:10   ` Tanmay Jagdale
2021-09-02 16:29   ` Mike Leach
2021-09-02 16:29     ` Mike Leach
2021-09-02 16:32 ` Mike Leach [this message]
2021-09-02 16:32   ` [PATCH 0/2] coresight: tmc: Add support to configure AXI " Mike Leach
2021-09-07 17:17 ` Mathieu Poirier
2021-09-07 17:17   ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ9a7VhJ-KC3VPCbgw8nqsZNMypsEACxyZstF9hinWYL+xa-tQ@mail.gmail.com \
    --to=mike.leach@linaro.org \
    --cc=al.grant@arm.com \
    --cc=bbhushan2@marvell.com \
    --cc=coresight@lists.linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lcherian@marvell.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=sgoutham@marvell.com \
    --cc=suzuki.poulose@arm.com \
    --cc=tanmay@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.