* Re: [PATCH] cgroup: remove unused macro for_each_e_css()
@ 2023-05-27 3:55 ` Yosry Ahmed
0 siblings, 0 replies; 7+ messages in thread
From: Yosry Ahmed @ 2023-05-27 3:55 UTC (permalink / raw)
To: Miaohe Lin; +Cc: lizefan.x, tj, hannes, cgroups, linux-kernel
On Fri, May 26, 2023 at 6:43 PM Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> for_each_e_css() is unused now. Remove it.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
LGTM. I can't see any references in Linus's tree or mm-unstable.
Reviewed-by: Yosry Ahmed <yosryahmed@google.com>
> ---
> kernel/cgroup/cgroup.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index 625d7483951c..413b4f1f1b70 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -689,21 +689,6 @@ EXPORT_SYMBOL_GPL(of_css);
> lockdep_is_held(&cgroup_mutex)))) { } \
> else
>
> -/**
> - * for_each_e_css - iterate all effective css's of a cgroup
> - * @css: the iteration cursor
> - * @ssid: the index of the subsystem, CGROUP_SUBSYS_COUNT after reaching the end
> - * @cgrp: the target cgroup to iterate css's of
> - *
> - * Should be called under cgroup_[tree_]mutex.
> - */
> -#define for_each_e_css(css, ssid, cgrp) \
> - for ((ssid) = 0; (ssid) < CGROUP_SUBSYS_COUNT; (ssid)++) \
> - if (!((css) = cgroup_e_css_by_mask(cgrp, \
> - cgroup_subsys[(ssid)]))) \
> - ; \
> - else
> -
> /**
> * do_each_subsys_mask - filter for_each_subsys with a bitmask
> * @ss: the iteration cursor
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] cgroup: remove unused macro for_each_e_css()
@ 2023-05-27 3:55 ` Yosry Ahmed
0 siblings, 0 replies; 7+ messages in thread
From: Yosry Ahmed @ 2023-05-27 3:55 UTC (permalink / raw)
To: Miaohe Lin
Cc: lizefan.x-EC8Uxl6Npydl57MIdRCFDg, tj-DgEjT+Ai2ygdnm+yROfE0A,
hannes-druUgvl0LCNAfugRpC6u6w, cgroups-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Fri, May 26, 2023 at 6:43 PM Miaohe Lin <linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:
>
> for_each_e_css() is unused now. Remove it.
>
> Signed-off-by: Miaohe Lin <linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
LGTM. I can't see any references in Linus's tree or mm-unstable.
Reviewed-by: Yosry Ahmed <yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> ---
> kernel/cgroup/cgroup.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index 625d7483951c..413b4f1f1b70 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -689,21 +689,6 @@ EXPORT_SYMBOL_GPL(of_css);
> lockdep_is_held(&cgroup_mutex)))) { } \
> else
>
> -/**
> - * for_each_e_css - iterate all effective css's of a cgroup
> - * @css: the iteration cursor
> - * @ssid: the index of the subsystem, CGROUP_SUBSYS_COUNT after reaching the end
> - * @cgrp: the target cgroup to iterate css's of
> - *
> - * Should be called under cgroup_[tree_]mutex.
> - */
> -#define for_each_e_css(css, ssid, cgrp) \
> - for ((ssid) = 0; (ssid) < CGROUP_SUBSYS_COUNT; (ssid)++) \
> - if (!((css) = cgroup_e_css_by_mask(cgrp, \
> - cgroup_subsys[(ssid)]))) \
> - ; \
> - else
> -
> /**
> * do_each_subsys_mask - filter for_each_subsys with a bitmask
> * @ss: the iteration cursor
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] cgroup: remove unused macro for_each_e_css()
@ 2023-05-27 9:33 ` Miaohe Lin
0 siblings, 0 replies; 7+ messages in thread
From: Miaohe Lin @ 2023-05-27 9:33 UTC (permalink / raw)
To: lizefan.x, tj, hannes; +Cc: cgroups, linux-kernel, linmiaohe
for_each_e_css() is unused now. Remove it.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
kernel/cgroup/cgroup.c | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 625d7483951c..413b4f1f1b70 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -689,21 +689,6 @@ EXPORT_SYMBOL_GPL(of_css);
lockdep_is_held(&cgroup_mutex)))) { } \
else
-/**
- * for_each_e_css - iterate all effective css's of a cgroup
- * @css: the iteration cursor
- * @ssid: the index of the subsystem, CGROUP_SUBSYS_COUNT after reaching the end
- * @cgrp: the target cgroup to iterate css's of
- *
- * Should be called under cgroup_[tree_]mutex.
- */
-#define for_each_e_css(css, ssid, cgrp) \
- for ((ssid) = 0; (ssid) < CGROUP_SUBSYS_COUNT; (ssid)++) \
- if (!((css) = cgroup_e_css_by_mask(cgrp, \
- cgroup_subsys[(ssid)]))) \
- ; \
- else
-
/**
* do_each_subsys_mask - filter for_each_subsys with a bitmask
* @ss: the iteration cursor
--
2.27.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] cgroup: remove unused macro for_each_e_css()
@ 2023-05-27 9:33 ` Miaohe Lin
0 siblings, 0 replies; 7+ messages in thread
From: Miaohe Lin @ 2023-05-27 9:33 UTC (permalink / raw)
To: lizefan.x-EC8Uxl6Npydl57MIdRCFDg, tj-DgEjT+Ai2ygdnm+yROfE0A,
hannes-druUgvl0LCNAfugRpC6u6w
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linmiaohe-hv44wF8Li93QT0dZR+AlfA
for_each_e_css() is unused now. Remove it.
Signed-off-by: Miaohe Lin <linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
kernel/cgroup/cgroup.c | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 625d7483951c..413b4f1f1b70 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -689,21 +689,6 @@ EXPORT_SYMBOL_GPL(of_css);
lockdep_is_held(&cgroup_mutex)))) { } \
else
-/**
- * for_each_e_css - iterate all effective css's of a cgroup
- * @css: the iteration cursor
- * @ssid: the index of the subsystem, CGROUP_SUBSYS_COUNT after reaching the end
- * @cgrp: the target cgroup to iterate css's of
- *
- * Should be called under cgroup_[tree_]mutex.
- */
-#define for_each_e_css(css, ssid, cgrp) \
- for ((ssid) = 0; (ssid) < CGROUP_SUBSYS_COUNT; (ssid)++) \
- if (!((css) = cgroup_e_css_by_mask(cgrp, \
- cgroup_subsys[(ssid)]))) \
- ; \
- else
-
/**
* do_each_subsys_mask - filter for_each_subsys with a bitmask
* @ss: the iteration cursor
--
2.27.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] cgroup: remove unused macro for_each_e_css()
2023-05-27 9:33 ` Miaohe Lin
(?)
(?)
@ 2023-06-01 14:06 ` Michal Koutný
-1 siblings, 0 replies; 7+ messages in thread
From: Michal Koutný @ 2023-06-01 14:06 UTC (permalink / raw)
To: Miaohe Lin; +Cc: lizefan.x, tj, hannes, cgroups, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 328 bytes --]
On Sat, May 27, 2023 at 05:33:53PM +0800, Miaohe Lin <linmiaohe@huawei.com> wrote:
> for_each_e_css() is unused now. Remove it.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> kernel/cgroup/cgroup.c | 15 ---------------
> 1 file changed, 15 deletions(-)
Reviewed-by: Michal Koutný <mkoutny@suse.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] cgroup: remove unused macro for_each_e_css()
@ 2023-06-05 19:20 ` Tejun Heo
0 siblings, 0 replies; 7+ messages in thread
From: Tejun Heo @ 2023-06-05 19:20 UTC (permalink / raw)
To: Miaohe Lin; +Cc: lizefan.x, hannes, cgroups, linux-kernel
On Sat, May 27, 2023 at 05:33:53PM +0800, Miaohe Lin wrote:
> for_each_e_css() is unused now. Remove it.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Applied to cgroup/for-6.5.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] cgroup: remove unused macro for_each_e_css()
@ 2023-06-05 19:20 ` Tejun Heo
0 siblings, 0 replies; 7+ messages in thread
From: Tejun Heo @ 2023-06-05 19:20 UTC (permalink / raw)
To: Miaohe Lin
Cc: lizefan.x-EC8Uxl6Npydl57MIdRCFDg, hannes-druUgvl0LCNAfugRpC6u6w,
cgroups-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Sat, May 27, 2023 at 05:33:53PM +0800, Miaohe Lin wrote:
> for_each_e_css() is unused now. Remove it.
>
> Signed-off-by: Miaohe Lin <linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Applied to cgroup/for-6.5.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-06-05 19:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-27 9:33 [PATCH] cgroup: remove unused macro for_each_e_css() Miaohe Lin
2023-05-27 9:33 ` Miaohe Lin
2023-05-27 3:55 ` Yosry Ahmed
2023-05-27 3:55 ` Yosry Ahmed
2023-06-01 14:06 ` Michal Koutný
2023-06-05 19:20 ` Tejun Heo
2023-06-05 19:20 ` Tejun Heo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.