From: Guo Ren <guoren@kernel.org> To: Mark Rutland <mark.rutland@arm.com> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Albert Ou <aou@eecs.berkeley.edu>, Catalin Marinas <catalin.marinas@arm.com>, Vincent Chen <deanbo422@gmail.com>, Greentime Hu <green.hu@gmail.com>, Jonas Bonn <jonas@southpole.se>, kernelfans@gmail.com, Linux ARM <linux-arm-kernel@lists.infradead.org>, Russell King <linux@armlinux.org.uk>, Marc Zyngier <maz@kernel.org>, Nick Hu <nickhu@andestech.com>, Palmer Dabbelt <palmer@dabbelt.com>, Paul McKenney <paulmck@kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, Peter Zijlstra <peterz@infradead.org>, Stafford Horne <shorne@gmail.com>, Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>, Thomas Gleixner <tglx@linutronix.de>, Linus Torvalds <torvalds@linux-foundation.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, vgupta@kernel.org, Will Deacon <will@kernel.org> Subject: Re: [PATCH 11/15] irq: csky: perform irqentry in entry code Date: Fri, 22 Oct 2021 10:19:53 +0800 [thread overview] Message-ID: <CAJF2gTQOtz_=0anK0SdwJJ+Nu+eX1DKRMP+MMiFwpojgf43nyg@mail.gmail.com> (raw) In-Reply-To: <20211021180236.37428-12-mark.rutland@arm.com> On Fri, Oct 22, 2021 at 2:03 AM Mark Rutland <mark.rutland@arm.com> wrote: > > In preparation for removing HANDLE_DOMAIN_IRQ_IRQENTRY, have arch/csky > perform all the irqentry accounting in its entry code. As arch/csky uses > GENERIC_IRQ_MULTI_HANDLER, we can use generic_handle_arch_irq() to do > so. > > There should be no functional change as a result of this patch. > > Signed-off-by: Mark Rutland <mark.rutland@arm.com> > Cc: Guo Ren <guoren@kernel.org> > Cc: Marc Zyngier <maz@kernel.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > --- > arch/csky/Kconfig | 1 - > arch/csky/kernel/entry.S | 2 +- > arch/csky/kernel/irq.c | 5 ----- > 3 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig > index 45f03f674a61..9d4d898df76b 100644 > --- a/arch/csky/Kconfig > +++ b/arch/csky/Kconfig > @@ -18,7 +18,6 @@ config CSKY > select DMA_DIRECT_REMAP > select IRQ_DOMAIN > select HANDLE_DOMAIN_IRQ > - select HANDLE_DOMAIN_IRQ_IRQENTRY > select DW_APB_TIMER_OF > select GENERIC_IOREMAP > select GENERIC_LIB_ASHLDI3 > diff --git a/arch/csky/kernel/entry.S b/arch/csky/kernel/entry.S > index 00e3c8ebf9b8..a4ababf25e24 100644 > --- a/arch/csky/kernel/entry.S > +++ b/arch/csky/kernel/entry.S > @@ -249,7 +249,7 @@ ENTRY(csky_irq) > > > mov a0, sp > - jbsr csky_do_IRQ > + jbsr generic_handle_arch_irq > > jmpi ret_from_exception > > diff --git a/arch/csky/kernel/irq.c b/arch/csky/kernel/irq.c > index 03a1930f1cbb..fcdaf3156286 100644 > --- a/arch/csky/kernel/irq.c > +++ b/arch/csky/kernel/irq.c > @@ -15,8 +15,3 @@ void __init init_IRQ(void) > setup_smp_ipi(); > #endif > } > - > -asmlinkage void __irq_entry csky_do_IRQ(struct pt_regs *regs) > -{ > - handle_arch_irq(regs); > -} Seems the previous code has lost old_regs save/restore? + struct pt_regs *old_regs; + + irq_enter(); + old_regs = set_irq_regs(regs); + handle_arch_irq(regs); + set_irq_regs(old_regs); + irq_exit(); > -- > 2.11.0 > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/
WARNING: multiple messages have this Message-ID (diff)
From: Guo Ren <guoren@kernel.org> To: Mark Rutland <mark.rutland@arm.com> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Albert Ou <aou@eecs.berkeley.edu>, Catalin Marinas <catalin.marinas@arm.com>, Vincent Chen <deanbo422@gmail.com>, Greentime Hu <green.hu@gmail.com>, Jonas Bonn <jonas@southpole.se>, kernelfans@gmail.com, Linux ARM <linux-arm-kernel@lists.infradead.org>, Russell King <linux@armlinux.org.uk>, Marc Zyngier <maz@kernel.org>, Nick Hu <nickhu@andestech.com>, Palmer Dabbelt <palmer@dabbelt.com>, Paul McKenney <paulmck@kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, Peter Zijlstra <peterz@infradead.org>, Stafford Horne <shorne@gmail.com>, Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>, Thomas Gleixner <tglx@linutronix.de>, Linus Torvalds <torvalds@linux-foundation.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, vgupta@kernel.org, Will Deacon <will@kernel.org> Subject: Re: [PATCH 11/15] irq: csky: perform irqentry in entry code Date: Fri, 22 Oct 2021 10:19:53 +0800 [thread overview] Message-ID: <CAJF2gTQOtz_=0anK0SdwJJ+Nu+eX1DKRMP+MMiFwpojgf43nyg@mail.gmail.com> (raw) In-Reply-To: <20211021180236.37428-12-mark.rutland@arm.com> On Fri, Oct 22, 2021 at 2:03 AM Mark Rutland <mark.rutland@arm.com> wrote: > > In preparation for removing HANDLE_DOMAIN_IRQ_IRQENTRY, have arch/csky > perform all the irqentry accounting in its entry code. As arch/csky uses > GENERIC_IRQ_MULTI_HANDLER, we can use generic_handle_arch_irq() to do > so. > > There should be no functional change as a result of this patch. > > Signed-off-by: Mark Rutland <mark.rutland@arm.com> > Cc: Guo Ren <guoren@kernel.org> > Cc: Marc Zyngier <maz@kernel.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > --- > arch/csky/Kconfig | 1 - > arch/csky/kernel/entry.S | 2 +- > arch/csky/kernel/irq.c | 5 ----- > 3 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig > index 45f03f674a61..9d4d898df76b 100644 > --- a/arch/csky/Kconfig > +++ b/arch/csky/Kconfig > @@ -18,7 +18,6 @@ config CSKY > select DMA_DIRECT_REMAP > select IRQ_DOMAIN > select HANDLE_DOMAIN_IRQ > - select HANDLE_DOMAIN_IRQ_IRQENTRY > select DW_APB_TIMER_OF > select GENERIC_IOREMAP > select GENERIC_LIB_ASHLDI3 > diff --git a/arch/csky/kernel/entry.S b/arch/csky/kernel/entry.S > index 00e3c8ebf9b8..a4ababf25e24 100644 > --- a/arch/csky/kernel/entry.S > +++ b/arch/csky/kernel/entry.S > @@ -249,7 +249,7 @@ ENTRY(csky_irq) > > > mov a0, sp > - jbsr csky_do_IRQ > + jbsr generic_handle_arch_irq > > jmpi ret_from_exception > > diff --git a/arch/csky/kernel/irq.c b/arch/csky/kernel/irq.c > index 03a1930f1cbb..fcdaf3156286 100644 > --- a/arch/csky/kernel/irq.c > +++ b/arch/csky/kernel/irq.c > @@ -15,8 +15,3 @@ void __init init_IRQ(void) > setup_smp_ipi(); > #endif > } > - > -asmlinkage void __irq_entry csky_do_IRQ(struct pt_regs *regs) > -{ > - handle_arch_irq(regs); > -} Seems the previous code has lost old_regs save/restore? + struct pt_regs *old_regs; + + irq_enter(); + old_regs = set_irq_regs(regs); + handle_arch_irq(regs); + set_irq_regs(old_regs); + irq_exit(); > -- > 2.11.0 > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-22 2:20 UTC|newest] Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-21 18:02 [PATCH 00/15] irq: remove handle_domain_{irq,nmi}() Mark Rutland 2021-10-21 18:02 ` Mark Rutland 2021-10-21 18:02 ` [PATCH 01/15] irq: mips: avoid nested irq_enter() Mark Rutland 2021-10-21 18:02 ` Mark Rutland 2021-10-22 10:38 ` Marc Zyngier 2021-10-22 10:38 ` Marc Zyngier 2021-10-22 15:05 ` Mark Rutland 2021-10-22 15:05 ` Mark Rutland 2021-10-24 15:31 ` Thomas Bogendoerfer 2021-10-24 15:31 ` Thomas Bogendoerfer 2021-10-21 18:02 ` [PATCH 02/15] irq: mips: stop (ab)using handle_domain_irq() Mark Rutland 2021-10-21 18:02 ` Mark Rutland 2021-10-24 15:30 ` Thomas Bogendoerfer 2021-10-24 15:30 ` Thomas Bogendoerfer 2021-10-21 18:02 ` [PATCH 03/15] irq: mips: simplify do_domain_IRQ() Mark Rutland 2021-10-21 18:02 ` Mark Rutland 2021-10-24 15:31 ` Thomas Bogendoerfer 2021-10-24 15:31 ` Thomas Bogendoerfer 2021-10-28 17:07 ` Guenter Roeck 2021-10-28 17:07 ` Guenter Roeck 2021-10-28 17:11 ` Mark Rutland 2021-10-28 17:11 ` Mark Rutland 2021-10-21 18:02 ` [PATCH 04/15] irq: simplify handle_domain_{irq,nmi}() Mark Rutland 2021-10-21 18:02 ` Mark Rutland 2021-10-22 10:52 ` Marc Zyngier 2021-10-22 10:52 ` Marc Zyngier 2021-10-22 15:05 ` Mark Rutland 2021-10-22 15:05 ` Mark Rutland 2021-10-21 18:02 ` [PATCH 05/15] irq: add generic_handle_arch_irq() Mark Rutland 2021-10-21 18:02 ` Mark Rutland 2021-10-22 2:10 ` Pingfan Liu 2021-10-22 2:10 ` Pingfan Liu 2021-10-22 9:02 ` Mark Rutland 2021-10-22 9:02 ` Mark Rutland 2021-10-22 2:33 ` Guo Ren 2021-10-22 2:33 ` Guo Ren 2021-10-22 8:52 ` Mark Rutland 2021-10-22 8:52 ` Mark Rutland 2021-10-24 1:53 ` Guo Ren 2021-10-24 1:53 ` Guo Ren 2021-10-21 18:02 ` [PATCH 06/15] irq: arc: avoid CONFIG_HANDLE_DOMAIN_IRQ Mark Rutland 2021-10-21 18:02 ` Mark Rutland 2021-10-21 18:02 ` [PATCH 07/15] irq: nds32: " Mark Rutland 2021-10-21 18:02 ` Mark Rutland 2021-10-22 6:35 ` Greentime Hu 2021-10-22 6:35 ` Greentime Hu 2021-10-21 18:02 ` [PATCH 08/15] irq: add a (temporary) CONFIG_HANDLE_DOMAIN_IRQ_IRQENTRY Mark Rutland 2021-10-21 18:02 ` Mark Rutland 2021-10-21 18:02 ` [PATCH 09/15] irq: arm: perform irqentry in entry code Mark Rutland 2021-10-21 18:02 ` Mark Rutland 2021-10-22 15:18 ` Vladimir Murzin 2021-10-22 15:18 ` Vladimir Murzin 2021-10-22 15:36 ` Mark Rutland 2021-10-22 15:36 ` Mark Rutland 2021-10-22 16:34 ` Vladimir Murzin 2021-10-22 16:34 ` Vladimir Murzin 2021-10-22 17:58 ` Mark Rutland 2021-10-22 17:58 ` Mark Rutland 2021-10-22 18:43 ` Marc Zyngier 2021-10-22 18:43 ` Marc Zyngier 2021-10-23 12:06 ` Vladimir Murzin 2021-10-23 12:06 ` Vladimir Murzin 2021-10-23 13:18 ` Marc Zyngier 2021-10-23 13:18 ` Marc Zyngier 2021-10-23 13:36 ` Vladimir Murzin 2021-10-23 13:36 ` Vladimir Murzin 2021-11-30 8:49 ` Vladimir Murzin 2021-11-30 8:49 ` Vladimir Murzin 2021-12-01 7:56 ` Marc Zyngier 2021-12-01 7:56 ` Marc Zyngier 2021-10-21 18:02 ` [PATCH 10/15] irq: arm64: " Mark Rutland 2021-10-21 18:02 ` Mark Rutland 2021-10-22 1:57 ` Pingfan Liu 2021-10-22 1:57 ` Pingfan Liu 2021-10-25 18:00 ` Catalin Marinas 2021-10-25 18:00 ` Catalin Marinas 2021-10-21 18:02 ` [PATCH 11/15] irq: csky: " Mark Rutland 2021-10-21 18:02 ` Mark Rutland 2021-10-22 2:19 ` Guo Ren [this message] 2021-10-22 2:19 ` Guo Ren 2021-10-22 2:26 ` Guo Ren 2021-10-22 2:26 ` Guo Ren 2021-10-21 18:02 ` [PATCH 12/15] irq: openrisc: " Mark Rutland 2021-10-21 18:02 ` Mark Rutland 2021-10-22 20:40 ` Stafford Horne 2021-10-22 20:40 ` Stafford Horne 2021-10-21 18:02 ` [PATCH 13/15] irq: riscv: " Mark Rutland 2021-10-21 18:02 ` Mark Rutland 2021-10-22 1:59 ` Guo Ren 2021-10-22 1:59 ` Guo Ren 2021-10-27 21:22 ` Palmer Dabbelt 2021-10-27 21:22 ` Palmer Dabbelt 2021-10-21 18:02 ` [PATCH 14/15] irq: remove CONFIG_HANDLE_DOMAIN_IRQ_IRQENTRY Mark Rutland 2021-10-21 18:02 ` Mark Rutland 2021-10-21 18:02 ` [PATCH 15/15] irq: remove handle_domain_{irq,nmi}() Mark Rutland 2021-10-21 18:02 ` Mark Rutland 2021-10-22 10:05 ` Marc Zyngier 2021-10-22 10:05 ` Marc Zyngier 2021-10-22 15:06 ` Mark Rutland 2021-10-22 15:06 ` Mark Rutland 2021-10-22 1:26 ` [PATCH 00/15] " Linus Torvalds 2021-10-22 1:26 ` Linus Torvalds 2021-10-22 11:20 ` Marc Zyngier 2021-10-22 11:20 ` Marc Zyngier 2021-10-22 15:10 ` Mark Rutland 2021-10-22 15:10 ` Mark Rutland 2021-10-23 16:06 ` Marc Zyngier 2021-10-23 16:06 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJF2gTQOtz_=0anK0SdwJJ+Nu+eX1DKRMP+MMiFwpojgf43nyg@mail.gmail.com' \ --to=guoren@kernel.org \ --cc=aou@eecs.berkeley.edu \ --cc=catalin.marinas@arm.com \ --cc=deanbo422@gmail.com \ --cc=green.hu@gmail.com \ --cc=jonas@southpole.se \ --cc=kernelfans@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=nickhu@andestech.com \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=paulmck@kernel.org \ --cc=peterz@infradead.org \ --cc=shorne@gmail.com \ --cc=stefan.kristiansson@saunalahti.fi \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ --cc=tsbogend@alpha.franken.de \ --cc=vgupta@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.