All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu,
	deanbo422@gmail.com, green.hu@gmail.com, guoren@kernel.org,
	jonas@southpole.se, kernelfans@gmail.com,
	linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk,
	maz@kernel.org, nickhu@andestech.com, palmer@dabbelt.com,
	paulmck@kernel.org, paul.walmsley@sifive.com,
	peterz@infradead.org, shorne@gmail.com,
	stefan.kristiansson@saunalahti.fi, tglx@linutronix.de,
	torvalds@linux-foundation.org, tsbogend@alpha.franken.de,
	vgupta@kernel.org, will@kernel.org
Subject: Re: [PATCH 10/15] irq: arm64: perform irqentry in entry code
Date: Mon, 25 Oct 2021 19:00:40 +0100	[thread overview]
Message-ID: <YXbwyKeAOfIayN1A@arm.com> (raw)
In-Reply-To: <20211021180236.37428-11-mark.rutland@arm.com>

On Thu, Oct 21, 2021 at 07:02:31PM +0100, Mark Rutland wrote:
> In preparation for removing HANDLE_DOMAIN_IRQ_IRQENTRY, have arch/arm64
> perform all the irqentry accounting in its entry code.
> 
> As arch/arm64 already performs portions of the irqentry logic in
> enter_from_kernel_mode() and exit_to_kernel_mode(), including
> rcu_irq_{enter,exit}(), the only additional calls that need to be made
> are to irq_{enter,exit}_rcu(). Removing the calls to
> rcu_irq_{enter,exit}() from handle_domain_irq() ensures that we inform
> RCU once per IRQ entry and will correctly identify quiescent periods.
> 
> Since we should not call irq_{enter,exit}_rcu() when entering a
> pseudo-NMI, el1_interrupt() is reworked to have separate __el1_irq() and
> __el1_pnmi() paths for regular IRQ and psuedo-NMI entry, with
> irq_{enter,exit}_irq() only called for the former.
> 
> In preparation for removing HANDLE_DOMAIN_IRQ, the irq regs are managed
> in do_interrupt_handler() for both regular IRQ and pseudo-NMI. This is
> currently redundant, but not harmful.
> 
> For clarity the preemption logic is moved into __el1_irq(). We should
> never preempt within a pseudo-NMI, and arm64_enter_nmi() already
> enforces this by incrementing the preempt_count, but it's clearer if we
> never invoke the preemption logic when entering a pseudo-NMI.
> 
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Will Deacon <will@kernel.org>

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu,
	deanbo422@gmail.com, green.hu@gmail.com, guoren@kernel.org,
	jonas@southpole.se, kernelfans@gmail.com,
	linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk,
	maz@kernel.org, nickhu@andestech.com, palmer@dabbelt.com,
	paulmck@kernel.org, paul.walmsley@sifive.com,
	peterz@infradead.org, shorne@gmail.com,
	stefan.kristiansson@saunalahti.fi, tglx@linutronix.de,
	torvalds@linux-foundation.org, tsbogend@alpha.franken.de,
	vgupta@kernel.org, will@kernel.org
Subject: Re: [PATCH 10/15] irq: arm64: perform irqentry in entry code
Date: Mon, 25 Oct 2021 19:00:40 +0100	[thread overview]
Message-ID: <YXbwyKeAOfIayN1A@arm.com> (raw)
In-Reply-To: <20211021180236.37428-11-mark.rutland@arm.com>

On Thu, Oct 21, 2021 at 07:02:31PM +0100, Mark Rutland wrote:
> In preparation for removing HANDLE_DOMAIN_IRQ_IRQENTRY, have arch/arm64
> perform all the irqentry accounting in its entry code.
> 
> As arch/arm64 already performs portions of the irqentry logic in
> enter_from_kernel_mode() and exit_to_kernel_mode(), including
> rcu_irq_{enter,exit}(), the only additional calls that need to be made
> are to irq_{enter,exit}_rcu(). Removing the calls to
> rcu_irq_{enter,exit}() from handle_domain_irq() ensures that we inform
> RCU once per IRQ entry and will correctly identify quiescent periods.
> 
> Since we should not call irq_{enter,exit}_rcu() when entering a
> pseudo-NMI, el1_interrupt() is reworked to have separate __el1_irq() and
> __el1_pnmi() paths for regular IRQ and psuedo-NMI entry, with
> irq_{enter,exit}_irq() only called for the former.
> 
> In preparation for removing HANDLE_DOMAIN_IRQ, the irq regs are managed
> in do_interrupt_handler() for both regular IRQ and pseudo-NMI. This is
> currently redundant, but not harmful.
> 
> For clarity the preemption logic is moved into __el1_irq(). We should
> never preempt within a pseudo-NMI, and arm64_enter_nmi() already
> enforces this by incrementing the preempt_count, but it's clearer if we
> never invoke the preemption logic when entering a pseudo-NMI.
> 
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Will Deacon <will@kernel.org>

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-10-25 18:00 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 18:02 [PATCH 00/15] irq: remove handle_domain_{irq,nmi}() Mark Rutland
2021-10-21 18:02 ` Mark Rutland
2021-10-21 18:02 ` [PATCH 01/15] irq: mips: avoid nested irq_enter() Mark Rutland
2021-10-21 18:02   ` Mark Rutland
2021-10-22 10:38   ` Marc Zyngier
2021-10-22 10:38     ` Marc Zyngier
2021-10-22 15:05     ` Mark Rutland
2021-10-22 15:05       ` Mark Rutland
2021-10-24 15:31   ` Thomas Bogendoerfer
2021-10-24 15:31     ` Thomas Bogendoerfer
2021-10-21 18:02 ` [PATCH 02/15] irq: mips: stop (ab)using handle_domain_irq() Mark Rutland
2021-10-21 18:02   ` Mark Rutland
2021-10-24 15:30   ` Thomas Bogendoerfer
2021-10-24 15:30     ` Thomas Bogendoerfer
2021-10-21 18:02 ` [PATCH 03/15] irq: mips: simplify do_domain_IRQ() Mark Rutland
2021-10-21 18:02   ` Mark Rutland
2021-10-24 15:31   ` Thomas Bogendoerfer
2021-10-24 15:31     ` Thomas Bogendoerfer
2021-10-28 17:07   ` Guenter Roeck
2021-10-28 17:07     ` Guenter Roeck
2021-10-28 17:11     ` Mark Rutland
2021-10-28 17:11       ` Mark Rutland
2021-10-21 18:02 ` [PATCH 04/15] irq: simplify handle_domain_{irq,nmi}() Mark Rutland
2021-10-21 18:02   ` Mark Rutland
2021-10-22 10:52   ` Marc Zyngier
2021-10-22 10:52     ` Marc Zyngier
2021-10-22 15:05     ` Mark Rutland
2021-10-22 15:05       ` Mark Rutland
2021-10-21 18:02 ` [PATCH 05/15] irq: add generic_handle_arch_irq() Mark Rutland
2021-10-21 18:02   ` Mark Rutland
2021-10-22  2:10   ` Pingfan Liu
2021-10-22  2:10     ` Pingfan Liu
2021-10-22  9:02     ` Mark Rutland
2021-10-22  9:02       ` Mark Rutland
2021-10-22  2:33   ` Guo Ren
2021-10-22  2:33     ` Guo Ren
2021-10-22  8:52     ` Mark Rutland
2021-10-22  8:52       ` Mark Rutland
2021-10-24  1:53       ` Guo Ren
2021-10-24  1:53         ` Guo Ren
2021-10-21 18:02 ` [PATCH 06/15] irq: arc: avoid CONFIG_HANDLE_DOMAIN_IRQ Mark Rutland
2021-10-21 18:02   ` Mark Rutland
2021-10-21 18:02 ` [PATCH 07/15] irq: nds32: " Mark Rutland
2021-10-21 18:02   ` Mark Rutland
2021-10-22  6:35   ` Greentime Hu
2021-10-22  6:35     ` Greentime Hu
2021-10-21 18:02 ` [PATCH 08/15] irq: add a (temporary) CONFIG_HANDLE_DOMAIN_IRQ_IRQENTRY Mark Rutland
2021-10-21 18:02   ` Mark Rutland
2021-10-21 18:02 ` [PATCH 09/15] irq: arm: perform irqentry in entry code Mark Rutland
2021-10-21 18:02   ` Mark Rutland
2021-10-22 15:18   ` Vladimir Murzin
2021-10-22 15:18     ` Vladimir Murzin
2021-10-22 15:36     ` Mark Rutland
2021-10-22 15:36       ` Mark Rutland
2021-10-22 16:34       ` Vladimir Murzin
2021-10-22 16:34         ` Vladimir Murzin
2021-10-22 17:58         ` Mark Rutland
2021-10-22 17:58           ` Mark Rutland
2021-10-22 18:43           ` Marc Zyngier
2021-10-22 18:43             ` Marc Zyngier
2021-10-23 12:06             ` Vladimir Murzin
2021-10-23 12:06               ` Vladimir Murzin
2021-10-23 13:18               ` Marc Zyngier
2021-10-23 13:18                 ` Marc Zyngier
2021-10-23 13:36                 ` Vladimir Murzin
2021-10-23 13:36                   ` Vladimir Murzin
2021-11-30  8:49                   ` Vladimir Murzin
2021-11-30  8:49                     ` Vladimir Murzin
2021-12-01  7:56                     ` Marc Zyngier
2021-12-01  7:56                       ` Marc Zyngier
2021-10-21 18:02 ` [PATCH 10/15] irq: arm64: " Mark Rutland
2021-10-21 18:02   ` Mark Rutland
2021-10-22  1:57   ` Pingfan Liu
2021-10-22  1:57     ` Pingfan Liu
2021-10-25 18:00   ` Catalin Marinas [this message]
2021-10-25 18:00     ` Catalin Marinas
2021-10-21 18:02 ` [PATCH 11/15] irq: csky: " Mark Rutland
2021-10-21 18:02   ` Mark Rutland
2021-10-22  2:19   ` Guo Ren
2021-10-22  2:19     ` Guo Ren
2021-10-22  2:26     ` Guo Ren
2021-10-22  2:26       ` Guo Ren
2021-10-21 18:02 ` [PATCH 12/15] irq: openrisc: " Mark Rutland
2021-10-21 18:02   ` Mark Rutland
2021-10-22 20:40   ` Stafford Horne
2021-10-22 20:40     ` Stafford Horne
2021-10-21 18:02 ` [PATCH 13/15] irq: riscv: " Mark Rutland
2021-10-21 18:02   ` Mark Rutland
2021-10-22  1:59   ` Guo Ren
2021-10-22  1:59     ` Guo Ren
2021-10-27 21:22   ` Palmer Dabbelt
2021-10-27 21:22     ` Palmer Dabbelt
2021-10-21 18:02 ` [PATCH 14/15] irq: remove CONFIG_HANDLE_DOMAIN_IRQ_IRQENTRY Mark Rutland
2021-10-21 18:02   ` Mark Rutland
2021-10-21 18:02 ` [PATCH 15/15] irq: remove handle_domain_{irq,nmi}() Mark Rutland
2021-10-21 18:02   ` Mark Rutland
2021-10-22 10:05   ` Marc Zyngier
2021-10-22 10:05     ` Marc Zyngier
2021-10-22 15:06     ` Mark Rutland
2021-10-22 15:06       ` Mark Rutland
2021-10-22  1:26 ` [PATCH 00/15] " Linus Torvalds
2021-10-22  1:26   ` Linus Torvalds
2021-10-22 11:20 ` Marc Zyngier
2021-10-22 11:20   ` Marc Zyngier
2021-10-22 15:10   ` Mark Rutland
2021-10-22 15:10     ` Mark Rutland
2021-10-23 16:06     ` Marc Zyngier
2021-10-23 16:06       ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXbwyKeAOfIayN1A@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=deanbo422@gmail.com \
    --cc=green.hu@gmail.com \
    --cc=guoren@kernel.org \
    --cc=jonas@southpole.se \
    --cc=kernelfans@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=nickhu@andestech.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=shorne@gmail.com \
    --cc=stefan.kristiansson@saunalahti.fi \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=vgupta@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.